[PATCH v1 0/1] Remove x86 legacy UART defaults

public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed

* [PATCH v1 0/1] Remove x86 legacy UART defaults
@ 2020-07-08 14:08 Marcello Sylvester Bauer
  2020-07-08 14:09 ` [PATCH v1 1/1] UefiPayloadPkg: " Marcello Sylvester Bauer
  0 siblings, 1 reply; 4+ messages in thread
From: Marcello Sylvester Bauer @ 2020-07-08 14:08 UTC (permalink / raw)
  To: devel

Do not fallback to a fixed UART base address, otherwise it can cause
errors during initialisation of a non-existent serial port.

Patrick Rudolph (1):
  UefiPayloadPkg: Remove x86 legacy UART defaults

 UefiPayloadPkg/UefiPayloadPkgIa32.dsc    | 2 +-
 UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
2.27.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v1 1/1] UefiPayloadPkg: Remove x86 legacy UART defaults
  2020-07-08 14:08 [PATCH v1 0/1] Remove x86 legacy UART defaults Marcello Sylvester Bauer
@ 2020-07-08 14:09 ` Marcello Sylvester Bauer
  2020-07-08 15:24   ` Ma, Maurice
  0 siblings, 1 reply; 4+ messages in thread
From: Marcello Sylvester Bauer @ 2020-07-08 14:09 UTC (permalink / raw)
  To: devel
  Cc: Patrick Rudolph, Christian Walter, Maurice Ma, Nate DeSimone,
	Star Zeng

From: Patrick Rudolph <patrick.rudolph@9elements.com>

Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Signed-off-by: Marcello Sylvester Bauer <marcello.bauer@9elements.com>
Cc: Patrick Rudolph <patrick.rudolph@9elements.com>
Cc: Christian Walter <christian.walter@9elements.com>
Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
---
 UefiPayloadPkg/UefiPayloadPkgIa32.dsc    | 2 +-
 UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
index 0efcfa8fb2f4..0d8854810700 100644
--- a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
+++ b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
@@ -306,7 +306,7 @@ [PcdsPatchableInModule.common]
   # The following parameters are set by Library/PlatformHookLib
   #
   gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseMmio|FALSE
-  gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x3f8
+  gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0
   gEfiMdeModulePkgTokenSpaceGuid.PcdSerialBaudRate|$(BAUD_RATE)
   gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterStride|1
 
diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
index d645d233cd08..34640b1fc1da 100644
--- a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
+++ b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
@@ -307,7 +307,7 @@ [PcdsPatchableInModule.common]
   # The following parameters are set by Library/PlatformHookLib
   #
   gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseMmio|FALSE
-  gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x3f8
+  gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0
   gEfiMdeModulePkgTokenSpaceGuid.PcdSerialBaudRate|$(BAUD_RATE)
   gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterStride|1
 
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v1 1/1] UefiPayloadPkg: Remove x86 legacy UART defaults
  2020-07-08 14:09 ` [PATCH v1 1/1] UefiPayloadPkg: " Marcello Sylvester Bauer
@ 2020-07-08 15:24   ` Ma, Maurice
  2020-07-08 17:46     ` Ma, Maurice
  0 siblings, 1 reply; 4+ messages in thread
From: Ma, Maurice @ 2020-07-08 15:24 UTC (permalink / raw)
  To: Marcello Sylvester Bauer, devel@edk2.groups.io
  Cc: Patrick Rudolph, Christian Walter, Desimone, Nathaniel L,
	Zeng, Star

Could you please add some commit message to explain what issue you are trying to address ?  Why is it required ?

Thanks
Maurice
> -----Original Message-----
> From: Marcello Sylvester Bauer <marcello.bauer@9elements.com>
> Sent: Wednesday, July 8, 2020 7:09
> To: devel@edk2.groups.io
> Cc: Patrick Rudolph <patrick.rudolph@9elements.com>; Christian Walter
> <christian.walter@9elements.com>; Ma, Maurice <maurice.ma@intel.com>;
> Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star
> <star.zeng@intel.com>
> Subject: [PATCH v1 1/1] UefiPayloadPkg: Remove x86 legacy UART defaults
> 
> From: Patrick Rudolph <patrick.rudolph@9elements.com>
> 
> Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
> Signed-off-by: Marcello Sylvester Bauer <marcello.bauer@9elements.com>
> Cc: Patrick Rudolph <patrick.rudolph@9elements.com>
> Cc: Christian Walter <christian.walter@9elements.com>
> Cc: Maurice Ma <maurice.ma@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> ---
>  UefiPayloadPkg/UefiPayloadPkgIa32.dsc    | 2 +-
>  UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> index 0efcfa8fb2f4..0d8854810700 100644
> --- a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> +++ b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> @@ -306,7 +306,7 @@ [PcdsPatchableInModule.common]
>    # The following parameters are set by Library/PlatformHookLib
> 
>    #
> 
>    gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseMmio|FALSE
> 
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x3f8
> 
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0
> 
>    gEfiMdeModulePkgTokenSpaceGuid.PcdSerialBaudRate|$(BAUD_RATE)
> 
>    gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterStride|1
> 
> 
> 
> diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> index d645d233cd08..34640b1fc1da 100644
> --- a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> +++ b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> @@ -307,7 +307,7 @@ [PcdsPatchableInModule.common]
>    # The following parameters are set by Library/PlatformHookLib
> 
>    #
> 
>    gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseMmio|FALSE
> 
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x3f8
> 
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0
> 
>    gEfiMdeModulePkgTokenSpaceGuid.PcdSerialBaudRate|$(BAUD_RATE)
> 
>    gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterStride|1
> 
> 
> 
> --
> 2.27.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1 1/1] UefiPayloadPkg: Remove x86 legacy UART defaults
  2020-07-08 15:24   ` Ma, Maurice
@ 2020-07-08 17:46     ` Ma, Maurice
  0 siblings, 0 replies; 4+ messages in thread
From: Ma, Maurice @ 2020-07-08 17:46 UTC (permalink / raw)
  To: Marcello Sylvester Bauer
  Cc: devel@edk2.groups.io, Patrick Rudolph, Christian Walter,
	Desimone, Nathaniel L, Zeng, Star

BTW,  I just noticed that not all package maintainers are on the CC list.    
For changed under UefiPayloadPkg,  please ensure you CC all UefiPayloadPkg maintainers listed in the Maintainers.txt under the root of the EDK2 directory.  

Thanks
Maurice
> -----Original Message-----
> From: Ma, Maurice
> Sent: Wednesday, July 8, 2020 8:25
> To: 'Marcello Sylvester Bauer' <marcello.bauer@9elements.com>;
> devel@edk2.groups.io
> Cc: Patrick Rudolph <patrick.rudolph@9elements.com>; Christian Walter
> <christian.walter@9elements.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: RE: [PATCH v1 1/1] UefiPayloadPkg: Remove x86 legacy UART defaults
> 
> Could you please add some commit message to explain what issue you are trying
> to address ?  Why is it required ?
> 
> Thanks
> Maurice
> > -----Original Message-----
> > From: Marcello Sylvester Bauer <marcello.bauer@9elements.com>
> > Sent: Wednesday, July 8, 2020 7:09
> > To: devel@edk2.groups.io
> > Cc: Patrick Rudolph <patrick.rudolph@9elements.com>; Christian Walter
> > <christian.walter@9elements.com>; Ma, Maurice <maurice.ma@intel.com>;
> > Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star
> > <star.zeng@intel.com>
> > Subject: [PATCH v1 1/1] UefiPayloadPkg: Remove x86 legacy UART
> > defaults
> >
> > From: Patrick Rudolph <patrick.rudolph@9elements.com>
> >
> > Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
> > Signed-off-by: Marcello Sylvester Bauer <marcello.bauer@9elements.com>
> > Cc: Patrick Rudolph <patrick.rudolph@9elements.com>
> > Cc: Christian Walter <christian.walter@9elements.com>
> > Cc: Maurice Ma <maurice.ma@intel.com>
> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > Cc: Star Zeng <star.zeng@intel.com>
> > ---
> >  UefiPayloadPkg/UefiPayloadPkgIa32.dsc    | 2 +-
> >  UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> > b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> > index 0efcfa8fb2f4..0d8854810700 100644
> > --- a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> > +++ b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> > @@ -306,7 +306,7 @@ [PcdsPatchableInModule.common]
> >    # The following parameters are set by Library/PlatformHookLib
> >
> >    #
> >
> >    gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseMmio|FALSE
> >
> > -  gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x3f8
> >
> > +  gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0
> >
> >    gEfiMdeModulePkgTokenSpaceGuid.PcdSerialBaudRate|$(BAUD_RATE)
> >
> >    gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterStride|1
> >
> >
> >
> > diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> > b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> > index d645d233cd08..34640b1fc1da 100644
> > --- a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> > +++ b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> > @@ -307,7 +307,7 @@ [PcdsPatchableInModule.common]
> >    # The following parameters are set by Library/PlatformHookLib
> >
> >    #
> >
> >    gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseMmio|FALSE
> >
> > -  gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x3f8
> >
> > +  gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0
> >
> >    gEfiMdeModulePkgTokenSpaceGuid.PcdSerialBaudRate|$(BAUD_RATE)
> >
> >    gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterStride|1
> >
> >
> >
> > --
> > 2.27.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-07-08 17:46 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-08 14:08 [PATCH v1 0/1] Remove x86 legacy UART defaults Marcello Sylvester Bauer
2020-07-08 14:09 ` [PATCH v1 1/1] UefiPayloadPkg: " Marcello Sylvester Bauer
2020-07-08 15:24   ` Ma, Maurice
2020-07-08 17:46     ` Ma, Maurice

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox