public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ma, Maurice" <maurice.ma@intel.com>
To: Patrick Rudolph <patrick.rudolph@9elements.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Dong, Guo" <guo.dong@intel.com>,
	"You, Benjamin" <benjamin.you@intel.com>
Subject: Re: [PATCH] UefiPayloadPkg: Fix PciLib dependency on BlSupportDxe
Date: Mon, 25 Jan 2021 15:37:52 +0000	[thread overview]
Message-ID: <DM6PR11MB279319E89DBCBEDAE49AED8289BD9@DM6PR11MB2793.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210125150506.3848562-1-patrick.rudolph@9elements.com>

Reviewed-by:  Maurice Ma <maurice.ma@intel.com>

Regards
Maurice

> -----Original Message-----
> From: Patrick Rudolph <patrick.rudolph@9elements.com>
> Sent: Monday, January 25, 2021 7:05
> To: devel@edk2.groups.io
> Cc: Ma, Maurice <maurice.ma@intel.com>; Dong, Guo
> <guo.dong@intel.com>; You, Benjamin <benjamin.you@intel.com>
> Subject: [PATCH] UefiPayloadPkg: Fix PciLib dependency on BlSupportDxe
> 
> The PciLib depends on PCDs
> - PcdPciExpressBaseAddress
> - PcdPciExpressBaseSize
> being updated by BlSupportDxe before MMCONF accesses are working.
> 
> Add BlSupportDxe to APRIORI to start it first and get the system into an
> useable state where at least PCI accesses work reliable.
> 
> Fixes a bug where BlSupportDxe is scheduled too late and other DXEs fail to
> load due to broken PCI access.
> 
> Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
> ---
>  UefiPayloadPkg/UefiPayloadPkg.fdf | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf
> b/UefiPayloadPkg/UefiPayloadPkg.fdf
> index a97ace7395..1ae260c13a 100644
> --- a/UefiPayloadPkg/UefiPayloadPkg.fdf
> +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
> @@ -80,6 +80,11 @@ READ_STATUS        = TRUE
>  READ_LOCK_CAP      = TRUE READ_LOCK_STATUS   = TRUE +APRIORI DXE {+
> INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf+  INF
> MdeModulePkg/Universal/PCD/Dxe/Pcd.inf+  INF
> UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf+}  # # DXE Phase modules--
> 2.26.2


      reply	other threads:[~2021-01-25 15:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-25 15:05 [PATCH] UefiPayloadPkg: Fix PciLib dependency on BlSupportDxe Patrick Rudolph
2021-01-25 15:37 ` Ma, Maurice [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB279319E89DBCBEDAE49AED8289BD9@DM6PR11MB2793.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox