public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] UefiPayloadPkg: Fix PciLib dependency on BlSupportDxe
@ 2021-01-25 15:05 Patrick Rudolph
  2021-01-25 15:37 ` Ma, Maurice
  0 siblings, 1 reply; 2+ messages in thread
From: Patrick Rudolph @ 2021-01-25 15:05 UTC (permalink / raw)
  To: devel; +Cc: maurice.ma, guo.dong, benjamin.you

The PciLib depends on PCDs
- PcdPciExpressBaseAddress
- PcdPciExpressBaseSize
being updated by BlSupportDxe before MMCONF accesses are working.

Add BlSupportDxe to APRIORI to start it first and get the system into
an useable state where at least PCI accesses work reliable.

Fixes a bug where BlSupportDxe is scheduled too late and other DXEs fail
to load due to broken PCI access.

Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
---
 UefiPayloadPkg/UefiPayloadPkg.fdf | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf b/UefiPayloadPkg/UefiPayloadPkg.fdf
index a97ace7395..1ae260c13a 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.fdf
+++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
@@ -80,6 +80,11 @@ READ_STATUS        = TRUE
 READ_LOCK_CAP      = TRUE
 READ_LOCK_STATUS   = TRUE
 
+APRIORI DXE {
+  INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
+  INF  MdeModulePkg/Universal/PCD/Dxe/Pcd.inf
+  INF  UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf
+}
 
 #
 # DXE Phase modules
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] UefiPayloadPkg: Fix PciLib dependency on BlSupportDxe
  2021-01-25 15:05 [PATCH] UefiPayloadPkg: Fix PciLib dependency on BlSupportDxe Patrick Rudolph
@ 2021-01-25 15:37 ` Ma, Maurice
  0 siblings, 0 replies; 2+ messages in thread
From: Ma, Maurice @ 2021-01-25 15:37 UTC (permalink / raw)
  To: Patrick Rudolph, devel@edk2.groups.io; +Cc: Dong, Guo, You, Benjamin

Reviewed-by:  Maurice Ma <maurice.ma@intel.com>

Regards
Maurice

> -----Original Message-----
> From: Patrick Rudolph <patrick.rudolph@9elements.com>
> Sent: Monday, January 25, 2021 7:05
> To: devel@edk2.groups.io
> Cc: Ma, Maurice <maurice.ma@intel.com>; Dong, Guo
> <guo.dong@intel.com>; You, Benjamin <benjamin.you@intel.com>
> Subject: [PATCH] UefiPayloadPkg: Fix PciLib dependency on BlSupportDxe
> 
> The PciLib depends on PCDs
> - PcdPciExpressBaseAddress
> - PcdPciExpressBaseSize
> being updated by BlSupportDxe before MMCONF accesses are working.
> 
> Add BlSupportDxe to APRIORI to start it first and get the system into an
> useable state where at least PCI accesses work reliable.
> 
> Fixes a bug where BlSupportDxe is scheduled too late and other DXEs fail to
> load due to broken PCI access.
> 
> Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
> ---
>  UefiPayloadPkg/UefiPayloadPkg.fdf | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf
> b/UefiPayloadPkg/UefiPayloadPkg.fdf
> index a97ace7395..1ae260c13a 100644
> --- a/UefiPayloadPkg/UefiPayloadPkg.fdf
> +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
> @@ -80,6 +80,11 @@ READ_STATUS        = TRUE
>  READ_LOCK_CAP      = TRUE READ_LOCK_STATUS   = TRUE +APRIORI DXE {+
> INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf+  INF
> MdeModulePkg/Universal/PCD/Dxe/Pcd.inf+  INF
> UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf+}  # # DXE Phase modules--
> 2.26.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-01-25 15:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-25 15:05 [PATCH] UefiPayloadPkg: Fix PciLib dependency on BlSupportDxe Patrick Rudolph
2021-01-25 15:37 ` Ma, Maurice

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox