From: "Ma, Maurice" <maurice.ma@intel.com>
To: Marcello Sylvester Bauer <marcello.bauer@9elements.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Patrick Rudolph <patrick.rudolph@9elements.com>,
Christian Walter <christian.walter@9elements.com>,
"Dong, Guo" <guo.dong@intel.com>,
"You, Benjamin" <benjamin.you@intel.com>
Subject: Re: [PATCH v2 1/1] UefiPayloadPkg: Make TerminalDxe build time configurable
Date: Wed, 24 Jun 2020 14:07:18 +0000 [thread overview]
Message-ID: <DM6PR11MB279373FABB331653984F5C8289950@DM6PR11MB2793.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200624095755.27057-2-marcello.bauer@9elements.com>
Reviewed-by: Maurice Ma <maurice.ma@intel.com>
> -----Original Message-----
> From: Marcello Sylvester Bauer <marcello.bauer@9elements.com>
> Sent: Wednesday, June 24, 2020 2:58
> To: devel@edk2.groups.io
> Cc: Patrick Rudolph <patrick.rudolph@9elements.com>; Christian Walter
> <christian.walter@9elements.com>; Ma, Maurice <maurice.ma@intel.com>;
> Dong, Guo <guo.dong@intel.com>; You, Benjamin <benjamin.you@intel.com>
> Subject: [PATCH v2 1/1] UefiPayloadPkg: Make TerminalDxe build time
> configurable
>
> From: Patrick Rudolph <patrick.rudolph@9elements.com>
>
> As the TerminalDxe significantly slows down the boot menu rendering, add the
> DISABLE_SERIAL_TERMINAL option to disable it at build time.
>
> Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
> Signed-off-by: Marcello Sylvester Bauer <marcello.bauer@9elements.com>
> Cc: Patrick Rudolph <patrick.rudolph@9elements.com>
> Cc: Christian Walter <christian.walter@9elements.com>
> Cc: Maurice Ma <maurice.ma@intel.com>
> Cc: Guo Dong <guo.dong@intel.com>
> Cc: Benjamin You <benjamin.you@intel.com>
> ---
> UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 5 +++++
> UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 5 +++++
> UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++
> 3 files changed, 12 insertions(+)
>
> diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> index c6c47833871b..49f42285882d 100644
> --- a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> +++ b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> @@ -58,6 +58,9 @@ [Defines]
> DEFINE UART_DEFAULT_STOP_BITS = 1 DEFINE
> DEFAULT_TERMINAL_TYPE = 0 + # Enabling the serial terminal will slow
> down the boot menu rendering!+ DEFINE DISABLE_SERIAL_TERMINAL =
> FALSE+ # # typedef struct { # UINT16 VendorId; ///< Vendor ID to
> match the PCI device. The value 0xFFFF terminates the list of entries.@@ -
> 502,7 +505,9 @@ [Components.IA32]
> MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf
> MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf
> MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.in
> f+!if $(DISABLE_SERIAL_TERMINAL) == FALSE
> MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf+!endif
> UefiPayloadPkg/GraphicsOutputDxe/GraphicsOutputDxe.inf #--------------------
> ----------diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> index 5559b1258521..33805902f705 100644
> --- a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> +++ b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> @@ -59,6 +59,9 @@ [Defines]
> DEFINE UART_DEFAULT_STOP_BITS = 1 DEFINE
> DEFAULT_TERMINAL_TYPE = 0 + # Enabling the serial terminal will slow
> down the boot menu redering!+ DEFINE DISABLE_SERIAL_TERMINAL =
> FALSE+ # # typedef struct { # UINT16 VendorId; ///< Vendor ID to
> match the PCI device. The value 0xFFFF terminates the list of entries.@@ -
> 504,7 +507,9 @@ [Components.X64]
> MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf
> MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf
> MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.in
> f+!if $(DISABLE_SERIAL_TERMINAL) == FALSE
> MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf+!endif
> UefiPayloadPkg/GraphicsOutputDxe/GraphicsOutputDxe.inf #--------------------
> ----------diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf
> b/UefiPayloadPkg/UefiPayloadPkg.fdf
> index dfbcde566849..03ff6a9595d1 100644
> --- a/UefiPayloadPkg/UefiPayloadPkg.fdf
> +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
> @@ -131,7 +131,9 @@ [FV.DXEFV]
> INF MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf
> INF MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf INF
> MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.in
> f+!if $(DISABLE_SERIAL_TERMINAL) == FALSE INF
> MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf+!endif INF
> UefiPayloadPkg/GraphicsOutputDxe/GraphicsOutputDxe.inf #--
> 2.25.4
next prev parent reply other threads:[~2020-06-24 14:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 9:57 [PATCH v2 0/1] UefiPayloadPkg: Make TerminalDxe build time configurable marcello.bauer
2020-06-24 9:57 ` [PATCH v2 1/1] " Marcello Sylvester Bauer
2020-06-24 14:07 ` Ma, Maurice [this message]
2020-06-24 14:32 ` Guo Dong
2020-07-13 10:13 ` Marcello Sylvester Bauer
2020-07-13 15:58 ` [edk2-devel] " Guo Dong
2020-07-13 16:54 ` Marcello Sylvester Bauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB279373FABB331653984F5C8289950@DM6PR11MB2793.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox