From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web12.14473.1593007647877551874 for ; Wed, 24 Jun 2020 07:07:28 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=h/dDM8LI; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: maurice.ma@intel.com) IronPort-SDR: gBgrhhM0tFJyeXJ54EKulHSD1FF/v1BqzFp7psMt//3LNhi1uqf8K/N+lAjckl+lpF+ATCOIAe J6pu1frPjlPg== X-IronPort-AV: E=McAfee;i="6000,8403,9662"; a="205970138" X-IronPort-AV: E=Sophos;i="5.75,275,1589266800"; d="scan'208";a="205970138" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2020 07:07:21 -0700 IronPort-SDR: RnE/7quEakwRENntJzi89kEBYX2qa2T6V3oFgyz2/jUPszF4W3rQIoclGebFvtOS9rGLkeImyk pzSFuqDT+SAw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,275,1589266800"; d="scan'208";a="263647416" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by fmsmga007.fm.intel.com with ESMTP; 24 Jun 2020 07:07:21 -0700 Received: from orsmsx156.amr.corp.intel.com (10.22.240.22) by ORSMSX109.amr.corp.intel.com (10.22.240.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 24 Jun 2020 07:07:21 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX156.amr.corp.intel.com (10.22.240.22) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 24 Jun 2020 07:07:20 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 24 Jun 2020 07:07:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ijS/nINen/RFbRDge9bKYdjEn1K64dR226lneL3F5QkCP3xT4vRyLHEbVtlW5QpBi16lRAM2jVBTmMsbrVsGYtNwp+qMmBApGO+pu4SeZP8ykoqhdcJr2SHpkTXBIye0ZfMXuN9pvChVMdrQUCavprg+g8P3EnrTasaTNMo3p5FbRrIY+zteFK9L0Z+TQh6odGbgXwjvp76zaUO6An/2/pvDfVg9Bi3FF3fknK8yjdVOaArev3Ybqpm6tzhYf0tHfi2KBXbp2+7QfHbuqjJsH7yGYiLw3DLRH/8y/yW6TeGljiJJzvlnOFU0iAdyf5c0UPhGkmq30AQ3R2mRKbUbTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XCU5XQ9LBUDLNlFka0S0qwyPdi6k0TNVnPOG5Rh3X14=; b=STWURg0f7le9+GyMvNwtXniY2VWYyc4Vhz2PL7TH8bpDkA50jpJp5s3lUB6zA5afzt/ehAKEVF7oTFegya6rCg4hWH4z2/B2aAOV5qSWlja+9HiigZlKgq/bRA9JuXDdvMBFkeG7cdtB95tKpxt/UGVwqkD359hVHpo4+y1ZTASrnGDh/ET62f8tUGWNhnk+NHUVdlzGrs0R0u1mulWwJ0JnNtCTDjg0V4myWB/zFZGox0kO44sDBYIxAVc4pNRs9Xfqkcxz2vvP9HgkGttEZUdPy+zrp8J8NhEnarRe8SGcMWsS8XWOJUyyLpytuDtUs5yVP3XYZAxZaCZ8PwFj0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XCU5XQ9LBUDLNlFka0S0qwyPdi6k0TNVnPOG5Rh3X14=; b=h/dDM8LIOuEcGV7VQzdLRsR7PxkBDRMIgxwji9Ujrhzv4Fpfgq0DCo2d88/Xy6HVHyePnzMooSEbcZezxb2DHceW76UiZchXQuWQdMsWRcR5XWonxIjImwQnDsSk5oJUzsHm7Ff+OI8dmZiu+tsJyQPGMrO7UI1ISQsDVjOL2Ss= Received: from DM6PR11MB2793.namprd11.prod.outlook.com (2603:10b6:5:c0::29) by DM6PR11MB2585.namprd11.prod.outlook.com (2603:10b6:5:ce::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.21; Wed, 24 Jun 2020 14:07:19 +0000 Received: from DM6PR11MB2793.namprd11.prod.outlook.com ([fe80::d43:5665:5cee:b3c5]) by DM6PR11MB2793.namprd11.prod.outlook.com ([fe80::d43:5665:5cee:b3c5%6]) with mapi id 15.20.3109.027; Wed, 24 Jun 2020 14:07:19 +0000 From: "Ma, Maurice" To: Marcello Sylvester Bauer , "devel@edk2.groups.io" CC: Patrick Rudolph , Christian Walter , "Dong, Guo" , "You, Benjamin" Subject: Re: [PATCH v2 1/1] UefiPayloadPkg: Make TerminalDxe build time configurable Thread-Topic: [PATCH v2 1/1] UefiPayloadPkg: Make TerminalDxe build time configurable Thread-Index: AQHWSg33RXwTGJ/lwUyJfFTve3ACqKjnzVOg Date: Wed, 24 Jun 2020 14:07:18 +0000 Message-ID: References: <20200624095755.27057-1-marcello.bauer@9elements.com> <20200624095755.27057-2-marcello.bauer@9elements.com> In-Reply-To: <20200624095755.27057-2-marcello.bauer@9elements.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action authentication-results: 9elements.com; dkim=none (message not signed) header.d=none;9elements.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [104.153.200.60] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 62e09f3f-9e06-495f-c41d-08d81847e830 x-ms-traffictypediagnostic: DM6PR11MB2585: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1332; x-forefront-prvs: 0444EB1997 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BQA7l0iZnWCukr5h1jwo3AY54QF9RKHzL1zyFnYSbK3r8wo6gdJty0jXv+VDeLzXqAb+yRdzYdavmT2S6VpQxBl8XvIr8X00EyLUTV/bA/Ssn9f5fkAF+FaIZV5vDBT7rOqS7MCA/DPaPtzNaw24TxXmEmtINbDROP7qTmv7S1iSBqOG/vSNQ9MqdPDmt/IE9DmPBHNs8Ja0POb2Yh+OK+Q2E4vh2SvgxJwA6GotedIVOIW3WeQ7evyYCYW+Sxs16L5OiRt2d7OYP0Z1yzMabcdfV+nWo21HR5NGtlnEYrbO8EyUcPwld05kK6qD+jRW/MnvKbMI0OUpvRfc9U/qXQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB2793.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(346002)(136003)(376002)(396003)(39860400002)(366004)(7696005)(83380400001)(53546011)(110136005)(8676002)(107886003)(26005)(54906003)(52536014)(55016002)(316002)(9686003)(186003)(19627235002)(2906002)(76116006)(4326008)(5660300002)(66946007)(6506007)(71200400001)(64756008)(66556008)(478600001)(66446008)(8936002)(33656002)(66476007)(86362001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: clxqmKAmwDzVbEj3CyaN6BILhq8Qa8h3wFP8fqt8il73vvJa2IImEtf2oQ4+wvlGWiRcIXqhQ9LxnvavfqdcMTlj3K7EyITVm2McrYZSmRN44BLFN7OI6kiEJNDrnvKgoSBA0rV21c83x8vASWlU4ugB5jtc7m4ql9lsvAYcLANB3KUz/DDa3ZvZ6AvCkoSBD4OEB7sXl4zZBwJJIefkbNKiDv+Ayd79dpP1RPZlA8aO7NG7Y+OOUnqtWdbVRJO/kagCA9ltc2+QR767rpIkDYBu0QGcG3Dw/3cV3GnFNnsTwyntOqEC6kNHeDFNTHhjG2pSKZjwmIRUBPB11OpFc+k4RK0JeD4TNfIrk1RLpO+44jHATRS+h8vZI/VhRhcvPiya7wAwrE87e5mzObYa8GiI0bHvymfOpxHWLLp0ehenzK0zxrMNA/uK8vdoNbjQUg5xkcX6+P66WuYRLP+Ssfw/7lCKbg/Q5E2YeMeeoyhLaznWcLU+dAXdwwtg3iNo MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 62e09f3f-9e06-495f-c41d-08d81847e830 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jun 2020 14:07:18.9050 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KWTe/+IQgrrIXG0A0ecXa0dMmoaLEI1ZmLpB3KfNDtd97qy7PY6KS8P7S3FH6DHSAY9qSnqgHRiNlZsxyEi4qw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2585 Return-Path: maurice.ma@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Maurice Ma > -----Original Message----- > From: Marcello Sylvester Bauer > Sent: Wednesday, June 24, 2020 2:58 > To: devel@edk2.groups.io > Cc: Patrick Rudolph ; Christian Walter > ; Ma, Maurice ; > Dong, Guo ; You, Benjamin > Subject: [PATCH v2 1/1] UefiPayloadPkg: Make TerminalDxe build time > configurable >=20 > From: Patrick Rudolph >=20 > As the TerminalDxe significantly slows down the boot menu rendering, add = the > DISABLE_SERIAL_TERMINAL option to disable it at build time. >=20 > Signed-off-by: Patrick Rudolph > Signed-off-by: Marcello Sylvester Bauer > Cc: Patrick Rudolph > Cc: Christian Walter > Cc: Maurice Ma > Cc: Guo Dong > Cc: Benjamin You > --- > UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 5 +++++ > UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 5 +++++ > UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++ > 3 files changed, 12 insertions(+) >=20 > diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > index c6c47833871b..49f42285882d 100644 > --- a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > +++ b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > @@ -58,6 +58,9 @@ [Defines] > DEFINE UART_DEFAULT_STOP_BITS =3D 1 DEFINE > DEFAULT_TERMINAL_TYPE =3D 0 + # Enabling the serial terminal will= slow > down the boot menu rendering!+ DEFINE DISABLE_SERIAL_TERMINAL =3D > FALSE+ # # typedef struct { # UINT16 VendorId; ///< V= endor ID to > match the PCI device. The value 0xFFFF terminates the list of entries.@@= - > 502,7 +505,9 @@ [Components.IA32] > MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf > MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf > MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.in > f+!if $(DISABLE_SERIAL_TERMINAL) =3D=3D FALSE > MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf+!endif > UefiPayloadPkg/GraphicsOutputDxe/GraphicsOutputDxe.inf #--------------= ------ > ----------diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > index 5559b1258521..33805902f705 100644 > --- a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > +++ b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > @@ -59,6 +59,9 @@ [Defines] > DEFINE UART_DEFAULT_STOP_BITS =3D 1 DEFINE > DEFAULT_TERMINAL_TYPE =3D 0 + # Enabling the serial terminal will= slow > down the boot menu redering!+ DEFINE DISABLE_SERIAL_TERMINAL =3D > FALSE+ # # typedef struct { # UINT16 VendorId; ///< V= endor ID to > match the PCI device. The value 0xFFFF terminates the list of entries.@@= - > 504,7 +507,9 @@ [Components.X64] > MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf > MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf > MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.in > f+!if $(DISABLE_SERIAL_TERMINAL) =3D=3D FALSE > MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf+!endif > UefiPayloadPkg/GraphicsOutputDxe/GraphicsOutputDxe.inf #--------------= ------ > ----------diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf > b/UefiPayloadPkg/UefiPayloadPkg.fdf > index dfbcde566849..03ff6a9595d1 100644 > --- a/UefiPayloadPkg/UefiPayloadPkg.fdf > +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf > @@ -131,7 +131,9 @@ [FV.DXEFV] > INF MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf > INF MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf INF > MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.in > f+!if $(DISABLE_SERIAL_TERMINAL) =3D=3D FALSE INF > MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf+!endif INF > UefiPayloadPkg/GraphicsOutputDxe/GraphicsOutputDxe.inf #-- > 2.25.4