From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.22009.1594654075486528741 for ; Mon, 13 Jul 2020 08:27:55 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=v16HR4yy; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: maurice.ma@intel.com) IronPort-SDR: B1t/RkJnGISGGapPPmaYtj+0V6L0MX2iwLXZyfpV8ZOkB07qaOZmfDaODF/V3rRJLnIpyzOLvS Hg/BKmIdxyrQ== X-IronPort-AV: E=McAfee;i="6000,8403,9681"; a="136106243" X-IronPort-AV: E=Sophos;i="5.75,347,1589266800"; d="scan'208";a="136106243" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2020 08:27:54 -0700 IronPort-SDR: UlXGxPt6SZ9P6iFVTib6ZeoMSzouxBjZWJQTUvzayOo42xzE7RiFDa55KYBg5BZPjszrAHtBd8 4N5949TOjd0w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,347,1589266800"; d="scan'208";a="317412020" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga002.fm.intel.com with ESMTP; 13 Jul 2020 08:27:54 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 13 Jul 2020 08:27:53 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.173) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 13 Jul 2020 08:27:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RphvSJntD/4OSQNXn3k/egMhWIPkmeoZwXbeRKbauB8eKdQaBayzCkUH/D5a3vUlxhC8CnUrDEbSAWtheLS11lorL7cuIYEwNbqH5BYHmclZWP1rlrMQOS9uMFhmvWWMZ3inDh3JzzzH90dw27I6KLKqc1yGMgKQ2cfi5IJcL21HhUm9MrVAE8Xgm39jduH7+Ax5ZJ7hjT2GwZ1kkHFoZsy55zq+qbk6E4oMnhu9P9O8RoMjo/8BHWaUG2mUCGxHR4MKdA/3G58puSZiii9I6fOTa93Gtr9rabmuoQTQf8AiFSHzJronDMC6fcGjrVLGKzGvmZQm2jN9Vo4Tzh8N9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n+BW99HbNLFBSP56saWe9GOOOgH3DaOPoYwmO1qpq1A=; b=ej1ipt3O4UwG/SMsH1+LATCRX3vrlchpf8PcektLSoBKLALszDu8xS55ju0lryfO79LrYgICNzOhuOFLE+lQiROxeDSLghljSiXLbhT0xUdOd/gmd/RsNjYgi2cnxwCDXPH5keiFkiGWZ5GK5KyYg0l5zfIKXAIDg0zjEmDj37du3owMHjd4RcByQC/nNSDVPo2UJQ5I4nEhJLEcTHCVsbt4/cZkfO4+nm405yaAG7TFaChXFAp28S9EYvZLdP2XK2wiGMN7l8gMaONe6TDa83D5YJzUl7DEyNeGFbWogI7Zy6gotkPHIB4h7RfloIGOGput5QPgZQTyjbtVZeEw/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n+BW99HbNLFBSP56saWe9GOOOgH3DaOPoYwmO1qpq1A=; b=v16HR4yyIO/si1PnGFKfTy6XY9PEzJDDlOBH9IpOV1USXXmdiON/QgnWVklckf3ELnguDK14C0z5boinY03efebK01CIOV8CCXIuv1vNiDaZDshFKCrBQZ+TGRuRkJExuXlj86IqpmZdj/v4l2SFbpPL+t3zUtpOTXcY4J7IcSk= Received: from DM6PR11MB2793.namprd11.prod.outlook.com (2603:10b6:5:c0::29) by DM6PR11MB2793.namprd11.prod.outlook.com (2603:10b6:5:c0::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.21; Mon, 13 Jul 2020 15:27:46 +0000 Received: from DM6PR11MB2793.namprd11.prod.outlook.com ([fe80::d43:5665:5cee:b3c5]) by DM6PR11MB2793.namprd11.prod.outlook.com ([fe80::d43:5665:5cee:b3c5%6]) with mapi id 15.20.3174.025; Mon, 13 Jul 2020 15:27:46 +0000 From: "Ma, Maurice" To: Marcello Sylvester Bauer , "devel@edk2.groups.io" CC: Patrick Rudolph , Christian Walter , "Desimone, Nathaniel L" , "Zeng, Star" Subject: Re: [PATCH v2 1/1] UefiPayloadPkg: Remove x86 legacy UART defaults Thread-Topic: [PATCH v2 1/1] UefiPayloadPkg: Remove x86 legacy UART defaults Thread-Index: AQHWWO8vhdFJN7Tno0Kh/J31YXFcrKkFoKpA Date: Mon, 13 Jul 2020 15:27:46 +0000 Message-ID: References: <20200713082522.5168-1-marcello.bauer@9elements.com> <20200713082522.5168-2-marcello.bauer@9elements.com> In-Reply-To: <20200713082522.5168-2-marcello.bauer@9elements.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action authentication-results: 9elements.com; dkim=none (message not signed) header.d=none;9elements.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [104.153.200.60] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 345cb996-e20b-40c0-f150-08d827414b55 x-ms-traffictypediagnostic: DM6PR11MB2793: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CMeT53uar4XNVcxfNJ0Y5U5DozEE3IesxYUshbRfWLBRJZ9RqnH7on9myaf/X4QAHBiIq5LCtHQEVRjVm03xr/CXL8D09OM7Cm0A7xDZPkoBod6Mr9u4MkNxDP5geV9Qy3iTEl53Q9YImWNE3TMBoTpOxsaQNpuZkpupngprPmBQSUmHL9Z54EJ35oxeBNXlBQeBSnh5B6NsaSrBYD23z3UjYXLl19LVAVkK02Jw6I63VGB9bepUGMaRyy7VtOwoBZcMKejRc0mqfSVu4Fpl99M/pZLkZ71HKQGftOw2gRdT/Ww8A3NoZ3PY2tAkXRbpqHsPWxttYQSPjUJemEvXaA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB2793.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(39860400002)(366004)(136003)(346002)(376002)(396003)(2906002)(33656002)(71200400001)(26005)(5660300002)(54906003)(55016002)(9686003)(478600001)(186003)(8676002)(6506007)(53546011)(19627235002)(76116006)(316002)(66946007)(66446008)(64756008)(66476007)(66556008)(4326008)(8936002)(83380400001)(52536014)(110136005)(86362001)(107886003)(7696005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: 9Sj33NoGulT0boY5qQSnlTv71RHVLzM29loDqQWCq3yDFjbwFTyeaV1YGU03kcEIa3nOcppB/mW3TUstP74R1AVLNElHW9HUXyic7eXG77ATx1CDDwjtXOzYgRqNqmDmoRx3bULypzaGBqYGRvOVaTL8L6eyWg/neGf6TvvCxrdavLiFX/e9+4TlvTujDwmLJLhs4tu6RzvxS7kC7XfhOUzLAHHbX8S5I81nfPbeb2tVRvWeaqXYM4NOor/x2nwO7BVwANxhrlRON4F70TH8Gy7VS9Ev5NSaiCWoUStmG1JF4RG2qfyvbmcDPg4rgcC2oFzHat2eCjgeUbRMQVeJ7bOD+4CTDn+oMxxdyAy8Spi0iE0VCqxokOy/TbbT+UHiMUzynUwieZbkUWB2+CCaW9bU4ODEJgs0Uiv9jtvuhla7mGRWeSm51cA5xlsLl3Lw7xPdxvO8nl3v1enBUCi8L/YfSwH056l7SnCST8UyzEqbe6OL5kxpTsKTfK9JV8om MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2793.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 345cb996-e20b-40c0-f150-08d827414b55 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2020 15:27:46.1667 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WCkJo2Rj33GJkfLF0aZdytUP+cDnZPqAjRAA/B/7S6PU8VbH9U0cXOD1psottl1Tv24ZFHzh3qDn46QciQ/LtQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2793 Return-Path: maurice.ma@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable As I mentioned in the previous comments, could you please CC all UefiPaylo= adPkg maintainers listed in the Maintainers.txt under the root of the EDK2 = directory for code changes in UefiPayloadPkg ? =20 Other than that, this patch looks good to me. Reviewed-by: Maurice Ma Thanks Maurice > -----Original Message----- > From: Marcello Sylvester Bauer > Sent: Monday, July 13, 2020 1:25 > To: devel@edk2.groups.io > Cc: Patrick Rudolph ; Christian Walter > ; Ma, Maurice ; > Desimone, Nathaniel L ; Zeng, Star > > Subject: [PATCH v2 1/1] UefiPayloadPkg: Remove x86 legacy UART defaults >=20 > From: Patrick Rudolph >=20 > The BaseSerialPortLib16550 does fallback to a fixed address UART defined = by > PcdSerialRegisterBase and does not initialize if it is zero. Do not assum= e a serial > port at 0x3F8, otherwise it could cause errors during initialisation of a= non- > existent serial port on non legacy platforms. >=20 > Signed-off-by: Patrick Rudolph > Signed-off-by: Marcello Sylvester Bauer > Cc: Patrick Rudolph > Cc: Christian Walter > Cc: Maurice Ma > Cc: Nate DeSimone > Cc: Star Zeng > --- > UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 2 +- > UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > index 0efcfa8fb2f4..0d8854810700 100644 > --- a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > +++ b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > @@ -306,7 +306,7 @@ [PcdsPatchableInModule.common] > # The following parameters are set by Library/PlatformHookLib # > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseMmio|FALSE- > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x3f8+ > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0 > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialBaudRate|$(BAUD_RATE) > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterStride|1 diff --git > a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > index d645d233cd08..34640b1fc1da 100644 > --- a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > +++ b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > @@ -307,7 +307,7 @@ [PcdsPatchableInModule.common] > # The following parameters are set by Library/PlatformHookLib # > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseMmio|FALSE- > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x3f8+ > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0 > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialBaudRate|$(BAUD_RATE) > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterStride|1 -- > 2.27.0