From: "Ma, Maurice" <maurice.ma@intel.com>
To: Marcello Sylvester Bauer <marcello.bauer@9elements.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "patrick.rudolph@9elements.com" <patrick.rudolph@9elements.com>,
"Dong, Guo" <guo.dong@intel.com>,
"You, Benjamin" <benjamin.you@intel.com>
Subject: Re: [PATCH v2 1/1] UefiPayloadPkg: Set default PciBaseSize on Ia32
Date: Tue, 13 Oct 2020 19:00:51 +0000 [thread overview]
Message-ID: <DM6PR11MB2793EF61D41614B600CC626689040@DM6PR11MB2793.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20201013133338.27507-2-marcello.bauer@9elements.com>
Reviewed-by:
Maurice Ma <maurice.ma@intel.com>
> -----Original Message-----
> From: Marcello Sylvester Bauer <marcello.bauer@9elements.com>
> Sent: Tuesday, October 13, 2020 6:34
> To: devel@edk2.groups.io
> Cc: Marcello Sylvester Bauer <marcello.bauer@9elements.com>;
> patrick.rudolph@9elements.com; Ma, Maurice <maurice.ma@intel.com>; Dong,
> Guo <guo.dong@intel.com>; You, Benjamin <benjamin.you@intel.com>
> Subject: [PATCH v2 1/1] UefiPayloadPkg: Set default PciBaseSize on Ia32
>
> * Add needed PcdPciExpressBaseSize default on Ia32 targets analog to X64 in:
> 8028b2907e20b21cd7d69639a36ac82a77c81dc1
> * Remove no longer required build-time PcdPciExpressBaseAddress with regards
> to:
> 3900a63e3a1b9ba9a4105bedead7b986188cec2c
>
> Signed-off-by: Marcello Sylvester Bauer <marcello.bauer@9elements.com>
> Cc: Patrick Rudolph <patrick.rudolph@9elements.com>
> Cc: Maurice Ma <maurice.ma@intel.com>
> Cc: Guo Dong <guo.dong@intel.com>
> Cc: Benjamin You <benjamin.you@intel.com>
> ---
> UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> index 12d7ffe81416..d1fcbbb50207 100644
> --- a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> +++ b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> @@ -292,8 +292,6 @@ [PcdsFixedAtBuild]
> gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE
>
> gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa,
> 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23,
> 0x31 }
>
>
>
> - gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|$(PCIE_BASE)
>
> -
>
> !if $(SOURCE_DEBUG_ENABLE)
>
> gEfiSourceLevelDebugPkgTokenSpaceGuid.PcdDebugLoadImageMethod|0x2
>
> !endif
>
> @@ -364,6 +362,7 @@ [PcdsDynamicDefault]
> gEfiMdeModulePkgTokenSpaceGuid.PcdConOutRow|31
>
> gEfiMdeModulePkgTokenSpaceGuid.PcdConOutColumn|100
>
> gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0
>
> + gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseSize|0
>
>
>
>
> #############################################################
> ###################
>
> #
>
> --
> 2.28.0
next prev parent reply other threads:[~2020-10-13 19:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 13:33 [PATCH v2 0/1] UefiPayloadPkg: Set default PciBaseSize on Ia32 Marcello Sylvester Bauer
2020-10-13 13:33 ` [PATCH v2 1/1] " Marcello Sylvester Bauer
2020-10-13 19:00 ` Ma, Maurice [this message]
2020-10-13 19:02 ` [PATCH v2 0/1] " Ma, Maurice
2020-10-22 8:25 ` Marcello Sylvester Bauer
2020-10-23 2:49 ` Guo Dong
[not found] ` <16407F3C2F4AEB24.28553@groups.io>
2020-10-23 22:36 ` [edk2-devel] " Guo Dong
2020-11-09 10:47 ` Marcello Sylvester Bauer
2020-11-10 4:13 ` Guo Dong
2020-11-10 13:23 ` Marcello Sylvester Bauer
2020-11-10 19:28 ` Guo Dong
2020-11-11 17:51 ` Patrick Rudolph
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB2793EF61D41614B600CC626689040@DM6PR11MB2793.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox