From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "Kuo, IanX" <ianx.kuo@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Lu, James" <james.lu@intel.com>,
"Kumar, Chandana C" <chandana.c.kumar@intel.com>,
"Prabhala, Varalakshmi A" <varalakshmi.a.prabhala@intel.com>,
"Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>
Subject: Re: [edk2-platforms] [PATCH v6 5/6] Platform/Intel/WhiskeylakeOpenBoardPkg: Add ReportCpuHobLib.
Date: Tue, 21 Jul 2020 01:04:59 +0000 [thread overview]
Message-ID: <DM6PR11MB28092DFFAD4CD6C880EA1BD8E6780@DM6PR11MB2809.namprd11.prod.outlook.com> (raw)
In-Reply-To: <69e1d53bfdd22ccf030eec040a9258d90e4a801a.1595291556.git.ianx.kuo@intel.com>
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> -----Original Message-----
> From: Kuo, IanX <ianx.kuo@intel.com>
> Sent: Tuesday, July 21, 2020 8:36 AM
> To: devel@edk2.groups.io
> Cc: Lu, James <james.lu@intel.com>; Kumar, Chandana C
> <chandana.c.kumar@intel.com>; Prabhala, Varalakshmi A
> <varalakshmi.a.prabhala@intel.com>; Kuo, IanX <ianx.kuo@intel.com>;
> Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>
> Subject: [edk2-platforms] [PATCH v6 5/6]
> Platform/Intel/WhiskeylakeOpenBoardPkg: Add ReportCpuHobLib.
>
> Create a Library instance of ReportCpuHobLib from PlatformInitPei driver.
> PA bits reported can be overridden by Library instance in Platform.
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2674
>
> Change-Id: I999b29c30993c397f918a1f7b4ea19c61c0a460d
> Signed-off-by: IanX Kuo <ianx.kuo@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> ---
> .../Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc | 4 +++-
> .../WhiskeylakeURvp/OpenBoardPkg.dsc | 6
> ++++--
> 2 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
> index fdf85b43..f78dba87 100644
> ---
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
> +++
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
> @@ -39,7 +39,8 @@
> #
>
> # Include PCD configuration for this board.
>
> #
>
> - !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
>
>
> + !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
>
> +
>
> !include OpenBoardPkgPcd.dsc
>
> !include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc
>
>
>
> @@ -121,6 +122,7 @@
> PeiLib|$(PLATFORM_PACKAGE)/Library/PeiLib/PeiLib.inf
>
>
> PlatformBootManagerLib|$(PLATFORM_PACKAGE)/Bds/Library/DxePlatformB
> ootManagerLib/DxePlatformBootManagerLib.inf
>
>
> ReportFvLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/PeiReportFvLib/Pei
> ReportFvLib.inf
>
> +
> ReportCpuHobLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/ReportCpuH
> obLib/ReportCpuHobLib.inf
>
>
> TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLibNu
> ll/TestPointCheckLibNull.inf
>
>
>
> #######################################
>
> diff --git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP
> kg.dsc
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP
> kg.dsc
> index 11dffb08..9ee4030a 100644
> ---
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP
> kg.dsc
> +++
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP
> kg.dsc
> @@ -1,7 +1,7 @@
> ## @file
>
> # The main build description file for the WhiskeylakeURvp board.
>
> #
>
> -# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
>
> +# Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.<BR>
>
> #
>
> # SPDX-License-Identifier: BSD-2-Clause-Patent
>
> #
>
> @@ -39,7 +39,8 @@
> #
>
> # Include PCD configuration for this board.
>
> #
>
> - !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
>
>
> + !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
>
> +
>
> !include OpenBoardPkgPcd.dsc
>
> !include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc
>
>
>
> @@ -121,6 +122,7 @@
> PeiLib|$(PLATFORM_PACKAGE)/Library/PeiLib/PeiLib.inf
>
>
> PlatformBootManagerLib|$(PLATFORM_PACKAGE)/Bds/Library/DxePlatformB
> ootManagerLib/DxePlatformBootManagerLib.inf
>
>
> ReportFvLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/PeiReportFvLib/Pei
> ReportFvLib.inf
>
> +
> ReportCpuHobLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/ReportCpuH
> obLib/ReportCpuHobLib.inf
>
>
> TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLibNu
> ll/TestPointCheckLibNull.inf
>
>
>
> #######################################
>
> --
> 2.26.2.windows.1
next prev parent reply other threads:[~2020-07-21 1:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 0:35 [edk2-platforms] [PATCH v6 0/6] Create a Library instance of ReportCpuHobLib IanX Kuo
2020-07-21 0:35 ` [edk2-platforms] [PATCH v6 1/6] Platform/Intel/MinPlatformPkg: Fix build error IanX Kuo
2020-07-21 0:58 ` Chiu, Chasel
2020-07-21 2:12 ` [edk2-devel] " Liming Gao
2020-07-21 2:51 ` 回覆: " IanX Kuo
2020-07-21 0:35 ` [edk2-platforms] [PATCH v6 2/6] Platform/Intel/CometlakeOpenBoardPkg: Add ReportCpuHobLib IanX Kuo
2020-07-21 1:04 ` [edk2-devel] " Chiu, Chasel
2020-07-21 0:35 ` [edk2-platforms] [PATCH v6 3/6] Platform/Intel/KabylakeOpenBoardPkg: " IanX Kuo
2020-07-21 1:04 ` Chiu, Chasel
2020-07-21 0:36 ` [edk2-platforms] [PATCH v6 4/6] Platform/Intel/SimicsOpenBoardPkg: " IanX Kuo
2020-07-21 1:04 ` [edk2-devel] " Chiu, Chasel
2020-07-21 0:36 ` [edk2-platforms] [PATCH v6 5/6] Platform/Intel/WhiskeylakeOpenBoardPkg: " IanX Kuo
2020-07-21 1:04 ` Chiu, Chasel [this message]
2020-07-21 0:36 ` [edk2-platforms] [PATCH v6 6/6] Platform/Intel/MinPlatformPkg: " IanX Kuo
2020-07-21 1:05 ` Chiu, Chasel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB28092DFFAD4CD6C880EA1BD8E6780@DM6PR11MB2809.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox