From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.9628.1595293532664425425 for ; Mon, 20 Jul 2020 18:05:32 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=vW/7mR0i; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: chasel.chiu@intel.com) IronPort-SDR: oqUVGp4u2rTKF7MMds/79JJmVJR2XTUdAqgh/qbB/SavH+tqhRbMaORPKndT1EClE6kxSA/wCm pM8XDixWz+Vg== X-IronPort-AV: E=McAfee;i="6000,8403,9688"; a="149196995" X-IronPort-AV: E=Sophos;i="5.75,375,1589266800"; d="scan'208";a="149196995" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2020 18:05:26 -0700 IronPort-SDR: c23oAgr/7VmkhflQv0d1Wxxe/+r3f3au1+a8iuFyIAUSMeH42IJYx5/bjh788pSucxti48UFaL DCDeNBeTPr/g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,375,1589266800"; d="scan'208";a="326220302" Received: from orsmsx103.amr.corp.intel.com ([10.22.225.130]) by FMSMGA003.fm.intel.com with ESMTP; 20 Jul 2020 18:05:25 -0700 Received: from orsmsx161.amr.corp.intel.com (10.22.240.84) by ORSMSX103.amr.corp.intel.com (10.22.225.130) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 18:05:11 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX161.amr.corp.intel.com (10.22.240.84) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 18:05:12 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.47) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 18:05:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UKp9G80CGdtFR0sv/dmrmXb2hvl7CgKu0eKfIYvD/mWOnv+StKY2HOHHrJkLf/wRwUpeZD9e4Oj3MYTdWOLNO1ZKOwyzCD1ulkN6CeEBgp0RKR4FBqkqGPNcvsrHdJ7Bwrj59QHAMfIbJ+y2bC9/Y5IDzyibVNKmupCwpJW7TsAu16ZPmyGHK7JprAtfuofgfK3f71eeIVKJb+yRZgZwSxeXGaod3NzmxDUXOf9JFIqGK3zohdsfac2z1geQenk5DA1gGXnLd46VVRpUniH/YJGVsRmSa+HdxZU264p5VNhlsUIfR8CCJNMWkTmTOCK0+EoDAt02QJNeCh2MdkG95Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pR5qxB86oObwAZo5ziYG9UPz/PHTvsF7nl2CRKzOlD8=; b=ZmHdwMv6eloqwHvHXwsvCx4iDQrTE8fusp2zktJi+X66ZDgi/0qjqIUBsz5GU0LjyBZPZsaiEEJte1VSvY8hRIAj3ZAZo9PDHKbACS1WQ/aztSz+ceyYABdZ8ALEK1sjEgyN4lo8rVykbPTOKtLwxNDmbkEwukl3AjZsEPCM9Q1sORNO4tcQXeSqlS186z5RiL/Fw5ynofOuLpGwAvaSxHK04FoTfmV1wmTzT+sodejMavSzRwFm2qyiB9sdiQJeWR/LSUycmWZ6Swe4puKOYPECPEyarKAUIOjVbG8aLLXPGuh+CIsreLcwy+BSMxFZsBke3GDm77QEN6KOdHDlDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pR5qxB86oObwAZo5ziYG9UPz/PHTvsF7nl2CRKzOlD8=; b=vW/7mR0iOEdG7zjms9RFAmL1Yv0X6lwQ5DpXyg+5ObrE9oKMOBUJF4SKjK2YNkNImw+ypFkwtFiJWNPf/U/d+cZUCMjhFegXPjTQWxW5iyFQRtDYPowDwskVw5wdC63KD6XSFrl15jEgXPdIfobkXWpbQ/yQJkxWWwDZu/ArJx8= Received: from DM6PR11MB2809.namprd11.prod.outlook.com (2603:10b6:5:c5::14) by DM6PR11MB3353.namprd11.prod.outlook.com (2603:10b6:5:a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.24; Tue, 21 Jul 2020 01:05:08 +0000 Received: from DM6PR11MB2809.namprd11.prod.outlook.com ([fe80::24d5:3de9:3e29:8908]) by DM6PR11MB2809.namprd11.prod.outlook.com ([fe80::24d5:3de9:3e29:8908%3]) with mapi id 15.20.3195.025; Tue, 21 Jul 2020 01:05:08 +0000 From: "Chiu, Chasel" To: "Kuo, IanX" , "devel@edk2.groups.io" CC: "Lu, James" , "Kumar, Chandana C" , "Prabhala, Varalakshmi A" , "Chaganty, Rangasai V" Subject: Re: [edk2-platforms] [PATCH v6 6/6] Platform/Intel/MinPlatformPkg: Add ReportCpuHobLib. Thread-Topic: [edk2-platforms] [PATCH v6 6/6] Platform/Intel/MinPlatformPkg: Add ReportCpuHobLib. Thread-Index: AQHWXvcInj4UABpuNk+25aqk3Beq+6kRN/5w Date: Tue, 21 Jul 2020 01:05:08 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [61.60.205.141] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0e522cb3-2d33-489b-9011-08d82d121cbb x-ms-traffictypediagnostic: DM6PR11MB3353: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2449; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YtJtwYdv005eGoxHTSIZeWDXRqkbNm6V++cipH9mVtcjlA0akvRP1zX31sNHhAaBGmr2nQjU4ipy2MZWuKd0mRSppw0I+6s0v2+IgYy4yrrCsWRnCL4V91Ayxg6FllDoPJe0jKGrp00qtCASOo2u7rNKTFZgeeJIhmOVHHmZn669vNcrSMskteSR4AHNZ8jus6Xsr0ydqb/9ufCNkkHXCH/00c/vLLeYAmzukPqk/rROlvmNrTnfysnQlT4riOeErkzX7XwPQrF6vKtNK0iN9p7qUDVTVr7rkInD6S2sngYLxMmQjjUiOLLCUsciPjE4Uppl4VNbNFhcJpTQ3X4LSMKBSm+z/ZDC2R2G1t6NvGF8hRDRozK5/0DBzAs/NI5ArHXSUP8+3fFR2F790UB7Sw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB2809.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(39860400002)(396003)(376002)(346002)(366004)(316002)(5660300002)(66446008)(8676002)(64756008)(53546011)(7696005)(186003)(6506007)(66556008)(86362001)(66476007)(66946007)(26005)(76116006)(8936002)(33656002)(966005)(110136005)(54906003)(71200400001)(478600001)(4326008)(52536014)(2906002)(107886003)(83380400001)(55016002)(9686003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: 7ysHvL12sxIHM0lHeegnWzelLVjNJGl2h4jxGvd+IIFWxMpCR3r0aSvfs075oSF305ZJb7ijXtpCv06fGICEBAdYVeTd5P61ZTKlfRr5meancU0Da+TuUIFHdfWhydHmIxIvwwFqEZKph5dgHutFgj6yhdRcfOsrm97whda+6+32Yo+Fxho2zh+N10G9/X4sKNF6KDElAROwNd1s4QxkWe9Q6UyDOeTW+M2IhkhypWxg48xCb0TvzRic+l/oZGgWVYHidTDW/gCji7DjtLqIwbvW8IyzoN/Naysi44ita/F6bw7Oz38K9+I8W5qu/E8plxUwDQyNR+tKdWVCbJRYa1HZhniINa0I8ci2bVyoImxdpzn0VWu9hqoZFFRi6aNEdHKRasba0a9G2+axRBv2XW5dhAzd4knzHE/RseS4O4/xRhKUANxo1pp+WiZRIFUUNgDwByT3e50W7pBKSVUWaY0XiHp8TR03XIaJnS3jk22gaaxypgjuovtsGfVsIC49 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2809.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e522cb3-2d33-489b-9011-08d82d121cbb X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2020 01:05:08.6651 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BcKj13H4DqZzt3kxacwvNEv2vtavHVbPdCbwpxlVF/xmYAFRANoo0mMPX1fbV6KKDirImLmOlYvsVfOxsDWVdA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3353 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Kuo, IanX > Sent: Tuesday, July 21, 2020 8:37 AM > To: devel@edk2.groups.io > Cc: Lu, James ; Kumar, Chandana C > ; Prabhala, Varalakshmi A > ; Kuo, IanX ; > Chaganty, Rangasai V ; Chiu, Chasel > > Subject: [edk2-platforms] [PATCH v6 6/6] Platform/Intel/MinPlatformPkg: A= dd > ReportCpuHobLib. >=20 > Create a Library instance of ReportCpuHobLib from PlatformInitPei driver. > PA bits reported can be overridden by Library instance in Platform. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2674 >=20 > Change-Id: I1c14aece3b229c194960e91dc9505dd8120bbe30 > Signed-off-by: IanX Kuo > Cc: Sai Chaganty > Cc: Chasel Chiu > --- > .../Intel/MinPlatformPkg/MinPlatformPkg.dsc | 3 ++- > .../PlatformInitPei/PlatformInitPreMem.c | 25 ++----------------- > .../PlatformInitPei/PlatformInitPreMem.inf | 3 ++- > 3 files changed, 6 insertions(+), 25 deletions(-) >=20 > diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > index 13a0fda2..b62351da 100644 > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > @@ -1,7 +1,7 @@ > ## @file >=20 > # Platform description. >=20 > # >=20 > -# Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
>=20 > +# Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved.
>=20 > # >=20 > # SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > # >=20 > @@ -92,6 +92,7 @@ > # >=20 >=20 > FspWrapperPlatformLib|MinPlatformPkg/FspWrapper/Library/PeiFspWrappe > rPlatformLib/PeiFspWrapperPlatformLib.inf >=20 >=20 > ReportFvLib|MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiReport > FvLib.inf >=20 > + > ReportCpuHobLib|MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/R > eportCpuHobLib.inf >=20 >=20 > TestPointCheckLib|MinPlatformPkg/Test/Library/TestPointCheckLib/PeiTestPo > intCheckLib.inf >=20 >=20 > TestPointLib|MinPlatformPkg/Test/Library/TestPointLib/PeiTestPointLib.inf >=20 >=20 > SetCacheMtrrLib|MinPlatformPkg/Library/SetCacheMtrrLib/SetCacheMtrrLib > Null.inf >=20 > diff --git > a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInit= Pr > eMem.c > b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInit= Pr > eMem.c > index efdeb6a9..48cbe0df 100644 > --- > a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInit= Pr > eMem.c > +++ > b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInit= Pr > eMem.c > @@ -1,7 +1,7 @@ > /** @file >=20 > Source code file for Platform Init Pre-Memory PEI module >=20 >=20 >=20 > -Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
>=20 > +Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved.
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 >=20 >=20 > **/ >=20 > @@ -26,6 +26,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > #include >=20 > #include >=20 > #include >=20 > +#include >=20 > #include >=20 > #include >=20 > #include >=20 > @@ -355,28 +356,6 @@ Done: > return EFI_SUCCESS; >=20 > } >=20 >=20 >=20 > -VOID >=20 > -ReportCpuHob ( >=20 > - VOID >=20 > - ) >=20 > -{ >=20 > - UINT8 PhysicalAddressBits; >=20 > - UINT32 RegEax; >=20 > - >=20 > - AsmCpuid (0x80000000, &RegEax, NULL, NULL, NULL); >=20 > - if (RegEax >=3D 0x80000008) { >=20 > - AsmCpuid (0x80000008, &RegEax, NULL, NULL, NULL); >=20 > - PhysicalAddressBits =3D (UINT8) RegEax; >=20 > - } else { >=20 > - PhysicalAddressBits =3D 36; >=20 > - } >=20 > - >=20 > - /// >=20 > - /// Create a CPU hand-off information >=20 > - /// >=20 > - BuildCpuHob (PhysicalAddressBits, 16); >=20 > -} >=20 > - >=20 > /** >=20 > Install Firmware Volume Hob's once there is main memory >=20 >=20 >=20 > diff --git > a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInit= Pr > eMem.inf > b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInit= Pr > eMem.inf > index 7ee18eb6..8e828ff2 100644 > --- > a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInit= Pr > eMem.inf > +++ > b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInit= Pr > eMem.inf > @@ -1,7 +1,7 @@ > ### @file >=20 > # Component information file for the Platform Init Pre-Memory PEI module= . >=20 > # >=20 > -# Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
>=20 > +# Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved.
>=20 > # >=20 > # SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > # >=20 > @@ -28,6 +28,7 @@ > TestPointCheckLib >=20 > TimerLib >=20 > SetCacheMtrrLib >=20 > + ReportCpuHobLib >=20 >=20 >=20 > [Packages] >=20 > MinPlatformPkg/MinPlatformPkg.dec >=20 > -- > 2.26.2.windows.1