public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "Kuo, IanX" <ianx.kuo@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Lu, James" <james.lu@intel.com>,
	"Kumar, Chandana C" <chandana.c.kumar@intel.com>,
	"Prabhala, Varalakshmi A" <varalakshmi.a.prabhala@intel.com>,
	"Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>
Subject: Re: [edk2-platforms] [PATCH v6 1/6] Platform/Intel/MinPlatformPkg: Fix build error
Date: Tue, 21 Jul 2020 00:58:26 +0000	[thread overview]
Message-ID: <DM6PR11MB2809AE274333C02CC1F8358DE6780@DM6PR11MB2809.namprd11.prod.outlook.com> (raw)
In-Reply-To: <82e226162a72f62a6a46e3a4733d1752908bcabc.1595291556.git.ianx.kuo@intel.com>


Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

> -----Original Message-----
> From: Kuo, IanX <ianx.kuo@intel.com>
> Sent: Tuesday, July 21, 2020 8:35 AM
> To: devel@edk2.groups.io
> Cc: Lu, James <james.lu@intel.com>; Kumar, Chandana C
> <chandana.c.kumar@intel.com>; Prabhala, Varalakshmi A
> <varalakshmi.a.prabhala@intel.com>; Kuo, IanX <ianx.kuo@intel.com>;
> Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>
> Subject: [edk2-platforms] [PATCH v6 1/6] Platform/Intel/MinPlatformPkg: Fix
> build error
> 
> Fix ReportCpuHobLib build error
> 
> Create a Library instance of ReportCpuHobLib from PlatformInitPei driver.
> PA bits reported can be overridden by Library instance in Platform.
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2674
> 
> Change-Id: I0cd6ba4eb7231a3a84f080fdce85bbe74eb29eeb
> Signed-off-by: IanX Kuo <ianx.kuo@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> ---
>  .../PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.c   | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git
> a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/Re
> portCpuHobLib.c
> b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/Re
> portCpuHobLib.c
> index aa256534..83fc5249 100644
> ---
> a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/Re
> portCpuHobLib.c
> +++
> b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/Re
> portCpuHobLib.c
> @@ -6,7 +6,10 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> 
> 
>  **/
> 
> 
> 
> -#include <Base.h>
> 
> +#include <Uefi.h>
> 
> +#include <Pi/PiBootMode.h>
> 
> +#include <Pi/PiHob.h>
> 
> +#include <Library/BaseLib.h>
> 
>  #include <Library/HobLib.h>
> 
> 
> 
>  VOID
> 
> --
> 2.26.2.windows.1


  reply	other threads:[~2020-07-21  0:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-21  0:35 [edk2-platforms] [PATCH v6 0/6] Create a Library instance of ReportCpuHobLib IanX Kuo
2020-07-21  0:35 ` [edk2-platforms] [PATCH v6 1/6] Platform/Intel/MinPlatformPkg: Fix build error IanX Kuo
2020-07-21  0:58   ` Chiu, Chasel [this message]
2020-07-21  2:12     ` [edk2-devel] " Liming Gao
2020-07-21  2:51       ` 回覆: " IanX Kuo
2020-07-21  0:35 ` [edk2-platforms] [PATCH v6 2/6] Platform/Intel/CometlakeOpenBoardPkg: Add ReportCpuHobLib IanX Kuo
2020-07-21  1:04   ` [edk2-devel] " Chiu, Chasel
2020-07-21  0:35 ` [edk2-platforms] [PATCH v6 3/6] Platform/Intel/KabylakeOpenBoardPkg: " IanX Kuo
2020-07-21  1:04   ` Chiu, Chasel
2020-07-21  0:36 ` [edk2-platforms] [PATCH v6 4/6] Platform/Intel/SimicsOpenBoardPkg: " IanX Kuo
2020-07-21  1:04   ` [edk2-devel] " Chiu, Chasel
2020-07-21  0:36 ` [edk2-platforms] [PATCH v6 5/6] Platform/Intel/WhiskeylakeOpenBoardPkg: " IanX Kuo
2020-07-21  1:04   ` Chiu, Chasel
2020-07-21  0:36 ` [edk2-platforms] [PATCH v6 6/6] Platform/Intel/MinPlatformPkg: " IanX Kuo
2020-07-21  1:05   ` Chiu, Chasel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB2809AE274333C02CC1F8358DE6780@DM6PR11MB2809.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox