From: "Guomin Jiang" <guomin.jiang@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"lersek@redhat.com" <lersek@redhat.com>,
Abner Chang <abner.chang@hpe.com>
Cc: "Wang, Jian J" <jian.j.wang@intel.com>,
"Lu, XiaoyuX" <xiaoyux.lu@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/1] CryptoPkg/Library: Remove the redundant build option
Date: Wed, 12 Aug 2020 07:33:03 +0000 [thread overview]
Message-ID: <DM6PR11MB29552ADAB1DFA0B7BE219AF99D420@DM6PR11MB2955.namprd11.prod.outlook.com> (raw)
In-Reply-To: <9a8b1d04-36dd-35b9-91e2-9498aa7f3804@redhat.com>
Pushed in commit be01087e07809d20aa2db27b37029c324c824407.
Thanks
Guomin
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Laszlo
> Ersek
> Sent: Friday, July 17, 2020 5:39 PM
> To: Abner Chang <abner.chang@hpe.com>; devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Lu, XiaoyuX
> <xiaoyux.lu@intel.com>
> Subject: Re: [edk2-devel] [PATCH 1/1] CryptoPkg/Library: Remove the
> redundant build option
>
> On 07/16/20 16:55, Abner Chang wrote:
> > Remove the redundant build option for RISCV64 architecture.
> > BZ:2848
> >
> > Signed-off-by: Abner Chang <abner.chang@hpe.com>
> >
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > ---
> > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> b/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> > index c8ec9454bd..56acf39cac 100644
> > --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> > +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> > @@ -634,7 +634,7 @@
> > GCC:*_*_X64_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -
> Wno-error=maybe-uninitialized -Wno-error=format -Wno-format -Wno-
> error=unused-but-set-variable -DNO_MSABI_VA_FUNCS
> > GCC:*_*_ARM_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-
> uninitialized -Wno-error=unused-but-set-variable
> > GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-
> error=maybe-uninitialized -Wno-format -Wno-error=unused-but-set-
> variable
> > - GCC:*_*_RISCV64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=format -
> Wno-error=maybe-uninitialized -Wno-format -Wno-error=unused-but-set-
> variable
> > + GCC:*_*_RISCV64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-
> uninitialized -Wno-format -Wno-error=unused-but-set-variable
> > GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
> > GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
> > GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -
> Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-
> error=implicit-function-declaration -Wno-error=ignored-pragma-optimize
> >
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>
> Thanks!
> Laszlo
>
>
>
prev parent reply other threads:[~2020-08-12 7:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 14:55 [PATCH 1/1] CryptoPkg/Library: Remove the redundant build option Abner Chang
2020-07-17 0:41 ` [edk2-devel] " Guomin Jiang
2020-07-17 1:46 ` Abner Chang
2020-07-17 7:58 ` Guomin Jiang
2020-07-17 9:38 ` Laszlo Ersek
2020-08-12 7:33 ` Guomin Jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB29552ADAB1DFA0B7BE219AF99D420@DM6PR11MB2955.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox