From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web12.8873.1592873568293312006 for ; Mon, 22 Jun 2020 17:52:48 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=lGd5KWjo; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: guomin.jiang@intel.com) IronPort-SDR: HX250eBjdcXFjJsxkiN5HQh4xxYrT/Q3knwry/30xegKF0xJye8Med+JviDZUBZiXBhc4I1DZY K7st9heE8pgw== X-IronPort-AV: E=McAfee;i="6000,8403,9660"; a="124190760" X-IronPort-AV: E=Sophos;i="5.75,268,1589266800"; d="scan'208";a="124190760" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2020 17:52:46 -0700 IronPort-SDR: upm6thC4HYaxHH+MmMRF4z8f2Ebfs9wHrRw947rZ0PJfyc1CEeyh2EmWkoMDi5zBJJKMnaw1Gi TcKluimtPVww== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,268,1589266800"; d="scan'208";a="293031417" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga002.jf.intel.com with ESMTP; 22 Jun 2020 17:52:45 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 22 Jun 2020 17:52:45 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 22 Jun 2020 17:52:44 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 22 Jun 2020 17:52:44 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.177) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 22 Jun 2020 17:52:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KNfXU1nUCEPbC/k9o7idqi0QFtRFjTRMMwkMa29BGg/XBq4BZvASGSr70ZfTAY+u5x3T4FrPFuLhS7WbWlCRQekwDl0gILZg/UPydNzgMUE+kRJcQQ6zounV1GcQoKPcUdLAOoqcyezY9Prph/bHuDZm6IWxkUvft8c5Ni7rcuA37kUpKlijTiQmlqKv/G36IQXqHnmFbCxw+j/vbpLuE2+SXjnhQ0iYh6aomA61x/59i5KvHhvrdn7ck5+sLTkpeXm8CFWrbY9hGdkBvlnWjkW0i9M/XNtzhkXY4T4u9Tz9jFGCPynIMh37F/0BQAylBJ5YS6dwk4WSGmleWA10qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gTD/ALRFkEnyj+mkQ0itCpvTE0d53ymfUmLpH7HU7DA=; b=ibaubAWCYWfbEqPoPvpiVjqu56Azp67STJRRnLRdWBuCD+04ZAyRqFWrw8u1yRHmjQ73E5lOsp8qhQSsq5vFDVOBShfsJ7DQEI+WPmS0P76diCRj7Iih8twHd4tshwe8q7/f78038arG6D3dzv6OSoSFBdHZ3/v1zEPMgNDky1GcReqsCH7RG4xYDzz4vmArds/Rthwo92lTV0YrLgu9LIV0ND4LeSe3dKeGqJsNWyY1flbEm2OFK75/7+x2IQG6ILy4rqziNfgc6TIeNqkwtoXN831gXmqJZiRFIVYnKQxfKUF6mlsrWzlYHXM0+WaCTTZcd71dhL3PW7/akErvKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gTD/ALRFkEnyj+mkQ0itCpvTE0d53ymfUmLpH7HU7DA=; b=lGd5KWjo3/PwgR68+Hha7pJ1EaQw+oWJnLpFTS8TAf1M45SZB9qnCBBpzkJBW8G+Q55uThjR5Cg01DDdFtsnsWwatSw93hm/PniuBDWk03LhEzbVNcFljYl/nn9SfyXtKSi2KDz6I4+ESVsVS1sG11WmqQIHn6rDMrnE1e0mWUc= Received: from DM6PR11MB2955.namprd11.prod.outlook.com (2603:10b6:5:65::31) by DM6PR11MB3898.namprd11.prod.outlook.com (2603:10b6:5:19f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.23; Tue, 23 Jun 2020 00:52:35 +0000 Received: from DM6PR11MB2955.namprd11.prod.outlook.com ([fe80::e916:c766:fc41:b51d]) by DM6PR11MB2955.namprd11.prod.outlook.com ([fe80::e916:c766:fc41:b51d%5]) with mapi id 15.20.3109.027; Tue, 23 Jun 2020 00:52:35 +0000 From: "Guomin Jiang" To: "devel@edk2.groups.io" , "garrett.kirkendall@amd.com" CC: "Ni, Ray" Subject: Re: [edk2-devel] [PATCH v6 1/4] PcAtChipsetPkg: PcAtChipsetPkg.dsc add UefiCpuLib LibraryClass Thread-Topic: [edk2-devel] [PATCH v6 1/4] PcAtChipsetPkg: PcAtChipsetPkg.dsc add UefiCpuLib LibraryClass Thread-Index: AQHWSJhzgzULR/zO2kqoHgGd0Lr3LqjlXp4w Date: Tue, 23 Jun 2020 00:52:35 +0000 Message-ID: References: <20200622131825.1352-1-Garrett.Kirkendall@amd.com> <20200622131825.1352-2-Garrett.Kirkendall@amd.com> In-Reply-To: <20200622131825.1352-2-Garrett.Kirkendall@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.196] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 57567395-6bc5-4f73-1675-08d8170fb842 x-ms-traffictypediagnostic: DM6PR11MB3898: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 04433051BF x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FlW0eL5/m2oXzuH54meRYj8N6xdoEbx2s0aglFK/rI+vDEbYRY19iyic0H5q3SCisM/KRNLfUIVSV96gWAfj6OV+XX4hDJyd344+7fg/GrGj8QT36i1v56hCl08l1Kj0VaRDeXe0DF8Zu0D4YcEvBlyX9BVRXh6bQlWX7NTQawsTrx20znIsG0U+fi+HE/sgeBdAFguelLbiLEiPbI0f3IZNrZiw5WZWxN1sAOs/OKSdGOp7u7kmv50Z6NWC4EqMjCLwpdxB5pJu6fT5GHjamIJV1m/lMBDeBrpnbQQihqebarG/xQKsXnhj8UBAj6fvphMQzmBjUivKeu99gFjETgVrtVLX9mVsXALUFdV/kQLKUqJTDb4AugM6oZS7ySsKQLIxz5tcEDS5rw6ItRdcbw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB2955.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(6029001)(4636009)(376002)(136003)(346002)(39860400002)(366004)(396003)(55016002)(83380400001)(7696005)(186003)(26005)(66946007)(107886003)(4326008)(966005)(8936002)(33656002)(6506007)(53546011)(8676002)(86362001)(5660300002)(9686003)(76116006)(52536014)(64756008)(2906002)(110136005)(66476007)(66556008)(66446008)(478600001)(316002)(71200400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: bXPJqADdv7x8FQZLBODy0ntw+BtoyE9ov3a1ZDC8LJ8suF3N6U6GwbELflABTHStSu50lqRMGlbYlcWhbbBz4CcjXxFiemcdZczl/sEaSf9LAZgzZv/gUHuC1lyzkFtfRqnKrPGD5zN9DIWTCJ36h4cwLc7hUw3g+WWE1CET9iAcN3EENIS/1pPkCVdMZLOgvYHSqwpp3qqXXMByvJJeI+vcR7MGr6HRmJWBnJnSt+YNhNAy6fVQVKeH1OK4eFWNw/FChjhLoWfFK+glHM3vhmOq5XoGqpv/EcZdeeLmCIon3ZNzO26WLoyGt4MpyX9AMu3EMV6/0p9IlaJhtHTPohrutEnA8xZUU+b3lMonmYdILGHk6szcmLfunBsCwrMBP7BJcqixAAyGuqzanjv1YaC3sav9WgLwEPPMzGeACWrWhNNtdDYr17xvB4mc63TG6zejNHP/4WMBeVN4MOPbaAhaYvDYkutL2yWyobzQJ8ZmbcoxrWmJXaXjM0QNY+FN MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 57567395-6bc5-4f73-1675-08d8170fb842 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jun 2020 00:52:35.4503 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ikRSqZd0HtfvYP4ezQ+9OgRl7dnMoODSoRixl75IWVaWoGJelLex8ZFk0flZPaL75gHrfUknkCLljFo4MvRbMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3898 Return-Path: guomin.jiang@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Garrett, Thanks for report quickly and it work and the 'Mac format issue disappear'= . But another build error occur 'error LNK2005: _InitializeFloatingPointUnit= s already defined in FspSecCoreT.lib(InitializeFpu.obj)' It seem that result by ApicLib who depend UefiCpuLib now. I want to know why you add this dependency, have any other way to do it, f= or example, add the dependency to the dsc file. Best Regards Guomin > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of > Kirkendall, Garrett > Sent: Monday, June 22, 2020 9:18 PM > To: devel@edk2.groups.io > Cc: Ni, Ray > Subject: [edk2-devel] [PATCH v6 1/4] PcAtChipsetPkg: PcAtChipsetPkg.dsc > add UefiCpuLib LibraryClass >=20 > In preparation for moving StandardSignatureIsAuthenticAMD to UefiCpuLib > in UefiCpuPkg, PcAtChipset/PcAtChipsetPkg.dsc needs LibraryClass > UefiCpuLib. > LocalApicLib|UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf will need > UefiCpuLib LibraryClass. Likely most "real" platforms will be using > BaseX2XApicLib instance which already required UefiCpuLib. >=20 > Cc: Ray Ni > Signed-off-by: Garrett Kirkendall > --- > PcAtChipsetPkg/PcAtChipsetPkg.dsc | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/PcAtChipsetPkg/PcAtChipsetPkg.dsc > b/PcAtChipsetPkg/PcAtChipsetPkg.dsc > index 01a3ee716a98..b61b7d1f528e 100644 > --- a/PcAtChipsetPkg/PcAtChipsetPkg.dsc > +++ b/PcAtChipsetPkg/PcAtChipsetPkg.dsc > @@ -2,6 +2,7 @@ > # PC/AT Chipset Package > # > # Copyright (c) 2007 - 2019, Intel Corporation. All rights reserved. > +# Copyright (c) 2020, AMD Incorporated. All rights reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -39,6 +40,7 @@ > [LibraryClasses] >=20 > ResetSystemLib|PcAtChipsetPkg/Library/ResetSystemLib/ResetSystemLib.in > f > IoApicLib|PcAtChipsetPkg/Library/BaseIoApicLib/BaseIoApicLib.inf > LocalApicLib|UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf > + UefiCpuLib|UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf >=20 > ReportStatusCodeLib|MdePkg/Library/BaseReportStatusCodeLibNull/BaseR > eportStatusCodeLibNull.inf > HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf >=20 > -- > 2.27.0 >=20 >=20 >=20