From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web12.4119.1589936281445781480 for ; Tue, 19 May 2020 17:58:02 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=fVzwKDiB; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: guomin.jiang@intel.com) IronPort-SDR: 8AP7Wo+ZR8EJCuseiSxSVdCiZ9OTTCPylTFRYXXXz1VD2bXYeqsI2y6nID2Itwgjt2oReJfsZq Hd77QdshPJIA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2020 17:58:00 -0700 IronPort-SDR: peTw8XwcP8siBrt1lCi0z3/nijUtUfXxYFDX8QbZTqYe5v3tgPYYqRGx09UpjQpR9EDpqX4JDt Ih5OGB1lgopg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,412,1583222400"; d="scan'208";a="264497690" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 19 May 2020 17:58:00 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 19 May 2020 17:58:00 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 19 May 2020 17:58:00 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 19 May 2020 17:58:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G+e/HnpnPf1Tj5eUVOwhX8uA4ntG+kg+reD3wnx3syD3jcy6i7IjAFD4wSXVmSCYjAGzmjCDs6BAMRp85Zta2KVLBCRyy0pFy7NDGIUxcg6L1ttkKMEfQXb6Zd/rVfGpI0GCcTcwl63msztOSVJkjYGc2x+zLi8JsPbNgDzIf9iFFGcP0QsxC0LUQE1C65y5jM/yCd4jIEmwWB3EX/KDqHwVY6uzwfA/Pjn8M5koFeAXI0eXS/oDJ3IQfveb7OscMPOAj9Y4HxPZBuHAVDLuqeeFPlx0MMLhnD4XsmnhlzYRjKBBfCbTDsudERXbuqjUD190j+f91eM99CZSu6nsJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jB7h17q6a313hRtpX6Pnf5LTr/Zh4Fh8vWe1UACzU+Q=; b=EVG0iZBkWUfVYIPkrrvHLoUKl0plBL7UTRB2YtzhwGsOsxQ+RBphHBYsHesORJPXdFDRDNHF6igIdLvZOws82Y2I32z4tDbY0TaRsOe8iVjxKuy90dn72KHaYrN1YIhnXTy48pf9mg3tkKqQhSeYb78jFlhPb2jqHnaiae6nq+ednIOwZBEREXbrf5+SNnqzRUYjeZoq8VAtuEs5nPgVDItOLdTTDJfsKGnT3rbeZcOCFOoza12gysmmE1IOsOererbVTqB1Epe66cA/+N7KREBolWRYqgaU4ffC8VLkfnV8yQQOpNqFOS8TFk/yeM50D30Po2PWwIjUIBTQZBtkhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jB7h17q6a313hRtpX6Pnf5LTr/Zh4Fh8vWe1UACzU+Q=; b=fVzwKDiB46JCKKyo9Haxk8F7hDA2oBy6K7khR/Tft/RvHElbkcCGhJZ4lkNDX6MMCbJoJeNKCbcK7es8w+CYEPt3VEdOdu1uwQIv9uBL/fHVGvkpuWHi0xidbrBSN5Fgk4STv/CqXyHGs0oCl55Gox5fFFh4VPkWvdoIW6M1RTM= Received: from DM6PR11MB2955.namprd11.prod.outlook.com (2603:10b6:5:65::31) by DM6PR11MB2859.namprd11.prod.outlook.com (2603:10b6:5:c9::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.23; Wed, 20 May 2020 00:57:59 +0000 Received: from DM6PR11MB2955.namprd11.prod.outlook.com ([fe80::ccd4:4b0d:535a:58be]) by DM6PR11MB2955.namprd11.prod.outlook.com ([fe80::ccd4:4b0d:535a:58be%7]) with mapi id 15.20.3000.034; Wed, 20 May 2020 00:57:59 +0000 From: "Guomin Jiang" To: Oleksiy Yakovlev , "devel@edk2.groups.io" CC: "Feng, Bob C" , "Gao, Liming" , "Kinney, Michael D" , Felix Polyudov Subject: Re: [edk2-devel] [PATCH v7 1/7] MdePkg: Extend SERIAL_IO with DeviceTypeGuid Thread-Topic: [edk2-devel] [PATCH v7 1/7] MdePkg: Extend SERIAL_IO with DeviceTypeGuid Thread-Index: AQHWKWBBXuMXr9Y1uE2DkqVIiFfeRqim7/CAgACx7QCACI4ToA== Date: Wed, 20 May 2020 00:57:59 +0000 Message-ID: References: <20200513195248.50296-1-oleksiyy@ami.com> <20200513195248.50296-2-oleksiyy@ami.com> <6BD875C24FFE2A4E8D6EFC142C67836F03FFFFA33D@atlms1.us.megatrends.com> In-Reply-To: <6BD875C24FFE2A4E8D6EFC142C67836F03FFFFA33D@atlms1.us.megatrends.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: ami.com; dkim=none (message not signed) header.d=none;ami.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.196] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 21aab988-7482-4d71-3d68-08d7fc58d712 x-ms-traffictypediagnostic: DM6PR11MB2859: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-forefront-prvs: 04097B7F7F x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: npS9F7v00/9PNF1R5Qcz8elSMILAB56wmp8JF+HXm9hZqX6Mzz4Q7BkdQNsfsegLArjohvmcm24z5cGW67M2m+3x5GdG0rDk0ykZTxI7pAo7B7Qpdu8F/CC1j40kc6BnTVkHIlO+pNACoXCoZC1S6AFjp2GI5g77y+rAz1p86T2WWdAx2D+s7VPCMcVuBq7XAHaJP5QFt7lR4h3PXHIXoKpd1IuMTclk9IDdXYvhz/zKS+ryIzJr4jU53syeKaRU+rFf6JNTucD9lfe/GGVC0MH/uDzyb/ana910grEbKGKqGOfXr/CDLG2gnFAQVYy0UWsuuZ4tze/Yi2gOQUFyPJWNcTQ9t698NzpRkeJwQ73i6zPlribE4n4KblYE3IZVQtBCheYAGCmzuvfyV6Ln3Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB2955.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(39860400002)(136003)(366004)(346002)(376002)(396003)(8936002)(9686003)(71200400001)(55016002)(8676002)(966005)(478600001)(33656002)(66476007)(52536014)(86362001)(66556008)(64756008)(66946007)(66446008)(54906003)(76116006)(4326008)(53546011)(186003)(7696005)(2906002)(110136005)(5660300002)(316002)(6506007)(26005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: hxd/gOFw1o8KHS41ZRJNkHlWg6dWxL0/dfm6WtGKmJu3sGWSWTRNKH9X1twB27Z6LT+3omzhvBqGdKnWnMErJctm0pMXEvafqOGCTjIWRYbgDDVT/F2JoKG1DEm8KYWQaapZmzRHtGFYl851LdXwxrpEI8bXOs0AkpMGltT0vIdmtwYQuNjYEfBzG2EPG2Q9ZHvjUeOIidOu/z0FkT0qlfrJtOV47epH9pCaZvX6tH4UyH/vLfdPs0i+fkvep2Li580V4K3AcD6jcRn7xPocjklQT/RXzQAUE79nbJUAiTBZJwp5tz9hsC7HdpCp0ybA4MfeNzvAFwC9WGQxXVSKYnBS3Q1+1rL8nxVOzZhOHG7yqTwV/EhSuUlPqTqwOY6ge/r2K8Qw5SBea8CaGL2BrObzzyUKSOg1FklviaAE3pSCAk1xXfWaCLfIHueEMuyIcNsmJfWFJSAndsek0X4zx47uktGFjqxq515qilsmeRE= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 21aab988-7482-4d71-3d68-08d7fc58d712 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2020 00:57:59.0173 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zzqw/+z9seVIvOJdWtdifV9IL2aslVlZ4uleaIMKjvnMhs5N/X92u+aR9DNu6BiTJHcAR7/lNHyn27ZQOSlcOw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2859 Return-Path: guomin.jiang@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Sorry for reply later. I understood and the series is good to me. Reviewed-by: Guomin Jiang > -----Original Message----- > From: Oleksiy Yakovlev > Sent: Thursday, May 14, 2020 10:17 PM > To: Jiang, Guomin ; devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > ; Kinney, Michael D ; > Felix Polyudov > Subject: RE: [edk2-devel] [PATCH v7 1/7] MdePkg: Extend SERIAL_IO with > DeviceTypeGuid >=20 > There was a mistake in all previous v here. > I took it from original ECR and misted correction. > Now it is up to spec. >=20 > Regards, Oleksiy. >=20 > -----Original Message----- > From: Jiang, Guomin [mailto:guomin.jiang@intel.com] > Sent: Wednesday, May 13, 2020 11:43 PM > To: devel@edk2.groups.io; Oleksiy Yakovlev > Cc: Feng, Bob C; Gao, Liming; Kinney, Michael D; Felix Polyudov > Subject: RE: [edk2-devel] [PATCH v7 1/7] MdePkg: Extend SERIAL_IO with > DeviceTypeGuid >=20 > Add some comments. >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of > Oleksiy > > Yakovlev > > Sent: Thursday, May 14, 2020 3:53 AM > > To: devel@edk2.groups.io > > Cc: Feng, Bob C ; Gao, Liming > > ; Kinney, Michael D > > ; Felixp@ami.com; oleksiyy@ami.com > > Subject: [edk2-devel] [PATCH v7 1/7] MdePkg: Extend SERIAL_IO with > > DeviceTypeGuid > > > > EFI_SERIAL_IO_PROTOCOL_REVISION incremented to 0x00010001. > > CONST EFI_GUID *DeviceTypeGuid field added to the protocol structure. > > UEFI 2.8 mantis 1832. > > > > Signed-off-by: Oleksiy Yakovlev > > > > Reviewed-by: Liming Gao > > --- > > MdePkg/Include/Protocol/SerialIo.h | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/MdePkg/Include/Protocol/SerialIo.h > > b/MdePkg/Include/Protocol/SerialIo.h > > index 51eaa53..e2e0c61 100644 > > --- a/MdePkg/Include/Protocol/SerialIo.h > > +++ b/MdePkg/Include/Protocol/SerialIo.h > > @@ -263,6 +263,7 @@ typedef struct { > > } EFI_SERIAL_IO_MODE; > > > > #define EFI_SERIAL_IO_PROTOCOL_REVISION 0x00010000 > > +#define EFI_SERIAL_IO_PROTOCOL_REVISION1p1 0x00010001 >=20 > Why add this new definition, it is not exist in patch v5 but exist in pa= tch v6? >=20 > > #define SERIAL_IO_INTERFACE_REVISION > > EFI_SERIAL_IO_PROTOCOL_REVISION > > > > /// > > @@ -287,6 +288,14 @@ struct _EFI_SERIAL_IO_PROTOCOL { > > /// Pointer to SERIAL_IO_MODE data. > > /// > > EFI_SERIAL_IO_MODE *Mode; > > + /// > > + /// Pointer to a GUID identifying the device connected to the seria= l port. > > + /// This field is NULL when the protocol is installed by the serial > > + port /// driver and may be populated by a platform driver for a > > + serial port /// with a known device attached. The field will remain > > + NULL if there is /// no platform serial device identification > > + information > > available. > > + /// > > + CONST EFI_GUID *DeviceTypeGuid; // Revision 1.1 > > }; > > > > extern EFI_GUID gEfiSerialIoProtocolGuid; > > -- > > 2.9.0.windows.1 > > > > > > Please consider the environment before printing this email. > > > > The information contained in this message may be confidential and > > proprietary to American Megatrends (AMI). This communication is > > intended to be read only by the individual or entity to whom it is > > addressed or by their designee. If the reader of this message is not > > the intended recipient, you are on notice that any distribution of > > this message, in any form, is strictly prohibited. Please promptly > > notify the sender by reply e-mail or by telephone at 770-246-8600, and > > then delete or destroy all copies of the transmission. > > > >=20 >=20 >=20 > Please consider the environment before printing this email. >=20 > The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is intende= d > to be read only by the individual or entity to whom it is addressed or b= y their > designee. If the reader of this message is not the intended recipient, y= ou are > on notice that any distribution of this message, in any form, is strictl= y > prohibited. Please promptly notify the sender by reply e-mail or by > telephone at 770-246-8600, and then delete or destroy all copies of the > transmission.