Re: [edk2-devel] File in the build question. I'm working on a smart git grep

["Guomin Jiang" <guomin.jiang@intel.com>]

I would like that add BaseTols/Scripts/ to the PATH.

Usually, I use ```set PATH=%PATH%;%WORKSPACE%\BaseTools\Scripts``` to add new directory to the environment variable.

But I suggest that we should judge if the last character in PATH variable is ';' character and then add new directory.

Let me know what I can help you.

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Laszlo
> Ersek
> Sent: Tuesday, July 21, 2020 3:55 AM
> To: Andrew Fish <afish@apple.com>; edk2-devel-groups-io
> <devel@edk2.groups.io>
> Subject: Re: [edk2-devel] File in the build question. I'm working on a smart git
> grep
> 
> On 07/18/20 22:23, Andrew Fish wrote:
> > Wanted to see if people are OK with adding BaseTools/Scripts/ to the path
> when you run `. edksetuip.sh` or edksetup.bat?
> >
> > If we do that and I add BaseTools/Scripts/git-pgrep then it will show up as
> an extended git command.
> >
> > I was thinking over time we could add git-edk2* git commands to help
> automate the process or maintainer workflow.
> >
> > If people are OK with adding the path I can make a patch set to contribute
> git-pgrep, but I need some help with how to add the new path to
> edksetup.bat.
> 
> To be honest, I think edksetup.sh should add BaseTools/Scripts/ to the PATH
> environment variable anyway. I find it a bit awkward to run
> 
>   python BaseTools/Scripts/GetMaintainer.py -l ...
> 
> rather than just
> 
>   GetMaintainer.py -l ...
> 
> Thanks
> Laszlo
> 
> 
>