* Re: [edk2-devel] [edk2-platforms][PATCH] IntelSiliconPkg: Add library header files
2020-04-08 6:29 ` [edk2-devel] [edk2-platforms][PATCH] IntelSiliconPkg: Add library header files Guomin Jiang
@ 2020-04-08 8:28 ` Ni, Ray
2020-04-08 16:56 ` Chaganty, Rangasai V
1 sibling, 0 replies; 3+ messages in thread
From: Ni, Ray @ 2020-04-08 8:28 UTC (permalink / raw)
To: Jiang, Guomin, devel@edk2.groups.io; +Cc: Chaganty, Rangasai V
Reviewed-by: Ray Ni <ray.ni@intel.com>
> -----Original Message-----
> From: Jiang, Guomin <guomin.jiang@intel.com>
> Sent: Wednesday, April 8, 2020 2:30 PM
> To: devel@edk2.groups.io; Jiang, Guomin <guomin.jiang@intel.com>
> Cc: Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>
> Subject: RE: [edk2-devel] [edk2-platforms][PATCH] IntelSiliconPkg: Add library header files
>
> Hi Ray, Chaganty,
>
> Could you please help review the change.
>
> Best Regards
> guomin
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Guomin
> > Jiang
> > Sent: Tuesday, March 24, 2020 2:37 PM
> > To: devel@edk2.groups.io
> > Cc: Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V
> > <rangasai.v.chaganty@intel.com>
> > Subject: [edk2-devel] [edk2-platforms][PATCH] IntelSiliconPkg: Add library
> > header files
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2587
> >
> > SmmAccessLib.h and ConfigBlockLib.h is the primary header file in
> > IntelSiliconPkg.
> >
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> > Signed-off-by: Guomin Jiang <guomin.jiang@intel.com>
> > ---
> > Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec
> > b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec
> > index 3c49fb289c..7c43593382 100644
> > --- a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec
> > +++ b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec
> > @@ -30,6 +30,14 @@
> > #
> > PeiGetVtdPmrAlignmentLib|Include/Library/PeiGetVtdPmrAlignmentLib.h +
> > ## @libraryclass Provides services to access SMM information+ #+
> > SmmAccessLib|Include/Library/SmmAccessLib.h++ ## @libraryclass
> > Provides services to access config block+ #+
> > ConfigBlockLib|Include/Library/ConfigBlockLib.h+ [Guids] ## GUID for
> > Package token space # {A9F8D54E-1107-4F0A-ADD0-4587E7A4A735}--
> > 2.25.1.windows.1
> >
> >
> > -=-=-=-=-=-=
> > Groups.io Links: You receive all messages sent to this group.
> >
> > View/Reply Online (#56135): https://edk2.groups.io/g/devel/message/56135
> > Mute This Topic: https://groups.io/mt/72512093/4399222
> > Group Owner: devel+owner@edk2.groups.io
> > Unsubscribe: https://edk2.groups.io/g/devel/unsub
> > [guomin.jiang@intel.com] -=-=-=-=-=-=
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [edk2-devel] [edk2-platforms][PATCH] IntelSiliconPkg: Add library header files
2020-04-08 6:29 ` [edk2-devel] [edk2-platforms][PATCH] IntelSiliconPkg: Add library header files Guomin Jiang
2020-04-08 8:28 ` Ni, Ray
@ 2020-04-08 16:56 ` Chaganty, Rangasai V
1 sibling, 0 replies; 3+ messages in thread
From: Chaganty, Rangasai V @ 2020-04-08 16:56 UTC (permalink / raw)
To: Jiang, Guomin, devel@edk2.groups.io; +Cc: Ni, Ray
The commit message can be improved to reflect the actual changes correctly. For e.g.
" SmmAccessLib.h and ConfigBlockLib.h are the primary header file in IntelSiliconPkg. This commit adds path definitions for these header files in IntelSiliconPkg"
With that:
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>
-----Original Message-----
From: Jiang, Guomin <guomin.jiang@intel.com>
Sent: Tuesday, April 07, 2020 11:30 PM
To: devel@edk2.groups.io; Jiang, Guomin <guomin.jiang@intel.com>
Cc: Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>
Subject: RE: [edk2-devel] [edk2-platforms][PATCH] IntelSiliconPkg: Add library header files
Hi Ray, Chaganty,
Could you please help review the change.
Best Regards
guomin
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Guomin
> Jiang
> Sent: Tuesday, March 24, 2020 2:37 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>
> Subject: [edk2-devel] [edk2-platforms][PATCH] IntelSiliconPkg: Add
> library header files
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2587
>
> SmmAccessLib.h and ConfigBlockLib.h is the primary header file in
> IntelSiliconPkg.
>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> Signed-off-by: Guomin Jiang <guomin.jiang@intel.com>
> ---
> Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec
> b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec
> index 3c49fb289c..7c43593382 100644
> --- a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec
> +++ b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec
> @@ -30,6 +30,14 @@
> #
> PeiGetVtdPmrAlignmentLib|Include/Library/PeiGetVtdPmrAlignmentLib.h +
> ## @libraryclass Provides services to access SMM information+ #+
> SmmAccessLib|Include/Library/SmmAccessLib.h++ ## @libraryclass
> Provides services to access config block+ #+
> ConfigBlockLib|Include/Library/ConfigBlockLib.h+ [Guids] ## GUID for
> Package token space # {A9F8D54E-1107-4F0A-ADD0-4587E7A4A735}--
> 2.25.1.windows.1
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
>
> View/Reply Online (#56135):
> https://edk2.groups.io/g/devel/message/56135
> Mute This Topic: https://groups.io/mt/72512093/4399222
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [guomin.jiang@intel.com] -=-=-=-=-=-=
^ permalink raw reply [flat|nested] 3+ messages in thread