From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web12.6121.1589427769893710855 for ; Wed, 13 May 2020 20:42:49 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=a0YF2eMs; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: guomin.jiang@intel.com) IronPort-SDR: 0U5vHnGWw8Ae6pqBUnytx6Agc+WZoo+WXGffDY4v/5Qxb5u8kwqqe9owniLaYLh/Ei62M/lph0 wjBAN/NM0THQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2020 20:42:49 -0700 IronPort-SDR: xvmTF4RbuMqa2HXBoxxZbaRGE7Um3hepDEzsVr2qq8SzMa0WjHJgAATZIvVYRi1uxsQkmCdcxa zLbWg0eXFXog== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,390,1583222400"; d="scan'208";a="306978096" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by FMSMGA003.fm.intel.com with ESMTP; 13 May 2020 20:42:49 -0700 Received: from orsmsx152.amr.corp.intel.com (10.22.226.39) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 May 2020 20:42:49 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX152.amr.corp.intel.com (10.22.226.39) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 May 2020 20:42:48 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.49) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 May 2020 20:42:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jkaYTg5LmT1FU7zZ9/eGFLuTio7Uzeu4TCsRf7/qyoIuWXhAEr/oepegP6uknOvFD8v7tiLvj/WDbATpOKF2RNesC+vno+7r3oDHpmwDYdP4dRTj4HfgMN2OEo05fFmizo5C9oBX5O5aEPox6N0V2hsk3263aprFqctXlUV1i1BBuF9iP0iX0yFjkrbHDWJJvvGUYJc1hP25lJjDnGcQgaGzA5vRTkG75lWWZKVu78ZrpCquF9uEACGrkVICCyfgGHvzpPcNz5ktun0FjXTbN+sYPde9RBj0Js03jh7G7aXyeTc/l31Typyev8Kejiiah43EjfqNXugwqRGc5BmkHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sEHAJaO9HgygsiDaaZxFzDVWUQD+asQSMIzmyzWzK+o=; b=drewRCt+4GhQtTG3z1Wq/bwZfMRbAmIF6AYJkKBSZT6KkYSAE7uzZuYkR/pKMgVbJls1PTqhPXGoBhtoLpvIjQ+YJb/FHT7ZcfeRMmWzdS86dRgsV1Hg9YH9lbeZoI5zAvinKpiQ2GAzwsNFH7Thx7Uyjjx1zy86HPqUctsS7VBEGMEmeCWAY810xPEwnKE8MnvU72kZX0Qx5Mo9rj2Ym8WxAprFkE7DwoiVsvEZqoZgC1QrLYraaJSZ2vrmI0LaWRr16zIjdWeT6SLMVsEYuJrCj+W5/s+UyUZdbHxYVe+eBMt5rKb4Y1PeRqbSZD+hO9yWDLzZBRlE3fxZYjDBGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sEHAJaO9HgygsiDaaZxFzDVWUQD+asQSMIzmyzWzK+o=; b=a0YF2eMsG39VSOLFsabkxvdQygTVJgEJ9uxSnNiN74sKcB6GcfxmsnxHiZbXAv9n9U/1y7KKuXYYk5l29stWNRQrVxj23E0Uhz679Dq9j4wMhwO4KobD38UDnPfuTx5+31W+kKD/Fim/SuSnrVufkWFz/K2f4muzDQ72tzaGM3c= Received: from DM6PR11MB2955.namprd11.prod.outlook.com (2603:10b6:5:65::31) by DM6PR11MB4722.namprd11.prod.outlook.com (2603:10b6:5:2a7::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.25; Thu, 14 May 2020 03:42:47 +0000 Received: from DM6PR11MB2955.namprd11.prod.outlook.com ([fe80::ccd4:4b0d:535a:58be]) by DM6PR11MB2955.namprd11.prod.outlook.com ([fe80::ccd4:4b0d:535a:58be%7]) with mapi id 15.20.2979.033; Thu, 14 May 2020 03:42:47 +0000 From: "Guomin Jiang" To: "devel@edk2.groups.io" , "oleksiyy@ami.com" CC: "Feng, Bob C" , "Gao, Liming" , "Kinney, Michael D" , "Felixp@ami.com" Subject: Re: [edk2-devel] [PATCH v7 1/7] MdePkg: Extend SERIAL_IO with DeviceTypeGuid Thread-Topic: [edk2-devel] [PATCH v7 1/7] MdePkg: Extend SERIAL_IO with DeviceTypeGuid Thread-Index: AQHWKWBBXuMXr9Y1uE2DkqVIiFfeRqim7/CA Date: Thu, 14 May 2020 03:42:47 +0000 Message-ID: References: <20200513195248.50296-1-oleksiyy@ami.com> <20200513195248.50296-2-oleksiyy@ami.com> In-Reply-To: <20200513195248.50296-2-oleksiyy@ami.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.196] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6dc0acb9-5a2a-41c4-0dc8-08d7f7b8dea6 x-ms-traffictypediagnostic: DM6PR11MB4722: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-forefront-prvs: 040359335D x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5L/CA7fhhJA2b9l/ViPjLR29S13gyTAck3AwYqPmz1IH8cbQieRoEFuJn4dJVfdpELgvZ6L76lxrH4APfy6XyYiWBFr9UUALEMYtfn7+7m8BHTIEhREwW+OBO6PM6U9GK8L8m0YUe3UMPU4ELuvG3LZ/+xyuJafZOdXnj/RuCyDp3w8UAexXn4B8Vn5i2HP5OYp9TOQe34tFrrTYG9j079iVOcD3s8tuWj78Ul6ztAZskM6r3ull+XZ0VX8uo5Kxkql+JR/bAup5MuxHkU7bzDByFSWThkkfIQC8T6HvUiRGalkY56h5mwWB+Ps8blnLWAl6se+7j+qVI8dKspgaCqECXWrB55DalCaIleeY+//XSayB1bOqTWcwo/XdPphwkQl362+WRwgzR6FHnfQAngzxcxFFd1uenc4IlRKE/5KonsqnKQ6ZNjM10CRhAOXRYhAIAn9nThhmRftkd/pSotbvmMeLzvf32YNKbGvST4wEJ4IzakYfIMql0v9Rh/wd/tx7axOaPRxio/BWnfcaag== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB2955.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(396003)(366004)(376002)(39860400002)(136003)(346002)(54906003)(110136005)(26005)(55016002)(7696005)(53546011)(6506007)(86362001)(71200400001)(8936002)(5660300002)(66446008)(966005)(66946007)(186003)(478600001)(66556008)(66476007)(64756008)(2906002)(33656002)(4326008)(316002)(76116006)(52536014)(8676002)(9686003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: uJuDddXLVYqdaGqkRkkIIgAiQthVMejHUw0Bf9I114sgAngRZyWnSGjUj2UO7bS565wDxUKJyKfuMUE1tjLEG6Djrgvs7Jupv+NZ9kzFlLreltfT4HVBbDHSr/JR+klHSN8xp4IUY2xGmhS5pR4ZFapW7GBUIaJ42NZojGN6CZmN6ysk3vIKqq2cLcmsPPLbDNvRFeJquG12hBiiq8x0DUdw6I9iqNiuBnFf7q3NFNsKpxbWvxb8Ooc/vDAiBtcTPsYRwRKzOvN/6J+rMP3lIMC+LAysdjdVn2bnTFzjSVtkQZ/LrS/gRpa/ieh0oT6+SEc2RXHtatO6ohQ9VKkAl6uVvXOzgR9z7NslaV17XI89XIQA3F+XCbMTpI0AKbIL8hnT5BFBt1yz7OsZprh009GVM89MOITqJEmbo0eSWLXD17J+Uyw6UjOppkU1NHX45W/EisABHX30/qBqfmwd1NTQwHTUpHrew613/7Avt1Y= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 6dc0acb9-5a2a-41c4-0dc8-08d7f7b8dea6 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 May 2020 03:42:47.4713 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: x8OJN76aSH/s/xL2WvR+S0+W9KD/ZlX58m6GQ0lrf7rviClwuajeiPIid18OvjFfF3ytlWkQI9roneVrjnDkwA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4722 Return-Path: guomin.jiang@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Add some comments. > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Oleksiy > Yakovlev > Sent: Thursday, May 14, 2020 3:53 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > ; Kinney, Michael D ; > Felixp@ami.com; oleksiyy@ami.com > Subject: [edk2-devel] [PATCH v7 1/7] MdePkg: Extend SERIAL_IO with > DeviceTypeGuid >=20 > EFI_SERIAL_IO_PROTOCOL_REVISION incremented to 0x00010001. > CONST EFI_GUID *DeviceTypeGuid field added to the protocol structure. > UEFI 2.8 mantis 1832. >=20 > Signed-off-by: Oleksiy Yakovlev >=20 > Reviewed-by: Liming Gao > --- > MdePkg/Include/Protocol/SerialIo.h | 9 +++++++++ > 1 file changed, 9 insertions(+) >=20 > diff --git a/MdePkg/Include/Protocol/SerialIo.h > b/MdePkg/Include/Protocol/SerialIo.h > index 51eaa53..e2e0c61 100644 > --- a/MdePkg/Include/Protocol/SerialIo.h > +++ b/MdePkg/Include/Protocol/SerialIo.h > @@ -263,6 +263,7 @@ typedef struct { > } EFI_SERIAL_IO_MODE; >=20 > #define EFI_SERIAL_IO_PROTOCOL_REVISION 0x00010000 > +#define EFI_SERIAL_IO_PROTOCOL_REVISION1p1 0x00010001 Why add this new definition, it is not exist in patch v5 but exist in patc= h v6? > #define SERIAL_IO_INTERFACE_REVISION > EFI_SERIAL_IO_PROTOCOL_REVISION >=20 > /// > @@ -287,6 +288,14 @@ struct _EFI_SERIAL_IO_PROTOCOL { > /// Pointer to SERIAL_IO_MODE data. > /// > EFI_SERIAL_IO_MODE *Mode; > + /// > + /// Pointer to a GUID identifying the device connected to the serial = port. > + /// This field is NULL when the protocol is installed by the serial > + port /// driver and may be populated by a platform driver for a > + serial port /// with a known device attached. The field will remain > + NULL if there is /// no platform serial device identification informa= tion > available. > + /// > + CONST EFI_GUID *DeviceTypeGuid; // Revision 1.1 > }; >=20 > extern EFI_GUID gEfiSerialIoProtocolGuid; > -- > 2.9.0.windows.1 >=20 >=20 > Please consider the environment before printing this email. >=20 > The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is intende= d > to be read only by the individual or entity to whom it is addressed or b= y their > designee. If the reader of this message is not the intended recipient, y= ou are > on notice that any distribution of this message, in any form, is strictl= y > prohibited. Please promptly notify the sender by reply e-mail or by > telephone at 770-246-8600, and then delete or destroy all copies of the > transmission. >=20 >=20