[edk2-discuss] Best Known Methods for avoiding sending abnormal patch

[edk2-discuss] Best Known Methods for avoiding sending abnormal patch

[Guomin Jiang]

[-- Attachment #1.1: Type: text/plain, Size: 1040 bytes --]

Hi All,

I encounter a error recently, and it will result in abnormal patch, abnormal CI build and abnormal edk2-devel message.

You can run ``` git config sendemail.transferencoding 8bit``` to avoid the error.

The detail information as below,
When I ready a patch and send it to devel@edk2.groups.io<mailto:devel@edk2.groups.io>, will see below abnormal picture.

>From Mail:
[cid:image001.png@01D61D85.07F968D0]

>From groups.io
[cid:image002.png@01D61D86.BD272250]

>From CI:
[cid:image003.png@01D61D86.BD272250]

The defect happened because of CR+LF is keep in patch and will keep in mail, it seem that the CI or groups system haven't dispose it correctly.

I get the answers from https://stackoverflow.com/questions/6289001/git-am-format-patch-control-format-of-line-endings, and bit8 can avoid unnecessary CR when send email. It explain the history why import the option as well.

https://git-scm.com/docs/git-send-email provide the usage for the option.

Help it is useful for yours

Best Regards
guomin

[-- Attachment #1.2: Type: text/html, Size: 5619 bytes --]

[-- Attachment #2: image001.png --]
[-- Type: image/png, Size: 107498 bytes --]

[-- Attachment #3: image002.png --]
[-- Type: image/png, Size: 68841 bytes --]

[-- Attachment #4: image003.png --]
[-- Type: image/png, Size: 61454 bytes --]

Re: [edk2-devel] [edk2-discuss] Best Known Methods for avoiding sending abnormal patch

[Laszlo Ersek]

On 04/28/20 13:30, Guomin Jiang wrote:
> Hi All,
> 
> I encounter a error recently, and it will result in abnormal patch, abnormal CI build and abnormal edk2-devel message.
> 
> You can run ``` git config sendemail.transferencoding 8bit``` to avoid the error.
> 
> The detail information as below,
> When I ready a patch and send it to devel@edk2.groups.io<mailto:devel@edk2.groups.io>, will see below abnormal picture.
> 
> From Mail:
> [cid:image001.png@01D61D85.07F968D0]
> 
> From groups.io
> [cid:image002.png@01D61D86.BD272250]
> 
> From CI:
> [cid:image003.png@01D61D86.BD272250]
> 
> The defect happened because of CR+LF is keep in patch and will keep in mail, it seem that the CI or groups system haven't dispose it correctly.
> 
> I get the answers from https://stackoverflow.com/questions/6289001/git-am-format-patch-control-format-of-line-endings, and bit8 can avoid unnecessary CR when send email. It explain the history why import the option as well.
> 
> https://git-scm.com/docs/git-send-email provide the usage for the option.
> 
> Help it is useful for yours

Yes, please refer to edk2 commit a5abd9cc2ceb ("BaseTools/Scripts: Add
sendemail.transferEncoding to SetupGit.py", 2019-12-24).

$ git show -b a5abd9cc2ceb

Thanks
Laszlo