From: "Guomin Jiang" <guomin.jiang@intel.com>
To: Kun Qin <Kun.Qin@microsoft.com>,
Sean Brogan <sean.brogan@microsoft.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer.
Date: Mon, 13 Apr 2020 06:20:44 +0000 [thread overview]
Message-ID: <DM6PR11MB2955A4D92C082791B16C652A9DDD0@DM6PR11MB2955.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MWHPR21MB019299DFF5226CC8520C40F2E9DE0@MWHPR21MB0192.namprd21.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1884 bytes --]
Hi Qin,
Refer https://github.com/guominjia/edk2/commit/eed5154853f6522e6150b9cff16d24e0c88ad3cc
Best Regards
guomin
From: Kun Qin <Kun.Qin@microsoft.com>
Sent: Friday, April 10, 2020 3:18 PM
To: Jiang, Guomin <guomin.jiang@intel.com>; Sean Brogan <sean.brogan@microsoft.com>; devel@edk2.groups.io
Subject: RE: [edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer.
Hi Guomin,
Could you please point me to the proposed change?
Thanks,
Kun
From: Jiang, Guomin <guomin.jiang@intel.com<mailto:guomin.jiang@intel.com>>
Sent: Wednesday, April 8, 2020 6:30 PM
To: Sean Brogan <sean.brogan@microsoft.com<mailto:sean.brogan@microsoft.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Kun Qin <Kun.Qin@microsoft.com<mailto:Kun.Qin@microsoft.com>>
Subject: [EXTERNAL] RE: [edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer.
Hi Sean,
I think it meet the original code logic more closely.
According to the LoadUnitTestCache(), it need pointer to pointer, the defect is resulted by pointer to local pointer and I think the original logical just want use the local variable as pointer to pointer.
I have reviewed the suggested change and think both are the same logic.
Hi Qin,
Can you give some comment?
Best Regards
guomin
From: sean.brogan via [] <sean.brogan=microsoft.com@[]<mailto:sean.brogan=microsoft.com@[]>>
Sent: Wednesday, April 8, 2020 2:00 PM
To: Jiang, Guomin <guomin.jiang@intel.com<mailto:guomin.jiang@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Subject: Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer.
Guomin,
Can you speak to why you implemented differently than the suggested and validated patch? Seems you created a local whereas ours just used the internal data member.
Thanks
sean
[-- Attachment #2: Type: text/html, Size: 6216 bytes --]
next prev parent reply other threads:[~2020-04-13 6:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <160150CCACE2328E.16021@groups.io>
2020-04-08 5:29 ` [edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer Guomin Jiang
2020-04-08 5:59 ` Sean
2020-04-09 1:29 ` Guomin Jiang
2020-04-10 7:17 ` Kun Qin
2020-04-13 6:20 ` Guomin Jiang [this message]
2020-04-13 6:47 ` Kun Qin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB2955A4D92C082791B16C652A9DDD0@DM6PR11MB2955.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox