From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.6153.1588922630502707411 for ; Fri, 08 May 2020 00:23:50 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=xHcN6kQ3; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: guomin.jiang@intel.com) IronPort-SDR: jnb7JPpkSyUCj5g9v3XaEKLh8uhrVP5bIAraj++n+XEFXFGo+StDkXBu1PiFn6FpAXvQBs+6VI Oi4N6jz8a+Yw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2020 00:23:49 -0700 IronPort-SDR: EJkEArixrlOrpYa+xIC9wDVttTVpV53OIhCBBT07cChoEnT6n9kBYe5L/2tDifZdN+meYfXFSy /lgwE43sh+Xw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,366,1583222400"; d="scan'208";a="285288415" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga004.fm.intel.com with ESMTP; 08 May 2020 00:23:49 -0700 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 8 May 2020 00:23:48 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 8 May 2020 00:23:48 -0700 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (104.47.44.53) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 8 May 2020 00:23:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I+hYGTB/oM4lAoxzGwmAlN69yBrng9X1/oPnZ1JCyktKaNzEEsX+lO5+ePg73bggzvfpuwUg8k4w4de+iDzL+D4QYTTpoTXoiQxdfRBybcsAXl1vy9f9EO0OBwUwHP5ZXD86rA7kgtDX6dQisLxciptxmgdJCizaRKTbOe1KXIml0fbIL7U8w5nXX1bdFafC41xb1Y3Z9pQWwxsDtw4jjzQ2ph4cCoQBuB4AeA92gaYUZpNj3g414KQzPHUE0qEwliofyi7yxD4n/JvWVij+y+hCYFHblkzx8c1F/Iygn5Z+yim2nb6MVwx63aVccQwbvFmuzbdh2LgmzO2VtIs1FA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B4yMd+3Oc2URS6EZnq7mGOI70JxX+nnitQnk9g0at/g=; b=M3jn52vPobFnDR3IoZAHD4bhsC6aO5p1uARa62F1ptsvCVygu4/brbabEgkObKMWyK9yRUbneE8lN9KfhYtYpzS8GHyXqbtZFVYJbdkGWZy7go8TaCJSlmefJ1GKJDyEsAD9qyDLnt/Vz/BV20tAbGDYh2vK8ZOL0WBGylE8H04q0B4+191WHnj5UiwDLp0gtbobEtBvAEav4sHjxnlELGmDzAr4gZg8PHxWSIuDgh7541vGNZGyad/w065Ja3aJEvfF9aagC1/WTC+CX+VPcvnR6pKOk9CSGJJwqSe4nsB92zg88kIkruMLqKoDxmmTpEE3ICJhI6RemfNuaFcYMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B4yMd+3Oc2URS6EZnq7mGOI70JxX+nnitQnk9g0at/g=; b=xHcN6kQ3kUpUYpdZYf8WTy929oiVOV5L4mioBs4br0uZQ6/U9dA6KQas7oNnh6pBTJ5VZGEoELwur3uG1Q9z0gnrhUSlzUBFiQ/iDSWaKgMfFoSFkiq9Cb03LgIeW0R88PIK8CdIlqHUKCx0VC6/V/MTjBJl5h4POgNYCLRpQdQ= Received: from DM6PR11MB2955.namprd11.prod.outlook.com (2603:10b6:5:65::31) by DM6PR11MB2908.namprd11.prod.outlook.com (2603:10b6:5:70::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.26; Fri, 8 May 2020 07:23:45 +0000 Received: from DM6PR11MB2955.namprd11.prod.outlook.com ([fe80::ccd4:4b0d:535a:58be]) by DM6PR11MB2955.namprd11.prod.outlook.com ([fe80::ccd4:4b0d:535a:58be%7]) with mapi id 15.20.2958.033; Fri, 8 May 2020 07:23:45 +0000 From: "Guomin Jiang" To: "devel@edk2.groups.io" , "Gao, Zhichao" CC: "Wang, Jian J" , "Lu, XiaoyuX" , "Fu, Siyuan" , "Kinney, Michael D" , "Yao, Jiewen" Subject: Re: [edk2-devel] [PATCH V3 0/8] CryptoPkg: Retire the deprecated functions Thread-Topic: [edk2-devel] [PATCH V3 0/8] CryptoPkg: Retire the deprecated functions Thread-Index: AQHWJAI9GH8P6AKDTkC5C3bsrLpOgqidyiZQ Date: Fri, 8 May 2020 07:23:44 +0000 Message-ID: References: <20200506235746.19500-1-zhichao.gao@intel.com> In-Reply-To: <20200506235746.19500-1-zhichao.gao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.205] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 84bd99c6-2f15-418c-82c8-08d7f320be31 x-ms-traffictypediagnostic: DM6PR11MB2908: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1443; x-forefront-prvs: 039735BC4E x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: q30srFfsPgDfJUm7CkKaYvEihZzvl3zO/NMYFVx4/n3Rj3ZyF6F9t1t6f29s3RH5loFUkVmN/o4UMVmYrOt1sgZy2ZBGkR2tWLcRP6D/hs4L/72pS7EyzizW+8LwRnC3gxffhGw9q0VOgI84woOcIqecV4b8QgqzX5Ghhz4Q4BLb/Qp3E49U7EIByFb2grckrD+AzcQWXV3aImh/6Lohukkmls5I5TZC9QLBF8cv1FYBQ6g06Rj0bGYLc3oCQgga/wovtvp0FNWlfa1DmKrfppqdwqKNxSJasif66YhRa/bfW1bvEoLRD8MuJ3dNco2QtOmIEViNnPOVJKs6MT/JXQLuaCFS2A3gXamfsUjyloZtLT6eyrie/pAvsP5CbJdmUf96VmtsH1WwSki0Azw7TIWsjAJEtHMqNbbIjFYZWNCn5oOHvn+fK875EkJLDdq6Kw/Y1gCuWfECEBCq1/99XO2Hefu+O8WqVCP42zPsZui336k5lAcGd5Rs0D5QdPkSvIxEKpjfU3UymB68j7JnZAjvL33UiwOhE7OcgJ5sUCzPhDgaAVnVDEMDYaoIyK8rZOJLkrCvMPFtWkU750N+4kpPYo2uqavnaUuoUn1Tz48= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB2955.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(396003)(346002)(39860400002)(366004)(136003)(376002)(33430700001)(71200400001)(6506007)(2906002)(478600001)(5660300002)(4326008)(966005)(53546011)(83300400001)(33440700001)(107886003)(83280400001)(83310400001)(83320400001)(83290400001)(6636002)(66446008)(9686003)(66946007)(66556008)(52536014)(55016002)(66476007)(64756008)(8936002)(7696005)(76116006)(8676002)(316002)(33656002)(19627235002)(26005)(86362001)(186003)(110136005)(54906003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: 9drUvjYsqOPuu4iMmBU3sEiLDT3CpUfhbgQ2WAHgoEHK1WR5EKyOT2mZ3fDhfobsGRQvtDab15jujl771qybo7vN8Y4kyihafqNGuNDPAiByOSz4lQ0sbJSaOs4T4UKMA5RG63h/S1mc6NoljIwt2B1/dbXghBS1HOpYDvKhy95huL4fkOqSokGKIR210OOexmK9BfcUVwx7kuWEo1jQe6UflOPgUDbUoKpaVCn+MNsrcQQu0pjqEPn0gw2ZYGBs2ox6CNa+GInDJq7DuwKe/yTHHjiNwDrfO2HbMcqhxesG+nia5/ZuzkoxkhSzBli3b4JeVY5VgOdOnPXe2JU5FG3PnQv7YwYo2q4YiHhlbjwFABnc3btKl40Dru1IvIjWj1d2GzcQVX/eoBjfoDGsoxi15tDGiHZJRiqUrwInhdk6IIl56c5T9XSf2HBg6QxTPXuuEG6jEZwQzbGcmBuUgfIjlWjxjOZHhUg3qpLOeJ4= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 84bd99c6-2f15-418c-82c8-08d7f320be31 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 May 2020 07:23:44.7645 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VBraiOthbaBawcakXB1pmOIF8n6XoPZnKbdRSrEbNsaB1Yn9xrG36o7fkiB4Ft7LIY7QuvB08jDRQfOHg9xIvQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2908 Return-Path: guomin.jiang@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable It seem ok except some typo, please modify it. Reviewed-by: Guomin Jiang > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Gao, > Zhichao > Sent: Thursday, May 7, 2020 7:58 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Lu, XiaoyuX ; > Fu, Siyuan ; Kinney, Michael D > ; Yao, Jiewen > Subject: [edk2-devel] [PATCH V3 0/8] CryptoPkg: Retire the deprecated > functions >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1898 >=20 > Retire below deprecated functions: > MD4, ARC4, TDES, AES ECB MODE, HMAC MD5, HMAC SHA1. >=20 > V2: > Seprate the MD5 and SHA1 changes to other patch set. > Change the deprecated function wrapper implementatuion in > EDKII_CRYPTO_PROTOCOL to call a dummy function to print debug message > and assert. >=20 > V3: > Remove the missing part of deprecated functions in V2. > Change the name field in the EDKII_CRYPTO_PROTOCOL to indicate the > function is deprecated and unsupported. >=20 > Cc: Jian J Wang > Cc: Xiaoyu Lu > Cc: Siyuan Fu > Cc: Michael D Kinney > Cc: Jiewen Yao > Signed-off-by: Zhichao Gao >=20 > Zhichao Gao (8): > CryptoPkg/CryptoDxe: Add function to indicate the deprecated algorithm > CryptoPkg/BaseCrpytLib: Retire MD4 algorithm > CryptoPkg/BaseCryptLib: Retire ARC4 algorithm > CryptoPkg/BaseCryptLib: Retire the Tdes algorithm > CryptoPkg/BaseCryptLib: Retire Aes Ecb mode algorithm > CryptoPkg/BaseCryptLib: Retire HMAC MD5 algorithm > CryptoPkg/BaseCryptLib: Retire HMAC SHA1 algorithm > CryptoPkg/Crypto.h: Update the version of Crypto Driver >=20 > CryptoPkg/CryptoPkg.dsc | 46 +- > CryptoPkg/Driver/Crypto.c | 780 ++--------- > CryptoPkg/Include/Library/BaseCryptLib.h | 809 ------------ > .../Library/BaseCryptLib/BaseCryptLib.inf | 7 +- > .../Library/BaseCryptLib/Cipher/CryptAes.c | 114 -- > .../BaseCryptLib/Cipher/CryptAesNull.c | 52 - > .../Library/BaseCryptLib/Cipher/CryptArc4.c | 205 --- > .../BaseCryptLib/Cipher/CryptArc4Null.c | 124 -- > .../Library/BaseCryptLib/Cipher/CryptTdes.c | 364 ------ > .../BaseCryptLib/Cipher/CryptTdesNull.c | 160 --- > .../Library/BaseCryptLib/Hash/CryptMd4.c | 223 ---- > .../Library/BaseCryptLib/Hash/CryptMd4Null.c | 143 -- > .../Library/BaseCryptLib/Hmac/CryptHmacMd5.c | 216 --- > .../BaseCryptLib/Hmac/CryptHmacMd5Null.c | 139 -- > .../Library/BaseCryptLib/Hmac/CryptHmacSha1.c | 216 --- > .../BaseCryptLib/Hmac/CryptHmacSha1Null.c | 139 -- > .../Library/BaseCryptLib/PeiCryptLib.inf | 11 +- > .../Library/BaseCryptLib/PeiCryptLib.uni | 4 +- > CryptoPkg/Library/BaseCryptLib/Pem/CryptPem.c | 7 +- > .../Library/BaseCryptLib/RuntimeCryptLib.inf | 11 +- > .../Library/BaseCryptLib/RuntimeCryptLib.uni | 4 +- > .../Library/BaseCryptLib/SmmCryptLib.inf | 12 +- > .../Library/BaseCryptLib/SmmCryptLib.uni | 4 +- > .../BaseCryptLibNull/BaseCryptLibNull.inf | 5 - > .../BaseCryptLibNull/Cipher/CryptAesNull.c | 52 - > .../BaseCryptLibNull/Cipher/CryptArc4Null.c | 124 -- > .../BaseCryptLibNull/Cipher/CryptTdesNull.c | 160 --- > .../BaseCryptLibNull/Hash/CryptMd4Null.c | 143 -- > .../BaseCryptLibNull/Hmac/CryptHmacMd5Null.c | 139 -- > .../BaseCryptLibNull/Hmac/CryptHmacSha1Null.c | 139 -- > .../BaseCryptLibOnProtocolPpi/CryptLib.c | 1157 ++--------------- > .../Library/Include/openssl/opensslconf.h | 9 + > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 28 - > .../Library/OpensslLib/OpensslLibCrypto.inf | 28 - > CryptoPkg/Private/Protocol/Crypto.h | 708 ++-------- > 35 files changed, 389 insertions(+), 6093 deletions(-) delete mode 100= 644 > CryptoPkg/Library/BaseCryptLib/Cipher/CryptArc4.c > delete mode 100644 > CryptoPkg/Library/BaseCryptLib/Cipher/CryptArc4Null.c > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Cipher/CryptTdes.c > delete mode 100644 > CryptoPkg/Library/BaseCryptLib/Cipher/CryptTdesNull.c > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Hash/CryptMd4.c > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Hash/CryptMd4Null.c > delete mode 100644 > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacMd5.c > delete mode 100644 > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacMd5Null.c > delete mode 100644 > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha1.c > delete mode 100644 > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha1Null.c > delete mode 100644 > CryptoPkg/Library/BaseCryptLibNull/Cipher/CryptArc4Null.c > delete mode 100644 > CryptoPkg/Library/BaseCryptLibNull/Cipher/CryptTdesNull.c > delete mode 100644 > CryptoPkg/Library/BaseCryptLibNull/Hash/CryptMd4Null.c > delete mode 100644 > CryptoPkg/Library/BaseCryptLibNull/Hmac/CryptHmacMd5Null.c > delete mode 100644 > CryptoPkg/Library/BaseCryptLibNull/Hmac/CryptHmacSha1Null.c >=20 > -- > 2.21.0.windows.1 >=20 >=20 >=20