Re: [edk2-devel] [PATCH 1/1] CryptoPkg/Library: Remove the redundant build option

["Guomin Jiang" <guomin.jiang@intel.com>]

Reviewed-by: Guomin Jiang <guomin.jiang@intel.com>

I review the manual from https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html,

It is explained in [-Werror=] option.

Thank for your explanation as well.

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Abner
> Chang
> Sent: Friday, July 17, 2020 9:46 AM
> To: devel@edk2.groups.io; Jiang, Guomin <guomin.jiang@intel.com>
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Lu, XiaoyuX
> <xiaoyux.lu@intel.com>; Laszlo Ersek <lersek@redhat.com>
> Subject: Re: [edk2-devel] [PATCH 1/1] CryptoPkg/Library: Remove the
> redundant build option
> 
> Hi Liming,  what I know about "format" is the switch used to check if the
> proper arguments are assigned printf(). The build option I omitted could be
> copied from somewhere in the same INF file but actually -Wno-format has
> done the same thing.
> 
> Abner
> 
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Guomin Jiang
> > Sent: Friday, July 17, 2020 8:41 AM
> > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> > <abner.chang@hpe.com>
> > Cc: Wang, Jian J <jian.j.wang@intel.com>; Lu, XiaoyuX
> > <xiaoyux.lu@intel.com>; Laszlo Ersek <lersek@redhat.com>
> > Subject: Re: [edk2-devel] [PATCH 1/1] CryptoPkg/Library: Remove the
> > redundant build option
> >
> > Can you explain the -Wno-error=format? I haven't search the switch
> > from google.
> >
> > Appreciate it.
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> Abner
> > > Chang
> > > Sent: Thursday, July 16, 2020 10:55 PM
> > > To: devel@edk2.groups.io
> > > Cc: abner.chang@hpe.com; Wang, Jian J <jian.j.wang@intel.com>; Lu,
> > > XiaoyuX <xiaoyux.lu@intel.com>; Laszlo Ersek <lersek@redhat.com>
> > > Subject: [edk2-devel] [PATCH 1/1] CryptoPkg/Library: Remove the
> > > redundant build option
> > >
> > > Remove the redundant build option for RISCV64 architecture.
> > > BZ:2848
> > >
> > > Signed-off-by: Abner Chang <abner.chang@hpe.com>
> > >
> > > Cc: Jian J Wang <jian.j.wang@intel.com>
> > > Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> > > Cc: Laszlo Ersek <lersek@redhat.com>
> > > ---
> > >  CryptoPkg/Library/OpensslLib/OpensslLib.inf | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> > > b/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> > > index c8ec9454bd..56acf39cac 100644
> > > --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> > > +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> > > @@ -634,7 +634,7 @@
> > >    GCC:*_*_X64_CC_FLAGS     = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS)
> -
> > > Wno-error=maybe-uninitialized -Wno-error=format -Wno-format -Wno-
> > > error=unused-but-set-variable -DNO_MSABI_VA_FUNCS
> > > GCC:*_*_ARM_CC_FLAGS     = $(OPENSSL_FLAGS) -Wno-error=maybe-
> > > uninitialized -Wno-error=unused-but-set-variable
> > > GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-
> error=maybe-
> > > uninitialized -Wno-format -Wno-error=unused-but-set-variable-
> > > GCC:*_*_RISCV64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=format -
> > > Wno-error=maybe-uninitialized -Wno-format -Wno-error=unused-but-
> set-
> > > variable+  GCC:*_*_RISCV64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-
> > > error=maybe-uninitialized -Wno-format -Wno-error=unused-but-set-
> > > variable   GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-
> > error=uninitialized
> > > GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
> > > GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -
> > Wno-
> > > error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-
> > > error=implicit-function-declaration
> > > -Wno-error=ignored-pragma-optimize--
> > > 2.25.0
> > >
> > >
> > > -=-=-=-=-=-=
> > > Groups.io Links: You receive all messages sent to this group.
> > >
> > > View/Reply Online (#62701):
> > > INVALID URI REMOVED
> > 3A__edk2.groups.io_g_
> > >
> >
> devel_message_62701&d=DwIFAg&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN
> > 6FZBN4Vgi4U
> > >
> >
> lkskz6qU3NYRO03nHp9P7Z5q59A3E&m=fxx7QeF34XWrLO8xTfpQHDiAKJnEV
> > aibHbBprV
> > > 2t40A&s=Uiv8Z_CxhmBlsOpLs6Zyr5aoWomyYqs-TvIyN1vHQTE&e=
> > > Mute This Topic:
> > > INVALID URI REMOVED
> > 3A__groups.io_mt_7554
> > >
> >
> 4235_4399222&d=DwIFAg&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4V
> > gi4Ulkskz6q
> > >
> >
> U3NYRO03nHp9P7Z5q59A3E&m=fxx7QeF34XWrLO8xTfpQHDiAKJnEVaibHbB
> > prV2t40A&s
> > > =bSGjbaXsEHNPH3OasPi7KFv2RAEtq99X_1naItW3GPY&e=
> > > Group Owner: devel+owner@edk2.groups.io
> > > Unsubscribe:
> > > INVALID URI REMOVED
> > 3A__edk2.groups.io_g_
> > >
> >
> devel_unsub&d=DwIFAg&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi
> > 4Ulkskz6qU
> > >
> >
> 3NYRO03nHp9P7Z5q59A3E&m=fxx7QeF34XWrLO8xTfpQHDiAKJnEVaibHbBpr
> > V2t40A&s=
> > > XTAHbAiP9YqSOzVDE4JHRDFkD4gli53w39dL39vWdg0&e=
> > > [guomin.jiang@intel.com] -=-=-=-=-=-=
> >
> >
> >
> 
> 
>