* [PATCH 1/1] CryptoPkg/Library: Remove the redundant build option
@ 2020-07-16 14:55 Abner Chang
2020-07-17 0:41 ` [edk2-devel] " Guomin Jiang
2020-07-17 9:38 ` Laszlo Ersek
0 siblings, 2 replies; 6+ messages in thread
From: Abner Chang @ 2020-07-16 14:55 UTC (permalink / raw)
To: devel; +Cc: abner.chang, Jian J Wang, Xiaoyu Lu, Laszlo Ersek
Remove the redundant build option for RISCV64 architecture.
BZ:2848
Signed-off-by: Abner Chang <abner.chang@hpe.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
---
CryptoPkg/Library/OpensslLib/OpensslLib.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf b/CryptoPkg/Library/OpensslLib/OpensslLib.inf
index c8ec9454bd..56acf39cac 100644
--- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf
+++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf
@@ -634,7 +634,7 @@
GCC:*_*_X64_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-error=format -Wno-format -Wno-error=unused-but-set-variable -DNO_MSABI_VA_FUNCS
GCC:*_*_ARM_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-error=unused-but-set-variable
GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-format -Wno-error=unused-but-set-variable
- GCC:*_*_RISCV64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=format -Wno-error=maybe-uninitialized -Wno-format -Wno-error=unused-but-set-variable
+ GCC:*_*_RISCV64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-format -Wno-error=unused-but-set-variable
GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-error=implicit-function-declaration -Wno-error=ignored-pragma-optimize
--
2.25.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] CryptoPkg/Library: Remove the redundant build option
2020-07-16 14:55 [PATCH 1/1] CryptoPkg/Library: Remove the redundant build option Abner Chang
@ 2020-07-17 0:41 ` Guomin Jiang
2020-07-17 1:46 ` Abner Chang
2020-07-17 9:38 ` Laszlo Ersek
1 sibling, 1 reply; 6+ messages in thread
From: Guomin Jiang @ 2020-07-17 0:41 UTC (permalink / raw)
To: devel@edk2.groups.io, abner.chang@hpe.com
Cc: Wang, Jian J, Lu, XiaoyuX, Laszlo Ersek
Can you explain the -Wno-error=format? I haven't search the switch from google.
Appreciate it.
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Abner
> Chang
> Sent: Thursday, July 16, 2020 10:55 PM
> To: devel@edk2.groups.io
> Cc: abner.chang@hpe.com; Wang, Jian J <jian.j.wang@intel.com>; Lu,
> XiaoyuX <xiaoyux.lu@intel.com>; Laszlo Ersek <lersek@redhat.com>
> Subject: [edk2-devel] [PATCH 1/1] CryptoPkg/Library: Remove the
> redundant build option
>
> Remove the redundant build option for RISCV64 architecture.
> BZ:2848
>
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> ---
> CryptoPkg/Library/OpensslLib/OpensslLib.inf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> b/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> index c8ec9454bd..56acf39cac 100644
> --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> @@ -634,7 +634,7 @@
> GCC:*_*_X64_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -
> Wno-error=maybe-uninitialized -Wno-error=format -Wno-format -Wno-
> error=unused-but-set-variable -DNO_MSABI_VA_FUNCS
> GCC:*_*_ARM_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-
> uninitialized -Wno-error=unused-but-set-variable
> GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-
> uninitialized -Wno-format -Wno-error=unused-but-set-variable-
> GCC:*_*_RISCV64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=format -
> Wno-error=maybe-uninitialized -Wno-format -Wno-error=unused-but-set-
> variable+ GCC:*_*_RISCV64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-
> error=maybe-uninitialized -Wno-format -Wno-error=unused-but-set-
> variable GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
> GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
> GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-
> error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-
> error=implicit-function-declaration -Wno-error=ignored-pragma-optimize--
> 2.25.0
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
>
> View/Reply Online (#62701): https://edk2.groups.io/g/devel/message/62701
> Mute This Topic: https://groups.io/mt/75544235/4399222
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [guomin.jiang@intel.com] -=-=-=-=-=-=
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] CryptoPkg/Library: Remove the redundant build option
2020-07-17 0:41 ` [edk2-devel] " Guomin Jiang
@ 2020-07-17 1:46 ` Abner Chang
2020-07-17 7:58 ` Guomin Jiang
0 siblings, 1 reply; 6+ messages in thread
From: Abner Chang @ 2020-07-17 1:46 UTC (permalink / raw)
To: devel@edk2.groups.io, guomin.jiang@intel.com
Cc: Wang, Jian J, Lu, XiaoyuX, Laszlo Ersek
Hi Liming, what I know about "format" is the switch used to check if the proper arguments are assigned printf(). The build option I omitted could be copied from somewhere in the same INF file but actually -Wno-format has done the same thing.
Abner
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Guomin Jiang
> Sent: Friday, July 17, 2020 8:41 AM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> <abner.chang@hpe.com>
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Lu, XiaoyuX
> <xiaoyux.lu@intel.com>; Laszlo Ersek <lersek@redhat.com>
> Subject: Re: [edk2-devel] [PATCH 1/1] CryptoPkg/Library: Remove the
> redundant build option
>
> Can you explain the -Wno-error=format? I haven't search the switch from
> google.
>
> Appreciate it.
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Abner
> > Chang
> > Sent: Thursday, July 16, 2020 10:55 PM
> > To: devel@edk2.groups.io
> > Cc: abner.chang@hpe.com; Wang, Jian J <jian.j.wang@intel.com>; Lu,
> > XiaoyuX <xiaoyux.lu@intel.com>; Laszlo Ersek <lersek@redhat.com>
> > Subject: [edk2-devel] [PATCH 1/1] CryptoPkg/Library: Remove the
> > redundant build option
> >
> > Remove the redundant build option for RISCV64 architecture.
> > BZ:2848
> >
> > Signed-off-by: Abner Chang <abner.chang@hpe.com>
> >
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > ---
> > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> > b/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> > index c8ec9454bd..56acf39cac 100644
> > --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> > +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> > @@ -634,7 +634,7 @@
> > GCC:*_*_X64_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -
> > Wno-error=maybe-uninitialized -Wno-error=format -Wno-format -Wno-
> > error=unused-but-set-variable -DNO_MSABI_VA_FUNCS
> > GCC:*_*_ARM_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-
> > uninitialized -Wno-error=unused-but-set-variable
> > GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-
> > uninitialized -Wno-format -Wno-error=unused-but-set-variable-
> > GCC:*_*_RISCV64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=format -
> > Wno-error=maybe-uninitialized -Wno-format -Wno-error=unused-but-set-
> > variable+ GCC:*_*_RISCV64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-
> > error=maybe-uninitialized -Wno-format -Wno-error=unused-but-set-
> > variable GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-
> error=uninitialized
> > GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
> > GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -
> Wno-
> > error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-
> > error=implicit-function-declaration
> > -Wno-error=ignored-pragma-optimize--
> > 2.25.0
> >
> >
> > -=-=-=-=-=-=
> > Groups.io Links: You receive all messages sent to this group.
> >
> > View/Reply Online (#62701):
> > INVALID URI REMOVED
> 3A__edk2.groups.io_g_
> >
> devel_message_62701&d=DwIFAg&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN
> 6FZBN4Vgi4U
> >
> lkskz6qU3NYRO03nHp9P7Z5q59A3E&m=fxx7QeF34XWrLO8xTfpQHDiAKJnEV
> aibHbBprV
> > 2t40A&s=Uiv8Z_CxhmBlsOpLs6Zyr5aoWomyYqs-TvIyN1vHQTE&e=
> > Mute This Topic:
> > INVALID URI REMOVED
> 3A__groups.io_mt_7554
> >
> 4235_4399222&d=DwIFAg&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4V
> gi4Ulkskz6q
> >
> U3NYRO03nHp9P7Z5q59A3E&m=fxx7QeF34XWrLO8xTfpQHDiAKJnEVaibHbB
> prV2t40A&s
> > =bSGjbaXsEHNPH3OasPi7KFv2RAEtq99X_1naItW3GPY&e=
> > Group Owner: devel+owner@edk2.groups.io
> > Unsubscribe:
> > INVALID URI REMOVED
> 3A__edk2.groups.io_g_
> >
> devel_unsub&d=DwIFAg&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi
> 4Ulkskz6qU
> >
> 3NYRO03nHp9P7Z5q59A3E&m=fxx7QeF34XWrLO8xTfpQHDiAKJnEVaibHbBpr
> V2t40A&s=
> > XTAHbAiP9YqSOzVDE4JHRDFkD4gli53w39dL39vWdg0&e=
> > [guomin.jiang@intel.com] -=-=-=-=-=-=
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] CryptoPkg/Library: Remove the redundant build option
2020-07-17 1:46 ` Abner Chang
@ 2020-07-17 7:58 ` Guomin Jiang
0 siblings, 0 replies; 6+ messages in thread
From: Guomin Jiang @ 2020-07-17 7:58 UTC (permalink / raw)
To: devel@edk2.groups.io, abner.chang@hpe.com
Cc: Wang, Jian J, Lu, XiaoyuX, Laszlo Ersek
Reviewed-by: Guomin Jiang <guomin.jiang@intel.com>
I review the manual from https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html,
It is explained in [-Werror=] option.
Thank for your explanation as well.
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Abner
> Chang
> Sent: Friday, July 17, 2020 9:46 AM
> To: devel@edk2.groups.io; Jiang, Guomin <guomin.jiang@intel.com>
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Lu, XiaoyuX
> <xiaoyux.lu@intel.com>; Laszlo Ersek <lersek@redhat.com>
> Subject: Re: [edk2-devel] [PATCH 1/1] CryptoPkg/Library: Remove the
> redundant build option
>
> Hi Liming, what I know about "format" is the switch used to check if the
> proper arguments are assigned printf(). The build option I omitted could be
> copied from somewhere in the same INF file but actually -Wno-format has
> done the same thing.
>
> Abner
>
>
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Guomin Jiang
> > Sent: Friday, July 17, 2020 8:41 AM
> > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> > <abner.chang@hpe.com>
> > Cc: Wang, Jian J <jian.j.wang@intel.com>; Lu, XiaoyuX
> > <xiaoyux.lu@intel.com>; Laszlo Ersek <lersek@redhat.com>
> > Subject: Re: [edk2-devel] [PATCH 1/1] CryptoPkg/Library: Remove the
> > redundant build option
> >
> > Can you explain the -Wno-error=format? I haven't search the switch
> > from google.
> >
> > Appreciate it.
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> Abner
> > > Chang
> > > Sent: Thursday, July 16, 2020 10:55 PM
> > > To: devel@edk2.groups.io
> > > Cc: abner.chang@hpe.com; Wang, Jian J <jian.j.wang@intel.com>; Lu,
> > > XiaoyuX <xiaoyux.lu@intel.com>; Laszlo Ersek <lersek@redhat.com>
> > > Subject: [edk2-devel] [PATCH 1/1] CryptoPkg/Library: Remove the
> > > redundant build option
> > >
> > > Remove the redundant build option for RISCV64 architecture.
> > > BZ:2848
> > >
> > > Signed-off-by: Abner Chang <abner.chang@hpe.com>
> > >
> > > Cc: Jian J Wang <jian.j.wang@intel.com>
> > > Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> > > Cc: Laszlo Ersek <lersek@redhat.com>
> > > ---
> > > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> > > b/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> > > index c8ec9454bd..56acf39cac 100644
> > > --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> > > +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> > > @@ -634,7 +634,7 @@
> > > GCC:*_*_X64_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS)
> -
> > > Wno-error=maybe-uninitialized -Wno-error=format -Wno-format -Wno-
> > > error=unused-but-set-variable -DNO_MSABI_VA_FUNCS
> > > GCC:*_*_ARM_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-
> > > uninitialized -Wno-error=unused-but-set-variable
> > > GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-
> error=maybe-
> > > uninitialized -Wno-format -Wno-error=unused-but-set-variable-
> > > GCC:*_*_RISCV64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=format -
> > > Wno-error=maybe-uninitialized -Wno-format -Wno-error=unused-but-
> set-
> > > variable+ GCC:*_*_RISCV64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-
> > > error=maybe-uninitialized -Wno-format -Wno-error=unused-but-set-
> > > variable GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-
> > error=uninitialized
> > > GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
> > > GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -
> > Wno-
> > > error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-
> > > error=implicit-function-declaration
> > > -Wno-error=ignored-pragma-optimize--
> > > 2.25.0
> > >
> > >
> > > -=-=-=-=-=-=
> > > Groups.io Links: You receive all messages sent to this group.
> > >
> > > View/Reply Online (#62701):
> > > INVALID URI REMOVED
> > 3A__edk2.groups.io_g_
> > >
> >
> devel_message_62701&d=DwIFAg&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN
> > 6FZBN4Vgi4U
> > >
> >
> lkskz6qU3NYRO03nHp9P7Z5q59A3E&m=fxx7QeF34XWrLO8xTfpQHDiAKJnEV
> > aibHbBprV
> > > 2t40A&s=Uiv8Z_CxhmBlsOpLs6Zyr5aoWomyYqs-TvIyN1vHQTE&e=
> > > Mute This Topic:
> > > INVALID URI REMOVED
> > 3A__groups.io_mt_7554
> > >
> >
> 4235_4399222&d=DwIFAg&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4V
> > gi4Ulkskz6q
> > >
> >
> U3NYRO03nHp9P7Z5q59A3E&m=fxx7QeF34XWrLO8xTfpQHDiAKJnEVaibHbB
> > prV2t40A&s
> > > =bSGjbaXsEHNPH3OasPi7KFv2RAEtq99X_1naItW3GPY&e=
> > > Group Owner: devel+owner@edk2.groups.io
> > > Unsubscribe:
> > > INVALID URI REMOVED
> > 3A__edk2.groups.io_g_
> > >
> >
> devel_unsub&d=DwIFAg&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi
> > 4Ulkskz6qU
> > >
> >
> 3NYRO03nHp9P7Z5q59A3E&m=fxx7QeF34XWrLO8xTfpQHDiAKJnEVaibHbBpr
> > V2t40A&s=
> > > XTAHbAiP9YqSOzVDE4JHRDFkD4gli53w39dL39vWdg0&e=
> > > [guomin.jiang@intel.com] -=-=-=-=-=-=
> >
> >
> >
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] CryptoPkg/Library: Remove the redundant build option
2020-07-16 14:55 [PATCH 1/1] CryptoPkg/Library: Remove the redundant build option Abner Chang
2020-07-17 0:41 ` [edk2-devel] " Guomin Jiang
@ 2020-07-17 9:38 ` Laszlo Ersek
2020-08-12 7:33 ` [edk2-devel] " Guomin Jiang
1 sibling, 1 reply; 6+ messages in thread
From: Laszlo Ersek @ 2020-07-17 9:38 UTC (permalink / raw)
To: Abner Chang, devel; +Cc: Jian J Wang, Xiaoyu Lu
On 07/16/20 16:55, Abner Chang wrote:
> Remove the redundant build option for RISCV64 architecture.
> BZ:2848
>
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> ---
> CryptoPkg/Library/OpensslLib/OpensslLib.inf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf b/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> index c8ec9454bd..56acf39cac 100644
> --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> @@ -634,7 +634,7 @@
> GCC:*_*_X64_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-error=format -Wno-format -Wno-error=unused-but-set-variable -DNO_MSABI_VA_FUNCS
> GCC:*_*_ARM_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-error=unused-but-set-variable
> GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-format -Wno-error=unused-but-set-variable
> - GCC:*_*_RISCV64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=format -Wno-error=maybe-uninitialized -Wno-format -Wno-error=unused-but-set-variable
> + GCC:*_*_RISCV64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-format -Wno-error=unused-but-set-variable
> GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
> GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
> GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-error=implicit-function-declaration -Wno-error=ignored-pragma-optimize
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks!
Laszlo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] CryptoPkg/Library: Remove the redundant build option
2020-07-17 9:38 ` Laszlo Ersek
@ 2020-08-12 7:33 ` Guomin Jiang
0 siblings, 0 replies; 6+ messages in thread
From: Guomin Jiang @ 2020-08-12 7:33 UTC (permalink / raw)
To: devel@edk2.groups.io, lersek@redhat.com, Abner Chang
Cc: Wang, Jian J, Lu, XiaoyuX
Pushed in commit be01087e07809d20aa2db27b37029c324c824407.
Thanks
Guomin
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Laszlo
> Ersek
> Sent: Friday, July 17, 2020 5:39 PM
> To: Abner Chang <abner.chang@hpe.com>; devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Lu, XiaoyuX
> <xiaoyux.lu@intel.com>
> Subject: Re: [edk2-devel] [PATCH 1/1] CryptoPkg/Library: Remove the
> redundant build option
>
> On 07/16/20 16:55, Abner Chang wrote:
> > Remove the redundant build option for RISCV64 architecture.
> > BZ:2848
> >
> > Signed-off-by: Abner Chang <abner.chang@hpe.com>
> >
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > ---
> > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> b/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> > index c8ec9454bd..56acf39cac 100644
> > --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> > +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> > @@ -634,7 +634,7 @@
> > GCC:*_*_X64_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -
> Wno-error=maybe-uninitialized -Wno-error=format -Wno-format -Wno-
> error=unused-but-set-variable -DNO_MSABI_VA_FUNCS
> > GCC:*_*_ARM_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-
> uninitialized -Wno-error=unused-but-set-variable
> > GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-
> error=maybe-uninitialized -Wno-format -Wno-error=unused-but-set-
> variable
> > - GCC:*_*_RISCV64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=format -
> Wno-error=maybe-uninitialized -Wno-format -Wno-error=unused-but-set-
> variable
> > + GCC:*_*_RISCV64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-
> uninitialized -Wno-format -Wno-error=unused-but-set-variable
> > GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
> > GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
> > GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -
> Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-
> error=implicit-function-declaration -Wno-error=ignored-pragma-optimize
> >
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>
> Thanks!
> Laszlo
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-08-12 7:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-16 14:55 [PATCH 1/1] CryptoPkg/Library: Remove the redundant build option Abner Chang
2020-07-17 0:41 ` [edk2-devel] " Guomin Jiang
2020-07-17 1:46 ` Abner Chang
2020-07-17 7:58 ` Guomin Jiang
2020-07-17 9:38 ` Laszlo Ersek
2020-08-12 7:33 ` [edk2-devel] " Guomin Jiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox