From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web10.1571.1587435344411177114 for ; Mon, 20 Apr 2020 19:15:44 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=ADDAZKJz; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: guomin.jiang@intel.com) IronPort-SDR: A985uBUjbosCdB7HplcPzdFUgiN56hu3STaLViGZLBb6YbX/1UPEE5l7EuZRxrwQ6wVdQpAPVd 55qIUJXbpfSQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2020 19:15:43 -0700 IronPort-SDR: kJKBEItL8YSlbuxnIAaC/IpbVIg1PlTs6jvnRZ2Ear/wBSvOMEv04nGC04w22HLbErJEgMnspN ozWnHhfJcDMw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,408,1580803200"; d="scan'208";a="365194509" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga001.fm.intel.com with ESMTP; 20 Apr 2020 19:15:43 -0700 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Apr 2020 19:15:43 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Apr 2020 19:15:42 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.109) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Apr 2020 19:15:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QERL4iHlsf7IWmTdMYptGpevB3CLnZ+xMr0KcBwjMXe22MyTiBH+Gnjs9/57O8zxU7WhaiVfp4yV1AtrzcrRklSmHk/zRLNol1znQoWmBKdBfJFvuswbf8dsV6c4hgFqyMA1jiZFq2vH08ZQnvOiIrn+h+0oxl1n1Vyy4/hMM/Wih74aeIKgvrNezIE9E2pCEzdhEqHXIMXXP5WMa9SovJgBVGbZ3n9phvc8DNg+NmC1QbPFQWFQ6xyNRhlUJgyxy8ZrHOtr74R2JCbmBNduYMTUmFQJYwc5SrcMVb8/4k1kB1StNdhseFvIh7LdT+PHcy3qpJS4YBhbN8wuCWm3zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=InuKmMCPqoWf+bJSPyOg9/qOFvo8pXIr9b+zkRQwTm4=; b=WkYl1fhMou9i5USaE8VK/mWOAl2Ndao0opfQ8LRW4sumSGg0q3QYkqrQK6lsxsM3QhanTplDPmD062nW/h8E49a60BMpQlDk7lmkdNHL0etUV3HePtEQTiEb/dGBTFWhDmBO50H9Tqa/Fqji29yhxdHkCmZ6TNQ9+xVCUnfjmslDViog6iXsnr/akAru95DCnUVgbpW57eXnXH271PTKKr6va9TGbIfmgiY/f+sb8xxz2VlCEN1sovOZJTUkyo+cqFptzJd1IRXjJ6jYT8HMqo5ptSgEM2XKGooPeTzaxcgn4w/aLGIJkWvpKxCXE40fubxO2QwF2CPs1MMbnhHRhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=InuKmMCPqoWf+bJSPyOg9/qOFvo8pXIr9b+zkRQwTm4=; b=ADDAZKJzpC9dMxzRuGhhNSMpy1Tm74I/eSVHHlRp2szbLvbOqIrpYJr7Hg+r84VAE7mAv9Rcehs8cCVETlTrKLTD9CIkJorxiQL4GYWSGG2ZNj6ZP7BCGmyLoZpDwNMT14uXJZfPtAUq2lFaRfqr4nNkCUs6TUMVguy/nVA8Z6k= Received: from DM6PR11MB2955.namprd11.prod.outlook.com (2603:10b6:5:65::31) by DM6PR11MB4427.namprd11.prod.outlook.com (2603:10b6:5:1db::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.29; Tue, 21 Apr 2020 02:15:41 +0000 Received: from DM6PR11MB2955.namprd11.prod.outlook.com ([fe80::ccd4:4b0d:535a:58be]) by DM6PR11MB2955.namprd11.prod.outlook.com ([fe80::ccd4:4b0d:535a:58be%7]) with mapi id 15.20.2921.030; Tue, 21 Apr 2020 02:15:41 +0000 From: "Guomin Jiang" To: Laszlo Ersek , "devel@edk2.groups.io" Subject: Re: [edk2-devel] [PATCH v2 0/6] Mark the File parameter as OPTIONAL Thread-Topic: [edk2-devel] [PATCH v2 0/6] Mark the File parameter as OPTIONAL Thread-Index: AQHWFwhilWPWdRc18UKkO/rQ5r17o6iC1Sxg Date: Tue, 21 Apr 2020 02:15:40 +0000 Message-ID: References: <20200416073354.2232-1-guomin.jiang@intel.com> <8ab786ea-d813-896e-83aa-4bd6b1296b1a@redhat.com> In-Reply-To: <8ab786ea-d813-896e-83aa-4bd6b1296b1a@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: spf=none (sender IP is ) smtp.mailfrom=guomin.jiang@intel.com; x-originating-ip: [192.55.52.205] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9b39a9bc-687e-41df-b1ef-08d7e599e3c6 x-ms-traffictypediagnostic: DM6PR11MB4427: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 038002787A x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB2955.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10019020)(39860400002)(396003)(346002)(366004)(136003)(376002)(52536014)(33656002)(86362001)(478600001)(19627235002)(110136005)(55016002)(9686003)(71200400001)(53546011)(66446008)(66556008)(64756008)(6506007)(2906002)(7696005)(66476007)(186003)(5660300002)(66946007)(8676002)(76116006)(26005)(81156014)(8936002)(316002);DIR:OUT;SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: h3GdFQu6r3PqD2EGu/L3pXTV43g8gQO83pW8PHwcz0tADbyadN8FBwxkzLh0Kd81kX5y5xIbTFlOyDVn+KqD0Fb4s2l83Pgbih8VovlcjS+t8ICU7VXgfZSon7S/kcS0Fej6cUCTp8IYbGmXIsh0GEHSNZqXEvRotVY1tb3My3052RiVHLFhPIfo4Ti45Cy3vQMhT1u6tULD8zHePEmhIKV61+qUcNv2hWZL3/6dEMewmYEvnbSz2tjf8n7/bArRH0MyNLW7mKD09rBZyPXnukyOaHwsS5yXArcnNLUeiaFrTOj3ef+q5F+JXORWJ2vSk8cpsFLLRTSTfU+1XEPDFmJHWM5tBQyGx6NU0ycv83K1ouNcNrV4hIENeDfhuWledFikQODBBWgeh0JvUpl+uuvWC61M3S6Uk2PZ3H05cOxClpeyY5ApC9MY0BOrGkxz x-ms-exchange-antispam-messagedata: 2HQS2mWewxcQcYeKpqytTdJRCDmkEgIDO0aXUiTyqLxBYO3vU1ZkvAqPumndx+4YMAwYsqbTSc5dN9VauK/b5THXMRYDrLkB1n7y6Dj/LEH43Y/aryYSE7ZhQZCCNRRhH6qpuZXjldTqGJB/IWeFpg== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 9b39a9bc-687e-41df-b1ef-08d7e599e3c6 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2020 02:15:40.8792 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: axyF6t6a8XQGgAIB5BUqiFgU10cVdUwEO1mVGPQMSUH874DCr5AXD4Stjyyte0UKycuTyeYrWCiJZ81VA09UeA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4427 Return-Path: guomin.jiang@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Laszlo, I'm sad when saw the message. but I still appreciate the advice provided by= you. I think that this is not the only documentation issue, and should discuss i= n other topic. Hi Jian, Chao, Just for this issue, please give some feedback. Best Regards Guomin > -----Original Message----- > From: Laszlo Ersek > Sent: Monday, April 20, 2020 7:39 PM > To: devel@edk2.groups.io; Jiang, Guomin > Subject: Re: [edk2-devel] [PATCH v2 0/6] Mark the File parameter as > OPTIONAL >=20 > On 04/16/20 09:33, Guomin Jiang wrote: > > File paramter should be optional according to the descritpion. > > > > Guomin Jiang (6): > > SecurityPkg/TPM: measure UEFI images without associated device paths > > again > > SecurityPkg/DxeImageAuth: Mark the File parameter as option > > SecurityPkg/DxeImageVerificationLib: Mark the File parameter as > > OPTIONAL > > MdeModulePkg/SecurityManagementLib: Mark the File parameter as > > OPTIONAL > > MdeModulePkg/SecurityStubDxe: Mark the File parameter as OPTIONAL > > MdePkg/Security2: Mark the File parameter as OPTIONAL. > > > > .../Include/Library/SecurityManagementLib.h | 2 +- > > .../DxeSecurityManagementLib.c | 2 +- > > .../Universal/SecurityStubDxe/SecurityStub.c | 2 +- > > MdePkg/Include/Protocol/Security2.h | 2 +- > > .../DxeImageAuthenticationStatusLib.c | 2 +- > > .../DxeImageVerificationLib.c | 2 +- > > .../DxeTpm2MeasureBootLib.c | 20 +++++++++---------- > > .../DxeTpmMeasureBootLib.c | 20 +++++++++---------- > > 8 files changed, 26 insertions(+), 26 deletions(-) > > >=20 > The more I look at the pre-patch code, the more the pre-existent > documentation inconsistencies irritate me. >=20 > I withdraw from reviewing this series. Proceed as you and other reviewers > see fit. >=20 > If you prefer, go ahead and simply revert 4b026f0d5af3. If you do so, I w= ill not > review that patch either. The existent function-level comments are broken= , > so I don't think anyone can really rely on them for guidance. >=20 > If you want to do the right thing, the whole comment mess has to be clean= ed > up. Up to you, but I'm out. >=20 > Laszlo