From: "Guomin Jiang" <guomin.jiang@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"michael.kubacki@outlook.com" <michael.kubacki@outlook.com>,
"Gao, Liming" <liming.gao@intel.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH v1 0/7] FmpDevicePkg Minor Fixes
Date: Wed, 5 Aug 2020 04:42:19 +0000 [thread overview]
Message-ID: <DM6PR11MB2955D38F52D21DF4412A196E9D4B0@DM6PR11MB2955.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MWHPR07MB3440CF47C4CFC3C51A501B2FE94A0@MWHPR07MB3440.namprd07.prod.outlook.com>
Reviewed-by: Guomin Jiang <guomin.jiang@intel.com> for the patch series.
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael
> Kubacki
> Sent: Wednesday, August 5, 2020 3:12 AM
> To: devel@edk2.groups.io; Gao, Liming <liming.gao@intel.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] [PATCH v1 0/7] FmpDevicePkg Minor Fixes
>
> I saw one R-b for the series from Wei6 Xu.
>
> Could the remaining reviewers please help with review?
>
> I have a larger series that is based on it that I'd like to send once this series is
> merged.
>
> Thanks,
> Michael
>
> On 7/30/2020 8:14 PM, Michael Kubacki wrote:
> > From: Michael Kubacki <michael.kubacki@microsoft.com>
> >
> > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2869
> >
> > This patch series makes minor fixes and enhancements in FmpDevicePkg.
> > None of the issues impact functionality in a major way.
> >
> > These are smaller sets of changes that are being submitted prior to a
> > larger future patch series that will cover functional changes for
> > BZ2802.
> >
> > Please check the git notes in patch 3 and patch 5.
> >
> > Cc: Liming Gao <liming.gao@intel.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> >
> > Michael Kubacki (7):
> > FmpDevicePkg/FmpDependencyLib: Correct ValidateDependency()
> > documentation
> > FmpDevicePkg/FmpDependencyLib: Fix "exression" typo
> > FmpDevicePkg/FmpDependencyLib: Handle version string overflow
> > FmpDevicePkg/FmpDependencyCheckLib: Return unsatisfied on handle
> > failure
> > FmpDevicePkg/FmpDxe: Better warn of potential ImageTypeId misconfig
> > FmpDevicePkg/FmpDxe: Indicate ESRT GUID on invalid ImageIdName
> > FmpDevicePkg/FmpDxe: Improve function parameter validation
> >
> > FmpDevicePkg/FmpDxe/FmpDxe.c | 62
> ++++++++++++++++----
> >
> FmpDevicePkg/Library/FmpDependencyCheckLib/FmpDependencyCheckLib
> .c | 2 +
> > FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c |
> 8 ++-
> > FmpDevicePkg/FmpDxe/FmpDxe.h | 10 ++--
> > FmpDevicePkg/Include/Library/FmpDependencyLib.h | 5 +-
> > 5 files changed, 67 insertions(+), 20 deletions(-)
> >
>
>
next prev parent reply other threads:[~2020-08-05 4:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1626B7E87C6880F1.8866@groups.io>
2020-08-04 19:11 ` [edk2-devel] [PATCH v1 0/7] FmpDevicePkg Minor Fixes Michael Kubacki
2020-08-05 4:42 ` Guomin Jiang [this message]
2020-07-31 3:14 Michael Kubacki
2020-07-31 6:56 ` [edk2-devel] " Xu, Wei6
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB2955D38F52D21DF4412A196E9D4B0@DM6PR11MB2955.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox