* Re: [edk2-devel] [PATCH v1 0/7] FmpDevicePkg Minor Fixes
2020-07-31 3:14 Michael Kubacki
@ 2020-07-31 6:56 ` Xu, Wei6
0 siblings, 0 replies; 3+ messages in thread
From: Xu, Wei6 @ 2020-07-31 6:56 UTC (permalink / raw)
To: devel@edk2.groups.io, michael.kubacki@outlook.com
Cc: Gao, Liming, Kinney, Michael D, Xu, Wei6
Reviewed-by: Wei6 Xu <wei6.xu@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael Kubacki
Sent: Friday, July 31, 2020 11:15 AM
To: devel@edk2.groups.io
Cc: Gao, Liming <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: [edk2-devel] [PATCH v1 0/7] FmpDevicePkg Minor Fixes
From: Michael Kubacki <michael.kubacki@microsoft.com>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2869
This patch series makes minor fixes and enhancements in FmpDevicePkg. None of the issues impact functionality in a major way.
These are smaller sets of changes that are being submitted prior to a larger future patch series that will cover functional changes for BZ2802.
Please check the git notes in patch 3 and patch 5.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Michael Kubacki (7):
FmpDevicePkg/FmpDependencyLib: Correct ValidateDependency()
documentation
FmpDevicePkg/FmpDependencyLib: Fix "exression" typo
FmpDevicePkg/FmpDependencyLib: Handle version string overflow
FmpDevicePkg/FmpDependencyCheckLib: Return unsatisfied on handle
failure
FmpDevicePkg/FmpDxe: Better warn of potential ImageTypeId misconfig
FmpDevicePkg/FmpDxe: Indicate ESRT GUID on invalid ImageIdName
FmpDevicePkg/FmpDxe: Improve function parameter validation
FmpDevicePkg/FmpDxe/FmpDxe.c | 62 ++++++++++++++++----
FmpDevicePkg/Library/FmpDependencyCheckLib/FmpDependencyCheckLib.c | 2 +
FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c | 8 ++-
FmpDevicePkg/FmpDxe/FmpDxe.h | 10 ++--
FmpDevicePkg/Include/Library/FmpDependencyLib.h | 5 +-
5 files changed, 67 insertions(+), 20 deletions(-)
--
2.27.0.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [PATCH v1 0/7] FmpDevicePkg Minor Fixes
[not found] <1626B7E87C6880F1.8866@groups.io>
@ 2020-08-04 19:11 ` Michael Kubacki
2020-08-05 4:42 ` Guomin Jiang
0 siblings, 1 reply; 3+ messages in thread
From: Michael Kubacki @ 2020-08-04 19:11 UTC (permalink / raw)
To: devel, Liming Gao, Michael D Kinney
I saw one R-b for the series from Wei6 Xu.
Could the remaining reviewers please help with review?
I have a larger series that is based on it that I'd like to send once
this series is merged.
Thanks,
Michael
On 7/30/2020 8:14 PM, Michael Kubacki wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2869
>
> This patch series makes minor fixes and enhancements in
> FmpDevicePkg. None of the issues impact functionality in a
> major way.
>
> These are smaller sets of changes that are being submitted prior
> to a larger future patch series that will cover functional changes
> for BZ2802.
>
> Please check the git notes in patch 3 and patch 5.
>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>
> Michael Kubacki (7):
> FmpDevicePkg/FmpDependencyLib: Correct ValidateDependency()
> documentation
> FmpDevicePkg/FmpDependencyLib: Fix "exression" typo
> FmpDevicePkg/FmpDependencyLib: Handle version string overflow
> FmpDevicePkg/FmpDependencyCheckLib: Return unsatisfied on handle
> failure
> FmpDevicePkg/FmpDxe: Better warn of potential ImageTypeId misconfig
> FmpDevicePkg/FmpDxe: Indicate ESRT GUID on invalid ImageIdName
> FmpDevicePkg/FmpDxe: Improve function parameter validation
>
> FmpDevicePkg/FmpDxe/FmpDxe.c | 62 ++++++++++++++++----
> FmpDevicePkg/Library/FmpDependencyCheckLib/FmpDependencyCheckLib.c | 2 +
> FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c | 8 ++-
> FmpDevicePkg/FmpDxe/FmpDxe.h | 10 ++--
> FmpDevicePkg/Include/Library/FmpDependencyLib.h | 5 +-
> 5 files changed, 67 insertions(+), 20 deletions(-)
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [PATCH v1 0/7] FmpDevicePkg Minor Fixes
2020-08-04 19:11 ` [edk2-devel] [PATCH v1 0/7] FmpDevicePkg Minor Fixes Michael Kubacki
@ 2020-08-05 4:42 ` Guomin Jiang
0 siblings, 0 replies; 3+ messages in thread
From: Guomin Jiang @ 2020-08-05 4:42 UTC (permalink / raw)
To: devel@edk2.groups.io, michael.kubacki@outlook.com, Gao, Liming,
Kinney, Michael D
Reviewed-by: Guomin Jiang <guomin.jiang@intel.com> for the patch series.
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael
> Kubacki
> Sent: Wednesday, August 5, 2020 3:12 AM
> To: devel@edk2.groups.io; Gao, Liming <liming.gao@intel.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] [PATCH v1 0/7] FmpDevicePkg Minor Fixes
>
> I saw one R-b for the series from Wei6 Xu.
>
> Could the remaining reviewers please help with review?
>
> I have a larger series that is based on it that I'd like to send once this series is
> merged.
>
> Thanks,
> Michael
>
> On 7/30/2020 8:14 PM, Michael Kubacki wrote:
> > From: Michael Kubacki <michael.kubacki@microsoft.com>
> >
> > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2869
> >
> > This patch series makes minor fixes and enhancements in FmpDevicePkg.
> > None of the issues impact functionality in a major way.
> >
> > These are smaller sets of changes that are being submitted prior to a
> > larger future patch series that will cover functional changes for
> > BZ2802.
> >
> > Please check the git notes in patch 3 and patch 5.
> >
> > Cc: Liming Gao <liming.gao@intel.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> >
> > Michael Kubacki (7):
> > FmpDevicePkg/FmpDependencyLib: Correct ValidateDependency()
> > documentation
> > FmpDevicePkg/FmpDependencyLib: Fix "exression" typo
> > FmpDevicePkg/FmpDependencyLib: Handle version string overflow
> > FmpDevicePkg/FmpDependencyCheckLib: Return unsatisfied on handle
> > failure
> > FmpDevicePkg/FmpDxe: Better warn of potential ImageTypeId misconfig
> > FmpDevicePkg/FmpDxe: Indicate ESRT GUID on invalid ImageIdName
> > FmpDevicePkg/FmpDxe: Improve function parameter validation
> >
> > FmpDevicePkg/FmpDxe/FmpDxe.c | 62
> ++++++++++++++++----
> >
> FmpDevicePkg/Library/FmpDependencyCheckLib/FmpDependencyCheckLib
> .c | 2 +
> > FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c |
> 8 ++-
> > FmpDevicePkg/FmpDxe/FmpDxe.h | 10 ++--
> > FmpDevicePkg/Include/Library/FmpDependencyLib.h | 5 +-
> > 5 files changed, 67 insertions(+), 20 deletions(-)
> >
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-05 4:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1626B7E87C6880F1.8866@groups.io>
2020-08-04 19:11 ` [edk2-devel] [PATCH v1 0/7] FmpDevicePkg Minor Fixes Michael Kubacki
2020-08-05 4:42 ` Guomin Jiang
2020-07-31 3:14 Michael Kubacki
2020-07-31 6:56 ` [edk2-devel] " Xu, Wei6
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox