Re: [edk2-devel] [PATCH v2] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer

Re: [edk2-devel] [PATCH v2] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer

[Guomin Jiang]

Hi Michael, Sean, Bret,

Please help review the change.

Best Regards
guomin

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Guomin
> Jiang
> Sent: Tuesday, April 14, 2020 9:33 AM
> To: devel@edk2.groups.io
> Cc: kuqin <kuqin@microsoft.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Sean Brogan <sean.brogan@microsoft.com>;
> Bret Barkelew <Bret.Barkelew@microsoft.com>
> Subject: [edk2-devel] [PATCH v2] UnitTestFrameworkPkg/UnitTestLib:
> Correct dereferred pointer
> 
> From: kuqin <kuqin@microsoft.com>
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2609
> 
> SavedState is not sticky, copied pointer update will not change source
> pointer
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Signed-off-by: Guomin Jiang <guomin.jiang@intel.com>
> ---
>  UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c
> b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c
> index b136992d99..ba4b18568d 100644
> --- a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c
> +++ b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c
> @@ -209,7 +209,6 @@ InitUnitTestFramework (
>    EFI_STATUS                  Status;   UNIT_TEST_FRAMEWORK_HANDLE
> NewFrameworkHandle;   UNIT_TEST_FRAMEWORK         *NewFramework;-
> UNIT_TEST_SAVE_HEADER       *SavedState;    Status       = EFI_SUCCESS;
> NewFramework = NULL;@@ -264,8 +263,7 @@ InitUnitTestFramework (
>    // If there is a persisted context, load it now.   //   if (DoesCacheExist
> (NewFrameworkHandle)) {-    SavedState = (UNIT_TEST_SAVE_HEADER
> *)NewFramework->SavedState;-    Status = LoadUnitTestCache
> (NewFrameworkHandle, &SavedState);+    Status = LoadUnitTestCache
> (NewFrameworkHandle,  (UNIT_TEST_SAVE_HEADER**)(&NewFramework-
> >SavedState));     if (EFI_ERROR (Status)) {       //       // Don't actually report it
> as an error, but emit a warning.--
> 2.25.1.windows.1
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> 
> View/Reply Online (#57288): https://edk2.groups.io/g/devel/message/57288
> Mute This Topic: https://groups.io/mt/73002073/4399222
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [guomin.jiang@intel.com] -=-=-=-=-=-=

Re: [edk2-devel] [PATCH v2] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer

[Bret Barkelew]

[-- Attachment #1: Type: text/plain, Size: 4348 bytes --]

Reviewed-by: Bret Barkelew <bret.barkelew@microsoft.com>

- Bret

________________________________
From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Guomin Jiang via groups.io <guomin.jiang=intel.com@groups.io>
Sent: Sunday, April 19, 2020 9:30:57 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>; Jiang, Guomin <guomin.jiang@intel.com>
Cc: Kun Qin <Kun.Qin@microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>
Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v2] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer

Hi Michael, Sean, Bret,

Please help review the change.

Best Regards
guomin

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Guomin
> Jiang
> Sent: Tuesday, April 14, 2020 9:33 AM
> To: devel@edk2.groups.io
> Cc: kuqin <kuqin@microsoft.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Sean Brogan <sean.brogan@microsoft.com>;
> Bret Barkelew <Bret.Barkelew@microsoft.com>
> Subject: [edk2-devel] [PATCH v2] UnitTestFrameworkPkg/UnitTestLib:
> Correct dereferred pointer
>
> From: kuqin <kuqin@microsoft.com>
>
> REF: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2609&amp;data=02%7C01%7CBret.Barkelew%40microsoft.com%7C42a07ae2da8047642dbe08d7e4e3a195%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637229538634306948&amp;sdata=LnkRj186gkkT52eyVRrC6WeabUpQK4fqGfJ8zRGJpH8%3D&amp;reserved=0
>
> SavedState is not sticky, copied pointer update will not change source
> pointer
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Signed-off-by: Guomin Jiang <guomin.jiang@intel.com>
> ---
>  UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c
> b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c
> index b136992d99..ba4b18568d 100644
> --- a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c
> +++ b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c
> @@ -209,7 +209,6 @@ InitUnitTestFramework (
>    EFI_STATUS                  Status;   UNIT_TEST_FRAMEWORK_HANDLE
> NewFrameworkHandle;   UNIT_TEST_FRAMEWORK         *NewFramework;-
> UNIT_TEST_SAVE_HEADER       *SavedState;    Status       = EFI_SUCCESS;
> NewFramework = NULL;@@ -264,8 +263,7 @@ InitUnitTestFramework (
>    // If there is a persisted context, load it now.   //   if (DoesCacheExist
> (NewFrameworkHandle)) {-    SavedState = (UNIT_TEST_SAVE_HEADER
> *)NewFramework->SavedState;-    Status = LoadUnitTestCache
> (NewFrameworkHandle, &SavedState);+    Status = LoadUnitTestCache
> (NewFrameworkHandle,  (UNIT_TEST_SAVE_HEADER**)(&NewFramework-
> >SavedState));     if (EFI_ERROR (Status)) {       //       // Don't actually report it
> as an error, but emit a warning.--
> 2.25.1.windows.1
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
>
> View/Reply Online (#57288): https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F57288&amp;data=02%7C01%7CBret.Barkelew%40microsoft.com%7C42a07ae2da8047642dbe08d7e4e3a195%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637229538634316946&amp;sdata=PEomgQB9WlQXGut1oqdWdNt%2BbBNTAGv3HHRcv8eo8QM%3D&amp;reserved=0
> Mute This Topic: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.io%2Fmt%2F73002073%2F4399222&amp;data=02%7C01%7CBret.Barkelew%40microsoft.com%7C42a07ae2da8047642dbe08d7e4e3a195%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637229538634316946&amp;sdata=vtcVI4gP7UjLhQMuAc1JO%2B3yRrWAysPB7tuqsZLmj6s%3D&amp;reserved=0
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Funsub&amp;data=02%7C01%7CBret.Barkelew%40microsoft.com%7C42a07ae2da8047642dbe08d7e4e3a195%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637229538634316946&amp;sdata=snyZZwLcC1sDGE6ov2uGT8MPM%2FHsBi0yKP0z5FpFMIU%3D&amp;reserved=0
> [guomin.jiang@intel.com] -=-=-=-=-=-=





[-- Attachment #2: Type: text/html, Size: 8440 bytes --]