From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.173.1587357059787113099 for ; Sun, 19 Apr 2020 21:31:00 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=CZCeM3vp; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: guomin.jiang@intel.com) IronPort-SDR: 3AiSyUhEPrF97iDIZUaBdL6o0g2BDCeHTSTxm7/z4TJEM3Uofl0OGtsZ+N1xN/N3WnTb/AgRte H6BTkDco4Ffg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2020 21:30:59 -0700 IronPort-SDR: 1gK41H+lhd0kukdayx3vK+XKrEtI2ay+ahpdyE+RJNHptMTgDb6d4r7vHOuzXN591GWsi9Vtdx oYmSs1XKLulw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,405,1580803200"; d="scan'208";a="289961808" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by fmsmga002.fm.intel.com with ESMTP; 19 Apr 2020 21:30:59 -0700 Received: from orsmsx160.amr.corp.intel.com (10.22.226.43) by ORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 19 Apr 2020 21:30:59 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX160.amr.corp.intel.com (10.22.226.43) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 19 Apr 2020 21:30:58 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.105) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 19 Apr 2020 21:30:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CQZN5Svjl1cfW99/O9c/SqUeLnL24XeTT3+x5BBjYr4BV/tjeYbZi78IGRZjTDd9ho+raMQl547BIYg1qi3mOHBJSxN43GAiEsc4Yr0rzvsrjw5rc4CqVJ6l8nKIMMNLc7NzIq/C/AIGlrLEU//MDwTXWYtf4DtiJicEhr1mbDH0agq5rTf0ex0IoWTYssV9eYkfxnJpz0bgwLfzrCS1HPi6ueXlU+hjCmS41Zuly2rjdi1+yh1usOQ2E0v8QH42T5cpFMFSJNM5I+xb3opYEiNF9Y7cgoOZqIp2kNQMG0FEPO3XxpeQfYrMfWadcntt0NzCtVOC7Hzce0rqUMDBvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=47ZOUtpzDDYdQEjeo8VVY/zHTVhqjjgVFP3ZDBxgwfU=; b=NlROQIHK37RLRSyBcsFF9f3GfkGlvSE787Qt0AGcfi3+neUouLmcEMbnTqjO2BQnYAszzuty6r1mzZSUdoNR3lgo5AMzW63QWod5RDb3BjeDn1HuC2Eg99CO7aJDhLMPiD50tEWSVY1jJa/1R3q7WsVUzglLKsHNM4VZkEyntV3kdfCFJ7h5lZM9rkt8biR0KbnMgcpe/kq2kQZ1Tz0AZCmjm5RsGomngGStP0LsGrqU2uNk2FuRnvjF34gln6d6+Tj5rhFcM5FaTrbuiWrLv6t3pMkLuj+HSO9NsyjsdsanN4gIwr1s4uEezyplJA1CAsu2DV0miKi0QMebKTzzSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=47ZOUtpzDDYdQEjeo8VVY/zHTVhqjjgVFP3ZDBxgwfU=; b=CZCeM3vp7pG3qzkZJiSQuDAY16irMYWDM8FOjSWiX1V0gEi/sgXC3z4UdKc2IQ/fFAdtBftHzBpwzgKxQo3dBAGpgEoKST6CI789njluZoI8u1wyULhsilOrUr9K4jncCgx0BHTBvYJt7Iv36kyHWvTdajSeAqZPji4pHBiFRcc= Received: from DM6PR11MB2955.namprd11.prod.outlook.com (2603:10b6:5:65::31) by DM6PR11MB4577.namprd11.prod.outlook.com (2603:10b6:5:2a1::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25; Mon, 20 Apr 2020 04:30:57 +0000 Received: from DM6PR11MB2955.namprd11.prod.outlook.com ([fe80::ccd4:4b0d:535a:58be]) by DM6PR11MB2955.namprd11.prod.outlook.com ([fe80::ccd4:4b0d:535a:58be%7]) with mapi id 15.20.2921.027; Mon, 20 Apr 2020 04:30:57 +0000 From: "Guomin Jiang" To: "devel@edk2.groups.io" , "Jiang, Guomin" CC: kuqin , "Kinney, Michael D" , Sean Brogan , "Bret Barkelew" Subject: Re: [edk2-devel] [PATCH v2] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer Thread-Topic: [edk2-devel] [PATCH v2] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer Thread-Index: AQHWEfy2yrpfv/rnz0GO+lwBs4cFxaiBc19Q Date: Mon, 20 Apr 2020 04:30:57 +0000 Message-ID: References: <16058BA3AE571281.11156@groups.io> In-Reply-To: <16058BA3AE571281.11156@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: spf=none (sender IP is ) smtp.mailfrom=guomin.jiang@intel.com; x-originating-ip: [192.55.52.205] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7a73612b-2848-425a-0318-08d7e4e39f51 x-ms-traffictypediagnostic: DM6PR11MB4577: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1169; x-forefront-prvs: 03793408BA x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB2955.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10019020)(396003)(366004)(136003)(346002)(376002)(39860400002)(2906002)(53546011)(6506007)(8936002)(54906003)(4326008)(110136005)(316002)(26005)(66476007)(66446008)(66946007)(64756008)(66556008)(71200400001)(8676002)(81156014)(76116006)(55016002)(9686003)(7696005)(5660300002)(86362001)(33656002)(52536014)(478600001)(966005)(186003);DIR:OUT;SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: L0BkkVmKERg9ZchDGfKd8drPMazuEln/0ESYEQE4xcChG/mFrdLdrlbYMpI/d7Rgo0xqEdCGcLsoIiy9ac1S3EMXZujIU4hGmUTvY9ZRGjIseAbupd8GJOEnAtaPwKIwp61Iku38q83fov0TVhNlVd+kvEjyUBxdfGWnlHR1YIJHy+sRV3MGhApElgT93hz+odXGwv+zJXiRvL94vGZIUHhe9ykmFn3jKBEIPDAjWauxFO0jDP545drR3TVvFPnUiC2OSFDM+4nNjmzVrxURLAIK+bdDy+iX4dRUb+XX6oCbhPB9QP7O9TcuspuZnx1EfiR/zeo9tYivrWL2bxxc6VHmfw0Bjb5jslfk3dfg1JvTPnO9z6IgSUSTzitrCEj2TozOAXG6t+DK7QoKzEv5cAFho007rqCJh2DpqhwdSzrp4giXGTU4lLx5bWaI9UP6tt1OojkmxezLoTFdp7o1886MbgCIlfT08DXuXJgSTR1LR9ohiJSP5vcWNHVItDCfMMfo13sPb9VIaLT1Kv+o2w== x-ms-exchange-antispam-messagedata: QxLAh3yNRKDunQFwj+1p5WYQUOTsdZfPMQePBHz+CRw3h/0QLFhIVECs9C7/NrPGu26qGsypey6PbgUc8weZDxRelSe+o3WhEQEjEj7mKBnmA/g57qiUK5Jk1AR7xqVaHzHMtWC7FfpDMYXroYKgBA== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 7a73612b-2848-425a-0318-08d7e4e39f51 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2020 04:30:57.6361 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TN/MnkFg3PqSzxZt8S9O97e/6buBTo7zH/Q2x2BVtd35BVn5S7qUOBx5wSXH27x0KjAcaIAOF1+IwZcNhz3oew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4577 Return-Path: guomin.jiang@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Michael, Sean, Bret, Please help review the change. Best Regards guomin > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Guomin > Jiang > Sent: Tuesday, April 14, 2020 9:33 AM > To: devel@edk2.groups.io > Cc: kuqin ; Kinney, Michael D > ; Sean Brogan ; > Bret Barkelew > Subject: [edk2-devel] [PATCH v2] UnitTestFrameworkPkg/UnitTestLib: > Correct dereferred pointer >=20 > From: kuqin >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2609 >=20 > SavedState is not sticky, copied pointer update will not change source > pointer >=20 > Cc: Michael D Kinney > Cc: Sean Brogan > Cc: Bret Barkelew > Signed-off-by: Guomin Jiang > --- > UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c > b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c > index b136992d99..ba4b18568d 100644 > --- a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c > +++ b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c > @@ -209,7 +209,6 @@ InitUnitTestFramework ( > EFI_STATUS Status; UNIT_TEST_FRAMEWORK_HANDLE > NewFrameworkHandle; UNIT_TEST_FRAMEWORK *NewFramework;- > UNIT_TEST_SAVE_HEADER *SavedState; Status =3D EFI_SUCCESS; > NewFramework =3D NULL;@@ -264,8 +263,7 @@ InitUnitTestFramework ( > // If there is a persisted context, load it now. // if (DoesCacheE= xist > (NewFrameworkHandle)) {- SavedState =3D (UNIT_TEST_SAVE_HEADER > *)NewFramework->SavedState;- Status =3D LoadUnitTestCache > (NewFrameworkHandle, &SavedState);+ Status =3D LoadUnitTestCache > (NewFrameworkHandle, (UNIT_TEST_SAVE_HEADER**)(&NewFramework- > >SavedState)); if (EFI_ERROR (Status)) { // // Don't actu= ally report it > as an error, but emit a warning.-- > 2.25.1.windows.1 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. >=20 > View/Reply Online (#57288): https://edk2.groups.io/g/devel/message/57288 > Mute This Topic: https://groups.io/mt/73002073/4399222 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [guomin.jiang@intel.com] -=3D-=3D-=3D-=3D-=3D-=3D