From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.1646.1586483257191262840 for ; Thu, 09 Apr 2020 18:47:37 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=e05NjWjB; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: guomin.jiang@intel.com) IronPort-SDR: 8UDOHuUjlvUR9z3VVHSvhwmBuwqUAqi/QmaP7bHtm3GLnNw05DP2JEhFxZ80a/obfklsPPV2nQ X/0jValTHOgA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2020 18:47:35 -0700 IronPort-SDR: QP0N+RqVNsgG8E3KTd+itNJpPEz7y0oV65wrl5fesC7gjYkhrEBOkhG6cflvJaqTRvM4v2hRqj +yjOB6yxi5QA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,364,1580803200"; d="scan'208";a="398786699" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga004.jf.intel.com with ESMTP; 09 Apr 2020 18:47:35 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Apr 2020 18:47:35 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Apr 2020 18:47:34 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.171) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Apr 2020 18:47:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DoYtWm3lLOpu88laIVcMzLBvedTdYVik0ECBs284FOQzcrWK8ltjzrwK1qnC4/gxvlX2JXlYJELltCUGY0Ux0pGZbcf1chTZgwmaakx6Wd2Euqi174GJNbGzREiyhvYko4ev4KW5XhQhUleMCMpXpZLljJG01TIDLfMemOMDDzJlve/tVWXbQru6G88OYbBdySzSlqVVp3ngOKCBvVnpk+qG62hJCnFMEnJxnDbNwDly/oZFGdngI3/wT13sgrs6RrC2xm5J8KVj9opzCWHBLgMlvA2FDwLWgL4wRIiNQAJ9CIgYRbqrtQSJg3qYwBJRnqBjQNdWRsgOWN4gFxm6SQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3R4aaFBHHzvCWoxQ4jgohyn54JKubaiqaSoyNwo4Nqo=; b=mbCC3gzZMXGcS8En6+pj9VsfJE0QBiWxc0Ff03/j5Re2MvM8kXPy60WdUyCr9Wk+AQ9Vx/31EIh6b38N7MJ/GgizOcFDCttXwubIdam+uJFpM1dwZTTCdN3k/Vj/8dtqp4w+vgfTm1RzCxCqXzJzZtVK5uLaeRmurGhTGyURrRTJenBlDWy5deMnS6V26JAU4xp2sa02id8fN69k/nCtksT5aRFDForo7kELrxHJZON89w/B9ii2VBhpdmt1Go+91uZDi8SQjMRLQA10R3Nbb7/DuJab17BsBJfMJx0GmgWAO2WBSFZ0YD/EP/J1jOHDnIo1vj1f15zY5DkcjEf5xw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3R4aaFBHHzvCWoxQ4jgohyn54JKubaiqaSoyNwo4Nqo=; b=e05NjWjBGi4YBJSwXDd5MgHLojIFKSltSi7jp7NnhqYcf7kIomXbarqGliGD3eScmEvuMF8bnO0mgOAvX0dB/csr6Qi9WeQUpiMq2MuASgetRe63sGIDN83Xo+bsMrXHwEUCcWuN5kTivJIGy/HmM3MHKKtd2xwTYxYsgOehB8k= Received: from DM6PR11MB2955.namprd11.prod.outlook.com (2603:10b6:5:65::31) by DM6PR11MB3675.namprd11.prod.outlook.com (2603:10b6:5:13e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.20; Fri, 10 Apr 2020 01:47:32 +0000 Received: from DM6PR11MB2955.namprd11.prod.outlook.com ([fe80::f1ec:734d:b127:4519]) by DM6PR11MB2955.namprd11.prod.outlook.com ([fe80::f1ec:734d:b127:4519%3]) with mapi id 15.20.2878.022; Fri, 10 Apr 2020 01:47:32 +0000 From: "Guomin Jiang" To: "devel@edk2.groups.io" , "michael.kubacki@outlook.com" CC: "Bi, Dandan" , "Wu, Hao A" , "Wang, Jian J" , "Gao, Liming" , "Ni, Ray" , Sean Brogan Subject: Re: [edk2-devel] [PATCH v1 4/7] MdeModulePkg/XhciDxe: Use BaseLib linked list iteration macros Thread-Topic: [edk2-devel] [PATCH v1 4/7] MdeModulePkg/XhciDxe: Use BaseLib linked list iteration macros Thread-Index: AQHWDqpwbd9I+pSvWkScHp4dwcGthahxlpSw Date: Fri, 10 Apr 2020 01:47:32 +0000 Message-ID: References: <20200409200514.32796-1-michael.kubacki@outlook.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: spf=none (sender IP is ) smtp.mailfrom=guomin.jiang@intel.com; x-originating-ip: [192.55.52.200] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 77d3d6fb-1177-49ef-c1e2-08d7dcf122f7 x-ms-traffictypediagnostic: DM6PR11MB3675: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1227; x-forefront-prvs: 0369E8196C x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB2955.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10019020)(366004)(396003)(39860400002)(376002)(136003)(346002)(4326008)(33656002)(76116006)(66446008)(66556008)(81166007)(52536014)(5660300002)(66476007)(9686003)(66946007)(64756008)(54906003)(26005)(53546011)(45080400002)(6506007)(478600001)(81156014)(186003)(2906002)(316002)(8936002)(966005)(7696005)(86362001)(110136005)(55016002)(71200400001)(8676002);DIR:OUT;SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MhGL613TRZZB4Jo2hU+68BGLLTTIszh1qKldOQl4pcfQwxNrwjIwMcaRPeuXZ9LouaXAhVTww/QTvZvY+7uHxQoflGk0vInoIHTzCEYZjxFG1Sx7SBX8S7x5Xw0RQqHLGDErB8oiAnyjb+QCMv2ujXuFuYwrykvkNVxPgiX2MKmNdQdoh7OA1EWV9C5b2zkK1YB/5UXfjtyPt+zjlCLAnVyMp86n0ktrcVXz4z1LIO7VHgz7v+j2F5haXgMs0nTJMBcmkv8s33q205SupuD4WG26PfUbKZz6Vk6gabFMCmw+EzU1xiEnipnJIsSKVcy+RDT32o9rmvZrG23yzcu1uwlwYfG6AHlgmur8rx67LxqvWNRwd8m/2FSoBJVnZT++fo2Z3RLQdQmkA7DmU+yywOIaJJ5K2cn13dqWsGuAQpAvFo0eAzgLF5YmhBQtqUzqsEzKFIwQGQRwCGmFvwkGiKur58Whq1v+a/jI9W4bEkaO/l5zFJuOYpeEPk5hUBcSxBKgVwbZ9/j1NS9Qzx5tIA== x-ms-exchange-antispam-messagedata: CSe5Wsg+tP9fahmwvTMuvw51jqgMhOObcIVHhneRj4CMmycs/H1G5vKMt27qHU/t0Xo6bC+oRa30ZG+MzaRksIeG0RugNKQU9xLER9HU5CwKwvwQJiap3deiUam1LOoZusudtXbLEqoWodKAtQRJXQ== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 77d3d6fb-1177-49ef-c1e2-08d7dcf122f7 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Apr 2020 01:47:32.6576 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xvkMU8QNI51TfyATRAP4P2e/W1NIALu8Upx+iEwlvewv18ruj1niDd+f+bW5Mc14szzeL69QG0N1x4cG1/lifg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3675 Return-Path: guomin.jiang@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Guomin Jiang > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Friday, April 10, 2020 4:05 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Wu, Hao A ; > Wang, Jian J ; Gao, Liming = ; > Ni, Ray ; Sean Brogan > Subject: [edk2-devel] [PATCH v1 4/7] MdeModulePkg/XhciDxe: Use BaseLib > linked list iteration macros >=20 > From: Michael Kubacki >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D1959 >=20 > Replaces usage of the linked list iteration macros defined in Xhci.h wit= h the > common definition in BaseLib.h. >=20 > Cc: Dandan Bi > Cc: Hao A Wu > Cc: Jian J Wang > Cc: Liming Gao > Cc: Ray Ni > Cc: Sean Brogan > Signed-off-by: Michael Kubacki > --- > MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 9 +++++---- > MdeModulePkg/Bus/Pci/XhciDxe/Xhci.h | 9 +-------- > 2 files changed, 6 insertions(+), 12 deletions(-) >=20 > diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > index c0c374fc4758..ab8957c546ee 100644 > --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > @@ -3,6 +3,7 @@ > XHCI transfer scheduling routines. >=20 > Copyright (c) 2011 - 2018, Intel Corporation. All rights reserved.
> +Copyright (c) Microsoft Corporation.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -1051,7 +1052,7 @@ IsAsyncIntTrb ( > LIST_ENTRY *Next; > URB *CheckedUrb; >=20 > - EFI_LIST_FOR_EACH_SAFE (Entry, Next, &Xhc->AsyncIntTransfers) { > + BASE_LIST_FOR_EACH_SAFE (Entry, Next, &Xhc->AsyncIntTransfers) { > CheckedUrb =3D EFI_LIST_CONTAINER (Entry, URB, UrbList); > if (IsTransferRingTrb (Xhc, Trb, CheckedUrb)) { > *Urb =3D CheckedUrb; > @@ -1346,7 +1347,7 @@ XhciDelAsyncIntTransfer ( >=20 > Urb =3D NULL; >=20 > - EFI_LIST_FOR_EACH_SAFE (Entry, Next, &Xhc->AsyncIntTransfers) { > + BASE_LIST_FOR_EACH_SAFE (Entry, Next, &Xhc->AsyncIntTransfers) { > Urb =3D EFI_LIST_CONTAINER (Entry, URB, UrbList); > if ((Urb->Ep.BusAddr =3D=3D BusAddr) && > (Urb->Ep.EpAddr =3D=3D EpNum) && > @@ -1386,7 +1387,7 @@ XhciDelAllAsyncIntTransfers ( > URB *Urb; > EFI_STATUS Status; >=20 > - EFI_LIST_FOR_EACH_SAFE (Entry, Next, &Xhc->AsyncIntTransfers) { > + BASE_LIST_FOR_EACH_SAFE (Entry, Next, &Xhc->AsyncIntTransfers) { > Urb =3D EFI_LIST_CONTAINER (Entry, URB, UrbList); >=20 > // > @@ -1578,7 +1579,7 @@ XhcMonitorAsyncRequests ( >=20 > Xhc =3D (USB_XHCI_INSTANCE*) Context; >=20 > - EFI_LIST_FOR_EACH_SAFE (Entry, Next, &Xhc->AsyncIntTransfers) { > + BASE_LIST_FOR_EACH_SAFE (Entry, Next, &Xhc->AsyncIntTransfers) { > Urb =3D EFI_LIST_CONTAINER (Entry, URB, UrbList); >=20 > // > diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.h > b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.h > index 72b4e084f14d..3285eb8798c0 100644 > --- a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.h > +++ b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.h > @@ -3,6 +3,7 @@ > Provides some data structure definitions used by the XHCI host contro= ller > driver. >=20 > Copyright (c) 2011 - 2017, Intel Corporation. All rights reserved.
> +Copyright (c) Microsoft Corporation.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -82,14 +83,6 @@ typedef struct _USB_DEV_CONTEXT > USB_DEV_CONTEXT; > #define INT_INTER 3 > #define INT_INTER_ASYNC 4 >=20 > -// > -// Iterate through the double linked list. This is delete-safe. > -// Don't touch NextEntry > -// > -#define EFI_LIST_FOR_EACH_SAFE(Entry, NextEntry, ListHead) \ > - for (Entry =3D (ListHead)->ForwardLink, NextEntry =3D Entry->ForwardL= ink;\ > - Entry !=3D (ListHead); Entry =3D NextEntry, NextEntry =3D Entry->= ForwardLink) > - > #define EFI_LIST_CONTAINER(Entry, Type, Field) BASE_CR(Entry, Type, Fie= ld) >=20 > #define XHC_LOW_32BIT(Addr64) ((UINT32)(((UINTN)(Addr64)) & > 0xFFFFFFFF)) > -- > 2.16.3.windows.1 >=20 >=20 >=20