public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Guomin Jiang" <guomin.jiang@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"abner.chang@hpe.com" <abner.chang@hpe.com>
Cc: Gilbert Chen <gilbert.chen@hpe.com>,
	Leif Lindholm <leif.lindholm@linaro.org>,
	"Wu, Hao A" <hao.a.wu@intel.com>,
	"Gao, Liming" <liming.gao@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 2/3] MdeModulePkg/CapsuleRuntimeDxe: Add RISCV64 arch.
Date: Mon, 25 May 2020 01:49:27 +0000	[thread overview]
Message-ID: <DM6PR11MB2955DDADAC369C0C30DB11739DB30@DM6PR11MB2955.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200426144024.7265-3-abner.chang@hpe.com>

The patch is good to me.
Reviewed-by: Guomin Jiang <guomin.jiang@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Abner
> Chang
> Sent: Sunday, April 26, 2020 10:40 PM
> To: devel@edk2.groups.io
> Cc: abner.chang@hpe.com; Gilbert Chen <gilbert.chen@hpe.com>; Leif
> Lindholm <leif.lindholm@linaro.org>; Wu, Hao A <hao.a.wu@intel.com>;
> Gao, Liming <liming.gao@intel.com>
> Subject: [edk2-devel] [PATCH v2 2/3] MdeModulePkg/CapsuleRuntimeDxe:
> Add RISCV64 arch.
> 
> Add RISC-V in INF for building CapsuleRuntimeDxe RISCV64 image.
> 
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> Co-authored-by: Gilbert Chen <gilbert.chen@hpe.com>
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> Acked-by: Hao A Wu <hao.a.wu@intel.com>
> 
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Gilbert Chen <gilbert.chen@hpe.com>
> ---
>  .../Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf    | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git
> a/MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf
> b/MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf
> index 942eda235c..8bf5035a69 100644
> ---
> a/MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf
> +++
> b/MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf
> @@ -5,6 +5,7 @@
>  #  the capsule runtime services are ready.
> 
>  #
> 
>  #  Copyright (c) 2006 - 2020, Intel Corporation. All rights reserved.<BR>
> 
> +#  Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All rights
> reserved.<BR>
> 
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>  #
> 
>  ##
> 
> @@ -21,20 +22,20 @@
>  #
> 
>  # The following information is for reference only and not required by the
> build tools.
> 
>  #
> 
> -#  VALID_ARCHITECTURES           = IA32 X64 EBC ARM AARCH64
> 
> +#  VALID_ARCHITECTURES           = IA32 X64 EBC ARM AARCH64 RISCV64
> 
>  #
> 
> 
> 
>  [Sources]
> 
>    CapsuleService.c
> 
>    CapsuleService.h
> 
> 
> 
> -[Sources.Ia32, Sources.EBC, Sources.ARM, Sources.AARCH64]
> 
> +[Sources.Ia32, Sources.EBC, Sources.ARM, Sources.AARCH64,
> Sources.RISCV64]
> 
>    SaveLongModeContext.c
> 
> 
> 
> -[Sources.Ia32, Sources.X64, Sources.ARM, Sources.AARCH64]
> 
> +[Sources.Ia32, Sources.X64, Sources.ARM, Sources.AARCH64,
> Sources.RISCV64]
> 
>    CapsuleCache.c
> 
> 
> 
> -[Sources.Ia32, Sources.X64, Sources.EBC]
> 
> +[Sources.Ia32, Sources.X64, Sources.EBC, Sources.RISCV64]
> 
>    CapsuleReset.c
> 
> 
> 
>  [Sources.ARM, Sources.AARCH64]
> 
> --
> 2.25.0
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> 
> View/Reply Online (#58149): https://edk2.groups.io/g/devel/message/58149
> Mute This Topic: https://groups.io/mt/73284218/4399222
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [guomin.jiang@intel.com]
> -=-=-=-=-=-=


  reply	other threads:[~2020-05-25  1:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-26 14:40 [PATCH v2 0/3] MdeModulePkg changes for RISC-V edk2 port Abner Chang
2020-04-26 14:40 ` [PATCH v2 1/3] MdeModulePkg/Logo Abner Chang
2020-04-26 14:40 ` [PATCH v2 2/3] MdeModulePkg/CapsuleRuntimeDxe: Add RISCV64 arch Abner Chang
2020-05-25  1:49   ` Guomin Jiang [this message]
2020-04-26 14:40 ` [PATCH v2 3/3] MdeModulePkg/DxeIplPeim : RISC-V platform level DxeIPL Abner Chang
2020-04-29 11:45   ` [edk2-devel] " Dandan Bi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB2955DDADAC369C0C30DB11739DB30@DM6PR11MB2955.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox