From: "Guomin Jiang" <guomin.jiang@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>
Cc: "Sun, Zailiang" <zailiang.sun@intel.com>, "Qian, Yi" <yi.qian@intel.com>
Subject: Re: [edk2-devel] [edk2-platforms] [PATCH 2/5] Vlv2TbltDevicePkg: Fix spelling errors
Date: Wed, 20 May 2020 00:23:08 +0000 [thread overview]
Message-ID: <DM6PR11MB2955E028763B6A6D5B3E1E469DB60@DM6PR11MB2955.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200519061802.5837-3-nathaniel.l.desimone@intel.com>
Add comment inline
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Nate
> DeSimone
> Sent: Tuesday, May 19, 2020 2:18 PM
> To: devel@edk2.groups.io
> Cc: Sun, Zailiang <zailiang.sun@intel.com>; Qian, Yi <yi.qian@intel.com>
> Subject: [edk2-devel] [edk2-platforms] [PATCH 2/5] Vlv2TbltDevicePkg: Fix
> spelling errors
>
> "implemenations" should be "implementations"
>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Cc: Yi Qian <yi.qian@intel.com>
> ---
> .../Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git
> a/Platform/Intel/Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.c
> b/Platform/Intel/Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.c
> index 8283483ff8..5607997f4e 100644
> ---
> a/Platform/Intel/Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.c
> +++
> b/Platform/Intel/Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.c
> @@ -1,14 +1,11 @@
> /** @file
>
> - Copyright (c) 2004 - 2014, Intel Corporation. All rights reserved.<BR>
> -
>
> - SPDX-License-Identifier: BSD-2-Clause-Patent
> + Copyright (c) 2004 - 2020, Intel Corporation. All rights
> + reserved.<BR>
>
> -
>
> + SPDX-License-Identifier: BSD-2-Clause-Patent
>
> Module Name:
>
> -
> MonoStatusCode.c
I think that there are too many empty line between the Module Name: with MonoStatusCode.c
I suggest use format as below:
Module Name: MonoStatusCode.c
Or
Module Name:
MonoStatusCode.c
Others change is good to me.
Reviewed-by: Guomin Jiang <guomin.jiang@intel.com>
>
> Abstract:
> @@ -35,7 +32,7 @@ EFI_PEI_PPI_DESCRIPTOR mPpiListStatusCode = { };
>
> //
> -// Function implemenations
> +// Function implementations
> //
>
> /**
> --
> 2.26.0.windows.1
>
>
>
next prev parent reply other threads:[~2020-05-20 0:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 6:17 [edk2-platforms] [PATCH 0/5] Intel: Fix spelling errors Nate DeSimone
2020-05-19 6:17 ` [edk2-platforms] [PATCH 1/5] MinPlatformPkg: " Nate DeSimone
2020-05-19 7:57 ` Chiu, Chasel
2020-05-19 8:02 ` Dong, Eric
2020-05-19 6:17 ` [edk2-platforms] [PATCH 2/5] Vlv2TbltDevicePkg: " Nate DeSimone
2020-05-19 7:57 ` [edk2-devel] " Chiu, Chasel
2020-05-19 17:08 ` Michael D Kinney
2020-05-20 0:23 ` Guomin Jiang [this message]
2020-05-19 6:18 ` [edk2-platforms] [PATCH 3/5] CoffeeLakeSiliconPkg: " Nate DeSimone
2020-05-19 6:45 ` Chaganty, Rangasai V
2020-05-19 7:57 ` Chiu, Chasel
2020-05-19 6:18 ` [edk2-platforms] [PATCH 4/5] IntelSiliconPkg: " Nate DeSimone
2020-05-19 6:50 ` Chaganty, Rangasai V
2020-05-19 7:57 ` [edk2-devel] " Chiu, Chasel
2020-05-19 6:18 ` [edk2-platforms] [PATCH 5/5] KabylakeSiliconPkg: " Nate DeSimone
2020-05-19 6:53 ` Chaganty, Rangasai V
2020-05-19 7:58 ` Chiu, Chasel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB2955E028763B6A6D5B3E1E469DB60@DM6PR11MB2955.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox