Re: [edk2-devel] [PATCH v1 1/2] SecurityPkg: Add PCD for SW SMI Command port

["Guomin Jiang" <guomin.jiang@intel.com>]

Reviewed-by: Guomin Jiang <guomin.jiang@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael
> Kubacki
> Sent: Tuesday, April 7, 2020 2:34 AM
> To: devel@edk2.groups.io
> Cc: Kun Qin <Kun.Qin@microsoft.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Zhang,
> Chao B <chao.b.zhang@intel.com>
> Subject: [edk2-devel] [PATCH v1 1/2] SecurityPkg: Add PCD for SW SMI
> Command port
> 
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2416
> 
> Adds a PCD to SecurityPkg used to specify the SW SMI Command port. This
> value may vary across platforms and is current hardcoded to 0xB2 in package
> code.
> 
> Cc: Kun Qin <Kun.Qin@microsoft.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>  SecurityPkg/SecurityPkg.dec | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/SecurityPkg/SecurityPkg.dec b/SecurityPkg/SecurityPkg.dec index
> 2cdfb02cc5a2..87b1fbad8056 100644
> --- a/SecurityPkg/SecurityPkg.dec
> +++ b/SecurityPkg/SecurityPkg.dec
> @@ -7,7 +7,7 @@
>  #
>  # Copyright (c) 2009 - 2019, Intel Corporation. All rights reserved.<BR>  # (C)
> Copyright 2015 Hewlett Packard Enterprise Development LP <BR> -#
> Copyright (c) 2017, Microsoft Corporation.  All rights reserved. <BR>
> +# Copyright (c) Microsoft Corporation.<BR>
>  # SPDX-License-Identifier: BSD-2-Clause-Patent  #  ## @@ -272,6 +272,12
> @@
>    # @ValidList  0x80000003 | 0x010D0000
> 
> gEfiSecurityPkgTokenSpaceGuid.PcdStatusCodeSubClassTpmDevice|0x010D
> 0000|UINT32|0x00000007
> 
> +  ## Defines the IO port used to trigger a software System Management
> + Interrupt (SMI).<BR><BR>  #  Used as the SMI Command IO port by
> + security functionality that triggers a software SMI such  #  as
> + Physical Presence Interface (PPI).<BR>  # @Prompt SMI Command IO port.
> +
> +
> gEfiSecurityPkgTokenSpaceGuid.PcdSmiCommandIoPort|0xB2|UINT16|0x00
> 0000
> + 09
> +
>    ## Progress Code for FV verification result.<BR><BR>
>    #  (EFI_SOFTWARE_PEI_MODULE | EFI_SUBCLASS_SPECIFIC | XXX)
>    # @Prompt Status Code for FV verification result
> --
> 2.16.3.windows.1
> 
> 
>