From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web10.1680.1588728947612475978 for ; Tue, 05 May 2020 18:35:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=zEgOTaEr; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: guomin.jiang@intel.com) IronPort-SDR: A2RO4anK1TsjevhQi8iNAmF60pWrFD9kpishhJocztyWVMM048puW8bGtqikx7O2bdjTLdZRG7 RKp3ipS/3HyQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2020 18:35:46 -0700 IronPort-SDR: 1ccePl54Seuji6iDdGV9tMXbWQ3da49NevAFtGwmDKrrJBI0lMoULWovQFTmMmVyjs8lIZ3hiM LEu9OIFz5+lQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,357,1583222400"; d="scan'208,217";a="407063273" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga004.jf.intel.com with ESMTP; 05 May 2020 18:35:45 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 5 May 2020 18:35:45 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 5 May 2020 18:35:43 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.106) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 5 May 2020 18:35:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MIECXBBlGrEGMe9XH6SLIfJ45lKQ+lJ7jqOluGp6EfFuL++hx+rsjw4XoZe/y/n2WCsdNfd29UNd4lSoGbV+DHJi1Sdk70j0YzyWBPAqrcTUEDjLdOmbQoxmDUqeX7pWk8Hwi8T93dHeyuO4cM0fgdW7PQeu9D7YRSSkVLvpIKJ4nOEiRZtyp5IqlpUgJ+ouMqCN6BEmqNvQ7r5d4NTqWL6qyxdc3z1YSir8+wbTK+jo87EhGksFkoXl3G5aKa8EyOarfS/e589+mjKpZ1VrufDUmBWtrEx6YC+N6IbQST/22k0bqxM62JIhgK314OjpTmW+kETKJlYWpR4i0rESKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uw8CP/yczhKQsVRbmWzTLAkMoHouuTxGZpIaGXd8kms=; b=Hhx/jGq8+vasd0nFmLumXGaaB82Ie5OSC0/3MMwroNg0PkVfgiiEdErpDxH1epfEnB6zQT3tP3ypH7iZccUNUQ361gR6h3M064UMNBW3Ejnw2Y0NbaNXEQ/NgtpG+RDovv8oMnR6KJyn4XVOT3HzOU54KxWQ2La5fOwqNrVAxHg1vzjvIMUgi6tqTh6TaCR7GjDW8++edgT3ECUd8/YWdyV7wD1yp/WOSDOpfxf1kJiKBYPEK+/AneXkairgljCDwbBcYtXL5qO5ayPKBidM6/iAyf8GWotCOD34JO4xcZzW8T7GglwnF/0jwENGduXr48+J2toXcH97lshfonVn3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uw8CP/yczhKQsVRbmWzTLAkMoHouuTxGZpIaGXd8kms=; b=zEgOTaErb+nLxiuPNaY/VeAKLq1s5RKk/cqaGtaT8iuaDPA8V7780BqSX8sWtWd6OF5mFRguW/OrqwVdQyhqQ7tzy8wezoTDJUvhj1joVncE3MYWtx+kuHRIC3pGDx6t0icmE6fwkGzU7k5J9my+kgNE3WdDbEj9h/g3PQbSfm4= Received: from DM6PR11MB2955.namprd11.prod.outlook.com (2603:10b6:5:65::31) by DM6PR11MB2636.namprd11.prod.outlook.com (2603:10b6:5:c8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.29; Wed, 6 May 2020 01:35:41 +0000 Received: from DM6PR11MB2955.namprd11.prod.outlook.com ([fe80::ccd4:4b0d:535a:58be]) by DM6PR11MB2955.namprd11.prod.outlook.com ([fe80::ccd4:4b0d:535a:58be%7]) with mapi id 15.20.2958.029; Wed, 6 May 2020 01:35:41 +0000 From: "Guomin Jiang" To: "devel@edk2.groups.io" , "Jiang, Guomin" , Kun Qin , "Kinney, Michael D" , "Xu, Wei6" CC: "Gao, Liming" Subject: Re: [edk2-devel] [PATCH] FmpDevicePkg/FmpDxe: Fix uninitialized pointer dereference Thread-Topic: [edk2-devel] [PATCH] FmpDevicePkg/FmpDxe: Fix uninitialized pointer dereference Thread-Index: AQHV/Ow90WEWUrmAW06w7cZabl8GS6hN8BUAgAfYilD//4PyAIAAjjLwgES18KA= Date: Wed, 6 May 2020 01:35:41 +0000 Message-ID: References: <20200318061227.12480-1-wei6.xu@intel.com> , <15FEE0ADB157EE06.9780@groups.io> In-Reply-To: <15FEE0ADB157EE06.9780@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.205] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 312ce7f4-dbdd-4f4b-0de2-08d7f15dc9f7 x-ms-traffictypediagnostic: DM6PR11MB2636: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2733; x-forefront-prvs: 03950F25EC x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vWo0hQ+D/dMK67+b4FAOzc3heSSQ8j5xKAwEY6Y2ZlI/T55C4G4GXDJec5a/hzpx4bJU24hb/WwzdnwGHMQrWRLjqOpO8gUXFOXqQStcpS8qAN8YheXbbV0bQ+6J7kZb0LiGaInNd5Ld7E0X5aoKFdcNu3U89rlvvoBqOxkSQzK5f6CAMhLBNB75fPOZr1O6gxEOaX+JBDuZvgv01ODVMrsKucU0PFRHvKOhAWadSJNeiwuQdeTnh/ar3WXfObLVwilNbz1fE22Ehgi36MblGkELCQbb6uLVaqsFe95AYiwOdbqOEPMZ0mtico/0R65Ou4Ov17MIZCQG7yVdpPQTCTUIIw4aTqLUdW9EuSKvLJv+H6AlYGUQ4VMneytaqnRcFx1JSSxt1dy7S2jckYrZtHq+dLViieQh54vH1QqTq4xAu0yk/X/UsED9ij2ZG1uUP3hQMjd2UBCHPf+UsdSqWWSLXKSTBI7SCYIy+wjWjQlpwY+RtC3IY5fZ3yaB0lYFRf/Db+I5P/wkq5Soo0Ys8bply5bMLuOe+g/CHx5+DrByxRxhv7OssAl0uAjyPJ0Y83Dge5MBKV0cHzymKYatDOyXfWWwuPWTWLzHdOZzcFo= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB2955.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(396003)(366004)(39860400002)(136003)(346002)(376002)(33430700001)(4326008)(52536014)(186003)(26005)(5660300002)(86362001)(33440700001)(2906002)(6636002)(966005)(53546011)(8936002)(76116006)(478600001)(71200400001)(107886003)(6506007)(33656002)(66946007)(66446008)(55016002)(66476007)(66556008)(45080400002)(76236002)(110136005)(9686003)(166002)(64756008)(8676002)(316002)(7696005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: i6MFEzgv378EX1yEfNFEBzg2u8Dni9Gmodh6EzDMN3EgkovOlGf1DY50Zexh4wmtvciZLnvWd0E3A/tD/ctP7YIPn1XmqHHtU4vEVetDnYaGuA/0QESDOxo/F9+3V6K1ElMJzBRhSfUdDOGJeJ3SWr+IbWegHMcBIu+dOSbtXatB1caJJ5bXWt44OTqJKaZYLCdTdTVsBMGLdPzarwX9rUw2uW400a+y2/VuqXeQYEscQzbGYkbXhJmwUBXi1FxyitBHauPVB2Hc8wJdLrD03wHXCC+YTVFSg4GEuTob6YOu1rMLxh+fbP9m+0VTA50mDDvCXlhTueVYaAGqEtAFMzZknVCq6MBmxZJpCtbbv2mlPg7/04A4Iz433IEsZIs8PDUnAroWATtlXoiWBsEY0QEQzhJrPpEizcv0wbneXC1bj3scrlYvcsmJJExQ6n8RikphketTLrFEy0EQucDTucUUTt19NYXeFKSTf+XiypXtbiodId58k0WNynxUNpbLWZMRf9UgnDP86/6sZNWsaqjJ2alif9FbC5Czlb4F6WpVimdI+0SVH1a0xdfYUX484Al4KgGvkVmEviHrZVjyvdN/P6mJ+nKICBnFP+tLLTJOIPxWc3U04bpKO75BNXngikoVH2zENN22q6HUfB4FHYxqzVkdsgVu89wdqZ4xvG7n2B3Gb6pyYSPgZxC9CpjAoZPv16JmSQeckk/dlVskQIeZTVbZBDGVDCJjx+CHfLaivQGrBDjNZfxYFs9yUfYA/mMP1+jGc7Y8UGtti44fCCCr4eU3ouP8FP7Ym9JiasI= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 312ce7f4-dbdd-4f4b-0de2-08d7f15dc9f7 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 May 2020 01:35:41.8258 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qs+K8AOeHmSW2OoBMzpP3vTvADAFyhNeCFdZmA/f1WoedHyQ3n+riHmsRXu/vH7R8hQ6jPUHr/+CIce+jH3EGA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2636 Return-Path: guomin.jiang@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_DM6PR11MB2955ECD012B413F3195ECC789DA40DM6PR11MB2955namp_" --_000_DM6PR11MB2955ECD012B413F3195ECC789DA40DM6PR11MB2955namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I can't search the patch in master, anyone can pull the patch if it haven't= been pull. Best Regards guomin From: devel@edk2.groups.io On Behalf Of Guomin Jian= g Sent: Monday, March 23, 2020 4:13 PM To: Kun Qin ; devel@edk2.groups.io; Kinney, Michael= D ; Xu, Wei6 Cc: Gao, Liming Subject: Re: [edk2-devel] [PATCH] FmpDevicePkg/FmpDxe: Fix uninitialized p= ointer dereference Hi Kun, It is clear and i have no confusion. Reviewed-by: Guomin Jiang > Thanks guomin From: Kun Qin [mailto:Kun.Qin@microsoft.com] Sent: Monday, March 23, 2020 3:40 PM To: Jiang, Guomin >;= devel@edk2.groups.io; Kinney, Michael D >; Xu, Wei6 > Cc: Gao, Liming > Subject: RE: [edk2-devel] [PATCH] FmpDevicePkg/FmpDxe: Fix uninitialized p= ointer dereference Hi Guomin, Thanks for reaching out. I did encounter a GP fault because of this issue: If Line 582 is triggered when = the first Fmp->GetImageInfo failed, this specific mFmpImageInfoBuf[Index] w= ill remain to be uninitialized value (0xFAFAFAFAFAF in my case). Later on w= hen it comes to line 632, it wi= ll pass the null pointer check and try to dereference it, which leads to GP= fault. Please let me know if you need further clarification. Thanks, Kun From: Jiang, Guomin Sent: Monday, March 23, 2020 12:21 AM To: devel@edk2.groups.io; Kinney, Michael D; Xu, Wei6 Cc: Kun Qin; Gao, Liming Subject: [EXTERNAL] RE: [edk2-devel] [PATCH] FmpDevicePkg/FmpDxe: Fix unin= itialized pointer dereference Hi Xuwei, QinKun, Have you indeed encounter this issue or just think it is potential issue. I think below code will always initialize the mFmpImageInfoBuf[] and make= sure it is valid. Line 585 - mFmpImageInfoBuf[Index] =3D AllocateZeroPool (ImageInfoSize); If the second GetImageInfo() is runned, I think it will always have correc= t mfmpImageInfoBuf[] address. Of course, it is ok to use AllocateZeroPool to ensure zero buffer is alloc= ated. Thanks > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@ed= k2.groups.io] On Behalf Of > Michael D Kinney > Sent: Wednesday, March 18, 2020 11:15 PM > To: Xu, Wei6 >; devel@edk2.g= roups.io; Kinney, Michael > D > > Cc: Kun Qin >; Gao, Limi= ng > > Subject: Re: [edk2-devel] [PATCH] FmpDevicePkg/FmpDxe: Fix uninitialized > pointer dereference > > Reviewed-by: Michael D Kinney > > > > -----Original Message----- > > From: Xu, Wei6 > > > Sent: Tuesday, March 17, 2020 11:12 PM > > To: devel@edk2.groups.io > > Cc: Kun Qin >; Kinney,= Michael D > > >; Gao, = Liming > > > Subject: [edk2-devel] [PATCH] FmpDevicePkg/FmpDxe: Fix uninitialized > > pointer dereference > > > > From: Kun Qin > > > > > REF: > > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbu= gzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2602&data=3D02%7C01%7CKun.Qi= n%40microsoft.com%7C3c1042cd095b42a51b9d08d7cefad022%7C72f988bf86f141af91ab= 2d7cd011db47%7C1%7C0%7C637205448946602054&sdata=3D95z6fDC0uceCCs2MuoeCR= 4MXgRhAI3dVssWeddsWT5s%3D&reserved=3D0 > > > > Zero the allocated buffer in case GetImageInfo `continue` in the > > middle of a loop. This will cause unexpected GetImageInfo failure not > > clearing the corresponding entry and lead to GP faults when > > dereferencing this entry. > > > > Cc: Michael D Kinney > > > Cc: Liming Gao > > > Signed-off-by: Wei6 Xu > > > --- > > FmpDevicePkg/FmpDxe/Dependency.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/FmpDevicePkg/FmpDxe/Dependency.c > > b/FmpDevicePkg/FmpDxe/Dependency.c > > index 8f97c42916..65c23989c6 100644 > > --- a/FmpDevicePkg/FmpDxe/Dependency.c > > +++ b/FmpDevicePkg/FmpDxe/Dependency.c > > @@ -550,11 +550,11 @@ EvaluateImageDependencies ( > > ); > > if (EFI_ERROR (Status)) { > > return EFI_ABORTED; > > } > > > > - mFmpImageInfoBuf =3D AllocatePool > > (sizeof(EFI_FIRMWARE_IMAGE_DESCRIPTOR *) * > mNumberOfFmpInstance); > > + mFmpImageInfoBuf =3D AllocateZeroPool > > (sizeof(EFI_FIRMWARE_IMAGE_DESCRIPTOR *) * > mNumberOfFmpInstance); > > if (mFmpImageInfoBuf =3D=3D NULL) { > > return EFI_OUT_OF_RESOURCES; > > } > > > > for (Index =3D 0; Index < mNumberOfFmpInstance; Index > > ++) { > > -- > > 2.16.2.windows.1 > > > --_000_DM6PR11MB2955ECD012B413F3195ECC789DA40DM6PR11MB2955namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

I can’t search the patch in master, anyone ca= n pull the patch if it haven’t been pull.

 

Best Regards

guomin

From: devel@edk2.groups.io <devel@edk2.gr= oups.io> On Behalf Of Guomin Jiang
Sent: Monday, March 23, 2020 4:13 PM
To: Kun Qin <Kun.Qin@microsoft.com>; devel@edk2.groups.io; Ki= nney, Michael D <michael.d.kinney@intel.com>; Xu, Wei6 <wei6.xu@in= tel.com>
Cc: Gao, Liming <liming.gao@intel.com>
Subject: Re: [edk2-devel] [PATCH] FmpDevicePkg/FmpDxe: Fix uninitia= lized pointer dereference

 

Hi Kun,

 

It is clear and i hav= e no confusion.

 

Reviewed-by: Guomin J= iang <guomin.jiang@intel.com>

 

Thanks

guomin

From: Kun Qin [mailto:Kun.Qin@microsoft.com]
Sent: Monday, March 23, 2020 3:40 PM
To: Jiang, Guomin <guo= min.jiang@intel.com>; devel@edk2.groups.io; Kinney, = Michael D <michael.d.kinne= y@intel.com>; Xu, Wei6 <wei6= .xu@intel.com>
Cc: Gao, Liming <liming.= gao@intel.com>
Subject: RE: [edk2-devel] [PATCH] FmpDevicePkg/FmpDxe: Fix uninitia= lized pointer dereference

 

Hi Guomin,

 

Thanks for reaching out. I did encounter a GP fault= because of this issue:

 

If Line 582 is triggered when the first Fmp->GetImageInfo failed, this= specific mFmpImageInfoBuf[Index] will remain to be uninitialized value (0xFA= FAFAFAFAF in my case). Later on when it comes to line 632, it will pass the null pointer check and try to dereference i= t, which leads to GP fault. Please let me know if you need further clarific= ation.

 

Thanks,

Kun

 

From: Jiang, Guomin
Sent: Monday, March 23, 2020 12:21 AM
To: devel@edk2.groups.io; Kinney, Michael D; Xu, Wei6 Cc: Kun Qin; Gao, Liming
Subject: [EXTERNAL] RE: [edk2-devel] [PATCH] FmpDevicePkg/FmpDxe: F= ix uninitialized pointer dereference

 

Hi Xuwei, QinKun,
Have you indeed encounter this issue or just think it is potential issue.<= br>
I think  below code will always initialize the mFmpImageInfoBuf[] and= make sure it is valid.
Line 585 - mFmpImageInfoBuf[Index] =3D AllocateZeroPool (ImageInfoSize);
If the second GetImageInfo() is runned, I think it will always have correc= t mfmpImageInfoBuf[] address.

Of course, it is ok to use AllocateZeroPool to ensure zero buffer is alloc= ated.

Thanks

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io]= On Behalf Of
> Michael D Kinney
> Sent: Wednesday, March 18, 2020 11:15 PM
> To: Xu, Wei6 <wei6.xu@intel.c= om>; devel@edk2.groups.io; Kinney, Michael
> D <michael.d.kinney@= intel.com>
> Cc: Kun Qin <kuqin@microsof= t.com>; Gao, Liming <limi= ng.gao@intel.com>
> Subject: Re: [edk2-devel] [PATCH] FmpDevicePkg/FmpDxe: Fix uninitiali= zed
> pointer dereference
>
> Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
>
> > -----Original Message-----
> > From: Xu, Wei6 <wei6.xu@= intel.com>
> > Sent: Tuesday, March 17, 2020 11:12 PM
> > To: devel@edk2.groups.io=
> > Cc: Kun Qin <kuqin@mic= rosoft.com>; Kinney, Michael D
> > <michael.d.kinn= ey@intel.com>; Gao, Liming <liming.gao@intel.com>
> > Subject: [edk2-devel] [PATCH] FmpDevicePkg/FmpDxe: Fix uninitial= ized
> > pointer dereference
> >
> > From: Kun Qin <kuqin@m= icrosoft.com>
> >
> > REF:
> > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbugzil= la.tianocore.org%2Fshow_bug.cgi%3Fid%3D2602&amp;data=3D02%7C01%7CKun.Qi= n%40microsoft.com%7C3c1042cd095b42a51b9d08d7cefad022%7C72f988bf86f141af91ab= 2d7cd011db47%7C1%7C0%7C637205448946602054&amp;sdata=3D95z6fDC0uceCCs2Mu= oeCR4MXgRhAI3dVssWeddsWT5s%3D&amp;reserved=3D0
> >
> > Zero the allocated buffer in case GetImageInfo `continue` in the=
> > middle of a loop. This will cause unexpected GetImageInfo failur= e not
> > clearing the corresponding entry and lead to GP faults when
> > dereferencing this entry.
> >
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <limin= g.gao@intel.com>
> > Signed-off-by: Wei6 Xu <= wei6.xu@intel.com>
> > ---
> >  FmpDevicePkg/FmpDxe/Dependency.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/FmpDevicePkg/FmpDxe/Dependency.c
> > b/FmpDevicePkg/FmpDxe/Dependency.c
> > index 8f97c42916..65c23989c6 100644
> > --- a/FmpDevicePkg/FmpDxe/Dependency.c
> > +++ b/FmpDevicePkg/FmpDxe/Dependency.c
> > @@ -550,11 +550,11 @@ EvaluateImageDependencies (
> >           = ;       );
> >    if (EFI_ERROR (Status)) {
> >      return EFI_ABORTED;
> >    }
> >
> > -  mFmpImageInfoBuf =3D AllocatePool
> > (sizeof(EFI_FIRMWARE_IMAGE_DESCRIPTOR *) *
> mNumberOfFmpInstance);
> > +  mFmpImageInfoBuf =3D AllocateZeroPool
> > (sizeof(EFI_FIRMWARE_IMAGE_DESCRIPTOR *) *
> mNumberOfFmpInstance);
> >    if (mFmpImageInfoBuf =3D=3D NULL) {
> >      return EFI_OUT_OF_RESOURCES;
> >    }
> >
> >    for (Index =3D 0; Index < mNumberOfFmpInsta= nce; Index
> > ++) {
> > --
> > 2.16.2.windows.1
>
>
>

 

--_000_DM6PR11MB2955ECD012B413F3195ECC789DA40DM6PR11MB2955namp_--