From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web10.2801.1590625411991745948 for ; Wed, 27 May 2020 17:23:32 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=bUog7HuE; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: guomin.jiang@intel.com) IronPort-SDR: qtV0LV46fGYhHYrPOTE8srw/3IbWGn4TPJ+RVO5xtM443wS9YjPbUk4L4MI1Y12ohld40r4QGk 13tDVvS62FtQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 May 2020 17:23:31 -0700 IronPort-SDR: APFc3FqW7sbTUm0uSOvfrCwwPfe+STCqswF/3m5TfqSNW/cOlVbD8hJ1Zwb3gT4fSWtXsb0lTM lBy/WEBhtjqQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,442,1583222400"; d="scan'208";a="345720374" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga001.jf.intel.com with ESMTP; 27 May 2020 17:23:30 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 27 May 2020 17:23:30 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.52) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 27 May 2020 17:23:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NlFC6Anbk4RoSAOaSXwdglOv9ZYU5dM503T7eYR5U4Okp8LBkuL+17Uywn/W9z+tZ5utXzN3l367b170tkNNztAV3yr+2vYheW/0CAFTXpGkm/5jkdH+y5ErBDeOILgx5cyf6Ws08jQodPpitdhFFrNfFXaKjTVxIqegfExa6LMq+Vu+LKQvhDeVsLBeUj/wrMt35SD2/BZuV9IKbNDr8Z1Nc6AioShiuXKM9thHoFZAEphxHBuHuXl+rtCUgpgesPJ+5nTzrFvPVumrR6Yz2X24Btla2kuzLACFiXZQBnjibbpJzmuMDUoXfc/3i/Z6G6/MWkVCBLc0IuBbMxGdTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7aRbuP1oYPnDf6xNZG4zUDCmggTdyImbEzuJ4IdfAe8=; b=SBrECpZdYDCkC0y6SiTvgzmzCXD9IsE2/khHnh3Nj03v//6siIVV9I2H0w0XfWsO9R4bHl1sb0kki1l5Q3+b5S6xJQIYkmy/cyDnqUnG9JSXFHO8Bx7rScC4TqplP4k8+5nh6MZDN2HdYDuJzwsU7l6aiejEP/MhNaQ84ypm4fUB449mGR/OoYaaEcthb4AbxhvEO7sc5ihPCTRM9nY7cbwtYIsn84Fo97UTURXl9X7DgrsJ/5xpTQm3dFH6To8fHo9CdHpoDoqq/c+xaeohlpGWfE+hOK8r5JBzIrmLIR9UGDyMkyLc7KTXp/3HqxNIbzxMhE+gqcfxOKtSq/RBFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7aRbuP1oYPnDf6xNZG4zUDCmggTdyImbEzuJ4IdfAe8=; b=bUog7HuEtGSbHRTCj0ynIM0FiGmQ7jrzUxsU0IjAmhYQAKUEQgm+x0EmV9MPRDtu1vi9mHbD1RiexkYP47PMhXKlbTf3+BziGoSptcvcIOBkAWDh4FdwfCSrFGbJz+Jnj3QzMXrtqdQme3mUjKbT3XbQN92OQL7s3PEpIej+Neg= Received: from DM6PR11MB2955.namprd11.prod.outlook.com (2603:10b6:5:65::31) by DM6PR11MB4027.namprd11.prod.outlook.com (2603:10b6:5:199::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.18; Thu, 28 May 2020 00:23:28 +0000 Received: from DM6PR11MB2955.namprd11.prod.outlook.com ([fe80::ccd4:4b0d:535a:58be]) by DM6PR11MB2955.namprd11.prod.outlook.com ([fe80::ccd4:4b0d:535a:58be%7]) with mapi id 15.20.3045.018; Thu, 28 May 2020 00:23:28 +0000 From: "Guomin Jiang" To: "devel@edk2.groups.io" , "rebecca@bsdio.com" CC: "Wang, Jian J" , "Lu, XiaoyuX" Subject: Re: [edk2-devel] [PATCH v2 1/1] CryptoPkg: Fix VS2017 build problem for ARM/AARCH64 Thread-Topic: [edk2-devel] [PATCH v2 1/1] CryptoPkg: Fix VS2017 build problem for ARM/AARCH64 Thread-Index: AQHWNECTYA87flnLwEWSWj8rf+ekQKi8o2lw Date: Thu, 28 May 2020 00:23:28 +0000 Message-ID: References: <20200527160412.42938-1-rebecca@bsdio.com> In-Reply-To: <20200527160412.42938-1-rebecca@bsdio.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.196] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f93f5fac-44e3-458c-b35a-08d8029d57f2 x-ms-traffictypediagnostic: DM6PR11MB4027: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2733; x-forefront-prvs: 0417A3FFD2 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qrQXKB/w5zkYjQN7r/ODeuMQpP4Ld/m5BuMsGrKibMwq0V1knEFXQ4yG6o9b3+tiTpHCgGTwu0m3jgWYHVVY6GcZc6iN0jTQu/PFL0ZNz67U0IDjXnh2X2cc5QcvcUUSBfvB07KG3yfdCBCbA28ey572nIjUe5GcgmwbbjdSaO8QtwnjA05c70ft+He92YvbuKOznPoepQhF9WizLfJf7myy8VKbvCYrVE5+j04AKLz4VYg8NWMMiePOycmUb1458DwNIAe6Yn17/MzlvrtIK6PtvGBaMUdxbdG5Pg+vIssSzSuFplhy4XUlI15VISykFa3X4unFv+82V2z7vm1wrxbac1C+zLDQpPgL5RI6MX4x2BCw3/wtaK+Kcj9BTeeuAsj92iKB5HBSYH2Jl5J+Im4HKVRLXu4jH4uyXXgDDVz/SpRUSzPQT/rEoMhUQ7i1RfU2VWErqayNFzqyTXz6GRKOt07b5uEJadzVmp3Y+bE= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB2955.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(396003)(136003)(39860400002)(346002)(366004)(376002)(6506007)(53546011)(966005)(19627235002)(2906002)(110136005)(8676002)(316002)(9686003)(478600001)(54906003)(86362001)(107886003)(33656002)(52536014)(71200400001)(66446008)(64756008)(55016002)(76116006)(66476007)(66556008)(26005)(7696005)(4326008)(186003)(8936002)(5660300002)(83380400001)(66946007)(3714002)(545624004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: y1gN8WA2lGjXej6ofw4DPodvLSmYu308IjJsR8TebhnlClRXyJgP165uzPSGrU+vYGYLUTauvAB98RmoMIVKjarB4+qVe4evO/b4sA/hfrf43YTk8wTlrU0l1eV1qaUzpIdKSOrYe/StZ0oQECPnmnOyVEDF/qrvIzamzz/+QIdxoGVfaZOA7K5xjp443rSq/8oaVD5KghkJolZBVO7oPWNzf7gXVwVE849lK8bz1GwyddAMSaf+whV8Ym2sYlaNLOQoIpoXe+ZmqFho5YKS5jN0hI7h9ngGDpv2DL/d8INWqJZEEc9gmrAqn20znVxTYFDGm1Yk1+l+XGcjfzGDJ7aO3kmFfxoz+tRUHfX7nNk0QtkhN3H07JbtrjZYTRu9NfzwxJXx3uhEkKmtkWsE0p+OiNT528ZP6w47+7V+UbhILnEcvuTGLTGLVg+szsVQudzPE/ueDtukp2jjs5Bgo2CvV8W9JX/OUhy43xAqsRM= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f93f5fac-44e3-458c-b35a-08d8029d57f2 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 May 2020 00:23:28.0510 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5gCk8LZYHfk45/CXlXBT4JHHoKq71RoE+pd+ea0QcocwrewqAAnn8RwtXDzcl3ihqAked1gBuy0sdcTIy2O6tg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4027 Return-Path: guomin.jiang@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I think it is good to me. Reviewed-by: Guomin Jiang > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Rebecca > Cran > Sent: Thursday, May 28, 2020 12:04 AM > To: devel@edk2.groups.io > Cc: Rebecca Cran ; Wang, Jian J > ; Lu, XiaoyuX > Subject: [edk2-devel] [PATCH v2 1/1] CryptoPkg: Fix VS2017 build problem > for ARM/AARCH64 >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2029 >=20 > 1. CryptPkcs7VerifyEku.c contains internal/x509_int.h header file, this > file contains internal/refcount.h file, if _M_ARM or _M_ARM64 > defined, it will contains (intrin.h). > So we undef these flags for MSVC. It will fix include header > dependence problem(intrin.h). >=20 > 2. ARM with MSFT toolchain was not enabled in BuildOptions, So > add CC_FLAGS for ARM/AARCH64 into OpensslLib[Crypto].inf BuildOptions > section to fix build problem. >=20 > Cc: Jian J Wang > Signed-off-by: Xiaoyu Lu > --- > CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf | 2 ++ > CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 2 ++ > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 2 ++ > CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 2 ++ > 4 files changed, 8 insertions(+) >=20 > diff --git a/CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf > b/CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf > index 4aae2aba95d6..4ed5b8265563 100644 > --- a/CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf > +++ b/CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf > @@ -94,6 +94,8 @@ [BuildOptions] > # C4090: 'function' : different 'const' qualifiers > # > MSFT:*_*_*_CC_FLAGS =3D /wd4090 > + MSFT:*_*_ARM_CC_FLAGS =3D /wd4090 /U_M_ARM /U_M_ARM64 > + MSFT:*_*_AARCH64_CC_FLAGS =3D /wd4090 /U_M_ARM /U_M_ARM64 >=20 > # -JCryptoPkg/Include : To disable the use of the system includes pro= vided > by RVCT > # --diag_remark=3D1 : Reduce severity of "#1-D: last line of file= ends > without a newline" > diff --git a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > index dc28e3a11d48..0e66d935ead8 100644 > --- a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > +++ b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > @@ -84,6 +84,8 @@ [BuildOptions] > # C4718: 'function call' : recursive call has no side effects, deleti= ng > # > MSFT:*_*_*_CC_FLAGS =3D /wd4090 /wd4718 > + MSFT:*_*_ARM_CC_FLAGS =3D /wd4090 /wd4718 /U_M_ARM > /U_M_ARM64 > + MSFT:*_*_AARCH64_CC_FLAGS =3D /wd4090 /wd4718 /U_M_ARM > /U_M_ARM64 >=20 > # -JCryptoPkg/Include : To disable the use of the system includes pro= vided > by RVCT > # --diag_remark=3D1 : Reduce severity of "#1-D: last line of file= ends > without a newline" > diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf > b/CryptoPkg/Library/OpensslLib/OpensslLib.inf > index c8ec9454bd90..c43c7bad4982 100644 > --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf > +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf > @@ -619,6 +619,8 @@ [BuildOptions] > # > MSFT:*_*_IA32_CC_FLAGS =3D -U_WIN32 -U_WIN64 -U_MSC_VER > $(OPENSSL_FLAGS) /wd4090 /wd4132 /wd4244 /wd4245 /wd4267 /wd4310 > /wd4389 /wd4700 /wd4702 /wd4706 /wd4819 > MSFT:*_*_X64_CC_FLAGS =3D -U_WIN32 -U_WIN64 -U_MSC_VER > $(OPENSSL_FLAGS) /wd4090 /wd4132 /wd4244 /wd4245 /wd4267 /wd4306 > /wd4310 /wd4700 /wd4389 /wd4702 /wd4706 /wd4819 > + MSFT:*_*_ARM_CC_FLAGS =3D -U_WIN32 -U_WIN64 -U_MSC_VER > $(OPENSSL_FLAGS) /wd4090 /wd4132 /wd4244 /wd4245 /wd4267 /wd4306 > /wd4310 /wd4700 /wd4389 /wd4702 /wd4706 /wd4819 > + MSFT:*_*_AARCH64_CC_FLAGS =3D -U_WIN32 -U_WIN64 -U_MSC_VER > $(OPENSSL_FLAGS) /wd4090 /wd4132 /wd4244 /wd4245 /wd4267 /wd4306 > /wd4310 /wd4700 /wd4389 /wd4702 /wd4706 /wd4819 >=20 > INTEL:*_*_IA32_CC_FLAGS =3D -U_WIN32 -U_WIN64 -U_MSC_VER -U__ICC > $(OPENSSL_FLAGS) /w > INTEL:*_*_X64_CC_FLAGS =3D -U_WIN32 -U_WIN64 -U_MSC_VER -U__ICC > $(OPENSSL_FLAGS) /w > diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > index 2f232e3e1289..594717331f68 100644 > --- a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > +++ b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > @@ -568,6 +568,8 @@ [BuildOptions] > # > MSFT:*_*_IA32_CC_FLAGS =3D -U_WIN32 -U_WIN64 -U_MSC_VER > $(OPENSSL_FLAGS) /wd4090 /wd4132 /wd4244 /wd4245 /wd4267 /wd4310 > /wd4389 /wd4700 /wd4702 /wd4706 /wd4819 > MSFT:*_*_X64_CC_FLAGS =3D -U_WIN32 -U_WIN64 -U_MSC_VER > $(OPENSSL_FLAGS) /wd4090 /wd4132 /wd4244 /wd4245 /wd4267 /wd4306 > /wd4310 /wd4700 /wd4389 /wd4702 /wd4706 /wd4819 > + MSFT:*_*_ARM_CC_FLAGS =3D -U_WIN32 -U_WIN64 -U_MSC_VER > $(OPENSSL_FLAGS) /wd4090 /wd4132 /wd4244 /wd4245 /wd4267 /wd4306 > /wd4310 /wd4700 /wd4389 /wd4702 /wd4706 /wd4819 > + MSFT:*_*_AARCH64_CC_FLAGS =3D -U_WIN32 -U_WIN64 -U_MSC_VER > $(OPENSSL_FLAGS) /wd4090 /wd4132 /wd4244 /wd4245 /wd4267 /wd4306 > /wd4310 /wd4700 /wd4389 /wd4702 /wd4706 /wd4819 >=20 > INTEL:*_*_IA32_CC_FLAGS =3D -U_WIN32 -U_WIN64 -U_MSC_VER -U__ICC > $(OPENSSL_FLAGS) /w > INTEL:*_*_X64_CC_FLAGS =3D -U_WIN32 -U_WIN64 -U_MSC_VER -U__ICC > $(OPENSSL_FLAGS) /w > -- > 2.26.2.windows.1 >=20 >=20 >=20 >=20