From: "Guomin Jiang" <guomin.jiang@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"matthewfcarlson@gmail.com" <matthewfcarlson@gmail.com>
Subject: Re: [edk2-devel] [PATCH v4 0/5] Use RngLib instead of TimerLib for OpensslLib
Date: Tue, 11 Aug 2020 11:33:36 +0000 [thread overview]
Message-ID: <DM6PR11MB2955EF1D44FA5424BCFCA4449D450@DM6PR11MB2955.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200811022200.1087-1-matthewfcarlson@gmail.com>
I will review the patch by next week(8/21).
Thanks
Guomin
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> Matthew Carlson
> Sent: Tuesday, August 11, 2020 10:22 AM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH v4 0/5] Use RngLib instead of TimerLib for
> OpensslLib
>
> From: Matthew Carlson <macarl@microsoft.com>
>
> Ref: https://github.com/tianocore/edk2/pull/845
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871
>
> Matthew Carlson (5):
> MdePkg: TimerRngLib: Added RngLib that uses TimerLib
> MdePkg: BaseRngLibDxe: Add RngLib that uses RngDxe
> OvmfPkg: Add RngLib based on TimerLib for Crypto
> ArmVirtPkg: Add RngLib based on TimerLib for CryptoPkg
> CryptoPkg: OpensslLib: Use RngLib to generate entropy in rand_pool
>
> CryptoPkg/Library/OpensslLib/rand_pool.c | 203 ++------------------
> CryptoPkg/Library/OpensslLib/rand_pool_noise.c | 29 ---
> CryptoPkg/Library/OpensslLib/rand_pool_noise_tsc.c | 43 -----
> MdePkg/Library/BaseRngLibDxe/RngDxeLib.c | 200
> +++++++++++++++++++
> MdePkg/Library/BaseRngLibTimerLib/RngLibTimer.c | 187
> ++++++++++++++++++
> ArmVirtPkg/ArmVirt.dsc.inc | 1 +
> CryptoPkg/CryptoPkg.dsc | 1 +
> CryptoPkg/Library/OpensslLib/OpensslLib.inf | 15 +-
> CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 15 +-
> CryptoPkg/Library/OpensslLib/rand_pool_noise.h | 29 ---
> MdePkg/Library/BaseRngLibDxe/BaseRngLibDxe.inf | 38 ++++
> MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf | 40 ++++
> MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.uni | 17 ++
> MdePkg/MdePkg.dsc | 5 +-
> OvmfPkg/OvmfPkgIa32.dsc | 1 +
> OvmfPkg/OvmfPkgIa32X64.dsc | 1 +
> OvmfPkg/OvmfPkgX64.dsc | 1 +
> OvmfPkg/OvmfXen.dsc | 1 +
> 18 files changed, 513 insertions(+), 314 deletions(-) delete mode 100644
> CryptoPkg/Library/OpensslLib/rand_pool_noise.c
> delete mode 100644 CryptoPkg/Library/OpensslLib/rand_pool_noise_tsc.c
> create mode 100644 MdePkg/Library/BaseRngLibDxe/RngDxeLib.c
> create mode 100644 MdePkg/Library/BaseRngLibTimerLib/RngLibTimer.c
> delete mode 100644 CryptoPkg/Library/OpensslLib/rand_pool_noise.h
> create mode 100644 MdePkg/Library/BaseRngLibDxe/BaseRngLibDxe.inf
> create mode 100644
> MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf
> create mode 100644
> MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.uni
>
> --
> 2.27.0.windows.1
>
>
>
next prev parent reply other threads:[~2020-08-11 11:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 2:21 [PATCH v4 0/5] Use RngLib instead of TimerLib for OpensslLib Matthew Carlson
2020-08-11 2:21 ` [PATCH v4 1/5] MdePkg: TimerRngLib: Added RngLib that uses TimerLib Matthew Carlson
2020-08-11 2:21 ` [PATCH v4 2/5] MdePkg: BaseRngLibDxe: Add RngLib that uses RngDxe Matthew Carlson
2020-08-11 2:21 ` [PATCH v4 3/5] OvmfPkg: Add RngLib based on TimerLib for Crypto Matthew Carlson
2020-08-11 8:22 ` Ard Biesheuvel
2020-08-11 16:09 ` [edk2-devel] " Laszlo Ersek
2020-08-11 16:15 ` Laszlo Ersek
2020-08-12 2:27 ` Matthew Carlson
2020-08-12 10:05 ` Laszlo Ersek
2020-08-15 5:33 ` Rebecca Cran
2020-08-11 2:21 ` [PATCH v4 4/5] ArmVirtPkg: Add RngLib based on TimerLib for CryptoPkg Matthew Carlson
2020-08-11 16:13 ` [edk2-devel] " Laszlo Ersek
2020-08-11 2:22 ` [PATCH v4 5/5] CryptoPkg: OpensslLib: Use RngLib to generate entropy in rand_pool Matthew Carlson
2020-08-11 11:33 ` Guomin Jiang [this message]
2020-08-12 2:21 ` [edk2-devel] [PATCH v4 0/5] Use RngLib instead of TimerLib for OpensslLib Matthew Carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB2955EF1D44FA5424BCFCA4449D450@DM6PR11MB2955.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox