From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web11.12746.1597145619662938663 for ; Tue, 11 Aug 2020 04:33:39 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=u7Qfcy2W; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: guomin.jiang@intel.com) IronPort-SDR: cVsW1fEycca8KJee9GshbCSnomlfkTaPzAX8EYfyhuqpxBRtfHCRvu4z15mFsn5A19hucQcM3G yT9ZL6ISdSAg== X-IronPort-AV: E=McAfee;i="6000,8403,9709"; a="151149797" X-IronPort-AV: E=Sophos;i="5.75,461,1589266800"; d="scan'208";a="151149797" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2020 04:33:38 -0700 IronPort-SDR: xHnUJ2Q/OPD/XB2RO8Mdav7NxXdF12iSPG2il9wBTHyMN9h9+MAjDoGmPgPAN44DCfKdoR70Br h4hWnpJxaajQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,461,1589266800"; d="scan'208";a="494650589" Received: from unknown (HELO fmsmsx605.amr.corp.intel.com) ([10.18.84.215]) by fmsmga006.fm.intel.com with ESMTP; 11 Aug 2020 04:33:38 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 11 Aug 2020 04:33:38 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 11 Aug 2020 04:33:37 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 11 Aug 2020 04:33:37 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.173) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 11 Aug 2020 04:33:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FTGBG4dD1b5GmplCvSo69zP324W/0FmFTTfnbihMTjL5eYBK94xHVMbGbkuhgSC6x1UzVbw9MvAy+rUAa3qeE2JEimeqx1dmAB1P1wox1RLDsk0Nei8irjUUs4PlRIX1mmKQuJD30GVLd3Yt7c0qtjCchvbxU66z8sfY71+VnMuZae0Yt6ilYBCfNlT17lQ4VPpVc5DnM8Zzfd2bWIU4k2xxm3PWQEbarP+Mzbd1m0ErjsQOoke2BlJ9kgE1LoZEzAVFNF0iGd/yOpaF69ekImNUA9jQXYMbelDroDpNUVmKoaRt/5Uyp9E9x1tHgdS5WlTpLhI7CJaT09mvRcINsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RHOk831c+n8H1O3k5nnYH9B5ksjR98bGI4wadj6EUMw=; b=fLpFaT5NHbO+pYsL6Eqkx6nNYvOSrQEQ2u/pjAfznbxNQdvduxsuKhBu4Vupx6k/izUvrqEstR0Dgg3QpkD5NJAbNk9ddoaTPUIhBP85TOOPIUt8TX5wWeawooPImATuDhnBqjDqfqhebw3/rAJ2JZWG05yvY1q5mw/bs0Yx4jHf4m5HHtNG1609XxV8kmfh61o/HWPxd/wP55ThUEcGK7vvgYXp3DV4x7mZNgzsEAvtbk5796C+gHZj42AXxrl1HNwXMThc57eWVRfMIomLV87kpNd/KVGn8Q4kEkCZ5teQeIcv4zbcFQLfBIsH72OWmWeFtVJQzeA1G3Dm2LmSog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RHOk831c+n8H1O3k5nnYH9B5ksjR98bGI4wadj6EUMw=; b=u7Qfcy2WWudHhLDB1VGxd0sUhB06IzeFZYJiXHno+8I7XES/U5CDhsuA89XutRLsCM+K47kiNIkpAhOoN3DVwI8M0IN+0UG245hOQiC16ILgpeUcFbwMRU80sxjeXmEUq3UJH/2CjOaZUddZs1M7wy1BAb2NjinZyTeN/8nlWiA= Received: from DM6PR11MB2955.namprd11.prod.outlook.com (2603:10b6:5:65::31) by DM5PR1101MB2092.namprd11.prod.outlook.com (2603:10b6:4:5a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.17; Tue, 11 Aug 2020 11:33:36 +0000 Received: from DM6PR11MB2955.namprd11.prod.outlook.com ([fe80::6d20:b482:b693:52c0]) by DM6PR11MB2955.namprd11.prod.outlook.com ([fe80::6d20:b482:b693:52c0%7]) with mapi id 15.20.3261.025; Tue, 11 Aug 2020 11:33:36 +0000 From: "Guomin Jiang" To: "devel@edk2.groups.io" , "matthewfcarlson@gmail.com" Subject: Re: [edk2-devel] [PATCH v4 0/5] Use RngLib instead of TimerLib for OpensslLib Thread-Topic: [edk2-devel] [PATCH v4 0/5] Use RngLib instead of TimerLib for OpensslLib Thread-Index: AQHWb4Y9n/+odLj1K0WEiHcZjl4ovqkyxx0Q Date: Tue, 11 Aug 2020 11:33:36 +0000 Message-ID: References: <20200811022200.1087-1-matthewfcarlson@gmail.com> In-Reply-To: <20200811022200.1087-1-matthewfcarlson@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.203] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 95e1ed8a-688f-451b-8c1c-08d83dea62cd x-ms-traffictypediagnostic: DM5PR1101MB2092: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2733; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: j+oMcXgc6ny8ODvcf61r7S3UXlzjgRVnkZZf7URLs6GJ5v/1kSQp+rZQQaAu87mmy1xBxTr9MgXxCHxKGoMZNqWEhYkOlXtiZ498q40MkljeKiyjuv1invYm+NQ2PO7PAwI8MDAe2au2Qq/Jmw8t/muS/GsFWjiRCPFvWL5C5dIa4wjbDba+nAF+Ix8hdKn1CJby+UFGjZGOmChGsg8LQijJqMyoqU1cyHqMB54BCtuggnM9NvOFceD38xtuaW/YITWy6/9gH6nY5IiwXySxf+vtaHjSXlBd1/A3pjnQTCJps240svrWDoqk7KwqHlC7GRJRQPyzq2XffHq6H0EqA8+m4o9Lop2jC5GsIUggjIzAPCXwKsgBB6fpCJwq1x+1qaJdTAng2pLn0oor43/KJw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB2955.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(366004)(2906002)(110136005)(19627235002)(33656002)(5660300002)(52536014)(8936002)(66446008)(498600001)(55016002)(66476007)(64756008)(71200400001)(66556008)(86362001)(76116006)(83380400001)(186003)(66946007)(9686003)(53546011)(6506007)(8676002)(966005)(7696005)(26005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: WlG9LTzKY1AH4I1S5UUWTjpNqMYKWuf4UXlfxAdlGdDIj5CbIoyo1sqpzbclr/ZYty70gvFkzKA5+Anvuj+utY9HLPPJHcy7SoRFcNgkIht8pxWh3z1ejSJkAdWtKayBFPVI2kqOqYHlb/GHF0SzfwgAJiDdDrUS0YnWpuDb/5cCHAkwjwdYWmICdlVcMPWPTK4I7m48MGow9ky9+MOQLlka08uVhC0//MJKhRJq7W+Oianzn3gyNXF0pg7riskDybTmNlDnP1BfGr8tFzRSa+cQrLczYnBH5HlgVnu7ROew2TBS73zut5uLrIqgmwHfgznlZswjku86+ePDXVMocY4ptP+KpoRHXpBKjaqDcCmaGWFPqIgEcMnstDWavpeDWZfodmdNObZ0h1Xc+cWh2MBspmLonPAt5hA1LGfDDv08hxIWxNC7/eNWCVx2ZLe3Zn2RHp/GC0Oc+yEdMQgr9M0zEwtkbwZtOQHdk6ABnQnPvqLIldwFSGOAosIN4pkelS6ZX8MFI/8cV87AJeUx0rkuWiqFgddC6JGAbUenKnkjauIrrf3mJrieRqirnQuy1G/EUTtOfGCTxi3m9i5+WLgm07WWo011owap+U9xIl0Ux35is7YYpxRLAnrEApOdtaBbNZBaYQtFQ8N/koNoCQ== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2955.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 95e1ed8a-688f-451b-8c1c-08d83dea62cd X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Aug 2020 11:33:36.1615 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xEVm5G9RfJ0vFmPYDziycjY6qDAe/Svm6XgfRO04z0Ryy8ru9ckb+JQJg5MJvcdX9VgAbvFlHe/esiHWT/6IEA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2092 Return-Path: guomin.jiang@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I will review the patch by next week(8/21). Thanks Guomin > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of > Matthew Carlson > Sent: Tuesday, August 11, 2020 10:22 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH v4 0/5] Use RngLib instead of TimerLib for > OpensslLib >=20 > From: Matthew Carlson >=20 > Ref: https://github.com/tianocore/edk2/pull/845 > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1871 >=20 > Matthew Carlson (5): > MdePkg: TimerRngLib: Added RngLib that uses TimerLib > MdePkg: BaseRngLibDxe: Add RngLib that uses RngDxe > OvmfPkg: Add RngLib based on TimerLib for Crypto > ArmVirtPkg: Add RngLib based on TimerLib for CryptoPkg > CryptoPkg: OpensslLib: Use RngLib to generate entropy in rand_pool >=20 > CryptoPkg/Library/OpensslLib/rand_pool.c | 203 ++------= ------------ > CryptoPkg/Library/OpensslLib/rand_pool_noise.c | 29 --- > CryptoPkg/Library/OpensslLib/rand_pool_noise_tsc.c | 43 ----- > MdePkg/Library/BaseRngLibDxe/RngDxeLib.c | 200 > +++++++++++++++++++ > MdePkg/Library/BaseRngLibTimerLib/RngLibTimer.c | 187 > ++++++++++++++++++ > ArmVirtPkg/ArmVirt.dsc.inc | 1 + > CryptoPkg/CryptoPkg.dsc | 1 + > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 15 +- > CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 15 +- > CryptoPkg/Library/OpensslLib/rand_pool_noise.h | 29 --- > MdePkg/Library/BaseRngLibDxe/BaseRngLibDxe.inf | 38 ++++ > MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf | 40 ++++ > MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.uni | 17 ++ > MdePkg/MdePkg.dsc | 5 +- > OvmfPkg/OvmfPkgIa32.dsc | 1 + > OvmfPkg/OvmfPkgIa32X64.dsc | 1 + > OvmfPkg/OvmfPkgX64.dsc | 1 + > OvmfPkg/OvmfXen.dsc | 1 + > 18 files changed, 513 insertions(+), 314 deletions(-) delete mode 1006= 44 > CryptoPkg/Library/OpensslLib/rand_pool_noise.c > delete mode 100644 CryptoPkg/Library/OpensslLib/rand_pool_noise_tsc.c > create mode 100644 MdePkg/Library/BaseRngLibDxe/RngDxeLib.c > create mode 100644 MdePkg/Library/BaseRngLibTimerLib/RngLibTimer.c > delete mode 100644 CryptoPkg/Library/OpensslLib/rand_pool_noise.h > create mode 100644 MdePkg/Library/BaseRngLibDxe/BaseRngLibDxe.inf > create mode 100644 > MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf > create mode 100644 > MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.uni >=20 > -- > 2.27.0.windows.1 >=20 >=20 >=20