+Hao, Ray,

Hi Libo, thanks for your explanation.

So I think the patch is improvement for current logic.

Hi Hao and Ray,

Can you give some comments for the change.

Hi Jeremy,

It may be helpful for the ASSERT issue https://edk2.groups.io/g/devel/message/62651,can you try it?

Best Regards

Guomin

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Feng Libo
Sent: Tuesday, August 11, 2020 5:50 PM
To: Jiang, Guomin <guomin.jiang@intel.com>
Cc: devel@edk2.groups.io; jeremy.linton@arm.com
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/UsbBusDxe: some USB PenDisk fails enumeration.

Hello, Mr. Jiang,

Thank for the review.

The original enumeration steps in the function of UsbEnumerateNewDev of file UsbEnumer.c: 1 reset the port, 2 set the usb device address, 3 get the Max Packet Size, 4 get the full device descriptor. However, when plugging a USB PenDisk with Innostor USB

controller chip (VID=0x1F75, PID=0x917, USB3.1), the fourth step always fails, trace as below:

========

XhcCheckUrbResult: TRANSACTION_ERROR! Completecode = 4 XhcControlTransfer: error - Device Error, transfer - 40 UsbGetOneConfig: failed to get full descript Device Error UsbBuildDescTable: failed to get configure (index 0) UsbEnumerateNewDev: failed to build descriptor table - Device Error

=======

The host controller need to get the full device descriptor, but this moment, the Pendisk device doesn't response any more. Then timeout. and UsbEnumerateNewDev complains : failed to build descriptor.

We have three Pendisks from different manufacturers, all with Innostor USB controller chip. they all can't be enumerated all. And we observed the problem on both Huawei KunPeng(华为鲲鹏）and Loognson（龙芯）platforms.

The three Pendisks always fail the USB enumeration. Other USB 2.0 and USB 3.0 on hand can work well.

With the patch, the three pendisks and other pendisks can all work well.

THanks

--

Best Regards

Feng Libo

ZD Technology (Beijing) Co., Ltd

发件人："Jiang, Guomin" <guomin.jiang@intel.com>
发送日期：2020-08-11 08:21:10
收件人："devel@edk2.groups.io" <devel@edk2.groups.io>,"Jiang, Guomin" <guomin.jiang@intel.com>,"lbfeng@zd-tech.com.cn" <lbfeng@zd-tech.com.cn>
抄送人："jeremy.linton@arm.com" <jeremy.linton@arm.com>
主题：RE: [edk2-devel] [PATCH] MdeModulePkg/UsbBusDxe: some USB PenDisk fails enumeration.

+Jeremy,

I review the patch and think it is reasonable, but I want to know some more detail information

1. Can you provide the detail debug log about USB?
2. The symptom always can be seen or have fail rate?

Best Regards

Guomin

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Guomin Jiang
Sent: Thursday, August 6, 2020 12:29 PM
To: devel@edk2.groups.io; lbfeng@zd-tech.com.cn
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/UsbBusDxe: some USB PenDisk fails enumeration.

I will review it by next weekend(8/14).

Thanks.

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Feng Libo
Sent: Thursday, August 6, 2020 9:25 AM
To: Feng Libo <lbfeng@zd-tech.com.cn>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/UsbBusDxe: some USB PenDisk fails enumeration.

Hello, 

could anyone review this PATCH?

We encountered the USB enumeration problem and the patch is based on the Microsoft post as below.

https://techcommunity.microsoft.com/t5/microsoft-usb-blog/how-does-usb-stack-enumerate-a-device/ba-p/270685#:~:text=%20How%20does%20USB%20stack%20enumerate%20a%20device%3F,a%20request%20for%20the%20USB%20Device...%20More%20

Thanks

Best Regards

Feng Libo