From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web12.1643.1586483151683714002 for ; Thu, 09 Apr 2020 18:45:52 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=Ty7x/B4J; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: guomin.jiang@intel.com) IronPort-SDR: ht0IwvxQUxB7v+FeSJPzktNa5ufOnNUDeM4K3HCqthI9dUDaep68ppT1OWsnSuv7vqfARxvo6U cuDsSBWr7izw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2020 18:45:50 -0700 IronPort-SDR: 1lx/kjLoCi0u126mK0nL/PL8L106BOwDLLsMKPYUS3HdTUtZ4nR5TaPPtBPEwPfta2jfHBfE0M GCnmClR0ojpw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,364,1580803200"; d="scan'208";a="259650467" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by orsmga008.jf.intel.com with ESMTP; 09 Apr 2020 18:45:50 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Apr 2020 18:45:49 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 9 Apr 2020 18:45:49 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 9 Apr 2020 18:45:49 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.106) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Apr 2020 18:45:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YOS+/O8OB0tsJVomnCaRvO5msbhhqTOSaIaWpsizPPtkMe/jAOcybL4j8EArNaSdZvtBvrWxL/3PkWIt89iBFUDc3CsyeUofJ/whPjqhurX1CfrHfJqNEm5qMbTnWH8OTDakXVx1oREywjEBstE0a1k06LobEpQHCJrRxraIQ1GlMwfV+5FoFcJ4uAatCbTpMrEVTWLkqa3iP7siYKxtzCT3yJ/2nUPezyzJNfCAcjCWbXU+DJj/yQ33f+8mIHfTPLOxRjbEpDDuqulXfElg18M8KqSqwxHEz1I91XZ/W2hmTT/dFxq6q8uAp0MHFto1hu355qKutRv1uaQjVTwcog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tMAHt3YZ4vsF/WRpjvULn8eKbKLMSiXBlG0GIU54cys=; b=k+iZH8o2pMrYk/DS6qDycAdpFFkCmM9PuWKpf+9S/4seabXztxcRXnSZ2ZAxTgmKbpQcqw/MNfx0K/86nC5PWaXeJvfQqnhoyzOaN7cRX5BLsgZFo5HU68RnMwgCOHPEBnOGJnP/RsCVB3a5mEcnJoll633p/RYOTXXuXWPZ0xDlb6Fty6wOMh66mfmfgnQMJa7Wn5dxhyCmdjYzyy1ibA8vW6XfDQJtEI/w42H2HNuBPzyXJrFjej2fRxgeoZAJeU1rqyLs2K0O4ocyd4B0Djq1MUAFcUDJLkCVhc4xjA2WwBLaTtCnCHiYCVANY6HNHxGf135CxFV0KbLxplC/+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tMAHt3YZ4vsF/WRpjvULn8eKbKLMSiXBlG0GIU54cys=; b=Ty7x/B4JtjH3/yAl8N71qlhVmxYCiE1lhKNpZwNj9mf0kWSizOWr1GD3tafw5HHGp+mzb8vDRQXYFMeCOnS4mAcTcuMAEknu13F5RXbRM4h48yuYA7pWIP3NMOoSSSNHGpOc/lJbew/qeT4GTe1IXUPeOsaKmJ0dmTckrYJMOnI= Received: from DM6PR11MB2955.namprd11.prod.outlook.com (2603:10b6:5:65::31) by DM6PR11MB3770.namprd11.prod.outlook.com (2603:10b6:5:13c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.20; Fri, 10 Apr 2020 01:45:45 +0000 Received: from DM6PR11MB2955.namprd11.prod.outlook.com ([fe80::f1ec:734d:b127:4519]) by DM6PR11MB2955.namprd11.prod.outlook.com ([fe80::f1ec:734d:b127:4519%3]) with mapi id 15.20.2878.022; Fri, 10 Apr 2020 01:45:44 +0000 From: "Guomin Jiang" To: "devel@edk2.groups.io" , "michael.kubacki@outlook.com" CC: "Bi, Dandan" , "Wu, Hao A" , "Wang, Jian J" , "Gao, Liming" , "Kinney, Michael D" , Sean Brogan Subject: Re: [edk2-devel] [PATCH v1 1/7] MdePkg/BaseLib: Add linked list iteration macros Thread-Topic: [edk2-devel] [PATCH v1 1/7] MdePkg/BaseLib: Add linked list iteration macros Thread-Index: AQHWDqpowc8fCJAbt0igIApWdyKp06hxlf4w Date: Fri, 10 Apr 2020 01:45:44 +0000 Message-ID: References: <20200409200514.32796-1-michael.kubacki@outlook.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: spf=none (sender IP is ) smtp.mailfrom=guomin.jiang@intel.com; x-originating-ip: [192.55.52.200] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c4c7ea44-c936-458e-7a56-08d7dcf0e2a7 x-ms-traffictypediagnostic: DM6PR11MB3770: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3173; x-forefront-prvs: 0369E8196C x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB2955.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10019020)(376002)(366004)(136003)(346002)(396003)(39860400002)(4326008)(81156014)(55016002)(8676002)(33656002)(966005)(45080400002)(110136005)(478600001)(2906002)(86362001)(186003)(9686003)(316002)(54906003)(64756008)(8936002)(7696005)(71200400001)(5660300002)(66556008)(76116006)(52536014)(81166007)(66476007)(66946007)(6506007)(66446008)(53546011)(26005);DIR:OUT;SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /i+pCC2q2OYEmDB0K9cvH0+CehqS69WRzVS8y/zTmVO0LamahJ2A/fGDSGDel7Wa+2YAFQrzUcqHdphp0nsbeerhTCJYPLgmZq1c+++hvBwPIoGFHHKV0PldFxEhE5fSrfbhLTR1cj2i41rFKqtp3x8AO8JXhTMl8qV+AeUqPcZPOdhoTJpOFRhMyg7KlI0gwduuxdSy4PA8MGyZGifVsCkO+Y3VyOkMRIpDBfO8dSVobPcfwJZlSty5RdQFBpYFN2ZmG9ewqd37N058UuU3wbgdq/2Xs3qeKt2JyuFcPyJZ1CD1/mfx+xxa7V8t7SesXMrJmUpkcDBilJRxZZ7gbjBlaoNfFV9Ewvd369gls2HeWY4R/qrLqR6C1pAVX2lTvlSc16HcIh2ZxCCvAbvpgtzF2pqTB0spIOvYhN8xFPyV34JxjPo9T00sv0cNgAnEp5LWml+n6jcZlgP4o2BiY+jEQ2rFmAyRZbRFQ9+nJDsjF7gizD4kTchz1ZLbK00etGPvM2HnNekPfeUaksdM6Q== x-ms-exchange-antispam-messagedata: YyeqrCOYAeK/J/EUwhay9uYUsVzSRCun6EpUCSgOZ1sKeweXfVzhUZtLG4ElR56f7ovtne/nZan9JhtuC+nWbLW5ADvpOP2u5EVVZUBTfJlJyAXvIWeKHss0oYbDZgXmTbgDgAMKq2x7ej7wRQs95w== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: c4c7ea44-c936-458e-7a56-08d7dcf0e2a7 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Apr 2020 01:45:44.7613 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: d8pJfPHGGp1IN5Muu1rU5i4cWQ2LNYbB8+RCZv7HG2s1Ab6EiTC8hGGw8lYyiFV7uOrySoysO4Wh9B+6ot9cWw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3770 Return-Path: guomin.jiang@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Guomin Jiang > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Friday, April 10, 2020 4:05 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Wu, Hao A ; > Wang, Jian J ; Gao, Liming = ; > Kinney, Michael D ; Sean Brogan > > Subject: [edk2-devel] [PATCH v1 1/7] MdePkg/BaseLib: Add linked list > iteration macros >=20 > From: Michael Kubacki >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D1959 >=20 > The macros EFI_LIST_FOR_EACH and EFI_LIST_FOR_EACH_SAFE have been > duplicated across several drivers. These macros have proven useful and > established a commonly used pattern for linked list iteration. >=20 > This change defines the macros in BaseLib.h alongside other generic link= ed > list macros and functions. >=20 > Cc: Dandan Bi > Cc: Hao A Wu > Cc: Jian J Wang > Cc: Liming Gao > Cc: Michael D Kinney > Cc: Sean Brogan > Signed-off-by: Michael Kubacki > --- > MdePkg/Include/Library/BaseLib.h | 27 ++++++++++++++++++++ > 1 file changed, 27 insertions(+) >=20 > diff --git a/MdePkg/Include/Library/BaseLib.h > b/MdePkg/Include/Library/BaseLib.h > index ecadff8b235e..d066f1be2495 100644 > --- a/MdePkg/Include/Library/BaseLib.h > +++ b/MdePkg/Include/Library/BaseLib.h > @@ -4,6 +4,7 @@ >=20 > Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.
> Portions copyright (c) 2008 - 2009, Apple Inc. All rights reserved.
> +Copyright (c) Microsoft Corporation.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -2972,6 +2973,32 @@ PathCleanUpDirectories( **/ #define > INITIALIZE_LIST_HEAD_VARIABLE(ListHead) {&(ListHead), &(ListHead)} >=20 > +/** > + Iterates over each node in a doubly linked list using each node's for= ward > link. > + > + @param Entry A pointer to a list node used as a loop cursor duri= ng > iteration > + @param ListHead The head node of the doubly linked list > + > +**/ > +#define BASE_LIST_FOR_EACH(Entry, ListHead) \ > + for(Entry =3D (ListHead)->ForwardLink; Entry !=3D (ListHead); Entry = =3D > +Entry->ForwardLink) > + > +/** > + Iterates over each node in a doubly linked list using each node's > +forward link > + with safety against node removal. > + > + This macro uses NextEntry to temporarily store the next list node so > + the node pointed to by Entry may be deleted in the current loop > + iteration step and iteration can continue from the node pointed to by > NextEntry. > + > + @param Entry A pointer to a list node used as a loop cursor duri= ng > iteration > + @param NextEntry A pointer to a list node used to temporarily store > + the next node @param ListHead The head node of the doubly linked > + list > + > +**/ > +#define BASE_LIST_FOR_EACH_SAFE(Entry, NextEntry, ListHead) = \ > + for(Entry =3D (ListHead)->ForwardLink, NextEntry =3D Entry->ForwardLi= nk;\ > + Entry !=3D (ListHead); Entry =3D NextEntry, NextEntry =3D > +Entry->ForwardLink) >=20 > /** > Checks whether FirstEntry and SecondEntry are part of the same doubly= - > linked > -- > 2.16.3.windows.1 >=20 >=20 >=20