From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web10.13593.1589984554212954449 for ; Wed, 20 May 2020 07:22:34 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=N4Qn93pZ; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: liming.gao@intel.com) IronPort-SDR: WVzcNfc5h6oa9iaP5WgNDF190R//5YXQL6259A7jK/CG9kws4gvZPuf+9x9cnmlWe3xvE0G1jR ilRnaXGtHVAw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2020 07:22:32 -0700 IronPort-SDR: 3JqQ5kD/EDecygnQkOMoe8do8UDQ5mSgPYPbdLRE+yI7rSCT5CHBII4DlIQ3jhrbGTdXtf1V9b blY3xbUvLUag== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,414,1583222400"; d="scan'208";a="264700589" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga003.jf.intel.com with ESMTP; 20 May 2020 07:22:33 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 20 May 2020 07:22:32 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 20 May 2020 07:22:32 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 20 May 2020 07:22:32 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 20 May 2020 07:22:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B/aRai5rn6YAbRrMA3LFICpTupRZI1gwlvwwnWAhtjSnIBpnPVn5690uIuo2o1QVUPhEfG4IhxaALLnvLuCnDThVqYADVM8ftum4FG16WVpl2c5QshfxiV6+IP5ovTNzlBLNkj1OCP9WOeUblmpYCcvI0WC51EqhwCAAerhaYvx6AfM6zm/ManvDgWZ0bAYsJV/7OLIq+Z0y+jq6BOr63sOoRVaV4JVQky6qrbIbxlKlUo7Exap6SOk3WVPngOenmBcc/D0a7ZCb/lyVKCW2VRWPR/cc8y4+GvTtcgtXaIpo9+1c0B21SeQKkwoxGYxyPRAKAWwWVuPKXOVWyXxL7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LOeqedJH9HwOhfYPFk/cDO6R5kIh5TnizijGk/fx2sg=; b=lFBMyzcZflmP9aVijG2qJxFh6YmBcwjvGiK1Zbh8HqFI+y4nybq/tidM70Rw7A4goz4wCFw1Fc6suLeFKVP7LTxcSWoEAVZmABj0UgONl+TLg1mncDMvGk5Bwf7eQqJ/sBqL6mlHuSX/By1sdIASylEmw6cvX84SlbveXgZ/PL6vG8yNZjuXcFUQfhA637X3ORMNzL2d5uFq+4+jnM5Vdnz8V2N1ssZ+id4R138N9nhRMoDQ4BbcMrMwyw6OtV7ib9bBEH0guuqmCARCyX0S+RnBnY32OXLovV5SsERoLBP7IpNZY4t0kzlsUIPN1Z8gytMIkaQHUZnvBNZpuF863A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LOeqedJH9HwOhfYPFk/cDO6R5kIh5TnizijGk/fx2sg=; b=N4Qn93pZNoVP3pgwig56CsyKot5XWx0hPVwG4rYYVgEeDKSfkYW/FGLG8lzUZt5FOu1Q7a5tp+4HZgQMRPEW0g0FvGmq/Pq7ltkqFHdkwvSwf+bqqjyXTuAKXdLhrA8iLKFhLl1Xl0zbYj5u1//rLrMtutyi/lQiumcfZL72Q4A= Received: from DM6PR11MB3195.namprd11.prod.outlook.com (2603:10b6:5:5d::17) by DM6PR11MB3051.namprd11.prod.outlook.com (2603:10b6:5:61::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.27; Wed, 20 May 2020 14:22:25 +0000 Received: from DM6PR11MB3195.namprd11.prod.outlook.com ([fe80::e920:42f3:eb13:1234]) by DM6PR11MB3195.namprd11.prod.outlook.com ([fe80::e920:42f3:eb13:1234%7]) with mapi id 15.20.3021.020; Wed, 20 May 2020 14:22:24 +0000 From: "Liming Gao" To: "devel@edk2.groups.io" , "oleksiyy@ami.com" CC: "Kinney, Michael D" , "Wang, Jian J" , "Wu, Hao A" , "Yao, Jiewen" , "Zhang, Chao B" , "Felix Polyudov" , "Xu, Wei6" Subject: Re: [edk2-devel] [PATCH V7 5/6] MdeModulePkg: Add FMP Capsule Image Header extension Thread-Topic: [edk2-devel] [PATCH V7 5/6] MdeModulePkg: Add FMP Capsule Image Header extension Thread-Index: AQHWKjGuApjYXW0ffEakQn6+iPmvr6ioqmYQgAXDNwCAACmVsIACcZcAgAAG42A= Date: Wed, 20 May 2020 14:22:24 +0000 Message-ID: References: <20200514205145.36956-1-oleksiyy@ami.com> <20200514205145.36956-6-oleksiyy@ami.com> <6BD875C24FFE2A4E8D6EFC142C67836F03FFFFA5E6@atlms1.us.megatrends.com> <6BD875C24FFE2A4E8D6EFC142C67836F03FFFFA722@atlms1.us.megatrends.com> In-Reply-To: <6BD875C24FFE2A4E8D6EFC142C67836F03FFFFA722@atlms1.us.megatrends.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.213] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fdffd9f6-5b11-4c8f-7984-08d7fcc937b8 x-ms-traffictypediagnostic: DM6PR11MB3051: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-forefront-prvs: 04097B7F7F x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3cakUf5rgB0p0dH8sWGxMEen3aFBRtDI73rhGLmvVvcsndp95EUBYDiRMMlQQSYPZohMGguTIFQYc/mIjhEP8RI6+olv5KFMo+njuC6V/cmyucBeb5V+pw8HTAa9lvaSKF3V1h2bvl8p3bFXwmYS1vw79DqnjVGp8Y4Dyos1bB2mF/T0l+pKrtZZ7JAHEbcbjrrBm2Nw4M4CO2Zm0iyp8r4WZTm1vQS4tO2Kap3JUTBGSB/6FH8zVwsX+Yxf/3drC6NIttfKWpo8eOZL+rU3NW7ggOjsTXehNIeouqOrRinq44xQgpRyBQPnLMqRiQasrIYUIRGB6MU5RCmtwolPUpmg0Y7Ad0Xce6VrxwWvJMoWGMapILTYcpOyuPvctNDOX0l3q7faFbZhm6lBsdnz7I9G7IxO0OD0C9KxWj/w2zt8xejd8bpWATjhT0xEWVdFRi5ZNzY+7aiJv4mJKP76mcCNWHLbh2erDhC9c+GzRQMH2HVJWQ7KrlD/TecynMeBAYJ9k4r+GFHgOu9yOquiDg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB3195.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(376002)(396003)(346002)(366004)(136003)(39860400002)(54906003)(86362001)(30864003)(8676002)(186003)(107886003)(33656002)(5660300002)(966005)(478600001)(26005)(2906002)(316002)(71200400001)(53546011)(7696005)(6506007)(110136005)(4326008)(52536014)(66446008)(55016002)(66476007)(66946007)(66556008)(64756008)(8936002)(76116006)(9686003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: boJ8ZQn5Bbly8nG3mxZrDErmxs8YgJQBlqlKpMhBkkEIVofsZRMJ47KvQMBCKmUocXvsSUXhsP3+uw/6UlP3a+j0gOLPAR/LXm1dcLqeWJm78ju2cCR606rqzFgkpqtS+2n7uS4FcOxjjqp5f0e6nQaR6wwmvE5ETwwaS6kqTupkRAsmYi6KG7PobhThVSVLIs2xHLse4yo4a9vovN4I8DvOLFwz9dsh1IfCG7e4FE/vAtg7kio7Lg5rlUy+49To5CHIxMcv0y7mOnUhFXoPQUqphHQdcHFghZsOIYwjQZyqeFX/uUYjuB6tJcDaDbXq1GQpbjByMtvAzZRKYfgpCSeMWzDzXBirx8zY0J3kyym9tH6qNKYMMpUH5enZZgyvzcfKPJiDqdbxBuLYCHgMMsSeaSY5zzlQThhMEMW2jwpT2mtNoA7ww5ZWhhBU0cmPHCVlRaYvLS4dbWBMaD8d9Kc/XWVZUQMhk3ap3nE/kRVehsHgMtrnuyBit5bd42xw MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: fdffd9f6-5b11-4c8f-7984-08d7fcc937b8 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2020 14:22:24.6868 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GbtjvALKiAnis+oj1c3t8fHYhoXSobpZX4wDk9WQo8mASLpf3b6ObFM79ers46y1DIoDX2DUTfvr5dnROM81eQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3051 Return-Path: liming.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable PR https://github.com/tianocore/edk2/pull/635 has been created for UEFI28a. > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Oleksiy Y= akovlev > Sent: Wednesday, May 20, 2020 9:57 PM > To: Gao, Liming ; devel@edk2.groups.io > Cc: Kinney, Michael D ; Wang, Jian J ; Wu, Hao A ; Yao, > Jiewen ; Zhang, Chao B ; F= elix Polyudov ; Xu, Wei6 > > Subject: Re: [edk2-devel] [PATCH V7 5/6] MdeModulePkg: Add FMP Capsule I= mage Header extension >=20 > Hi Lining, Wei. >=20 > Can you speed up pushing of 2.8a patches? >=20 > Regards, Oleksiy. >=20 > -----Original Message----- > From: Gao, Liming [mailto:liming.gao@intel.com] > Sent: Monday, May 18, 2020 8:40 PM > To: devel@edk2.groups.io; Oleksiy Yakovlev > Cc: Kinney, Michael D; Wang, Jian J; Wu, Hao A; Yao, Jiewen; Zhang, Chao= B; Felix Polyudov; Xu, Wei6 > Subject: RE: [edk2-devel] [PATCH V7 5/6] MdeModulePkg: Add FMP Capsule I= mage Header extension >=20 > Oleksiy: > Wei has sent the updated patches for the changes in MdeModulePkg and S= ignedCapsulePkg. > https://edk2.groups.io/g/devel/message/59652 >=20 > He bases on your patch and does some updated. Please help review wheth= er it is ok to you. You don't need to submit this patch set > again. >=20 > Thanks > Liming > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Oleksiy= Yakovlev > > Sent: Tuesday, May 19, 2020 6:10 AM > > To: Gao, Liming ; devel@edk2.groups.io > > Cc: Kinney, Michael D ; Wang, Jian J ; Wu, Hao A ; Yao, > > Jiewen ; Zhang, Chao B ;= Felix Polyudov ; Xu, Wei6 > > > > Subject: Re: [edk2-devel] [PATCH V7 5/6] MdeModulePkg: Add FMP Capsule= Image Header extension > > > > Hi Liming. > > > > From Your comment here I understand that you are waiting for somebody = else here. > > But looking through your comments - I agree with comment 1, but think = other two are incorrect. > > So do I need to resubmit 2.8a series? > > > > Regards, Oleksiy. > > > > > > > > -----Original Message----- > > From: Gao, Liming [mailto:liming.gao@intel.com] > > Sent: Friday, May 15, 2020 2:13 AM > > To: Oleksiy Yakovlev; devel@edk2.groups.io > > Cc: Kinney, Michael D; Wang, Jian J; Wu, Hao A; Yao, Jiewen; Zhang, Ch= ao B; Felix Polyudov; Xu, Wei6 > > Subject: RE: [PATCH V7 5/6] MdeModulePkg: Add FMP Capsule Image Header= extension > > > > Oleksiy: > > When create PR, I find some issue in this patch. The same issue is a= lso in SignedCapsulePkg. Because original comments from Xu > > Wei6, I would like Wei to provide the updated patch for MdeModulePkg a= nd SignedCapsulePkg. > > > > Thanks > > Liming > > > -----Original Message----- > > > From: Oleksiy Yakovlev > > > Sent: Friday, May 15, 2020 4:52 AM > > > To: devel@edk2.groups.io > > > Cc: Gao, Liming ; Kinney, Michael D ; Wang, Jian J ; > > Wu, > > > Hao A ; Yao, Jiewen ; Zhan= g, Chao B ; Felixp@ami.com; > > > oleksiyy@ami.com > > > Subject: [PATCH V7 5/6] MdeModulePkg: Add FMP Capsule Image Header e= xtension > > > > > > Add bitmask to structure which gives a binary-inspectable mechanism = to > > > determine if a capsule contains an authentication section or depex s= ection. > > > (UEFI 2.8 errata a, mantis 2026) > > > > > > Signed-off-by: Oleksiy Yakovlev > > > > > > Reviewed-by: Wei6 Xu > > > --- > > > MdeModulePkg/Application/CapsuleApp/CapsuleDump.c | 7 ++++-- > > > .../Library/DxeCapsuleLibFmp/DxeCapsuleLib.c | 26 +++++++++++= ++++++----- > > > 2 files changed, 25 insertions(+), 8 deletions(-) > > > > > > diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c b/Mde= ModulePkg/Application/CapsuleApp/CapsuleDump.c > > > index 7e3e072..057bfa8 100644 > > > --- a/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c > > > +++ b/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c > > > @@ -96,8 +96,11 @@ DumpFmpCapsule ( > > > Print(L" UpdateImageIndex - 0x%x\n", FmpImageHeader->Upd= ateImageIndex); > > > Print(L" UpdateImageSize - 0x%x\n", FmpImageHeader->Upd= ateImageSize); > > > Print(L" UpdateVendorCodeSize - 0x%x\n", FmpImageHeader->Upd= ateVendorCodeSize); > > > - if (FmpImageHeader->Version >=3D EFI_FIRMWARE_MANAGEMENT_CAPSUL= E_IMAGE_HEADER_INIT_VERSION) { > > > - Print(L" UpdateHardwareInstance - 0x%lx\n", FmpImageHeader->= UpdateHardwareInstance); > > > + if (ImageHeader->Version >=3D 1) { > > > + DEBUG((DEBUG_VERBOSE, " UpdateHardwareInstance - 0x%lx\n", I= mageHeader->UpdateHardwareInstance)); > > > + if (ImageHeader->Version >=3D EFI_FIRMWARE_MANAGEMENT_CAPSULE= _IMAGE_HEADER_INIT_VERSION) { > > > + DEBUG((DEBUG_VERBOSE, " ImageCapsuleSupport - 0x%lx\n",= ImageHeader->ImageCapsuleSupport)); > > > + } > > > } > > > } > > [Liming] Here should be FmpImageHeader > > > > > } > > > diff --git a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c > > b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c > > > index 5dda561..68cece6 100644 > > > --- a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c > > > +++ b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c > > > @@ -285,8 +285,10 @@ ValidateFmpCapsule ( > > > DEBUG((DEBUG_ERROR, "ImageHeader->Version(0x%x) Unknown\n", I= mageHeader->Version)); > > > return EFI_INVALID_PARAMETER; > > > } > > > - if (ImageHeader->Version < EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAG= E_HEADER_INIT_VERSION) { > > > + if (ImageHeader->Version =3D=3D 1) { > > > FmpImageHeaderSize =3D OFFSET_OF(EFI_FIRMWARE_MANAGEMENT_CAPS= ULE_IMAGE_HEADER, UpdateHardwareInstance); > > > + } else { > > > + FmpImageHeaderSize =3D OFFSET_OF(EFI_FIRMWARE_MANAGEMENT_CAPS= ULE_IMAGE_HEADER, ImageCapsuleSupport); > > > } > > > > [Liming] Here should have one condition for ImageHeader->Version =3D= =3D 2. > > > > > if (FmpImageSize < FmpImageHeaderSize) { > > > DEBUG((DEBUG_ERROR, "FmpImageSize(0x%lx) < FmpImageHeaderSize= (0x%x)\n", FmpImageSize, FmpImageHeaderSize)); > > > @@ -519,8 +521,11 @@ DumpFmpCapsule ( > > > DEBUG((DEBUG_VERBOSE, " UpdateImageIndex - 0x%x\n", Im= ageHeader->UpdateImageIndex)); > > > DEBUG((DEBUG_VERBOSE, " UpdateImageSize - 0x%x\n", Im= ageHeader->UpdateImageSize)); > > > DEBUG((DEBUG_VERBOSE, " UpdateVendorCodeSize - 0x%x\n", Im= ageHeader->UpdateVendorCodeSize)); > > > - if (ImageHeader->Version >=3D EFI_FIRMWARE_MANAGEMENT_CAPSULE_I= MAGE_HEADER_INIT_VERSION) { > > > - DEBUG((DEBUG_VERBOSE, " UpdateHardwareInstance - 0x%lx\n",= ImageHeader->UpdateHardwareInstance)); > > > + if (ImageHeader->Version >=3D 1) { > > [Liming] Here should be ImageHeader->Version >=3D 2. > > > > Thanks > > Liming > > > + DEBUG((DEBUG_INFO, "(UpdateHardwareInstance - 0x%x)", ImageHe= ader->UpdateHardwareInstance)); > > > + if (ImageHeader->Version >=3D EFI_FIRMWARE_MANAGEMENT_CAPSULE= _IMAGE_HEADER_INIT_VERSION) { > > > + DEBUG((DEBUG_INFO, "(ImageCapsuleSupport - 0x%x)", ImageHe= ader->ImageCapsuleSupport)); > > > + } > > > } > > > } > > > } > > > @@ -928,9 +933,14 @@ SetFmpImageData ( > > > } else { > > > // > > > // If the EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HEADER is versi= on 1, > > > - // Header should exclude UpdateHardwareInstance field > > > + // Header should exclude UpdateHardwareInstance field, and > > > + // ImageCapsuleSupport field if version is 2. > > > // > > > - Image =3D (UINT8 *)ImageHeader + OFFSET_OF(EFI_FIRMWARE_MANAGEM= ENT_CAPSULE_IMAGE_HEADER, > > > UpdateHardwareInstance); > > > + if (ImageHeader->Version =3D=3D 1) { > > > + Image =3D (UINT8 *)ImageHeader + OFFSET_OF(EFI_FIRMWARE_MANAG= EMENT_CAPSULE_IMAGE_HEADER, > > > UpdateHardwareInstance); > > > + } else { > > > + Image =3D (UINT8 *)ImageHeader + OFFSET_OF(EFI_FIRMWARE_MANAG= EMENT_CAPSULE_IMAGE_HEADER, > > ImageCapsuleSupport); > > > + } > > > } > > > > > > if (ImageHeader->UpdateVendorCodeSize =3D=3D 0) { > > > @@ -945,6 +955,7 @@ SetFmpImageData ( > > > DEBUG((DEBUG_INFO, "ImageIndex - 0x%x ", ImageHeader->UpdateImage= Index)); > > > if (ImageHeader->Version >=3D EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMA= GE_HEADER_INIT_VERSION) { > > > DEBUG((DEBUG_INFO, "(UpdateHardwareInstance - 0x%x)", ImageHead= er->UpdateHardwareInstance)); > > > + DEBUG((DEBUG_INFO, "(ImageCapsuleSupport - 0x%x)", ImageHeader-= >ImageCapsuleSupport)); > > > } > > > DEBUG((DEBUG_INFO, "\n")); > > > > > > @@ -1239,7 +1250,10 @@ ProcessFmpCapsuleImage ( > > > ImageHeader =3D (EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HEADER = *)((UINT8 *)FmpCapsuleHeader + > > > ItemOffsetList[Index]); > > > > > > UpdateHardwareInstance =3D 0; > > > - if (ImageHeader->Version >=3D EFI_FIRMWARE_MANAGEMENT_CAPSULE_I= MAGE_HEADER_INIT_VERSION) { > > > + /// > > > + /// UpdateHardwareInstance field was added in Version 2 > > > + /// > > > + if (ImageHeader->Version >=3D 2) { > > > UpdateHardwareInstance =3D ImageHeader->UpdateHardwareInstanc= e; > > > } > > > > > > -- > > > 2.9.0.windows.1 > > > > > > > > > Please consider the environment before printing this email. > > > > > > The information contained in this message may be confidential and pr= oprietary to American Megatrends (AMI). This > > communication > > > is intended to be read only by the individual or entity to whom it i= s addressed or by their designee. If the reader of this message > is > > > not the intended recipient, you are on notice that any distribution = of this message, in any form, is strictly prohibited. Please > > > promptly notify the sender by reply e-mail or by telephone at 770-24= 6-8600, and then delete or destroy all copies of the > > transmission. > > > > Please consider the environment before printing this email. > > > > The information contained in this message may be confidential and prop= rietary to American Megatrends (AMI). This > communication > > is intended to be read only by the individual or entity to whom it is = addressed or by their designee. If the reader of this message is > > not the intended recipient, you are on notice that any distribution of= this message, in any form, is strictly prohibited. Please > > promptly notify the sender by reply e-mail or by telephone at 770-246-= 8600, and then delete or destroy all copies of the > transmission. > > > > >=20 >=20 > Please consider the environment before printing this email. >=20 > The information contained in this message may be confidential and propri= etary to American Megatrends (AMI). This communication > is intended to be read only by the individual or entity to whom it is ad= dressed or by their designee. If the reader of this message is > not the intended recipient, you are on notice that any distribution of t= his message, in any form, is strictly prohibited. Please > promptly notify the sender by reply e-mail or by telephone at 770-246-86= 00, and then delete or destroy all copies of the transmission. >=20 >=20