From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web11.2380.1591838971618788039 for ; Wed, 10 Jun 2020 18:29:31 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=yVXqckK4; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: eric.dong@intel.com) IronPort-SDR: foW+VKOsC3/g12udDRFozgZ2lL18nUZM3iCmbpH6M4xnkbBK3b/vQEy192GS/Sag8LjTkABdEw MJhOEviiJ8Ug== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2020 18:29:30 -0700 IronPort-SDR: T1fT0naDcIc0hU13wYKt3DpLZk6NpYbrxwOR/6KCrEqEL+b4Zu2CtXheyPIljFBJ3/yB+NJkXY cLjQpC9upGFA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,498,1583222400"; d="scan'208,217";a="418944145" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by orsmga004.jf.intel.com with ESMTP; 10 Jun 2020 18:29:30 -0700 Received: from orsmsx111.amr.corp.intel.com (10.22.240.12) by ORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 10 Jun 2020 18:29:30 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX111.amr.corp.intel.com (10.22.240.12) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 10 Jun 2020 18:29:30 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.172) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 10 Jun 2020 18:29:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WK3FuVwNf5ehVqUiqbedzBVapGK+c6phhAbYMM0Wd2rRRznJ4gQYNUtXIvLLAsi5v1Z6OlACRkngNOUim3fn+gz4K2nqsgiA2idXiUNQWzLVlU0Bhvg4xZdFFNR5X7DQObOm5De/kLP298z37Yus+9gqBgxBi6spPhQ6LA5AmKrjhLMrx4hhuOrrIuWDFswV9lVChscByLfM8n0NGyHuQihloQd2dVIw86nMlA+qD9oPD9FtV7wEB/ZD3mfO0tuIHMjNQMaJ3jrcG6/+Ig1Z/SO/7MabqftXpZeKy/pqXDZpaSln6ZHRai9lWjHw8MlHkzZuITyUiSYTSVqp22Q/LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HJhBsiKxI7cQJl473qUo5zPIHkdfNENJzhpKstBYFvw=; b=IS7IR+c1CpQS8GC9jLV2p9COa8VMyw2N9tjxagnjMtiI2pkjDt0CAS++rdIODrF3u8XOS2T5jqOq1w1Ij0oOuyuNP5oidi6Q4F7bfeHtYTMx0/8wN7FdD3iG8O1h/59emr53h0d1Jx5pMtZhGEr/HFLEt1lF7Il86HgSSF3MpHSJQMISRL8QduZFE//MJOTsq8TXsgpOYd9BywAYohqQjD+E3dtp9RZ3l0uLBQbtmtO0Xpw41rW/X48fU3ZXtdvCNrwga+1FuLcHKLbmRnoB81YnfyMSLrgaCWdEvVpWc8A43IrYFqOuzvhTKjYtKskEHXMvCaIr1M15KOi2HJxNDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HJhBsiKxI7cQJl473qUo5zPIHkdfNENJzhpKstBYFvw=; b=yVXqckK4xZ0r1Seq7GuCdbgJYSlK1EPMr7RoC7UIcN5IJhbpsVkmtiGuUGbdlzc+FPJn8P1AE7nhRUYsIDhBn7VjbSqFv3PueR8HApLLxFE/ga1bpOssgAFmFiDu+OQ752MRqmQ9SpAfG7H3Q+ljPgle5GpzqVEIXho5Tqe565k= Received: from DM6PR11MB3274.namprd11.prod.outlook.com (2603:10b6:5:b::26) by DM6PR11MB3386.namprd11.prod.outlook.com (2603:10b6:5:5c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.18; Thu, 11 Jun 2020 01:29:28 +0000 Received: from DM6PR11MB3274.namprd11.prod.outlook.com ([fe80::cc01:6f05:1402:e7d7]) by DM6PR11MB3274.namprd11.prod.outlook.com ([fe80::cc01:6f05:1402:e7d7%6]) with mapi id 15.20.3088.019; Thu, 11 Jun 2020 01:29:27 +0000 From: "Dong, Eric" To: "Ni, Ray" , "devel@edk2.groups.io" , "garrett.kirkendall@amd.com" CC: Laszlo Ersek Subject: Re: UefiCpuPkg: Discuss: Move StandardSignatureIsAuthenticAMD function to BaseUefiCpuLib Thread-Topic: UefiCpuPkg: Discuss: Move StandardSignatureIsAuthenticAMD function to BaseUefiCpuLib Thread-Index: AdY/LxrU4UeZwuEKT3qg1oH+0DYgTwAXZggwAACawuA= Date: Thu, 11 Jun 2020 01:29:27 +0000 Message-ID: References: <734D49CCEBEEF84792F5B80ED585239D5C5AB095@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C5AB095@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Enabled=true; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_SetDate=2020-06-10T13:48:24Z; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Method=Privileged; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Name=Public_0; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_ActionId=a0aba147-89af-413a-9a26-cb37e91c8949; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_ContentBits=1 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.210] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bed9ac78-11f7-4c7a-5b43-08d80da6e1f9 x-ms-traffictypediagnostic: DM6PR11MB3386: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 0431F981D8 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rO23Jay1jsTj6v+RnSmbPxp9fvf3H4xftfF5IGrvqti4619gLnrlNA6eRqvIIiLFD6RlcLGSXFmpEtQDNClv7RwJaK9QNvYIiXui66g8GHepus2ffCSgP0OyLW1n37/xPT5BqLNUU12nZevIAivaAF+7yV9aul89dAVPmSfAnnDkmQeooZhl9gNlJOKwsxqaD7jXtJ5xSyG7tOfpHwSy3H+EgRDrzwy4dwir2A7v5deADruOs9U0FQ1rZuCo6MlPmZBfyphr6CVJcNqikQLTBxqmD+bTzOhlB6dM7B9swq2yrNDHX1UFeAfkbQL0JyoU1Q0V5ogejQ1me+ruaq7QdytPSMVtle5LEV+NMHl7mtDXFTEMZvteaN7wGAkIiiMocHJdyo0cjl7BEKWGe6Bc0g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB3274.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(6029001)(346002)(136003)(396003)(39860400002)(376002)(366004)(478600001)(166002)(86362001)(83380400001)(966005)(66476007)(66556008)(64756008)(66446008)(66946007)(33656002)(76116006)(52536014)(186003)(26005)(7696005)(53546011)(6506007)(5660300002)(2906002)(8936002)(71200400001)(8676002)(316002)(4326008)(9686003)(110136005)(55016002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: Q6GZpJt4/i3Z8EFrgMEfUzl8wakhG2sFz1v/bbGiPIlGjAvrkvp8WzU6tj4/TSpgZA+5AJgZhBDD4eeO9qfzDsQUw5Y/wJamjH87RcCWL318Ascz1pT0eCXOg2dsGbyoMdaLwYMsCvJep++xdIS3r/YIpDVkG3ZzJ6W6EMKCRDE8bdsQGwkVdRYpdd/cbAbkle/4I3SrBUOKqOOyFCXem63TAHSmVbM+lKX4dgZn0JnzQHbS6LQhwIKOvgtahsqVM4p9vgHj4IrsyBU+rR8QRvl3oB30eu0GZ7rjFpYm0On162Uo1FlWXDygzOGdiBaZVnatWbVzqbwxPZ+XhPgSj1mZRKsSUxsdY7wUFXc9AaUIckNklFBOdbOpTa/KZWB33zbcqxmeVyAkBMNvNqKIRj0+Ab/YNWwQPL42/HlEd2xSs7Ij+NsC9roYfHcQnxlAHosjALtTa2niMGSHi7LnRHw7jA5A/QK/hh9XthX7CiM= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: bed9ac78-11f7-4c7a-5b43-08d80da6e1f9 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jun 2020 01:29:27.9533 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tim5+46XH62pWSx8/q+cYz30HjW12GxYXVyxj/D/B2ht4ORdLw4r6iKdnLmK9KpZHSCVkTwgraPMapOMjmwqdg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3386 Return-Path: eric.dong@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_DM6PR11MB327401EA0A0EB92DF9CEFBE0FE800DM6PR11MB3274namp_" --_000_DM6PR11MB327401EA0A0EB92DF9CEFBE0FE800DM6PR11MB3274namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable This proposal is ok to me. I'm not sure whether it can be added to MdePkg, just like add to CpuLib. I= found all the definitions and functions used in StandardSignatureIsAuthent= icAMD function defined in MdePkg. If it can be added to MdePkg, all code base can use this function, if it b= een added to UefiCpuPkg, other core packages may can't use it. Thanks, Eric From: Ni, Ray Sent: Thursday, June 11, 2020 9:12 AM To: devel@edk2.groups.io; garrett.kirkendall@amd.com Cc: Dong, Eric ; Laszlo Ersek Subject: RE: UefiCpuPkg: Discuss: Move StandardSignatureIsAuthenticAMD fun= ction to BaseUefiCpuLib Since all platform DSCs have already listed UefiCpuLib.inf so this change = doesn't impact platform DSC. I don't see an issue with this change. Eric, What's your opinion? Thanks, Ray > -----Original Message----- > From: devel@edk2.groups.io > On Behalf Of Kirkendall, Garrett > Sent: Wednesday, June 10, 2020 10:18 PM > To: devel@edk2.groups.io > Cc: Dong, Eric >; Ni, Ra= y >; Laszlo Ersek > > Subject: [edk2-devel] UefiCpuPkg: Discuss: Move StandardSignatureIsAuthe= nticAMD function to BaseUefiCpuLib > > [AMD Public Use] > > There are currently three instances of StandardSignatureIsAuthenticAMD F= unction in the below locations. I need to > propose another change that will require the same function in PiSmmCpuDx= eSmm. I would like to see this function move > to a single "LibraryClass" location. I think no one knew where to propo= se the function, so we ended up with three > instances so far. The best place I can find would be UefiCpuPkg/BaseUef= iCpuLib/. Thoughts? Is there a better function > name such that a similar Intel identifier function could be created when= needed in the future? > > I'm thinking this will be 3 patches > 1. Add StandardSignatureIsAuthenticAMD to BaseUefiCpuLib > 2. Move current instances to Library function > 3. Propose code change in PiSmmCpuDxeSmm > > UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c: StandardSignatureIsAuthe= nticAMD ( > UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c: StandardSign= atureIsAuthenticAMD ( > UefiCpuPkg/Library/MpInitLib/MpLib.c: StandardSignatureIsAuthenticAMD ( > > GARRETT KIRKENDALL > SMTS Firmware Engineer | CTE > 7171 Southwest Parkway, Austin, TX 78735 USA > AMD facebook | amd.com > >=20 --_000_DM6PR11MB327401EA0A0EB92DF9CEFBE0FE800DM6PR11MB3274namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

This proposal is ok to me.

 

I’m not sure whether it can be added to MdePk= g, just like add to CpuLib. I found all the definitions and functions used = in StandardSignatureIsAuthenticAMD function defined in MdePkg.

 

If it can be added to MdePkg, all code base can use= this function, if it been added to UefiCpuPkg, other core packages may can= ’t use it.

 

Thanks,

Eric

From: Ni, Ray <ray.ni@intel.com>
Sent: Thursday, June 11, 2020 9:12 AM
To: devel@edk2.groups.io; garrett.kirkendall@amd.com
Cc: Dong, Eric <eric.dong@intel.com>; Laszlo Ersek <lersek= @redhat.com>
Subject: RE: UefiCpuPkg: Discuss: Move StandardSignatureIsAuthentic= AMD function to BaseUefiCpuLib

 

Since all platform DSCs have already = listed UefiCpuLib.inf so this change doesn't = impact platform DSC.
I don't see an issue = with this change.

Eric,
What's your opinion?

Thanks,
Ray

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of&nbs= p;Kirkendall, Garrett
> Sent: Wednesday, June&nbs= p;10, 2020 10:18 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric <<= a href=3D"mailto:eric.dong@intel.com">eric.dong@intel.com>; Ni,=  Ray <ray.ni@intel.com= >; Laszlo Ersek <= lersek@redhat.com>
> Subject: [edk2-devel] Uef= iCpuPkg: Discuss: Move StandardSignatureIsAuthenticAMD = function to BaseUefiCpuLib
> 
> [AMD Public Use] > 
> There are currently = three instances of StandardSignatureIsAuthenticAMD Func= tion in the below locations.  I need&nbs= p;to
> propose another change&nb= sp;that will require the same function in&nbs= p;PiSmmCpuDxeSmm.  I would like to see t= his function move
> to a single "Li= braryClass" location.  I think no one&nb= sp;knew where to propose the function, so&nbs= p;we ended up with three
> instances so far. &n= bsp;The best place I can find would be&n= bsp;UefiCpuPkg/BaseUefiCpuLib/.  Thoughts?  Is the= re a better function
> name such that a&nbs= p;similar Intel identifier function could be = created when needed in the future?
> 
> I'm thinking this wi= ll be 3 patches
> 1. Add StandardSignatureI= sAuthenticAMD to BaseUefiCpuLib
> 2. Move current inst= ances to Library function
> 3. Propose code chan= ge in PiSmmCpuDxeSmm
> 
> UefiCpuPkg/Library/BaseXApicLib/Bas= eXApicLib.c: StandardSignatureIsAuthenticAMD (
> UefiCpuPkg/Library/BaseXApicX2ApicL= ib/BaseXApicX2ApicLib.c: StandardSignatureIsAuthenticAMD (=
> UefiCpuPkg/Library/MpInitLib/MpLib.= c: StandardSignatureIsAuthenticAMD (
> 
> GARRETT KIRKENDALL
> SMTS Firmware Engineer&nb= sp;| CTE
> 7171 Southwest Parkway,&n= bsp;Austin, TX 78735 USA
> AMD   facebook =  |  amd.com
> 
> 

--_000_DM6PR11MB327401EA0A0EB92DF9CEFBE0FE800DM6PR11MB3274namp_--