From: "Dong, Eric" <eric.dong@intel.com>
To: Laszlo Ersek <lersek@redhat.com>,
edk2-devel-groups-io <devel@edk2.groups.io>
Cc: "Wu, Hao A" <hao.a.wu@intel.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH 1/3] Maintainers.txt: retitle "MdeModulePkg: ACPI S3 modules"
Date: Fri, 5 Jun 2020 00:12:02 +0000 [thread overview]
Message-ID: <DM6PR11MB32740B73C4866B3D00033858FE860@DM6PR11MB3274.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200603160627.3594-2-lersek@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 3045 bytes --]
Reviewed-by: Eric Dong <eric.dong@intel.com>
From: Laszlo Ersek <lersek@redhat.com>
Sent: Thursday, June 4, 2020 12:06 AM
To: edk2-devel-groups-io <devel@edk2.groups.io>
Cc: Dong, Eric <eric.dong@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Philippe Mathieu-Daudé <philmd@redhat.com>
Subject: [PATCH 1/3] Maintainers.txt: retitle "MdeModulePkg: ACPI S3 modules"
The following two section titles in "Maintainers.txt" are not in
(case-sensitive) lexicographical order:
> MdeModulePkg: ACPI modules
> MdeModulePkg: ACPI S3 modules
However, if we simply sorted them, we'd have another problem: the specific
"ACPI S3 modules" line would precede the generic "ACPI modules" line.
Therefore, slightly reformulate the title on the second section, in order
to establish both lexicographical and hierarchical order.
Cc: Eric Dong <eric.dong@intel.com<mailto:eric.dong@intel.com>>
Cc: Hao A Wu <hao.a.wu@intel.com<mailto:hao.a.wu@intel.com>>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com<mailto:philmd@redhat.com>>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2778
Signed-off-by: Laszlo Ersek <lersek@redhat.com<mailto:lersek@redhat.com>>
---
Maintainers.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index 896ac5821fc6..012b768035eb 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -209,35 +209,35 @@ F: IntelFsp2WrapperPkg/
W: https://github.com/tianocore/tianocore.github.io/wiki/IntelFsp2WrapperPkg
M: Chasel Chiu <chasel.chiu@intel.com<mailto:chasel.chiu@intel.com>>
R: Nate DeSimone <nathaniel.l.desimone@intel.com<mailto:nathaniel.l.desimone@intel.com>>
R: Star Zeng <star.zeng@intel.com<mailto:star.zeng@intel.com>>
MdeModulePkg
F: MdeModulePkg/
W: https://github.com/tianocore/tianocore.github.io/wiki/MdeModulePkg
M: Jian J Wang <jian.j.wang@intel.com<mailto:jian.j.wang@intel.com>>
M: Hao A Wu <hao.a.wu@intel.com<mailto:hao.a.wu@intel.com>>
MdeModulePkg: ACPI modules
F: MdeModulePkg/Include/*Acpi*.h
F: MdeModulePkg/Universal/Acpi/
R: Dandan Bi <dandan.bi@intel.com<mailto:dandan.bi@intel.com>>
R: Liming Gao <liming.gao@intel.com<mailto:liming.gao@intel.com>>
-MdeModulePkg: ACPI S3 modules
+MdeModulePkg: ACPI modules related to S3
F: MdeModulePkg/*LockBox*/
F: MdeModulePkg/Include/*BootScript*.h
F: MdeModulePkg/Include/*LockBox*.h
F: MdeModulePkg/Include/*S3*.h
F: MdeModulePkg/Library/*S3*/
R: Hao A Wu <hao.a.wu@intel.com<mailto:hao.a.wu@intel.com>>
R: Eric Dong <eric.dong@intel.com<mailto:eric.dong@intel.com>>
MdeModulePkg: BDS modules
F: MdeModulePkg/*BootManager*/
F: MdeModulePkg/Include/Library/UefiBootManagerLib.h
F: MdeModulePkg/Universal/BdsDxe/
F: MdeModulePkg/Universal/DevicePathDxe/
F: MdeModulePkg/Universal/DriverHealthManagerDxe/
F: MdeModulePkg/Universal/LoadFileOnFv2/
F: MdeModulePkg/Universal/SecurityStubDxe/Defer3rdPartyImageLoad.*
R: Zhichao Gao <zhichao.gao@intel.com<mailto:zhichao.gao@intel.com>>
--
2.19.1.3.g30247aa5d201
[-- Attachment #2: Type: text/html, Size: 9208 bytes --]
next prev parent reply other threads:[~2020-06-05 0:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 16:06 [PATCH 0/3] Maintainers.txt: restore lexicographical order between package / subsystem headers Laszlo Ersek
2020-06-03 16:06 ` [PATCH 1/3] Maintainers.txt: retitle "MdeModulePkg: ACPI S3 modules" Laszlo Ersek
2020-06-05 0:12 ` Dong, Eric [this message]
2020-06-03 16:06 ` [PATCH 2/3] Maintainers.txt: restore order of OvmfPkg sections Laszlo Ersek
2020-06-03 16:08 ` Ard Biesheuvel
2020-06-03 16:06 ` [PATCH 3/3] Maintainers.txt: move StandaloneMmPkg to the right spot Laszlo Ersek
2020-06-03 16:07 ` Ard Biesheuvel
2020-06-03 23:24 ` Yao, Jiewen
2020-06-03 16:09 ` [PATCH 0/3] Maintainers.txt: restore lexicographical order between package / subsystem headers Philippe Mathieu-Daudé
2020-06-03 16:16 ` Leif Lindholm
2020-06-09 18:17 ` [edk2-devel] " Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB32740B73C4866B3D00033858FE860@DM6PR11MB3274.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox