From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.6639.1591670766962041668 for ; Mon, 08 Jun 2020 19:46:07 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=jHexz1X4; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: eric.dong@intel.com) IronPort-SDR: /ylfNBqcfQ6R3Lqw6+m3/IwmT27QxJRYBk4YzN6byTpDR5CB3+6DYRsY406xLgnQ7hsEgTUOWM C4eH4gfdevcg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2020 19:46:01 -0700 IronPort-SDR: CBJmlfynx0PNm34E+TGySEbveZXpTaQ4X9MSpy8h2LDmmaZfkStkVTMTf8s20+mU1IbvqCldMP iQPQVJ54fmhw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,490,1583222400"; d="scan'208";a="379611690" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by fmsmga001.fm.intel.com with ESMTP; 08 Jun 2020 19:46:01 -0700 Received: from orsmsx162.amr.corp.intel.com (10.22.240.85) by ORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 8 Jun 2020 19:46:00 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX162.amr.corp.intel.com (10.22.240.85) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 8 Jun 2020 19:46:00 -0700 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.54) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 8 Jun 2020 19:45:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HE7tfUPZEm440HTT3HMgCSaSwdYEauN/+jz0rBKdfExYbZsEHzE2UTr0+1WS8HCtEtQTqJt0U2oWZ5rU7w6eWoP2zEscvTJDlg03LxN28ccptOTVmewCftwpoT3pBEbGxBnWBElYNTd44iJsUUMA8RY0AC2JJEK2hOTxt80kZ0r8J9MRz820D2ET9liLFFjOpoz7eKSSKd5uAgXRowtfaYCLeEqlIA6+kDpULb/4GTho+2WyRQrOWm6n2qAhFN7TOunUvmdZXLp3pQRG/JOTtEUW9YblpeD0M+/HCSp7bnf+DfQCdlG0vmp203jrCkXRcayfnoEfN3Ae7rFd+95hfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5E6tVydNhpHjZ5ItTsygfktRxnUbSPny2UjvsfRQ158=; b=V1TEwtAQYMcZNoYb4aa4t+au+rzLftkNaGN6DZMdYgVY1CvrVEESWGkLWsxfxN4/BMbbG+zQ5WmtaDI3IjiSS64wc5Da30HDm0amjL0q43xW/9g/RVH+zxllrqI+hQ1gQ/DsUgc3ijbZ+4nQvLD/SaWca/h/1H3+EbtrcjkgHy6luTbE7ZRcD4QMVNE2k4LOzpqCsPPzbnfevkfMZE/j7Co6FzrTWqorkNm5F0CxfrKs3/gHA4vvnA24WuSZohS75ukJiDiTu/MXqzuG26jhv9xqrJR1Up6YXJmdzLt2Kw23Lv66oOI7ESf/BL1rb3V4NEA0vv8FZz6QUSNz96gR8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5E6tVydNhpHjZ5ItTsygfktRxnUbSPny2UjvsfRQ158=; b=jHexz1X491EAai/SeVs5wVtbcvGSzko//jLx/uTMbazEOPEgVbJ77sOFhx6RgrzkTNUsCvw9dbpEQ0gqd7WP/JRFksRN/RXQWChBYBa1j/kgV7pB8VwGVQ5HangmtIIVMXFu2tkGlnKIvq+7URRkoMaNYWSBYPlhrTIUohSVbMw= Received: from DM6PR11MB3274.namprd11.prod.outlook.com (2603:10b6:5:b::26) by DM6PR11MB4657.namprd11.prod.outlook.com (2603:10b6:5:2a6::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.18; Tue, 9 Jun 2020 02:45:58 +0000 Received: from DM6PR11MB3274.namprd11.prod.outlook.com ([fe80::cc01:6f05:1402:e7d7]) by DM6PR11MB3274.namprd11.prod.outlook.com ([fe80::cc01:6f05:1402:e7d7%6]) with mapi id 15.20.3066.023; Tue, 9 Jun 2020 02:45:58 +0000 From: "Dong, Eric" To: "devel@edk2.groups.io" , "Tan, Ming" Subject: Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/StatusCodeHandler: do not output \n\r for string data Thread-Topic: [edk2-devel] [PATCH 1/2] MdeModulePkg/StatusCodeHandler: do not output \n\r for string data Thread-Index: AQHWPYY815+fZx9+QEqblxwUoY3RPKjPlDhg Date: Tue, 9 Jun 2020 02:45:58 +0000 Message-ID: References: <20200608111547.17649-1-ming.tan@intel.com> In-Reply-To: <20200608111547.17649-1-ming.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3f92f5b5-e764-4390-cd8c-08d80c1f3d37 x-ms-traffictypediagnostic: DM6PR11MB4657: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 042957ACD7 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DkDB1upS6gZU75ZckZrhHGVmhL5CEjXRlcZWbg4SBYrp4IrNpuaEHiv/FtXgjFYMwOuyCrhw37c4bTxq31AvwABNA0wPAxk9MnFRI7IaccM1C6KiVo5BzF52Jse/o6f4SNLlHrzeoQ5oqcAwPcbYFSYEiCG86q0creB75qAPTrE7OlpBG/3Se0vQ/9QkfpUDQqUMz6o8gwGiVyK+pPrcXtzKcyyIxKEPaxJ2M3HKU/Olq5DrnM3a6eFCKKqYrmMHzMgLPvIevz0vWb3iSgKLn5ORNvj0mbSwxzMNkWKDwplqS50v3748yXlJ98Nbvy9zbjPWuAjkbEqSHjkpryeSaIfVZJsJAcDe/zoN61f5DEQ4LZAzr8W95ihtZhmPAEr0D830tE7USFNBNYfxpHdpLg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB3274.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(366004)(346002)(396003)(136003)(39860400002)(376002)(2906002)(6506007)(76116006)(5660300002)(186003)(26005)(316002)(71200400001)(52536014)(55016002)(6636002)(110136005)(66446008)(9686003)(66476007)(66946007)(64756008)(66556008)(53546011)(7696005)(83380400001)(8676002)(966005)(33656002)(478600001)(86362001)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: dph+B2spGcj4356oZSP6kYf//Xe4XAjba71IOOQOz3ibAuZI5AIOWspw+fG1Pm9E7b5lGQhVZazAkXCuV2+/1n40PhyBZvKSuikZmBEwuB3pkGiANItntzXUFf4AUBZdoAFP9ipju+IvJMOQDsljzNhii/EX4fC8P9Mn8Jtoog+nSPMw8dCr/A350wIZIrEzn76ETHxRfbQaR8jzQuvlhSL44YXnmi3tfYUpatLoGaReJqa+IpAnZBZ9KyWikKXznVdUfkchqIpo1L/PN9b2KpooTEHfkAo74ZvpNoLA6RGQxVeJGhfYm4YnPMGxQLcjKt5vxZtYvKNOhrDNBCRcdJrkR42F7BTHRGkHfaTaS1DvpqV31OJHOb3BH011G2FH5UVM33U6U1OLBJC5emPQpAOObLpy3S9Gnqtgep/naTHlsgWMSRwzr09AeK6FXMYijUC9N7lqTF0LC3oS2gstCJbTFMJVLJ9jFIE9V3q6SFhwl/fsQY8aqr6+3GiUAgCl MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 3f92f5b5-e764-4390-cd8c-08d80c1f3d37 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jun 2020 02:45:58.2022 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ynn9vw4pm6YCqrdTTngJjladBkkPqUxI3rXJF9rkS+mtjhjlSzp1/bBCNtBM5+itbkyqCEUNwoufHe+/tkBNBg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4657 Return-Path: eric.dong@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Ming, Agree the change, the caller should own the responsibility to format the st= ring in the input parameter, driver should not append "\r\n" here. Reviewed-by: Eric Dong Next time, please Cc the Package maintainer when send the patch.=20 The maintainer info can be found in Maintainers.txt in the root of edk2 fol= der. Thanks, Eric > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Tan, > Ming > Sent: Monday, June 8, 2020 7:16 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH 1/2] MdeModulePkg/StatusCodeHandler: do > not output \n\r for string data >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2787 >=20 > When output string data through serial port, will not ouput \n\r now. > Caller can output several data in one line, and output \n\r when needed. >=20 > Signed-off-by: Ming Tan > --- > .../Universal/StatusCodeHandler/Pei/SerialStatusCodeWorker.c | 2 +- > .../StatusCodeHandler/RuntimeDxe/SerialStatusCodeWorker.c | 2 +- > .../Universal/StatusCodeHandler/Smm/SerialStatusCodeWorker.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git > a/MdeModulePkg/Universal/StatusCodeHandler/Pei/SerialStatusCodeWork > er.c > b/MdeModulePkg/Universal/StatusCodeHandler/Pei/SerialStatusCodeWork > er.c > index 2455f8b2a9..3aa5642b64 100644 > --- > a/MdeModulePkg/Universal/StatusCodeHandler/Pei/SerialStatusCodeWork > er.c > +++ > b/MdeModulePkg/Universal/StatusCodeHandler/Pei/SerialStatusCodeWork > e > +++ r.c > @@ -134,7 +134,7 @@ SerialStatusCodeReportWorker ( > CharCount =3D AsciiSPrint ( Buffer, = sizeof (Buffer),- > "%a\n\r",+ "%a", ((EFI_STATUS_CODE_STR= ING_DATA *) > Data)->String.Ascii ); } else {diff --git > a/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/SerialStatusC > odeWorker.c > b/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/SerialStatusC > odeWorker.c > index 2dc3ecfff5..0b98e7ec63 100644 > --- > a/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/SerialStatusC > odeWorker.c > +++ > b/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/SerialStatusC > o > +++ deWorker.c > @@ -129,7 +129,7 @@ SerialStatusCodeReportWorker ( > CharCount =3D AsciiSPrint ( Buffer, = sizeof (Buffer),- > "%a\n\r",+ "%a", ((EFI_STATUS_CODE_STR= ING_DATA *) > Data)->String.Ascii ); } else {diff --git > a/MdeModulePkg/Universal/StatusCodeHandler/Smm/SerialStatusCodeWo > rker.c > b/MdeModulePkg/Universal/StatusCodeHandler/Smm/SerialStatusCodeWo > rker.c > index c0c907b32f..3df0a67126 100644 > --- > a/MdeModulePkg/Universal/StatusCodeHandler/Smm/SerialStatusCodeWo > rker.c > +++ > b/MdeModulePkg/Universal/StatusCodeHandler/Smm/SerialStatusCodeWo > rke > +++ r.c > @@ -129,7 +129,7 @@ SerialStatusCodeReportWorker ( > CharCount =3D AsciiSPrint ( Buffer, = sizeof (Buffer),- > "%a\n\r",+ "%a", ((EFI_STATUS_CODE_STR= ING_DATA *) > Data)->String.Ascii ); } else {-- > 2.24.0.windows.2 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. >=20 > View/Reply Online (#60857): https://edk2.groups.io/g/devel/message/60857 > Mute This Topic: https://groups.io/mt/74749510/1768733 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [eric.dong@intel.com] = - > =3D-=3D-=3D-=3D-=3D-=3D