From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web11.10702.1591923786138077605 for ; Thu, 11 Jun 2020 18:03:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=UNBLwK28; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: eric.dong@intel.com) IronPort-SDR: GtxYCN5+OT93PnxJsqe8BFzy9h06bZ46mGRACTB+NykJmQ1iddb99E039LWiihOrwkJ+IDK6Qo q7ZjU0TeLMAw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2020 18:03:05 -0700 IronPort-SDR: DRtuUyPekr+Cvc2aW4yiZ4XfOatOHr/yqA2KqpbdG6bjMCdsVhXQO7O/nQHG4WPS4AIo1Eg1IZ I1Bv23sBLvrg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,501,1583222400"; d="scan'208";a="474022405" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga005.fm.intel.com with ESMTP; 11 Jun 2020 18:03:05 -0700 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 11 Jun 2020 18:03:05 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 11 Jun 2020 18:03:04 -0700 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.54) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 11 Jun 2020 18:03:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NCGYEypmTQMF8ieg/3ITGxhRmkRF+4U2rQgZ06+vCqekHc0ex/ZVNk8kyaILqLlq06O6JeOA4bnafmmcKSXwu5L7wPCJgmLAW5L1uNrYT/Pfj3rDfznjNP7dthcldCvtqngKvMLK3L3Rfdj529C3zd3cfucO/a0CCcgYXomIuIAX6PyXCNhuZ31zZ7beenrd4rI8ZYeIwxm6m4uCJepv9bj+mJG7w3qMozqjlRHcKQHi4iX3Syt+4PyH2DwlYpWTM6a9bHmLz75hSCDk2HEZNiP0/r3rAd3lAe+KiGBG/TI/da4ekTjhqwmbQQsDHvnD1j/lLX6+njNkQ39sADFtjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Bdgcw7N2dRmb06skugwfGfsCZEflSeMA42QdAl1Bc0I=; b=Zwae+40Rimxxjgombb7X8w6MEPnkv2lL5g8h4kn/kvfcy6RUztasc1j39yzAtWo3makRkon5k7hSnJpeQteX5yqYs3PDnbi8Lv3gAZapftUezuHHQu2S4g1rjyceenpa/aCiC6GKltm6NrCxCEeco5TILbnUdr9O3omu/EHp/a/KNyyiCg5yF5r4+RIxmE3BOrmFituqbkS9vlvYiBWN3DoiT45MKpkjArAZhrS8U27oKoJOgtorGrFsW3vvYrVTzku4eBtmPcs0pXjIeEeZcRASw7W3AabFZHrqDitTMiK5Lhlf5bjVRpEKOYei1sXzs7I1QHtvvT7QUe2AEuQ/8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Bdgcw7N2dRmb06skugwfGfsCZEflSeMA42QdAl1Bc0I=; b=UNBLwK28Lp/2OcpG94xWh/UBDVu8i7To9gRl/ya3inJpIccSDKf2rtZnqpYacb0+cAA2sR1NnafozrXQx8zyU9uE8aBp+T2r9820FXAAxLnDQNX8LizqZVsVlXAy9Au3rTspNBVagF4IN2h8MKY4FmOCapyBjbBGqSdqCLBysj0= Received: from DM6PR11MB3274.namprd11.prod.outlook.com (2603:10b6:5:b::26) by DM5PR11MB1289.namprd11.prod.outlook.com (2603:10b6:3:b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.18; Fri, 12 Jun 2020 01:03:03 +0000 Received: from DM6PR11MB3274.namprd11.prod.outlook.com ([fe80::cc01:6f05:1402:e7d7]) by DM6PR11MB3274.namprd11.prod.outlook.com ([fe80::cc01:6f05:1402:e7d7%6]) with mapi id 15.20.3088.019; Fri, 12 Jun 2020 01:03:03 +0000 From: "Dong, Eric" To: Tom Lendacky , "devel@edk2.groups.io" CC: Brijesh Singh , Ard Biesheuvel , "Justen, Jordan L" , Laszlo Ersek , "Gao, Liming" , "Kinney, Michael D" , "Ni, Ray" Subject: Re: [PATCH v9 33/46] UefiCpuPkg: Create an SEV-ES workarea PCD Thread-Topic: [PATCH v9 33/46] UefiCpuPkg: Create an SEV-ES workarea PCD Thread-Index: AQHWOz1h+guJRSvBGEy6eqLYrjv9+6jUM+3g Date: Fri, 12 Jun 2020 01:03:02 +0000 Message-ID: References: <36f09f3a002e532d7a326c55988c8a7be288772c.1591363657.git.thomas.lendacky@amd.com> In-Reply-To: <36f09f3a002e532d7a326c55988c8a7be288772c.1591363657.git.thomas.lendacky@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.210] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 851f35eb-1f02-420a-4c1a-08d80e6c5bb4 x-ms-traffictypediagnostic: DM5PR11MB1289: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-forefront-prvs: 0432A04947 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VSmwtsMrZIV+T8vOTCz9MB2tDkBoqVN151XKYfq3p0YwSw/D6LdVbVQiDoVI1lZWJlQRRj+aDxY2lzhgyPD1/Qqq6e9oyKMdhmyT/JUJB5LJ4u2z+7bYNbTQv+bh+TeUd0cQK78OjWm2iqLZ9XzdUyjsD6+SkfIDMYZ51owd/prQWXYHTC4ZlJbJC0SsS6uroYk1P2+/b5YaHOKw7H8+EHFcGTnCtd7NR6D3SS0nqMlfODxLI7C5ebLEcOoNkjCpjqoPyBCGiGgBa1kUFV492atOI9Kcg5QcGA2AhNbJz6IjpBgcoIFQ+j4IawNau+CwyklRgF2LWwKzSGOI/z5/Wy45EMDt5NhPI380amImXUu4KENWz2RWqS41It9pYbwDjWOR8xs8k/eT/bTPT0S1vg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB3274.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(346002)(136003)(376002)(39860400002)(396003)(366004)(7696005)(5660300002)(52536014)(71200400001)(26005)(64756008)(66556008)(76116006)(83380400001)(33656002)(86362001)(66446008)(66946007)(6506007)(53546011)(66476007)(186003)(110136005)(9686003)(55016002)(316002)(8936002)(966005)(54906003)(107886003)(8676002)(2906002)(4326008)(478600001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: BKL7MO6gIUSnwGg1QBIE3oMtBMxu4gdOm8GwUsCBiSJ0Ws9rOXEKVnrAUwDmWvENVpf1Y8Sw2Pgrnx5KfcIJjd7xy07/PwShvwNO0P4yl1E3nsXZRv/AeSARG5sdCRhH/vI+GXYxjVEgLD3y6oXr1N2AY9BpCGjPt4jaYGbxphNVOm//22tMRJe7IA97S/3kIqK+kWW5IIuQzzDI28Gyvn0d537nGAKMjJokiTxRwuutbI5eCcDH7LuArimxgt7bTs23276rYp93Jpigmrsz4vi10ApAPo9z+0GAjS81EIfp1sVyGtYKu9a3gXyb2RJP+Ph//wy/lIoKVEy/s66amuqk3BHWDOUD2wIKFj/z63xIBqodulcXwuwfcvswffd+ueWHcjId/i4efdXf641KBhd0nlpX4ThOntVsLe5DJgXjDDmWWmz0jfP+o46gVoD3pdh6rfEUORdXDbPfxQyfCX82YugV0zVPTSuppfJ0t1qhkoxe91lwbkCj5mb3xUV6 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 851f35eb-1f02-420a-4c1a-08d80e6c5bb4 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2020 01:03:02.9995 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: u19/FzK15GW4F6j2BmzbrhPxelFDDODwx7urfeH2izzjSSSJwZy2D2iR5ptlO22i18ST9we9j2MZ4h4nJPcg6A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1289 Return-Path: eric.dong@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong Thanks, Eric > -----Original Message----- > From: Tom Lendacky > Sent: Friday, June 5, 2020 9:27 PM > To: devel@edk2.groups.io > Cc: Brijesh Singh ; Ard Biesheuvel > ; Dong, Eric ; Justen, > Jordan L ; Laszlo Ersek ; > Gao, Liming ; Kinney, Michael D > ; Ni, Ray > Subject: [PATCH v9 33/46] UefiCpuPkg: Create an SEV-ES workarea PCD >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2198 >=20 > Create an SEV-ES workarea PCD. This PCD will be used for BSP > communication > during SEC and for AP startup during PEI and DXE phases, the latter is th= e > reason for creating it in the UefiCpuPkg. >=20 > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Signed-off-by: Tom Lendacky > --- > UefiCpuPkg/UefiCpuPkg.dec | 8 ++++++++ > UefiCpuPkg/UefiCpuPkg.uni | 8 ++++++++ > 2 files changed, 16 insertions(+) >=20 > diff --git a/UefiCpuPkg/UefiCpuPkg.dec b/UefiCpuPkg/UefiCpuPkg.dec > index cb92f34b6f55..8c614f9b42bd 100644 > --- a/UefiCpuPkg/UefiCpuPkg.dec > +++ b/UefiCpuPkg/UefiCpuPkg.dec > @@ -161,6 +161,14 @@ [PcdsFixedAtBuild] > # @Prompt Specify the count of pre allocated SMM MP tokens per chunk. >=20 >=20 > gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmMpTokenCountPerChunk|64|UI > NT32|0x30002002 >=20 >=20 >=20 > + ## Area of memory where the SEV-ES work area block lives. >=20 > + # @Prompt Configure the SEV-ES work area base >=20 > + > gUefiCpuPkgTokenSpaceGuid.PcdSevEsWorkAreaBase|0x0|UINT32|0x30002 > 005 >=20 > + >=20 > + ## Size of teh area of memory where the SEV-ES work area block lives. >=20 > + # @Prompt Configure the SEV-ES work area base >=20 > + > gUefiCpuPkgTokenSpaceGuid.PcdSevEsWorkAreaSize|0x0|UINT32|0x30002 > 006 >=20 > + >=20 > [PcdsFixedAtBuild, PcdsPatchableInModule] >=20 > ## This value is the CPU Local APIC base address, which aligns the add= ress > on a 4-KByte boundary. >=20 > # @Prompt Configure base address of CPU Local APIC >=20 > diff --git a/UefiCpuPkg/UefiCpuPkg.uni b/UefiCpuPkg/UefiCpuPkg.uni > index f4a0c72f6293..219c1963bf08 100644 > --- a/UefiCpuPkg/UefiCpuPkg.uni > +++ b/UefiCpuPkg/UefiCpuPkg.uni > @@ -281,3 +281,11 @@ >=20 >=20 > #string STR_gUefiCpuPkgTokenSpaceGuid_PcdSevEsIsEnabled_PROMPT > #language en-US "Specifies whether SEV-ES is enabled" >=20 > #string STR_gUefiCpuPkgTokenSpaceGuid_PcdSevEsIsEnabled_HELP > #language en-US "Set to TRUE when running as an SEV-ES guest, FALSE > otherwise." >=20 > + >=20 > +#string > STR_gUefiCpuPkgTokenSpaceGuid_PcdSevEsWorkAreaBase_PROMPT > #language en-US "Specify the address of the SEV-ES work area" >=20 > + >=20 > +#string STR_gUefiCpuPkgTokenSpaceGuid_PcdSevEsWorkAreaBase_HELP > #language en-US "Specifies the address of the work area used by an SEV-ES > guest." >=20 > + >=20 > +#string > STR_gUefiCpuPkgTokenSpaceGuid_PcdSevEsWorkAreaSize_PROMPT > #language en-US "Specify the size of the SEV-ES work area" >=20 > + >=20 > +#string STR_gUefiCpuPkgTokenSpaceGuid_PcdSevEsWorkAreaSize_HELP > #language en-US "Specifies the size of the work area used by an SEV-ES > guest." >=20 > -- > 2.27.0