From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web12.3636.1588990931224884517 for ; Fri, 08 May 2020 19:22:11 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=ij5ZtukV; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: eric.dong@intel.com) IronPort-SDR: S8MuGlcOMX5aLapVq5+V+B3nSNKXK1W4C1+vSRKg2IrQEDvW6E9VP+BVpv+vdH0REwivPGqwtX Nnwc/0ajpeLQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2020 19:22:10 -0700 IronPort-SDR: Z7ihFC50ITRnkMb8aJGXb2IjGQqH+RrvGHGebQ8ZEwaFzOm6vAx9aT7fkQ/ShgrBaoEjA4dULL Iew+DqiTjw1A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,370,1583222400"; d="scan'208";a="296325205" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by fmsmga002.fm.intel.com with ESMTP; 08 May 2020 19:22:10 -0700 Received: from orsmsx157.amr.corp.intel.com (10.22.240.23) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 8 May 2020 19:22:10 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX157.amr.corp.intel.com (10.22.240.23) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 8 May 2020 19:22:09 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.177) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 8 May 2020 19:18:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cTYUpAd7gnr4FnPpO4DJNjoppVHJUoHTeg0OG1sbEoCqc5kbr0pyaYY6a9FUI6Cnf/hAHikmadtqKf7gxp2G/m3eDv2jFC0o+M7DCsrEmc01O2gBTT03kznj4MgySClo4F6wYQUBsVEQWNnQtyKCGJ3/8r2sMXC9PVVSYTL1qF7SsG/7px8ojOAOgDZ8I8pA8QF9Bu+lTD1x0qSTTBAAxdQ23wYtZVrr43ECttt3t2xieGdvJ94FuPRyPTW/anw+T4r3pM2ajWNA4wyfYVvABsMiRGNYvH6e7MGl+cdjUh5+vWcMCIPjp7pwRB6CDYgX/euMfXHSx9svodtoyGT2/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r3+tDpkUnDTjgl1qmdbqAAIIXTNyBVfvhjqgWdGgBYI=; b=mhq9EnBfOplAwdjKEsrP0m/n41uDFMtf/RkristszGcXs0Q27eROGKsfzZ/40SOKEsgeZO88SOGeXXAiXkRyPX7T7xsObiMot57Z0RnyyLr0ijHt9e/Ihpj6x6CGGEaRSe8H00KVC1ZNfoKI7kWVhF+b1BrkbiJs49X9omKJT5EqwsZJ/B8NSFc59hYogotLpnrEmTla6DcKML2JRnTynV4t5e7sxwS+M777yW2Up7K/g4DPUzHH4DBuqP7xvls6W2008pDl0gEOep1NOEjniez4xvZS5Z8/5eWRJsOh4lHSvqVVSTHgNyOMJya6K7ijNSkkyY1uzUGs7pU2gA4EAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r3+tDpkUnDTjgl1qmdbqAAIIXTNyBVfvhjqgWdGgBYI=; b=ij5ZtukVDxYbElpX+UB1yh/d/GErXeJ7R5MHA9j07Hco7/SvtoudP4i3SNO9xYV7UYHRSnGPTkP1//2CjOTpmb1aNQz6fu4ThSBpNGe3uLNsp4To2jJFemHv4xOTEl2etjtmhgXGohBb+CH8ddVeHB0Q+VLUO1nuUGjnyLluNvA= Received: from DM6PR11MB3274.namprd11.prod.outlook.com (2603:10b6:5:b::26) by DM6PR11MB3628.namprd11.prod.outlook.com (2603:10b6:5:144::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.27; Sat, 9 May 2020 02:17:53 +0000 Received: from DM6PR11MB3274.namprd11.prod.outlook.com ([fe80::e1d1:a495:9826:f88b]) by DM6PR11MB3274.namprd11.prod.outlook.com ([fe80::e1d1:a495:9826:f88b%3]) with mapi id 15.20.2979.028; Sat, 9 May 2020 02:17:53 +0000 From: "Dong, Eric" To: "devel@edk2.groups.io" , "thomas.lendacky@amd.com" CC: "Justen, Jordan L" , Laszlo Ersek , Ard Biesheuvel , "Gao, Liming" , "Ni, Ray" , Anthony Perard , Julien Grall , Brijesh Singh , Andrew Fish Subject: Re: [edk2-devel] [PATCH v3 0/3] XCODE5 toolchain binary patching fix Thread-Topic: [edk2-devel] [PATCH v3 0/3] XCODE5 toolchain binary patching fix Thread-Index: AQHWJHCFiEWfBcLOhkWOiYx1nLMlMKifBw0w Date: Sat, 9 May 2020 02:17:53 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.45] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 77564ae6-c72f-4c4b-20f6-08d7f3bf2e25 x-ms-traffictypediagnostic: DM6PR11MB3628: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 03982FDC1D x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JIZ0wtXTZsUrc8Zh1pZ5knOWC/tHNEKJl1rl9evlqp8B2t9B2x8OsF6yPUBQC26h5K0ErrxP+21kCXxfJZ3z4TeMVZLRVRKI+Fls9cb7sAtbnolv5SPGRmS2N6Q+apME5hbi/lUtek/2RioGF9bwdr9vVTbkj5i3qTLze3K0SMm7NdewB3/Kid1qHbcdqrlODxPdmmOnm6iKcaucAGh145GjwOE5h7rMzCw+LJhU+QoENCi5iLrsG4bT/4OSgMdvL1gcyWM8HYga93B/60ap4oE2WOms97DEiYdIhZPWBrt2On33siBnDqBOj/bZ3mNjg08z8J9FEWJwTweeuIP5819iMmpT6EyqvXTCtw5G2S77lrQqwWqINIXxNAAzsc+HWLIwyPeO7Q3oqV37o1VqBi63h9CuhxMDHOVmO5pKT91wfMnd2z3ufSoq6BpSVlUvWTbJ/rVsN+eAlASapnyL6Qy78g71Pj6whgmUNk9V6Fn7NLLoW2KeJ9+u+IxYBhwrYgrrH1M2RqaPx6O6xkPQPqZEI9qMywznQII1HCBS4j/MziQN9jI2jXmYptHBd9wTRusiA3e+bS6V3w+sqh9rl2z/uW89ar7kRqOWny4tuiQ= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB3274.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(346002)(136003)(376002)(396003)(39860400002)(366004)(33430700001)(2906002)(33656002)(86362001)(66556008)(26005)(76116006)(53546011)(8676002)(66476007)(19627235002)(478600001)(64756008)(6506007)(7696005)(54906003)(8936002)(9686003)(316002)(71200400001)(110136005)(66446008)(55016002)(186003)(966005)(4326008)(33440700001)(5660300002)(66946007)(52536014);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: MPfiDyp5iz0Icv63Ll+N9T1oZ2RVa2gKx4f/3m5zLrt44FuJkHwKBZzQEk9ZKC+HT5kjmCKEY4MvHVxgqNxGnY0oIMqmmq/JavBOoXAIT/gmfxDgprL7HobPw/7qj49O+RqG+wX55Ktq+3/WuNSWQ6Jaf8B9Sr7Gpjxyi8O1Q9iWp6I3H0x2rjAB3JwSyKgaw967y6A+UfOnoA+x0HXH7Lpi59d4oSiIG5N7Bzv6zMKM5/cu9ToAGn2k8dWm63lfQ0YwsHHhX8HCwOFT9hl/R1B0Lnb4+vWJeu37EGyEErdLye3h+ZKKlytxWKPGS+GsKYf1nyGQrGhbaZ+i9Ka3s1rAkzPenDGsMUZ6B3a1UuSKO6fj9BLCT1DGAJb6X63Ag6eGp2VnlJnTXB6dpM5g0Y0Cwz4gBn0wV4viy0u2GdQU1P63kzacZ0XAnvCIe1xFpCvXFUnxk8BrCRYVG2QeU9kR2v9M7CAV2wCjhmYssMmof4MUYoSbRrhrckmm+Zww MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 77564ae6-c72f-4c4b-20f6-08d7f3bf2e25 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2020 02:17:53.3773 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CAVFnzUIpunsfkXrxorBJP3tdJeocAlIE8vIqml/X9weFzIlJtcQSmU29EIgL8ORpqPZNG1vkQSH/a3r0lAEYA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3628 Return-Path: eric.dong@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable For this patch series: Reviewed-by: Eric Dong > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of > Lendacky, Thomas > Sent: Thursday, May 7, 2020 9:07 PM > To: devel@edk2.groups.io > Cc: Justen, Jordan L ; Laszlo Ersek > ; Ard Biesheuvel ; Gao, > Liming ; Dong, Eric ; Ni, Ray > ; Anthony Perard ; Julien > Grall ; Brijesh Singh ; Andrew > Fish > Subject: [edk2-devel] [PATCH v3 0/3] XCODE5 toolchain binary patching fi= x >=20 >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2340 >=20 > Commit 2db0ccc2d7fe ("UefiCpuPkg: Update CpuExceptionHandlerLib pass > XCODE5 tool chain") introduced binary patching in the > ExceptionHandlerAsm.nasm in order to support the XCODE5 toolchain. > However, the CpuExceptionHandlerLib can be used during SEC phase which > would result in binary patching of flash. >=20 > This series creates a new CpuExceptionHandlerLib file to support the > required binary patching for the XCODE5 toolchain, while reverting the > changes from commit 2db0ccc2d7fe in the standard file. As the Pei, Dxe a= nd > SMM versions of the library operate in memory (as opposed to flash), onl= y > the SEC/PEI version is of the library is updated to use the version of t= he > ExceptionHandlerAsm.nasm that does not perform binary patching. >=20 > This is accomplished in phases: > - Create a new XCODE5 specific version of the ExceptionHandlerAsm.nasm > file and update all CpuExceptionHandler INF files to use it while al= so > creating a new SEC/PEI CpuExceptionHandler INF file specifically for > the XCODE5 toolchain. > - Update all package DSC files that use the SecPeiCpuExceptionHandlerL= ib > version of the library to use the XCODE5 version of the library, > Xcode5SecPeiCpuExceptionHandlerLib, when the XCODE5 toolchain is use= d. > - Revert the changes made by commit 2db0ccc2d7fe in the standard file > and update the SecPeiCpuExceptionHandlerLib.inf file to use the > standard file. >=20 > I don't have access to an XCODE5 toolchain setup, so I have not tested t= his > with XCODE5. I would like to request that someone who does please test t= his. >=20 > --- >=20 > These patches are based on commit: > faef5a367c83 ("ShellPkg: acpiview: Check if SBBR mandatory ACPI tables a= re > installed") >=20 > Cc: Andrew Fish > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Brijesh Singh > Cc: Eric Dong > Cc: Jordan Justen > Cc: Julien Grall > Cc: Laszlo Ersek > Cc: Liming Gao > Cc: Ray Ni >=20 > Changes since v2: > - Updated [Components] section of UefiCpuPkg.dsc to conditionally exclud= e > SecPeiCpuExceptionHandlerLib.inf for the XCODE5 toolchain. > - Added some missed Reviewed-by: and Acked-by: tags from previous > versions. >=20 > Changes since v1: > - Only apply the revert to the Sec/Pei CpuExceptionHandler library and > leave the Pei, Dxe and Smm versions using the binary patching version. > - Generate a unique file GUID for the new library INF file and create > a corresponding UNI file. > - Remove any references to SEV-ES (original patches accidentally submitt= ed > from wrong tree). >=20 > Tom Lendacky (3): > UefiCpuPkg/CpuExceptionHandler: Make XCODE5 changes toolchain specific > OvmfPkg: Use toolchain appropriate CpuExceptionHandlerLib > UefiCpuPkg/CpuExceptionHandler: Revert CpuExceptionHandler binary > patching >=20 > OvmfPkg/OvmfPkgIa32.dsc | 4 +++ > OvmfPkg/OvmfPkgIa32X64.dsc | 4 +++ > OvmfPkg/OvmfPkgX64.dsc | 4 +++ > OvmfPkg/OvmfXen.dsc | 4 +++ > UefiCpuPkg/UefiCpuPkg.dsc | 7 ++++++ > .../DxeCpuExceptionHandlerLib.inf | 2 +- > .../PeiCpuExceptionHandlerLib.inf | 2 +- > .../SmmCpuExceptionHandlerLib.inf | 2 +- > ...=3D> Xcode5SecPeiCpuExceptionHandlerLib.inf} | 13 +++++++--- > .../X64/ExceptionHandlerAsm.nasm | 25 +++++-------------- > ...sm.nasm =3D> Xcode5ExceptionHandlerAsm.nasm} | 0 > .../Xcode5SecPeiCpuExceptionHandlerLib.uni | 18 +++++++++++++ > 12 files changed, 59 insertions(+), 26 deletions(-) copy > UefiCpuPkg/Library/CpuExceptionHandlerLib/{SecPeiCpuExceptionHandlerLi > b.inf =3D> Xcode5SecPeiCpuExceptionHandlerLib.inf} (64%) copy > UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/{ExceptionHandlerAsm.na > sm =3D> Xcode5ExceptionHandlerAsm.nasm} (100%) create mode 100644 > UefiCpuPkg/Library/CpuExceptionHandlerLib/Xcode5SecPeiCpuExceptionHa > ndlerLib.uni >=20 > -- > 2.17.1 >=20 >=20 >=20