From: "Dong, Eric" <eric.dong@intel.com>
To: "Tan, Ming" <ming.tan@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Gao, Liming" <liming.gao@intel.com>
Subject: Re: [PATCH] Intel/Usb3DebugFeaturePkg: Remove the prefix path of Debugging/
Date: Sat, 13 Jun 2020 02:45:17 +0000 [thread overview]
Message-ID: <DM6PR11MB32745BA9E7EFD20D6818F5D2FE9E0@DM6PR11MB3274.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200612025228.33148-1-ming.tan@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
> -----Original Message-----
> From: Tan, Ming <ming.tan@intel.com>
> Sent: Friday, June 12, 2020 10:52 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH] Intel/Usb3DebugFeaturePkg: Remove the prefix path of
> Debugging/
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2795
>
> In Features/Intel/Debugging/Usb3DebugFeaturePkg, remove the prefix
> path of Debugging/ in the .inf and .dsc files.
>
> Now the PACKAGES_PATH already include the Features/Intel/Debugging/.
>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Ming Tan <ming.tan@intel.com>
> ---
> .../Include/Usb3DebugFeature.dsc | 16 ++++++++--------
> .../Usb3DebugPortLib/Usb3DebugPortLibDxe.inf | 4 ++--
> .../Usb3DebugPortLibDxeIoMmu.inf | 4 ++--
> .../Usb3DebugPortLib/Usb3DebugPortLibPei.inf | 4 ++--
> .../Usb3DebugPortLibPeiIoMmu.inf | 4 ++--
> .../Usb3DebugPortParamLibPcd.inf | 4 ++--
> 6 files changed, 18 insertions(+), 18 deletions(-)
>
> diff --git
> a/Features/Intel/Debugging/Usb3DebugFeaturePkg/Include/Usb3DebugFea
> ture.dsc
> b/Features/Intel/Debugging/Usb3DebugFeaturePkg/Include/Usb3DebugFea
> ture.dsc
> index 494dd7a342..95adb01a74 100644
> ---
> a/Features/Intel/Debugging/Usb3DebugFeaturePkg/Include/Usb3DebugFea
> ture.dsc
> +++
> b/Features/Intel/Debugging/Usb3DebugFeaturePkg/Include/Usb3DebugFea
> ture.dsc
> @@ -106,10 +106,10 @@
>
>
> # Add library instances here that are not included in package components
> and should be tested
>
> # in the package build.
>
> -
> Debugging/Usb3DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugP
> ortLibNull.inf
>
> -
> Debugging/Usb3DebugFeaturePkg/Library/Usb3DebugPortParamLibPcd/Usb
> 3DebugPortParamLibPcd.inf
>
> -
> Debugging/Usb3DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugP
> ortLibPei.inf
>
> -
> Debugging/Usb3DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugP
> ortLibPeiIoMmu.inf
>
> +
> Usb3DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPortLibNull.in
> f
>
> +
> Usb3DebugFeaturePkg/Library/Usb3DebugPortParamLibPcd/Usb3DebugPor
> tParamLibPcd.inf
>
> +
> Usb3DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPortLibPei.inf
>
> +
> Usb3DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPortLibPeiIo
> Mmu.inf
>
>
>
> # Add components here that should be included in the package build.
>
>
>
> @@ -126,10 +126,10 @@
>
>
> # Add library instances here that are not included in package components
> and should be tested
>
> # in the package build.
>
> -
> Debugging/Usb3DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugP
> ortLibNull.inf
>
> -
> Debugging/Usb3DebugFeaturePkg/Library/Usb3DebugPortParamLibPcd/Usb
> 3DebugPortParamLibPcd.inf
>
> -
> Debugging/Usb3DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugP
> ortLibDxe.inf
>
> -
> Debugging/Usb3DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugP
> ortLibDxeIoMmu.inf
>
> +
> Usb3DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPortLibNull.in
> f
>
> +
> Usb3DebugFeaturePkg/Library/Usb3DebugPortParamLibPcd/Usb3DebugPor
> tParamLibPcd.inf
>
> +
> Usb3DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPortLibDxe.in
> f
>
> +
> Usb3DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPortLibDxeIo
> Mmu.inf
>
>
>
> # Add components here that should be included in the package build.
>
>
>
> diff --git
> a/Features/Intel/Debugging/Usb3DebugFeaturePkg/Library/Usb3DebugPort
> Lib/Usb3DebugPortLibDxe.inf
> b/Features/Intel/Debugging/Usb3DebugFeaturePkg/Library/Usb3DebugPort
> Lib/Usb3DebugPortLibDxe.inf
> index 51671ce4e3..64a287a016 100644
> ---
> a/Features/Intel/Debugging/Usb3DebugFeaturePkg/Library/Usb3DebugPort
> Lib/Usb3DebugPortLibDxe.inf
> +++
> b/Features/Intel/Debugging/Usb3DebugFeaturePkg/Library/Usb3DebugPort
> Lib/Usb3DebugPortLibDxe.inf
> @@ -1,7 +1,7 @@
> ## @file
>
> # USB3 Debug port library.
>
> #
>
> -# Copyright (c) 2013 - 2019, Intel Corporation. All rights reserved.<BR>
>
> +# Copyright (c) 2013 - 2020, Intel Corporation. All rights reserved.<BR>
>
> # SPDX-License-Identifier: BSD-2-Clause-Patent
>
> #
>
> ##
>
> @@ -30,7 +30,7 @@
>
>
> [Packages]
>
> MdePkg/MdePkg.dec
>
> - Debugging/Usb3DebugFeaturePkg/Usb3DebugFeaturePkg.dec
>
> + Usb3DebugFeaturePkg/Usb3DebugFeaturePkg.dec
>
>
>
> [LibraryClasses]
>
> BaseLib
>
> diff --git
> a/Features/Intel/Debugging/Usb3DebugFeaturePkg/Library/Usb3DebugPort
> Lib/Usb3DebugPortLibDxeIoMmu.inf
> b/Features/Intel/Debugging/Usb3DebugFeaturePkg/Library/Usb3DebugPort
> Lib/Usb3DebugPortLibDxeIoMmu.inf
> index 3f38ba2649..906d20fa6f 100644
> ---
> a/Features/Intel/Debugging/Usb3DebugFeaturePkg/Library/Usb3DebugPort
> Lib/Usb3DebugPortLibDxeIoMmu.inf
> +++
> b/Features/Intel/Debugging/Usb3DebugFeaturePkg/Library/Usb3DebugPort
> Lib/Usb3DebugPortLibDxeIoMmu.inf
> @@ -1,7 +1,7 @@
> ## @file
>
> # USB3 Debug port library.
>
> #
>
> -# Copyright (c) 2013 - 2019, Intel Corporation. All rights reserved.<BR>
>
> +# Copyright (c) 2013 - 2020, Intel Corporation. All rights reserved.<BR>
>
> # SPDX-License-Identifier: BSD-2-Clause-Patent
>
> #
>
> ##
>
> @@ -32,7 +32,7 @@
> [Packages]
>
> MdePkg/MdePkg.dec
>
> MdeModulePkg/MdeModulePkg.dec
>
> - Debugging/Usb3DebugFeaturePkg/Usb3DebugFeaturePkg.dec
>
> + Usb3DebugFeaturePkg/Usb3DebugFeaturePkg.dec
>
>
>
> [LibraryClasses]
>
> BaseLib
>
> diff --git
> a/Features/Intel/Debugging/Usb3DebugFeaturePkg/Library/Usb3DebugPort
> Lib/Usb3DebugPortLibPei.inf
> b/Features/Intel/Debugging/Usb3DebugFeaturePkg/Library/Usb3DebugPort
> Lib/Usb3DebugPortLibPei.inf
> index ebea01d5a8..3da0844fee 100644
> ---
> a/Features/Intel/Debugging/Usb3DebugFeaturePkg/Library/Usb3DebugPort
> Lib/Usb3DebugPortLibPei.inf
> +++
> b/Features/Intel/Debugging/Usb3DebugFeaturePkg/Library/Usb3DebugPort
> Lib/Usb3DebugPortLibPei.inf
> @@ -1,7 +1,7 @@
> ## @file
>
> # USB3 Debug port library.
>
> #
>
> -# Copyright (c) 2013 - 2019, Intel Corporation. All rights reserved.<BR>
>
> +# Copyright (c) 2013 - 2020, Intel Corporation. All rights reserved.<BR>
>
> # SPDX-License-Identifier: BSD-2-Clause-Patent
>
> #
>
> ##
>
> @@ -28,7 +28,7 @@
>
>
> [Packages]
>
> MdePkg/MdePkg.dec
>
> - Debugging/Usb3DebugFeaturePkg/Usb3DebugFeaturePkg.dec
>
> + Usb3DebugFeaturePkg/Usb3DebugFeaturePkg.dec
>
>
>
> [LibraryClasses]
>
> BaseLib
>
> diff --git
> a/Features/Intel/Debugging/Usb3DebugFeaturePkg/Library/Usb3DebugPort
> Lib/Usb3DebugPortLibPeiIoMmu.inf
> b/Features/Intel/Debugging/Usb3DebugFeaturePkg/Library/Usb3DebugPort
> Lib/Usb3DebugPortLibPeiIoMmu.inf
> index 6c3e8bc760..3efab14c39 100644
> ---
> a/Features/Intel/Debugging/Usb3DebugFeaturePkg/Library/Usb3DebugPort
> Lib/Usb3DebugPortLibPeiIoMmu.inf
> +++
> b/Features/Intel/Debugging/Usb3DebugFeaturePkg/Library/Usb3DebugPort
> Lib/Usb3DebugPortLibPeiIoMmu.inf
> @@ -1,7 +1,7 @@
> ## @file
>
> # USB3 Debug port library.
>
> #
>
> -# Copyright (c) 2013 - 2019, Intel Corporation. All rights reserved.<BR>
>
> +# Copyright (c) 2013 - 2020, Intel Corporation. All rights reserved.<BR>
>
> # SPDX-License-Identifier: BSD-2-Clause-Patent
>
> #
>
> ##
>
> @@ -30,7 +30,7 @@
> [Packages]
>
> MdePkg/MdePkg.dec
>
> MdeModulePkg/MdeModulePkg.dec
>
> - Debugging/Usb3DebugFeaturePkg/Usb3DebugFeaturePkg.dec
>
> + Usb3DebugFeaturePkg/Usb3DebugFeaturePkg.dec
>
>
>
> [LibraryClasses]
>
> BaseLib
>
> diff --git
> a/Features/Intel/Debugging/Usb3DebugFeaturePkg/Library/Usb3DebugPort
> ParamLibPcd/Usb3DebugPortParamLibPcd.inf
> b/Features/Intel/Debugging/Usb3DebugFeaturePkg/Library/Usb3DebugPort
> ParamLibPcd/Usb3DebugPortParamLibPcd.inf
> index e891a0c459..f38b2dac01 100644
> ---
> a/Features/Intel/Debugging/Usb3DebugFeaturePkg/Library/Usb3DebugPort
> ParamLibPcd/Usb3DebugPortParamLibPcd.inf
> +++
> b/Features/Intel/Debugging/Usb3DebugFeaturePkg/Library/Usb3DebugPort
> ParamLibPcd/Usb3DebugPortParamLibPcd.inf
> @@ -1,7 +1,7 @@
> ## @file
>
> # USB3 Debug Port Parameter library instance based on PCD.
>
> #
>
> -# Copyright (c) 2013 - 2019, Intel Corporation. All rights reserved.<BR>
>
> +# Copyright (c) 2013 - 2020, Intel Corporation. All rights reserved.<BR>
>
> # SPDX-License-Identifier: BSD-2-Clause-Patent
>
> #
>
> ##
>
> @@ -23,7 +23,7 @@
>
>
> [Packages]
>
> MdePkg/MdePkg.dec
>
> - Debugging/Usb3DebugFeaturePkg/Usb3DebugFeaturePkg.dec
>
> + Usb3DebugFeaturePkg/Usb3DebugFeaturePkg.dec
>
>
>
> [Pcd]
>
> gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsbSerialXhciBus ##
> CONSUMES
>
> --
> 2.24.0.windows.2
prev parent reply other threads:[~2020-06-13 2:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 2:52 [PATCH] Intel/Usb3DebugFeaturePkg: Remove the prefix path of Debugging/ Tan, Ming
2020-06-13 2:45 ` Dong, Eric [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB32745BA9E7EFD20D6818F5D2FE9E0@DM6PR11MB3274.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox