From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.2291.1591859245279092679 for ; Thu, 11 Jun 2020 00:07:25 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=CbyeH6RF; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: eric.dong@intel.com) IronPort-SDR: 1c1viLQpRy+Q1HLHRdCiu2xVzJqI8RpHq48BoccJamQcsvvzhNcUA7USgkRM4puvJ5YWU41+Kv PLfV+xC5gcTA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2020 00:07:23 -0700 IronPort-SDR: nLMa6C+/c3kbczZJVL3pEBDOCc5ErYO1/CJ1aNq/v8ybAhZCqFx5ew6iknuD/KU3ENUFZ5BCE8 gEJOcTaKw0mA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,498,1583222400"; d="scan'208,217";a="260628260" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by fmsmga008.fm.intel.com with ESMTP; 11 Jun 2020 00:07:21 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 11 Jun 2020 00:07:20 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 11 Jun 2020 00:07:20 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 11 Jun 2020 00:07:20 -0700 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.50) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 11 Jun 2020 00:07:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cySWBCX2Tp2qZ1dEsb7xeUTyvmhfj7HRed9f3uiNbYMZWCkaPVrEA6Vn+dfPCB6yTZpzImnB2CT+/qLVps++q17Ri0cMlj68TRtjGN46GUt5M+VBa+NIJOiJSYU2Jzym5/QjVKh3jHgaH2ctuN+zWhA2xyGMqTuXJtdj7iogjgxMXaBtXM4Om2UsvetN/c0de6zv4n8/u+O0JLs7YE26rBQGpUzA8jXDGk72KzlPXNb2qVNT4YF+Zt0CTWOiUpYjGy54TJYCHxLIhJBBL4uz/nXdB5BnoIjT4QU4XRnyuBTzDNZbp9aOQUKWFIBJjZ14hV+gmm42lwIWFZp3iqJPog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=unVcAEZ1XTo/ZLMf+nUergWk3i9ctaRkUZxDeW8kI+U=; b=RCf5pYgvvYnfIV89jXGmM9+I/qFp8OJfgW/0+D5N895RpHkctTjorzRtk0eUtLxidtKJjBKqSDKEU/vkSfoR1TkbCVqg9rnHJvS/XGWXqn2ECbBwQzcGo5QOR4DZd4DqAclXhlscWUYC8yd9pfvjvd2ZLTs86kpcGHJrxipvbCSA01n7sw8Q652zbx5TLJ2MNe3vgYL359QnMoOi20ZcHBzHeU5vDL/K754eZsl63vpGKVX6Fg8bhxyTSwOJ3cpt5qEzbF12e+Bly2XSggS/EOlQjYm3q/IS6TT3C60wYxt3XfGXAzcsBMupERK6xE5/FW/d/Do15B4/oheQRvrifQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=unVcAEZ1XTo/ZLMf+nUergWk3i9ctaRkUZxDeW8kI+U=; b=CbyeH6RFD2YIRNAuCPRc92VQ7r4pheAIMxXnr3Dqjee/9Jfvh7t3wnmhHM5hEcO3G2R0dHSh7hoWftY+LzZq+qUcGQHmfxVPaQl36dbXR3UU5AB2UJFQ9cx63mTWxL00fdz+vQ0iiQvK3YlHr0iwy7wSlaW/IzRqYJn2ABAetnQ= Received: from DM6PR11MB3274.namprd11.prod.outlook.com (2603:10b6:5:b::26) by DM6PR11MB3577.namprd11.prod.outlook.com (2603:10b6:5:137::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.22; Thu, 11 Jun 2020 07:07:16 +0000 Received: from DM6PR11MB3274.namprd11.prod.outlook.com ([fe80::cc01:6f05:1402:e7d7]) by DM6PR11MB3274.namprd11.prod.outlook.com ([fe80::cc01:6f05:1402:e7d7%6]) with mapi id 15.20.3088.019; Thu, 11 Jun 2020 07:07:16 +0000 From: "Dong, Eric" To: "Ni, Ray" , "devel@edk2.groups.io" , "garrett.kirkendall@amd.com" CC: Laszlo Ersek Subject: Re: UefiCpuPkg: Discuss: Move StandardSignatureIsAuthenticAMD function to BaseUefiCpuLib Thread-Topic: UefiCpuPkg: Discuss: Move StandardSignatureIsAuthenticAMD function to BaseUefiCpuLib Thread-Index: AdY/LxrU4UeZwuEKT3qg1oH+0DYgTwAXZggwAACawuAAB1X4MAAEfJIQ Date: Thu, 11 Jun 2020 07:07:16 +0000 Message-ID: References: <734D49CCEBEEF84792F5B80ED585239D5C5AB095@SHSMSX104.ccr.corp.intel.com> <734D49CCEBEEF84792F5B80ED585239D5C5AB9FA@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C5AB9FA@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Enabled=true; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_SetDate=2020-06-10T13:48:24Z; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Method=Privileged; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Name=Public_0; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_ActionId=a0aba147-89af-413a-9a26-cb37e91c8949; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_ContentBits=1 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.210] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e971627d-de3d-485a-6a21-08d80dd612ef x-ms-traffictypediagnostic: DM6PR11MB3577: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 0431F981D8 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hjZjnOodxbrjoMxYptlZDDihVcqVD2CceCNccI3wEuyOqpFYk/uMo08NKNnb5EGBOZqUpOonTo+8x16lSKZa0KjJu+gvzerOeU/KYErgVv1t3hbBDl0zHjVKJez3jvBnuUHyF8s+l5Bit5k93lJm4q95VP6kIFDCx5K4P73+7Pkhs69Iiy8dmVOEahUhbU4e0EPMP+fBByYt+fmna+hBxsjHvNdchA8QfPs2zFsELdhroYixBPeTiFlIf+5LDseODetrGTKBXPmdYcLFtlHaPSCSNUE7ArkwOX5lpRk9+Jv2O89BJlJTtpEBSZF2vRteM1B1U2Z2VdGtYNElRh/TXyYpPYK0j+XdJkaFjMxV7xIALSnGOTKFC6hOzaBsEYapV9YAt071p7uOSAVTpLL+Kw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB3274.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(6029001)(136003)(39860400002)(396003)(366004)(346002)(376002)(66476007)(4326008)(166002)(83380400001)(55016002)(52536014)(966005)(316002)(26005)(8676002)(478600001)(9686003)(8936002)(186003)(5660300002)(6506007)(66446008)(2906002)(7696005)(64756008)(66556008)(33656002)(110136005)(66946007)(53546011)(76116006)(86362001)(71200400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: aoQHL5B8xegw81pO7gpHLczlGU8W5y3o0vBZTsdR1sQ/Xzrej56f2XjVeABrO6HapS/7JvG8YC1e0HIpiBGeh+muVqiLV/X/iPastIIorUdxYAna8kCzq9AmLSm26Xau5pW5kJBgVUA/IaboZxezCTdmHQg1qElrc7xnloP5faJHehzAwHdaxix57YWUN+oTB+gU6iMyKFqz3ZTer1THWYwSma3g6N3asS9Qt3qVH75n7HNOhnMocsWOE5HO9cIubImV33wqSwFqt2/OSRHAg51p5c9idtlY4xY0F09Vf5mTEI4owNEFVy0m38GDJDPtokCbgL10YBaz/IQwuiqDzR/VAmgwAwmfVYZZta0Wi+lLr5ePDWhevS58v9/+ZWGg2DVAeJqMKQnj3z1x//zzlU4VNT48dGPxiE3Gdco2nH72JD+tUmWWEwlHcfXT7ibGGoi+cE+bifTZpFOPg0Ryyhk9J6xQ+1G0UvauyQnHZdA= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: e971627d-de3d-485a-6a21-08d80dd612ef X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jun 2020 07:07:16.3448 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8MG0+c5EVK4ywpDwvViSFh4zlkXMyDXkzU7Xtl7R9ef1i/4cToJ4icDsO8SwrW3ZM7S3XwzglKT/TzyCt+tZqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3577 Return-Path: eric.dong@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_DM6PR11MB32746D55C8DBAC27FCD3FF69FE800DM6PR11MB3274namp_" --_000_DM6PR11MB32746D55C8DBAC27FCD3FF69FE800DM6PR11MB3274namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I mean there is already a BaseCpuLib in MdePkg. Is it possible to add it to= there? If no usage outside of UefiCpuPkg, I'm ok to move this function to UefiCpu= Lib. Thanks, Eric From: Ni, Ray Sent: Thursday, June 11, 2020 12:56 PM To: Dong, Eric ; devel@edk2.groups.io; garrett.kirken= dall@amd.com Cc: Laszlo Ersek Subject: RE: UefiCpuPkg: Discuss: Move StandardSignatureIsAuthenticAMD fun= ction to BaseUefiCpuLib UefiCpuLib is in UefiCpuPkg. All consumers are in UefiCpuPkg. I think we can keep its location unchange= d. From: Dong, Eric > Sent: Thursday, June 11, 2020 9:29 AM To: Ni, Ray >; devel@edk2.groups= .io; garrett.kirkendall@amd.com Cc: Laszlo Ersek > Subject: RE: UefiCpuPkg: Discuss: Move StandardSignatureIsAuthenticAMD fun= ction to BaseUefiCpuLib This proposal is ok to me. I'm not sure whether it can be added to MdePkg, just like add to CpuLib. I= found all the definitions and functions used in StandardSignatureIsAuthent= icAMD function defined in MdePkg. If it can be added to MdePkg, all code base can use this function, if it b= een added to UefiCpuPkg, other core packages may can't use it. Thanks, Eric From: Ni, Ray > Sent: Thursday, June 11, 2020 9:12 AM To: devel@edk2.groups.io; garrett.kirkendall@= amd.com Cc: Dong, Eric >; Laszlo E= rsek > Subject: RE: UefiCpuPkg: Discuss: Move StandardSignatureIsAuthenticAMD fun= ction to BaseUefiCpuLib Since all platform DSCs have already listed UefiCpuLib.inf so this change = doesn't impact platform DSC. I don't see an issue with this change. Eric, What's your opinion? Thanks, Ray > -----Original Message----- > From: devel@edk2.groups.io > On Behalf Of Kirkendall, Garrett > Sent: Wednesday, June 10, 2020 10:18 PM > To: devel@edk2.groups.io > Cc: Dong, Eric >; Ni, Ra= y >; Laszlo Ersek > > Subject: [edk2-devel] UefiCpuPkg: Discuss: Move StandardSignatureIsAuthe= nticAMD function to BaseUefiCpuLib > > [AMD Public Use] > > There are currently three instances of StandardSignatureIsAuthenticAMD F= unction in the below locations. I need to > propose another change that will require the same function in PiSmmCpuDx= eSmm. I would like to see this function move > to a single "LibraryClass" location. I think no one knew where to propo= se the function, so we ended up with three > instances so far. The best place I can find would be UefiCpuPkg/BaseUef= iCpuLib/. Thoughts? Is there a better function > name such that a similar Intel identifier function could be created when= needed in the future? > > I'm thinking this will be 3 patches > 1. Add StandardSignatureIsAuthenticAMD to BaseUefiCpuLib > 2. Move current instances to Library function > 3. Propose code change in PiSmmCpuDxeSmm > > UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c: StandardSignatureIsAuthe= nticAMD ( > UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c: StandardSign= atureIsAuthenticAMD ( > UefiCpuPkg/Library/MpInitLib/MpLib.c: StandardSignatureIsAuthenticAMD ( > > GARRETT KIRKENDALL > SMTS Firmware Engineer | CTE > 7171 Southwest Parkway, Austin, TX 78735 USA > AMD facebook | amd.com > >=20 --_000_DM6PR11MB32746D55C8DBAC27FCD3FF69FE800DM6PR11MB3274namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

I mean there is already a BaseCpuLib in MdePkg. Is = it possible to add it to there?

 

If no usage outside of UefiCpuPkg, I’m ok to = move this function to UefiCpuLib.

 

Thanks,

Eric

 

From: Ni, Ray <ray.ni@intel.com>
Sent: Thursday, June 11, 2020 12:56 PM
To: Dong, Eric <eric.dong@intel.com>; devel@edk2.groups.io; g= arrett.kirkendall@amd.com
Cc: Laszlo Ersek <lersek@redhat.com>
Subject: RE: UefiCpuPkg: Discuss: Move StandardSignatureIsAuthentic= AMD function to BaseUefiCpuLib

 

UefiCpuLib is in UefiCpuPkg.

All consumers are in UefiCpuPkg. I think we can kee= p its location unchanged.

 

From: Dong, Eric <eric.dong@intel.com>
Sent: Thursday, June 11, 2020 9:29 AM
To: Ni, Ray <ray.ni@intel.co= m>; devel@edk2.groups.io; ga= rrett.kirkendall@amd.com
Cc: Laszlo Ersek <lersek@re= dhat.com>
Subject: RE: UefiCpuPkg: Discuss: Move StandardSignatureIsAuthentic= AMD function to BaseUefiCpuLib

 

This proposal is ok to me.

 

I’m not sure whether it can be added to MdePk= g, just like add to CpuLib. I found all the definitions and functions used = in StandardSignatureIsAuthenticAMD function defined in MdePkg.

 

If it can be added to MdePkg, all code base can use= this function, if it been added to UefiCpuPkg, other core packages may can= ’t use it.

 

Thanks,

Eric

From: Ni, Ray <ray.ni@intel.com>
Sent: Thursday, June 11, 2020 9:12 AM
To: devel@edk2.groups.io; garrett.kirkendall@amd.com
Cc: Dong, Eric <eric.dong= @intel.com>; Laszlo Ersek <l= ersek@redhat.com>
Subject: RE: UefiCpuPkg: Discuss: Move StandardSignatureIsAuthentic= AMD function to BaseUefiCpuLib

 

Since all platform DSCs have already = listed UefiCpuLib.inf so this change doesn't = impact platform DSC.
I don't see an issue = with this change.

Eric,
What's your opinion?

Thanks,
Ray

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of&nbs= p;Kirkendall, Garrett
> Sent: Wednesday, June&nbs= p;10, 2020 10:18 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric <<= a href=3D"mailto:eric.dong@intel.com">eric.dong@intel.com>; Ni,=  Ray <ray.ni@intel.com= >; Laszlo Ersek <= lersek@redhat.com>
> Subject: [edk2-devel] Uef= iCpuPkg: Discuss: Move StandardSignatureIsAuthenticAMD = function to BaseUefiCpuLib
> 
> [AMD Public Use] > 
> There are currently = three instances of StandardSignatureIsAuthenticAMD Func= tion in the below locations.  I need&nbs= p;to
> propose another change&nb= sp;that will require the same function in&nbs= p;PiSmmCpuDxeSmm.  I would like to see t= his function move
> to a single "Li= braryClass" location.  I think no one&nb= sp;knew where to propose the function, so&nbs= p;we ended up with three
> instances so far. &n= bsp;The best place I can find would be&n= bsp;UefiCpuPkg/BaseUefiCpuLib/.  Thoughts?  Is the= re a better function
> name such that a&nbs= p;similar Intel identifier function could be = created when needed in the future?
> 
> I'm thinking this wi= ll be 3 patches
> 1. Add StandardSignatureI= sAuthenticAMD to BaseUefiCpuLib
> 2. Move current inst= ances to Library function
> 3. Propose code chan= ge in PiSmmCpuDxeSmm
> 
> UefiCpuPkg/Library/BaseXApicLib/Bas= eXApicLib.c: StandardSignatureIsAuthenticAMD (
> UefiCpuPkg/Library/BaseXApicX2ApicL= ib/BaseXApicX2ApicLib.c: StandardSignatureIsAuthenticAMD (=
> UefiCpuPkg/Library/MpInitLib/MpLib.= c: StandardSignatureIsAuthenticAMD (
> 
> GARRETT KIRKENDALL
> SMTS Firmware Engineer&nb= sp;| CTE
> 7171 Southwest Parkway,&n= bsp;Austin, TX 78735 USA
> AMD   facebook =  |  amd.com
> 
> 

--_000_DM6PR11MB32746D55C8DBAC27FCD3FF69FE800DM6PR11MB3274namp_--