From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.4319.1589419456467519873 for ; Wed, 13 May 2020 18:24:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=lE5UPW+x; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: eric.dong@intel.com) IronPort-SDR: SgjBgHUkd7Yo0bo1fJKR7woDnoazzZXTGpmc7/SeCJuBmx0sGdv092wW+0KOqoKIHXSMA+bw2O PU81WDLYm1pg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2020 18:24:15 -0700 IronPort-SDR: WYqWSJOAWsGERx8tVfMI1cuDRyDkAaSGy6xJKGC8wHO7xSTwNHrf0UHSK6rSxAx8LRzBc1uwul 0O7LyFAzGqeA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,389,1583222400"; d="scan'208";a="437717227" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by orsmga005.jf.intel.com with ESMTP; 13 May 2020 18:24:15 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 May 2020 18:24:15 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.55) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 May 2020 18:24:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LWMDmOJG3zTdQFa8gbpN7u9hc7bdneJO0volCZFykCRxVd991bshLSQEtrLcJfxj5AoeRdac1rzioPd6WEFWjUaaeyUL8i7hXFOpQWrTaFqLN/vYshdmC1HakhEFxwDScsjNqzRR7csUVuTNn17iFP4RqyyaTMdK9LhPz7PFcgI7QfeW6qV/kAekixf4yXL9i68pAxEw0FjLCOFtY9GiHf28kZ+grL88EphSNCeig7rVElWa8fqKyN9nPH+qEhyVWrp8Y2aWjD73Hr5fQnWxuLhxNplsSv+2IRtNesKsuadBEsj6Wp3S48uZkjv2mZsHuQVRZ8FoU3ejlvGiEqGWKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Mbf1LkKKKvYXJ4W7G1yRfINLH7umvKHYXz1DSJCLmEg=; b=X/xH5OA4+jtQ6rR6S4ZH+dkbwdi+93+Z2IWEm7oYp4wj0MlZBBe3yHGcRWts6Nejyps2kE124MoiCuN56KYhtDEMFFcf2YthzCfLPVewzYmf/vvMi2+ahAb1YaNjimoghrV/U9BeUA77iBvFhdx+8AhgHh/fRuPelPJbbC/ewkJTUhUxTq8QLfypDmwCesAvd5yD1+oF3AUN3vgutLfIlSGyCNrZyow8E7kk0epbdChJ5LXVvp49XtUgNoOtGo3RuVQq1Q10Nr3YSW31bugNKKhqNb+lwPMtFbT4nDTUURqgo1XTAESc2OOUNvF2SPgKkXybc+qj/1sTmkK3MNKDgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Mbf1LkKKKvYXJ4W7G1yRfINLH7umvKHYXz1DSJCLmEg=; b=lE5UPW+x/9hdXKFsvsrbcfH5nwLXJXIJ7r587Ag2d8lxOmbRl9A8+Wq4KLZRdbsTpXOrDPdzODhzIkLYVaspgzxEoy6pTrwPgmC0lVpyQ4i8PbukDQ8cEpVWyQLVqdxoW6YrRfthNwUBUOVpYS5x/MFRwb4Y88DvnebM0lopJ7w= Received: from DM6PR11MB3274.namprd11.prod.outlook.com (2603:10b6:5:b::26) by DM6PR11MB4348.namprd11.prod.outlook.com (2603:10b6:5:1db::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.29; Thu, 14 May 2020 01:24:13 +0000 Received: from DM6PR11MB3274.namprd11.prod.outlook.com ([fe80::e1d1:a495:9826:f88b]) by DM6PR11MB3274.namprd11.prod.outlook.com ([fe80::e1d1:a495:9826:f88b%3]) with mapi id 15.20.2979.033; Thu, 14 May 2020 01:24:13 +0000 From: "Dong, Eric" To: "devel@edk2.groups.io" , "Chaganty, Rangasai V" , "Esakkithevar, Kathappan" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" , "Kethi Reddy, Deepika" Subject: Re: [edk2-devel] [Patch V1 1/1] CometlakeOpenBoardPkg: Fix build error due to Ddr4MixedUDimm2DpcLimit Thread-Topic: [edk2-devel] [Patch V1 1/1] CometlakeOpenBoardPkg: Fix build error due to Ddr4MixedUDimm2DpcLimit Thread-Index: AQHWKIJ+x1E8uTy3Uk2GBaumQLVXVKilJQsAgAGlHGA= Date: Thu, 14 May 2020 01:24:13 +0000 Message-ID: References: <20200512172555.56680-1-kathappan.esakkithevar@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.45] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 367b1e49-35ef-4e2e-25ee-08d7f7a582d0 x-ms-traffictypediagnostic: DM6PR11MB4348: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2399; x-forefront-prvs: 040359335D x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /ueR7zjkuMHTtV6gV6jl0FI2vhTuPDH0qSqjKOuL3FoloA++5sQVNFk8WRPqXx40bdOK4zi2uvFiUgyN/bJSLsadqFf0UQ0djajoKcSqc5zlIFrA5TfYJKMPAgAtrGWihkQpjNgZq8b71O5p54gFDnrCRu1CrFMk03KLHePpjcRNEtJNkou0FfB+868wp9RzBd+2+X6W6+TU65C1GhD0kE4e2uMf6m4rdVtmk5dZnN+4CgBpowk3vwhIob5ZLkmq9XykTOiuAB9UyXD0LM080F6ob6wNFCPiGhY6k++iyS8EPMQ1jQJAtU+JccRGqpnheWZAvygQs3jgk5/+vqQjHszWvOUU0AMlA+/SvPTS6WkvyTE/Ac/nhVTLoxcx2Xnt2Pv5N3KlAI8l2j0VzkhVWfmnOH4rn+xJeL5vcTMLGVhTVm0P1/bTCGE/BycP9nYp4tLNlm8sTFsKb31cWfpxOYqLgBJQizRBsa1ebOndVC6D6X2cTKoGqYX4KYWMm8lIl+6CzQL9qtLHhzc9VdAeHg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB3274.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(366004)(39860400002)(136003)(346002)(396003)(376002)(52536014)(6636002)(966005)(26005)(7696005)(316002)(76116006)(8676002)(64756008)(6506007)(478600001)(19627235002)(110136005)(54906003)(53546011)(86362001)(186003)(66446008)(66946007)(66556008)(8936002)(66476007)(4326008)(2906002)(55016002)(107886003)(33656002)(71200400001)(9686003)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: xSv6hwS5sfYBbBPhUr+8hdT6zpg/CzGoVtyk3QRlQuA/NjSqNr72+3ZcnEIHqzG0PJEJgF4t7MQZhfJNm24zfVvakVom2h5ZvHSbf5AAN6Fyiy9GNMBoNEXlSwxS2VWKjV7uwXZ4tzK9rFjk5CWrdkWmg7W85L2PFPU8Z+vNv5CLVQdc0Cp+S3eOTO5XTm6D8cpxuQTqj6z3rvCcUwXoCeyYBHYWSsPDTU/gI40qZLhOhQpBvfx8+a0lCdEqny7HE85SOmPLllJhIzVLRgwSxoKbvXoUkv8d/wjmNASaqdFJrgmPPvuJLYnTtg3UVY1V2oox/Eka5CoR2IPfFRTTT5A9KjnOsxEgpoX7kkBstg9sDZCmrN7mMEYj1Kscx7hDh8zqD/CrsfAsQbOQgDr2EJ2wqb0rdutMjrjoFsDR15xKL3JbsOMQU1by6Ydvl4mSlyiPlMLTYjWuB/Sthida+T9uLRn+BR39EbTA1vMgjsiyo9+6X3S06oGBMCngCckQ MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 367b1e49-35ef-4e2e-25ee-08d7f7a582d0 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 May 2020 01:24:13.1199 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iy/Ie6fGY5zMZ4USdD2tZtkz9QsJhlsHkWupYn5XOh2evLOL5aJUpMnfiPYvVyE6BxMs35yseJlPMoIOmtHh2w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4348 Return-Path: eric.dong@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi all, Seems this patch has passed code review. Also, it used to fix a platform build failure, and other patches will be b= locked if this platform build failure, so I help to push the code change. Pushed: SHA-1: c2cb5a4d1b54e8fe79fe1c1132034989597fee10 Thanks, Eric > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of > Chaganty, Rangasai V > Sent: Wednesday, May 13, 2020 8:11 AM > To: Esakkithevar, Kathappan ; > devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Kethi Reddy, Deepika > > Subject: Re: [edk2-devel] [Patch V1 1/1] CometlakeOpenBoardPkg: Fix buil= d > error due to Ddr4MixedUDimm2DpcLimit >=20 > Reviewed-by: Sai Chaganty >=20 > -----Original Message----- > From: Esakkithevar, Kathappan > Sent: Tuesday, May 12, 2020 10:26 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Kethi Reddy, Deepika > > Subject: [Patch V1 1/1] CometlakeOpenBoardPkg: Fix build error due to > Ddr4MixedUDimm2DpcLimit >=20 > The Ddr4MixedUDimm2DpcLimit FSP-M Upd has been renamed as > Ddr4Mixed2DpcLimit at CometLakeFspBinPkg\CometLake1. > FSP wrapper driver need to use FSP-M Upd name Ddr4Mixed2DpcLimit from > CometLake1 FSP at CometlakeOpenBoardPkg. >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2714 >=20 > Signed-off-by: Kathappan Esakkithevar > Cc: Sai Chaganty > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Deepika Kethi Reddy > --- > .../FspWrapper/Library/PeiFspPolicyInitLib/PeiFspSaPolicyInitLib.c = | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git > a/Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiFspPolic > yInitLib/PeiFspSaPolicyInitLib.c > b/Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiFspPolic > yInitLib/PeiFspSaPolicyInitLib.c > index 45d76ad5e4..53f26d824f 100644 > --- > a/Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiFspPolic > yInitLib/PeiFspSaPolicyInitLib.c > +++ > b/Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiFspPoli > +++ cyInitLib/PeiFspSaPolicyInitLib.c > @@ -344,7 +344,7 @@ PeiFspSaPolicyInitPreMem ( > FspmUpd->FspmConfig.GdxcIotSize =3D MemConfig->GdxcIotSiz= e; > FspmUpd->FspmConfig.GdxcMotSize =3D MemConfig->GdxcMotSiz= e; > FspmUpd->FspmConfig.DualDimmPerChannelBoardType =3D(UINT8) > MemConfig->DualDimmPerChannelBoardType; > - FspmUpd->FspmConfig.Ddr4MixedUDimm2DpcLimit =3D(UINT8) > MemConfig->Ddr4MixedUDimm2DpcLimit; > + FspmUpd->FspmConfig.Ddr4Mixed2DpcLimit =3D(UINT8) MemConfig- > >Ddr4MixedUDimm2DpcLimit; > // > // Update UPD:CaVrefConfig > // > -- > 2.16.2.windows.1 >=20 >=20 >=20