From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web12.8794.1594090547429357056 for ; Mon, 06 Jul 2020 19:55:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=DeXPi32j; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: eric.dong@intel.com) IronPort-SDR: sKkV4/vecH/ad3X4E/VL4+AD0LPvWBByDZ4hRkaVRUo8etXoKdU9g/i9/StkfIFER54olWmb3t htjSBsAz/Rew== X-IronPort-AV: E=McAfee;i="6000,8403,9674"; a="127617424" X-IronPort-AV: E=Sophos;i="5.75,321,1589266800"; d="scan'208";a="127617424" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2020 19:55:46 -0700 IronPort-SDR: 2ghfIJfYf+WLOK6IgPuxk+FXdeqA7qZvL1/VyPYzgy16eME/vsqWNBMMR5XQmc727+UcYd2CXF sSCJZEbc9dyg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,321,1589266800"; d="scan'208";a="427306038" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by orsmga004.jf.intel.com with ESMTP; 06 Jul 2020 19:55:46 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 6 Jul 2020 19:55:44 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 6 Jul 2020 19:55:43 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 6 Jul 2020 19:55:43 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 6 Jul 2020 19:55:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CbEm5Xx/7F7xtC3CKxjEz7Z3h+lE5UeF+Wfutu12ILztufKZwXW5XtFl800kLVfNEWInb9DaFqtZVr8CwmZHajTZRkjZLgpoiunPNC1h3TDf9tF6aKIFGCqmi26E7NwlAYIlQ8oFg569uNDNxqD7utY6rDE1fjLbD7YoCbcRkETcNBClMJ8kbcCipFssVAtky20C4Ft+d4PZOyQuMr/zZPhNecyzIA4rq559Fpurrq6A1jdVDFuRepdJzQbTym1takNaAFvVXA6JwzKRsFk4R0lZQv4QAeOl8ky+vyA54R4d644NtzqhoKhweG0xXpp3gwr4C+J2HjvCZOesLbn8cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vBP3SnOt0F4iLqab9x7cRjG89V5izrxAmX5yxM3xAqw=; b=gSwwBgtyXz6Yv6oxISa+RQNycri/Zsro9Xp0gDkuwtdMfLwdbubVwZyoa9H1/NitYHq3yauBhxiHxfIMMG+TOsECLhZWDUPKJx6TvroD8olpjvqXTNM25FfbEOV5dh16oZ0vuj3v6cYqgxuPgCSNeiPsbEPH2TCws4xAWcnGRnOmcquhB2hIFt2cG/YJhy+9VJ3UiSXzw1gZDbE4Lzttig5jsq6WqcunGmuzmdk3kBG2XN8NZKkYZUGmi+a4kwvfdoeKIAlxOS/uFhGr27b75uZc/aaDIFXIypBc1/5OlnS3J3y2uyAivblFhYKhqNiJH4B+T9lJzBSIzgvGlsq4hg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vBP3SnOt0F4iLqab9x7cRjG89V5izrxAmX5yxM3xAqw=; b=DeXPi32jgNB3IQzpaCvxW7mBGdHrmq69JNMDZIhXcgFuC8dvxd3AYgHkqrg7eFtVjhbwmrP1v+FY4mT1sknM4/27wWCBA/qc4Y0BQbVlGnA5TynbOcAlDyKDN6jZsu+zBGsst6TT0Rp9t75uHP3F6b7K65H7gfM3DzDhh+HxO8A= Received: from DM6PR11MB3274.namprd11.prod.outlook.com (2603:10b6:5:b::26) by DM6PR11MB4490.namprd11.prod.outlook.com (2603:10b6:5:1df::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.23; Tue, 7 Jul 2020 02:55:41 +0000 Received: from DM6PR11MB3274.namprd11.prod.outlook.com ([fe80::cc01:6f05:1402:e7d7]) by DM6PR11MB3274.namprd11.prod.outlook.com ([fe80::cc01:6f05:1402:e7d7%6]) with mapi id 15.20.3153.029; Tue, 7 Jul 2020 02:55:41 +0000 From: "Dong, Eric" To: Garrett Kirkendall , "devel@edk2.groups.io" CC: "Ni, Ray" , Laszlo Ersek Subject: Re: [PATCH v6 3/4] UefiCpuPkg: Move StandardSignatureIsAuthenticAMD to BaseUefiCpuLib Thread-Topic: [PATCH v6 3/4] UefiCpuPkg: Move StandardSignatureIsAuthenticAMD to BaseUefiCpuLib Thread-Index: AQHWSJevQugPkZcbq0G5s/QdqMOE8Kj7gqaA Date: Tue, 7 Jul 2020 02:55:41 +0000 Message-ID: References: <20200622131825.1352-1-Garrett.Kirkendall@amd.com> <20200622131825.1352-4-Garrett.Kirkendall@amd.com> In-Reply-To: <20200622131825.1352-4-Garrett.Kirkendall@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.38] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 11fdbb6c-76e7-42b8-528e-08d822213c2c x-ms-traffictypediagnostic: DM6PR11MB4490: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 0457F11EAF x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: C8sWiePrOrS5iNIwXAIytbwRGNWC7cncxNdI2a91dl1n3fInkYWY/ygfXAwn54lbjJdb6PJVaWlOekzBswE7wyQFYp+5GWRyAforwtqXI+Ay3jRgRT1pKYSSpqTeQv7cA9i9q0t5YbTLJSu1T170Fxsdfwq8KQW4Zpyf2FkJRzL87qCnKQj+KRXnxFkDR6NfXQnfhZb8A7dUwqnG7HFVvUYnar83EccZNQdm6oHK5g7BG/iBvzA8glRsnjikXvDsgGRlGMb7T81JjiV+3E21RIedbn3T1HpcpwePBCXUQW8yR+hQ03cSVobarp0/xciLeEBys9ZPxuuflmOXssILog== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB3274.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(6029001)(4636009)(136003)(366004)(346002)(376002)(396003)(39860400002)(7696005)(5660300002)(33656002)(2906002)(55016002)(8676002)(86362001)(53546011)(6506007)(8936002)(186003)(52536014)(26005)(316002)(64756008)(110136005)(66946007)(66476007)(66556008)(76116006)(54906003)(66446008)(83380400001)(71200400001)(4326008)(478600001)(9686003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: BReP2R+pX2HUw9PJx+DXaHjYXO5sFHchwnmk2MGpTgYWLIls6NZ9ACicIi0bOqKLQUsdLnUHlzXqS1tz3EL3qEk11cMC6z1RWcvNKiZAccJSGapsXzv7O3B0XgKwgvfyr4SKIiCYRTVYJMKXlYX0qjLnHhoAmgE8wdkqgMe9l+ao7xzvy5RGx6DplklN59SFqNoa2tFKMsfpBvRv0X/o6B5ize5Qgv2LiusLeBs5BdHpn7KHS77z/gMOR3QBD+JP26J2D1xPzOtEgdOLLL85pqzCAUgftqjT50+PWFnAYtFRlfxoPmMoL0Ag7XLpJouU2MH1OmgRtJex+zGa2arwH4TBpLwi+na5d64M+hAs8C8FWgvxMC03PFGZI6xLkLwN5rAw3OIpm+awTKE6wxmhGmDLT96GF4q8KrEMwGmYq7OxaknYJvVLg8XlmuMQrnZOQyhGO2G3hDB4SHFKPdRnXq1XuBjK3gOMxlIEw+4tMGckD8ZNooI49cnFk75y74yi MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3274.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 11fdbb6c-76e7-42b8-528e-08d822213c2c X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2020 02:55:41.0450 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: b0lBHGl36TEzYL6MerO5vCgSERfgsZVCysVggbKCeLhLlxyV+aJk94isc5bbiJUXlppwmV6VBK6HZlQMz0aIJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4490 Return-Path: eric.dong@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong > -----Original Message----- > From: Garrett Kirkendall > Sent: Monday, June 22, 2020 9:18 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Laszlo > Ersek > Subject: [PATCH v6 3/4] UefiCpuPkg: Move > StandardSignatureIsAuthenticAMD to BaseUefiCpuLib >=20 > Refactor StandardSignatureIsAuthenticAMD into BaseUefiCpuLib from > separate copies in BaseXApicLib, BaseXApicX2ApicLib, and MpInitLib. > This allows for future use of StandarSignatureIsAuthinticAMD without > creating more instances in other modules. >=20 > This function allows IA32/X64 code to determine if it is running on an AM= D > brand processor. >=20 > UefiCpuLib is already included directly or indirectly in all modified mod= ules. > Complete move is made in this change. >=20 > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Signed-off-by: Garrett Kirkendall > Reviewed-by: Laszlo Ersek > Reviewed-by: Eric Dong > --- > UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf | 7 ++++ > UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf | 2 ++ > UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.inf | 2 ++ > UefiCpuPkg/Include/Library/UefiCpuLib.h | 14 ++++++= ++ > UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.c | 38 > ++++++++++++++++++++ > UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c | 25 ++----= ------- > UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c | 25 ++----= -- > ----- > UefiCpuPkg/Library/MpInitLib/MpLib.c | 23 ------= ------ > 8 files changed, 67 insertions(+), 69 deletions(-) >=20 > diff --git a/UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf > b/UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf > index 006b7acbf14e..34d3a7bb4303 100644 > --- a/UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf > +++ b/UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf > @@ -4,6 +4,7 @@ > # The library routines are UEFI specification compliant. > # > # Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved. > +# Copyright (c) 2020, AMD Inc. All rights reserved.
> # SPDX-License-Identifier: BSD-2-Clause-Patent # ## @@ -29,6 +30,12 @= @ > [Sources.IA32] [Sources.X64] > X64/InitializeFpu.nasm >=20 > +[Sources] > + BaseUefiCpuLib.c > + > [Packages] > MdePkg/MdePkg.dec > UefiCpuPkg/UefiCpuPkg.dec > + > +[LibraryClasses] > + BaseLib > diff --git a/UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf > b/UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf > index bdb2ff372677..561baa44b0e6 100644 > --- a/UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf > +++ b/UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf > @@ -5,6 +5,7 @@ > # where local APIC is disabled. > # > # Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved. > +# Copyright (c) 2020, AMD Inc. All rights reserved.
> # SPDX-License-Identifier: BSD-2-Clause-Patent # ## @@ -37,6 +38,7 @@ > [LibraryClasses] > TimerLib > IoLib > PcdLib > + UefiCpuLib >=20 > [Pcd] > gUefiCpuPkgTokenSpaceGuid.PcdCpuInitIpiDelayInMicroSeconds ## > SOMETIMES_CONSUMES diff --git > a/UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.inf > b/UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.inf > index ac1e0a1c9896..1e2a4f8b790f 100644 > --- a/UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.inf > +++ b/UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.inf > @@ -5,6 +5,7 @@ > # where local APIC is disabled. > # > # Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved. > +# Copyright (c) 2020, AMD Inc. All rights reserved.
> # SPDX-License-Identifier: BSD-2-Clause-Patent # ## @@ -37,6 +38,7 @@ > [LibraryClasses] > TimerLib > IoLib > PcdLib > + UefiCpuLib >=20 > [Pcd] > gUefiCpuPkgTokenSpaceGuid.PcdCpuInitIpiDelayInMicroSeconds ## > SOMETIMES_CONSUMES diff --git > a/UefiCpuPkg/Include/Library/UefiCpuLib.h > b/UefiCpuPkg/Include/Library/UefiCpuLib.h > index 82e53bab3a0f..5326e7246301 100644 > --- a/UefiCpuPkg/Include/Library/UefiCpuLib.h > +++ b/UefiCpuPkg/Include/Library/UefiCpuLib.h > @@ -5,6 +5,7 @@ > to be UEFI specification compliant. >=20 > Copyright (c) 2009, Intel Corporation. All rights reserved.
> + Copyright (c) 2020, AMD Inc. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -29,4 +30,17 @@ InitializeFloatingPointUnits ( > VOID > ); >=20 > +/** > + Determine if the standard CPU signature is "AuthenticAMD". > + > + @retval TRUE The CPU signature matches. > + @retval FALSE The CPU signature does not match. > + > +**/ > +BOOLEAN > +EFIAPI > +StandardSignatureIsAuthenticAMD ( > + VOID > + ); > + > #endif > diff --git a/UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.c > b/UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.c > new file mode 100644 > index 000000000000..c2cc3ff9a709 > --- /dev/null > +++ b/UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.c > @@ -0,0 +1,38 @@ > +/** @file > + This library defines some routines that are generic for IA32 family CP= U. > + > + The library routines are UEFI specification compliant. > + > + Copyright (c) 2020, AMD Inc. All rights reserved.
> + SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#include > +#include > + > +#include > +#include > + > +/** > + Determine if the standard CPU signature is "AuthenticAMD". > + > + @retval TRUE The CPU signature matches. > + @retval FALSE The CPU signature does not match. > + > +**/ > +BOOLEAN > +EFIAPI > +StandardSignatureIsAuthenticAMD ( > + VOID > + ) > +{ > + UINT32 RegEbx; > + UINT32 RegEcx; > + UINT32 RegEdx; > + > + AsmCpuid (CPUID_SIGNATURE, NULL, &RegEbx, &RegEcx, &RegEdx); > + return (RegEbx =3D=3D CPUID_SIGNATURE_AUTHENTIC_AMD_EBX && > + RegEcx =3D=3D CPUID_SIGNATURE_AUTHENTIC_AMD_ECX && > + RegEdx =3D=3D CPUID_SIGNATURE_AUTHENTIC_AMD_EDX); > +} > diff --git a/UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c > b/UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c > index 33ea15ca2916..52bd90d33428 100644 > --- a/UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c > +++ b/UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c > @@ -4,7 +4,7 @@ > This local APIC library instance supports xAPIC mode only. >=20 > Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved.
> - Copyright (c) 2017, AMD Inc. All rights reserved.
> + Copyright (c) 2017 - 2020, AMD Inc. All rights reserved.
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @@ -21,33 +21,12 @@ > #include > #include > #include > +#include >=20 > // > // Library internal functions > // >=20 > -/** > - Determine if the standard CPU signature is "AuthenticAMD". > - > - @retval TRUE The CPU signature matches. > - @retval FALSE The CPU signature does not match. > - > -**/ > -BOOLEAN > -StandardSignatureIsAuthenticAMD ( > - VOID > - ) > -{ > - UINT32 RegEbx; > - UINT32 RegEcx; > - UINT32 RegEdx; > - > - AsmCpuid (CPUID_SIGNATURE, NULL, &RegEbx, &RegEcx, &RegEdx); > - return (RegEbx =3D=3D CPUID_SIGNATURE_AUTHENTIC_AMD_EBX && > - RegEcx =3D=3D CPUID_SIGNATURE_AUTHENTIC_AMD_ECX && > - RegEdx =3D=3D CPUID_SIGNATURE_AUTHENTIC_AMD_EDX); > -} > - > /** > Determine if the CPU supports the Local APIC Base Address MSR. >=20 > diff --git a/UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c > b/UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c > index d0f92b33dc8c..cdcbca046191 100644 > --- a/UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c > +++ b/UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c > @@ -5,7 +5,7 @@ > which have xAPIC and x2APIC modes. >=20 > Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved.
> - Copyright (c) 2017, AMD Inc. All rights reserved.
> + Copyright (c) 2017 - 2020, AMD Inc. All rights reserved.
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @@ -22,33 +22,12 @@ > #include > #include > #include > +#include >=20 > // > // Library internal functions > // >=20 > -/** > - Determine if the standard CPU signature is "AuthenticAMD". > - > - @retval TRUE The CPU signature matches. > - @retval FALSE The CPU signature does not match. > - > -**/ > -BOOLEAN > -StandardSignatureIsAuthenticAMD ( > - VOID > - ) > -{ > - UINT32 RegEbx; > - UINT32 RegEcx; > - UINT32 RegEdx; > - > - AsmCpuid (CPUID_SIGNATURE, NULL, &RegEbx, &RegEcx, &RegEdx); > - return (RegEbx =3D=3D CPUID_SIGNATURE_AUTHENTIC_AMD_EBX && > - RegEcx =3D=3D CPUID_SIGNATURE_AUTHENTIC_AMD_ECX && > - RegEdx =3D=3D CPUID_SIGNATURE_AUTHENTIC_AMD_EDX); > -} > - > /** > Determine if the CPU supports the Local APIC Base Address MSR. >=20 > diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c > b/UefiCpuPkg/Library/MpInitLib/MpLib.c > index ab7a8ed6633a..9b0660a5d4ea 100644 > --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c > +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c > @@ -13,29 +13,6 @@ > EFI_GUID mCpuInitMpLibHobGuid =3D CPU_INIT_MP_LIB_HOB_GUID; >=20 >=20 > -/** > - Determine if the standard CPU signature is "AuthenticAMD". > - > - @retval TRUE The CPU signature matches. > - @retval FALSE The CPU signature does not match. > - > -**/ > -STATIC > -BOOLEAN > -StandardSignatureIsAuthenticAMD ( > - VOID > - ) > -{ > - UINT32 RegEbx; > - UINT32 RegEcx; > - UINT32 RegEdx; > - > - AsmCpuid (CPUID_SIGNATURE, NULL, &RegEbx, &RegEcx, &RegEdx); > - return (RegEbx =3D=3D CPUID_SIGNATURE_AUTHENTIC_AMD_EBX && > - RegEcx =3D=3D CPUID_SIGNATURE_AUTHENTIC_AMD_ECX && > - RegEdx =3D=3D CPUID_SIGNATURE_AUTHENTIC_AMD_EDX); > -} > - > /** > The function will check if BSP Execute Disable is enabled. >=20 > -- > 2.27.0