Re: [edk2-devel] [PATCH 1/1 v2] MdeModulePkg/StatusCodeHandler: do not output \n\r for string data

["Dong, Eric" <eric.dong@intel.com>]

Reviewed-by: Eric Dong <eric.dong@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Tan,
> Ming
> Sent: Monday, June 15, 2020 10:04 AM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH 1/1 v2] MdeModulePkg/StatusCodeHandler:
> do not output \n\r for string data
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2787
> 
> When output string data through serial port, will not ouput \n\r now.
> Caller can output several data in one line, and output \n\r when needed.
> 
> Signed-off-by: Ming Tan <ming.tan@intel.com>
> ---
> V2: Make it as a standalone patch.
>  .../Universal/StatusCodeHandler/Pei/SerialStatusCodeWorker.c    | 2 +-
>  .../StatusCodeHandler/RuntimeDxe/SerialStatusCodeWorker.c       | 2 +-
>  .../Universal/StatusCodeHandler/Smm/SerialStatusCodeWorker.c    | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git
> a/MdeModulePkg/Universal/StatusCodeHandler/Pei/SerialStatusCodeWork
> er.c
> b/MdeModulePkg/Universal/StatusCodeHandler/Pei/SerialStatusCodeWork
> er.c
> index 2455f8b2a908..3aa5642b64fb 100644
> ---
> a/MdeModulePkg/Universal/StatusCodeHandler/Pei/SerialStatusCodeWork
> er.c
> +++
> b/MdeModulePkg/Universal/StatusCodeHandler/Pei/SerialStatusCodeWork
> er.c
> @@ -134,7 +134,7 @@ SerialStatusCodeReportWorker (
>      CharCount = AsciiSPrint (
>                    Buffer,
>                    sizeof (Buffer),
> -                  "%a\n\r",
> +                  "%a",
>                    ((EFI_STATUS_CODE_STRING_DATA *) Data)->String.Ascii
>                    );
>    } else {
> diff --git
> a/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/SerialStatusC
> odeWorker.c
> b/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/SerialStatusC
> odeWorker.c
> index 2dc3ecfff52e..0b98e7ec6315 100644
> ---
> a/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/SerialStatusC
> odeWorker.c
> +++
> b/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/SerialStatusC
> odeWorker.c
> @@ -129,7 +129,7 @@ SerialStatusCodeReportWorker (
>      CharCount = AsciiSPrint (
>                    Buffer,
>                    sizeof (Buffer),
> -                  "%a\n\r",
> +                  "%a",
>                    ((EFI_STATUS_CODE_STRING_DATA *) Data)->String.Ascii
>                    );
>    } else {
> diff --git
> a/MdeModulePkg/Universal/StatusCodeHandler/Smm/SerialStatusCodeWo
> rker.c
> b/MdeModulePkg/Universal/StatusCodeHandler/Smm/SerialStatusCodeWo
> rker.c
> index c0c907b32f5a..3df0a6712611 100644
> ---
> a/MdeModulePkg/Universal/StatusCodeHandler/Smm/SerialStatusCodeWo
> rker.c
> +++
> b/MdeModulePkg/Universal/StatusCodeHandler/Smm/SerialStatusCodeWo
> rker.c
> @@ -129,7 +129,7 @@ SerialStatusCodeReportWorker (
>      CharCount = AsciiSPrint (
>                    Buffer,
>                    sizeof (Buffer),
> -                  "%a\n\r",
> +                  "%a",
>                    ((EFI_STATUS_CODE_STRING_DATA *) Data)->String.Ascii
>                    );
>    } else {
> --
> 2.24.0.windows.2
> 
> 
>