From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.9932.1592191559168187034 for ; Sun, 14 Jun 2020 20:25:59 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=bOnbMuro; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: eric.dong@intel.com) IronPort-SDR: LRBMyyxcusm33TOKDgxIFRvN/il0VHu2VwXYYpmzWyNXw25Kdb9SaMGFG9yrYGGf85sizRdbIx lQzSduEhiKDQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jun 2020 20:25:58 -0700 IronPort-SDR: JyozS0skOA7xuI2bZjFFSvNItTVoYp0+ydo0YCn2dQCymZrbuRvi6AZFBDyyupQmjwZYR3RWM5 oNRCB2cum1Bw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,513,1583222400"; d="scan'208";a="316750264" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by FMSMGA003.fm.intel.com with ESMTP; 14 Jun 2020 20:25:58 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 14 Jun 2020 20:25:58 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 14 Jun 2020 20:25:57 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.52) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 14 Jun 2020 20:25:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Eus7Dhmc06bh0zMb6wSRo45ydab8pYjImFrGEBo7ss+PyhOuda/ZbzeX2USFgnhHKfdv07F+U5RV0H8tlm3qz6QqBmHgBYrnKYm6toELrtqosDM4AJTb5SLSXZmmPVa+1KAXcK2IiD0nUUZqzzZSTFbA5HrBx/mv4/LbTMkMWwO2cYmr2gr7lp53C82qvn2FC47JDTqepiSFqSwVIaDQRjd5wWFkXFvpDPBVFGMuNc/nV0DzA609c/vAZyGW1U0UY7BqrD3WQavYy0ql7/750I699hFAeUGlq3I1KNK0FWrRWUX/jKBSeFo7Ra0Yk1mFQXt4YczPTQgzbqgXg/lkWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xhqcBfpD7/GUea+wMNkQtkDqZtEj7G5H01Adm264QFc=; b=RgTznVEqQSaIiZW1Ek/2QAwGLLNyJyq3bVIDplvMv3gys+hUoHx5VWaBsvq7SGVZLyHQLTuDE1KsHIH+zCC8YvBholap52E6ImU3It7pKH39JkzDg5WeMPj1N+0Xq98rJY8i6KiH74GNkVqvqHtAVZyWinuiIP1fEBOUmy2EvasmLHw25Ddr1wRIzTgeZ9fbypoD/5j69//K6ygwbejTjr2O8W/+NfHvG5DzmpO5ECw/Muz3vi51SrTGTUmdGMcjqWqSRgOpiMVO0KA26+abImP/h7Wi5ZJKx7M+fyjkgGNRij9c2Y5QzJ0mGE/SAVkXaH0WW2qTX280F4mAgD65GQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xhqcBfpD7/GUea+wMNkQtkDqZtEj7G5H01Adm264QFc=; b=bOnbMuroB0LPJQ7bIhwLBrmUOvua1S7Ju4jkyBF/tuEkafbTD0lInyeKjwFLqlxOt/2nw9GHf8eDML/q2ByaHDT00NZIci/qmJw6StC2Z89OR2lUmgFb9mLmECkSxuX/z2Ll9Zq9JuvZtqDJU3ZhLjMzum4oIs6HVusCxp6ZVcg= Received: from DM6PR11MB3274.namprd11.prod.outlook.com (2603:10b6:5:b::26) by DM6PR11MB2828.namprd11.prod.outlook.com (2603:10b6:5:c6::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.18; Mon, 15 Jun 2020 03:25:55 +0000 Received: from DM6PR11MB3274.namprd11.prod.outlook.com ([fe80::cc01:6f05:1402:e7d7]) by DM6PR11MB3274.namprd11.prod.outlook.com ([fe80::cc01:6f05:1402:e7d7%6]) with mapi id 15.20.3088.028; Mon, 15 Jun 2020 03:25:55 +0000 From: "Dong, Eric" To: "devel@edk2.groups.io" , "Tan, Ming" Subject: Re: [edk2-devel] [PATCH 1/1 v2] MdeModulePkg/StatusCodeHandler: do not output \n\r for string data Thread-Topic: [edk2-devel] [PATCH 1/1 v2] MdeModulePkg/StatusCodeHandler: do not output \n\r for string data Thread-Index: AQHWQrlrp2sxDzpZ4UW+2/6EHmpqnajZA9Hw Date: Mon, 15 Jun 2020 03:25:55 +0000 Message-ID: References: <20200615020344.39959-1-ming.tan@intel.com> In-Reply-To: <20200615020344.39959-1-ming.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: abb3ea41-96f3-46c8-da72-08d810dbd0aa x-ms-traffictypediagnostic: DM6PR11MB2828: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:81; x-forefront-prvs: 04359FAD81 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Q+kBt3Uw7YFlZMnygZOOCoh6zXAs7h7z9QbYTGLMTFqN0ixUghVMhNqM+TJKskB/DQACLgZFeVKcYreN98ehygTs+VlkAc3B8LSyD6JL0iEgSKyXC2GwPX2dRLkWRuirsGGVWU8VtJ8PZx5K6SKd3HRkjC3/56oxJGyDNTDn+2S+Ll5WbRwuoV8eKf8ElQM/lf+gBzHCa5aNyvTQ9SEN27gMgh8Cx76nKOElGuwrRE1hXW1r/aQTPICrku1wQ2V6ISKXqSSgIADUqieJI7b/59sgl6VA7APNkkp8QvgqTsksUc/DtyNeEvPghnNPsocmoxZDhTP/au7wq1/bBAGynHMRIXKyR5rLB/AQrp6weWe8Hj1xmwadAHxKI626rVgbwXqF/kawbJ1Vh5JkQMPVQQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB3274.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(346002)(396003)(366004)(376002)(136003)(39860400002)(186003)(71200400001)(8676002)(66556008)(9686003)(2906002)(55016002)(66476007)(66946007)(8936002)(76116006)(66446008)(64756008)(52536014)(6636002)(33656002)(86362001)(966005)(53546011)(7696005)(110136005)(5660300002)(26005)(316002)(478600001)(6506007)(83380400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: NHKx/BZay5cGZBHkLTdrwTdvij6MOlr6BeH9YVt2E/zP0j1eaSuimWdkivj6d6XqB+3HwjWDHugcAnrdvzM9m+mkW/mYFn+sNy5jsZD44Quq1+LgPVKsu4fzFoakW/bsnmFNBmt98P1Mqpuy84xKD6YaHsTc6wmcTXO4WYbtcUediZTUoeRKSmPUEwcqsGHP5WBxivbr0UlrA6vuGtf9VS5vcSsKOAsw1EiWFJpDc57zCwdG1piuSkaB/L4peM723ZsTiW9YsVRdFhsn7M9M+FRCoPtTtO5s9rem3ffxWhw4z81MCCqmjmIk83zjY01ca9uEZL/WG7fXGXDScY0Vv4Kt825OJY8iMgPva3fl07RDu5fFpFHFAkB2UkVYnRGr9glwjgK0qurXxNj/VOaI7rVJYKXsvWt93OMEnzywWTWxlC0R0GVnedxMff01x1fJuisln32XUUz1AXIjV8Fh+gthU+NNR4pGGkQcg/QQp4C8VqpZdz2oudTm39Hd75J1 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: abb3ea41-96f3-46c8-da72-08d810dbd0aa X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jun 2020 03:25:55.6316 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Tn8dV2ddR/65RzRDUyqjs6KlEVtgEAw3aaDy+0+wpoHPuiuqdtwHyhJkyMxK2Ok10mOvPYeqZO9mrlY1USLFFg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2828 Return-Path: eric.dong@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Tan, > Ming > Sent: Monday, June 15, 2020 10:04 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH 1/1 v2] MdeModulePkg/StatusCodeHandler: > do not output \n\r for string data >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2787 >=20 > When output string data through serial port, will not ouput \n\r now. > Caller can output several data in one line, and output \n\r when needed. >=20 > Signed-off-by: Ming Tan > --- > V2: Make it as a standalone patch. > .../Universal/StatusCodeHandler/Pei/SerialStatusCodeWorker.c | 2 +- > .../StatusCodeHandler/RuntimeDxe/SerialStatusCodeWorker.c | 2 +- > .../Universal/StatusCodeHandler/Smm/SerialStatusCodeWorker.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git > a/MdeModulePkg/Universal/StatusCodeHandler/Pei/SerialStatusCodeWork > er.c > b/MdeModulePkg/Universal/StatusCodeHandler/Pei/SerialStatusCodeWork > er.c > index 2455f8b2a908..3aa5642b64fb 100644 > --- > a/MdeModulePkg/Universal/StatusCodeHandler/Pei/SerialStatusCodeWork > er.c > +++ > b/MdeModulePkg/Universal/StatusCodeHandler/Pei/SerialStatusCodeWork > er.c > @@ -134,7 +134,7 @@ SerialStatusCodeReportWorker ( > CharCount =3D AsciiSPrint ( > Buffer, > sizeof (Buffer), > - "%a\n\r", > + "%a", > ((EFI_STATUS_CODE_STRING_DATA *) Data)->String.Ascii > ); > } else { > diff --git > a/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/SerialStatusC > odeWorker.c > b/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/SerialStatusC > odeWorker.c > index 2dc3ecfff52e..0b98e7ec6315 100644 > --- > a/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/SerialStatusC > odeWorker.c > +++ > b/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/SerialStatusC > odeWorker.c > @@ -129,7 +129,7 @@ SerialStatusCodeReportWorker ( > CharCount =3D AsciiSPrint ( > Buffer, > sizeof (Buffer), > - "%a\n\r", > + "%a", > ((EFI_STATUS_CODE_STRING_DATA *) Data)->String.Ascii > ); > } else { > diff --git > a/MdeModulePkg/Universal/StatusCodeHandler/Smm/SerialStatusCodeWo > rker.c > b/MdeModulePkg/Universal/StatusCodeHandler/Smm/SerialStatusCodeWo > rker.c > index c0c907b32f5a..3df0a6712611 100644 > --- > a/MdeModulePkg/Universal/StatusCodeHandler/Smm/SerialStatusCodeWo > rker.c > +++ > b/MdeModulePkg/Universal/StatusCodeHandler/Smm/SerialStatusCodeWo > rker.c > @@ -129,7 +129,7 @@ SerialStatusCodeReportWorker ( > CharCount =3D AsciiSPrint ( > Buffer, > sizeof (Buffer), > - "%a\n\r", > + "%a", > ((EFI_STATUS_CODE_STRING_DATA *) Data)->String.Ascii > ); > } else { > -- > 2.24.0.windows.2 >=20 >=20 >=20