Re: [edk2-devel] [PATCH v2 3/3] UefiCpuPkg/MtrrLib: Remove unnecessary API MtrrSetFixedMtrr()

["Dong, Eric" <eric.dong@intel.com>]

Reviewed-by: Eric Dong <eric.dong@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ni, Ray
> Sent: Monday, July 13, 2020 4:13 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric <eric.dong@intel.com>; Laszlo Ersek <lersek@redhat.com>;
> Kumar, Rahul1 <rahul1.kumar@intel.com>
> Subject: [edk2-devel] [PATCH v2 3/3] UefiCpuPkg/MtrrLib: Remove
> unnecessary API MtrrSetFixedMtrr()
> 
> MtrrSetFixedMtrr() sets all the fixed MTRR settings.
> But in fact MtrrSetAllMtrrs() is always used by callers to set all MTRR settings
> including the fixed and variable ones.
> 
> The patch removes the necessary API MtrrSetFixedMtrr() to simplify the
> MtrrLib API.
> 
> There is no code in edk2 and edk2-platforms repo that calls
> MtrrGetVariableMtrr().
> 
> Signed-off-by: Ray Ni <ray.ni@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> ---
>  UefiCpuPkg/Include/Library/MtrrLib.h | 15 --------------
> UefiCpuPkg/Library/MtrrLib/MtrrLib.c | 29 ----------------------------
>  2 files changed, 44 deletions(-)
> 
> diff --git a/UefiCpuPkg/Include/Library/MtrrLib.h
> b/UefiCpuPkg/Include/Library/MtrrLib.h
> index 0bc69e235c..9110787067 100644
> --- a/UefiCpuPkg/Include/Library/MtrrLib.h
> +++ b/UefiCpuPkg/Include/Library/MtrrLib.h
> @@ -200,21 +200,6 @@ MtrrGetFixedMtrr (
>    );  -/**-  This function sets fixed MTRRs--  @param[in]   FixedSettings      A
> buffer holding fixed MTRRs content.--  @return  The pointer of
> FixedSettings--**/-MTRR_FIXED_SETTINGS*-EFIAPI-MtrrSetFixedMtrr (-  IN
> MTRR_FIXED_SETTINGS          *FixedSettings-  );-- /**   This function gets the
> content in all MTRRs (variable and fixed) diff --git
> a/UefiCpuPkg/Library/MtrrLib/MtrrLib.c
> b/UefiCpuPkg/Library/MtrrLib/MtrrLib.c
> index 8b54f2c03b..ceab7a065f 100644
> --- a/UefiCpuPkg/Library/MtrrLib/MtrrLib.c
> +++ b/UefiCpuPkg/Library/MtrrLib/MtrrLib.c
> @@ -2580,35 +2580,6 @@ MtrrSetFixedMtrrWorker (
>  }  -/**-  This function sets fixed MTRRs--  @param[in]  FixedSettings  A
> buffer to hold fixed MTRRs content.--  @retval The pointer of FixedSettings--
> **/-MTRR_FIXED_SETTINGS*-EFIAPI-MtrrSetFixedMtrr (-  IN
> MTRR_FIXED_SETTINGS          *FixedSettings-  )-{-  MTRR_CONTEXT
> MtrrContext;--  if (!IsMtrrSupported ()) {-    return FixedSettings;-  }--
> MtrrLibPreMtrrChange (&MtrrContext);-  MtrrSetFixedMtrrWorker
> (FixedSettings);-  MtrrLibPostMtrrChange (&MtrrContext);-
> MtrrDebugPrintAllMtrrs ();--  return FixedSettings;-}-- /**   This function gets
> the content in all MTRRs (variable and fixed) --
> 2.27.0.windows.1
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> 
> View/Reply Online (#62406): https://edk2.groups.io/g/devel/message/62406
> Mute This Topic: https://groups.io/mt/75472804/1768733
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub  [eric.dong@intel.com] -
> =-=-=-=-=-=