From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web12.11720.1594692923704088273 for ; Mon, 13 Jul 2020 19:15:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=liBHRTXv; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: eric.dong@intel.com) IronPort-SDR: O66ihTl51Zg5opuvRP8iOZDkqg5MKkFm9NuIgFok64kW/TF/mizezGhMa7mZR3W3Hqp1RRemGd 0+VPccKF2vQQ== X-IronPort-AV: E=McAfee;i="6000,8403,9681"; a="210313062" X-IronPort-AV: E=Sophos;i="5.75,349,1589266800"; d="scan'208";a="210313062" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2020 19:15:22 -0700 IronPort-SDR: BrUG1s3CTVhQ+UywEc/qxX1a2N9PC/aVjPFZypExZR0De0DmeXoYlupnhgPC8SjwbEgx+kqKXO +1pepaw3sEog== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,349,1589266800"; d="scan'208";a="390349633" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga001.fm.intel.com with ESMTP; 13 Jul 2020 19:15:22 -0700 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 13 Jul 2020 19:15:22 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 13 Jul 2020 19:15:21 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.175) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 13 Jul 2020 19:15:21 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X1RFLZdoBCqaJPp1Fkm6dY07eMd13Ys9xklDgTBGSghslbdRXkFApOE+tdnnIJBQxZ/bd9pjcWcVF0LlHoQHCFPJ0AGwRXz0TEIaMRQNhA3GTXFz5pmelFEnBCsfTLAtPwY6rjyRCba8WKGjinQL2mT2e3MgF7tPpHVs+++31mT0HuFfxCs7f5tCkdxc7/Unbh9TIlJijzEMVY/8h/sJpHvuAWRT1yjf5cQDQQ22axUq1val9DEBB2BV7J2j/w8h6RDLhWjVCaa5E4Qm9dyeNE59r9J4CsYjxNLzPtNr9dPZqPERmVdyS96FLIZVIROKLLV49n6RhYKtbkX9HZqmTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=riSnKKQ/WVNINGC/be1iOj1zu4KpLUDsjm7w7WpRtQg=; b=fhzPE8oEKTcp1dd5J7NrftuGmiuwiFpGpk+1lhKJEeDEnyG8mrYlH1uIL9gBLczvgOzgePBTUaYu5+G4wW4qKxuFHKJjmdpT8NHbisyJQpaYVu89ayNwFMaV8hPrkTBSUQeNaXxBp1Mx1xEVYtuY9zjuaPjU535/xMy7/jzLeGcXsQeWJzZdu/qG5Alo/blJoH6AaD/LkCdYs3M5aHtZFxzz3jgwhnckKNuyprp9/nQpYkKDXmzgo7vdK7Acf2wXgttFoDVKfaCSEXWj8Gm6C9Gs+zgwsg/J0qRRelLqyqy3brnAaNZ577sjMNqdCD9jg3NhVDTfUS21DqDimKhA4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=riSnKKQ/WVNINGC/be1iOj1zu4KpLUDsjm7w7WpRtQg=; b=liBHRTXv/+aSbLETLNUAwUjxeLwJq/ciA0bscrf3tcCfdi/D7AU7DTtiXmyHMSR9P/L4uzgrOBoNstSFermZEOuiRtrIGkIhs1u0NXlVBh+Bqhz3isMRAL3JqX3k9fF4jshqbKrenEDoPxSgArZd4zEZoGk+iRmo1jKx1UWTZcI= Received: from DM6PR11MB3274.namprd11.prod.outlook.com (2603:10b6:5:b::26) by DM6PR11MB4011.namprd11.prod.outlook.com (2603:10b6:5:19d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.22; Tue, 14 Jul 2020 02:15:19 +0000 Received: from DM6PR11MB3274.namprd11.prod.outlook.com ([fe80::cc01:6f05:1402:e7d7]) by DM6PR11MB3274.namprd11.prod.outlook.com ([fe80::cc01:6f05:1402:e7d7%6]) with mapi id 15.20.3174.025; Tue, 14 Jul 2020 02:15:19 +0000 From: "Dong, Eric" To: "devel@edk2.groups.io" , "Ni, Ray" CC: Laszlo Ersek , "Kumar, Rahul1" Subject: Re: [edk2-devel] [PATCH v2 3/3] UefiCpuPkg/MtrrLib: Remove unnecessary API MtrrSetFixedMtrr() Thread-Topic: [edk2-devel] [PATCH v2 3/3] UefiCpuPkg/MtrrLib: Remove unnecessary API MtrrSetFixedMtrr() Thread-Index: AQHWWO2MSRTDFWwm1kaWFl70Lk7bY6kGV0XA Date: Tue, 14 Jul 2020 02:15:19 +0000 Message-ID: References: <20200713081236.1284-1-ray.ni@intel.com> <20200713081236.1284-4-ray.ni@intel.com> In-Reply-To: <20200713081236.1284-4-ray.ni@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.38] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0c215e92-3d2e-4eae-3785-08d8279bc1bb x-ms-traffictypediagnostic: DM6PR11MB4011: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4303; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uJ+PCy8nyAnQiTAsVQUlRXO5EuJ1JCvIyPjozGBw87JH7vb9ShSqxkQkmF8/h3uJg0uymtOzmEXIYB37T1rlPC3JMC8Ir93JHXDOTij2T8aPrk/pa0nNkjsDJJLAJWeAdxrjE3n1bfIE/ljbQWc/yQT2n0aSrgSPkO9LR6VsVbWrS4m2RbJUd6KYcAPKhI8rDiuaSFgTP4QUWmBpwUi0zJpYlKjIx/zx4QlmoVmIdBhhtFUVfnD4DzW91h+zF13/KMFcWUSLZQXY+ZUt4GSZEwKvwenxUWb1E/+3GTj0UyNBIWVxliXoXjd3e8u3c0TH4tDUYTXXVQFEVi2dADFQBDQRwYpklbbHDwXE255WC4GzMan88lre+twJTWMWzFRwiJkth991rOnP8/OyuC6bQw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB3274.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(39860400002)(396003)(366004)(376002)(346002)(2906002)(86362001)(478600001)(4326008)(7696005)(8936002)(186003)(8676002)(316002)(110136005)(5660300002)(54906003)(966005)(26005)(83380400001)(6506007)(71200400001)(53546011)(9686003)(55016002)(33656002)(6636002)(76116006)(66476007)(66946007)(107886003)(66556008)(52536014)(66446008)(64756008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: NyNUCNMwoSqldnQNL5SjkSde1aGHamvaJL8YLl9zRLXpkB/GWG9vYxeHr//J1MHzurmqmJdCROlRgHqg0qKvhbb4GVFiMAk2nm0wr8J0MwwZoedQKiieAPKyDAj6m7j3lfdnwKlw+FnN9P3TTD6oyCkyunmoICvQ7mRxzYpBML4+Txjx0X4o7LA8Ql+7C+xITDdBOUWNZEm2ynSDtUqqs53ic8/cqD8ENEb6hOlgIwy4NYV/18gAP2kJKEmquYEFM4lWfKfhWv783SI8GRv4fmQ0ULJFHiATwq0tHLMTDyPztxPmlD7kfJuxp/tS56mJNTxc+cx0+UIBxtVaat24I5QxpwCjSEN8K3MVhKx5s1gEdZR7zjAzrQVKVW69bVMEtif6gmK8CyYOgy6dpbrPru19kuOOSEtsxU7agWxVDXzVKLiT2K8Ys+5OT4ZX3cSjS+YArGLjVW5qccRvRLwU/c7iwTfhAla2qBP2FdgwQDbEvrbMh4U6bEp71hC+ghOq MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3274.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0c215e92-3d2e-4eae-3785-08d8279bc1bb X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2020 02:15:19.5322 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1IFkQEkTUzDql8MHgvV5sg69UdQlaktt+bXyq90mKjCysUlWK/Xw9XOkHD88TN6is98//MclhNBU3IZvd6G4hg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4011 Return-Path: eric.dong@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Monday, July 13, 2020 4:13 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Laszlo Ersek ; > Kumar, Rahul1 > Subject: [edk2-devel] [PATCH v2 3/3] UefiCpuPkg/MtrrLib: Remove > unnecessary API MtrrSetFixedMtrr() >=20 > MtrrSetFixedMtrr() sets all the fixed MTRR settings. > But in fact MtrrSetAllMtrrs() is always used by callers to set all MTRR s= ettings > including the fixed and variable ones. >=20 > The patch removes the necessary API MtrrSetFixedMtrr() to simplify the > MtrrLib API. >=20 > There is no code in edk2 and edk2-platforms repo that calls > MtrrGetVariableMtrr(). >=20 > Signed-off-by: Ray Ni > Cc: Eric Dong > Cc: Laszlo Ersek > Cc: Rahul Kumar > --- > UefiCpuPkg/Include/Library/MtrrLib.h | 15 -------------- > UefiCpuPkg/Library/MtrrLib/MtrrLib.c | 29 ---------------------------- > 2 files changed, 44 deletions(-) >=20 > diff --git a/UefiCpuPkg/Include/Library/MtrrLib.h > b/UefiCpuPkg/Include/Library/MtrrLib.h > index 0bc69e235c..9110787067 100644 > --- a/UefiCpuPkg/Include/Library/MtrrLib.h > +++ b/UefiCpuPkg/Include/Library/MtrrLib.h > @@ -200,21 +200,6 @@ MtrrGetFixedMtrr ( > ); -/**- This function sets fixed MTRRs-- @param[in] FixedSetting= s A > buffer holding fixed MTRRs content.-- @return The pointer of > FixedSettings--**/-MTRR_FIXED_SETTINGS*-EFIAPI-MtrrSetFixedMtrr (- IN > MTRR_FIXED_SETTINGS *FixedSettings- );-- /** This function ge= ts the > content in all MTRRs (variable and fixed) diff --git > a/UefiCpuPkg/Library/MtrrLib/MtrrLib.c > b/UefiCpuPkg/Library/MtrrLib/MtrrLib.c > index 8b54f2c03b..ceab7a065f 100644 > --- a/UefiCpuPkg/Library/MtrrLib/MtrrLib.c > +++ b/UefiCpuPkg/Library/MtrrLib/MtrrLib.c > @@ -2580,35 +2580,6 @@ MtrrSetFixedMtrrWorker ( > } -/**- This function sets fixed MTRRs-- @param[in] FixedSettings A > buffer to hold fixed MTRRs content.-- @retval The pointer of FixedSettin= gs-- > **/-MTRR_FIXED_SETTINGS*-EFIAPI-MtrrSetFixedMtrr (- IN > MTRR_FIXED_SETTINGS *FixedSettings- )-{- MTRR_CONTEXT > MtrrContext;-- if (!IsMtrrSupported ()) {- return FixedSettings;- }-= - > MtrrLibPreMtrrChange (&MtrrContext);- MtrrSetFixedMtrrWorker > (FixedSettings);- MtrrLibPostMtrrChange (&MtrrContext);- > MtrrDebugPrintAllMtrrs ();-- return FixedSettings;-}-- /** This functi= on gets > the content in all MTRRs (variable and fixed) -- > 2.27.0.windows.1 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. >=20 > View/Reply Online (#62406): https://edk2.groups.io/g/devel/message/62406 > Mute This Topic: https://groups.io/mt/75472804/1768733 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [eric.dong@intel.com] = - > =3D-=3D-=3D-=3D-=3D-=3D